JDK-8033260 (original) (raw)

Code Review for JDK-8033260

Prepared by: adlertz on Wed Feb 19 12:01:34 CET 2014
Workspace: /home/adlertz/repos/hotspot/JDK-8033260
Compare against: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/
Compare against version: 5902
Summary of changes: 34 lines changed: 4 ins; 0 del; 30 mod; 9436 unchg
Patch of changes: <JDK-8033260.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/vm/opto/block.hpp.cdiff.html) [Udiffs](src/share/vm/opto/block.hpp.udiff.html) [Sdiffs](src/share/vm/opto/block.hpp.sdiff.html) [Frames](src/share/vm/opto/block.hpp.frames.html) [Old](src/share/vm/opto/block.hpp-.html) [New](src/share/vm/opto/block.hpp.html) [Patch](src/share/vm/opto/block.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/block.hpp) src/share/vm/opto/block.hpp

rev 5903 : 8033260: assert(lrg._area >= 0.0) failed: negative spill area Summary: Change type from float to double on block frequency, and add check for +Inf - +Inf operation Reviewed-by:

15 lines changed: 0 ins; 0 del; 15 mod; 867 unchg

[Cdiffs](src/share/vm/opto/chaitin.cpp.cdiff.html) [Udiffs](src/share/vm/opto/chaitin.cpp.udiff.html) [Sdiffs](src/share/vm/opto/chaitin.cpp.sdiff.html) [Frames](src/share/vm/opto/chaitin.cpp.frames.html) [Old](src/share/vm/opto/chaitin.cpp-.html) [New](src/share/vm/opto/chaitin.cpp.html) [Patch](src/share/vm/opto/chaitin.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/chaitin.cpp) src/share/vm/opto/chaitin.cpp

rev 5903 : 8033260: assert(lrg._area >= 0.0) failed: negative spill area Summary: Change type from float to double on block frequency, and add check for +Inf - +Inf operation Reviewed-by:

1 line changed: 0 ins; 0 del; 1 mod; 2346 unchg

[Cdiffs](src/share/vm/opto/gcm.cpp.cdiff.html) [Udiffs](src/share/vm/opto/gcm.cpp.udiff.html) [Sdiffs](src/share/vm/opto/gcm.cpp.sdiff.html) [Frames](src/share/vm/opto/gcm.cpp.frames.html) [Old](src/share/vm/opto/gcm.cpp-.html) [New](src/share/vm/opto/gcm.cpp.html) [Patch](src/share/vm/opto/gcm.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/gcm.cpp) src/share/vm/opto/gcm.cpp

rev 5903 : 8033260: assert(lrg._area >= 0.0) failed: negative spill area Summary: Change type from float to double on block frequency, and add check for +Inf - +Inf operation Reviewed-by:

9 lines changed: 0 ins; 0 del; 9 mod; 2041 unchg

[Cdiffs](src/share/vm/opto/ifg.cpp.cdiff.html) [Udiffs](src/share/vm/opto/ifg.cpp.udiff.html) [Sdiffs](src/share/vm/opto/ifg.cpp.sdiff.html) [Frames](src/share/vm/opto/ifg.cpp.frames.html) [Old](src/share/vm/opto/ifg.cpp-.html) [New](src/share/vm/opto/ifg.cpp.html) [Patch](src/share/vm/opto/ifg.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/ifg.cpp) src/share/vm/opto/ifg.cpp

rev 5903 : 8033260: assert(lrg._area >= 0.0) failed: negative spill area Summary: Change type from float to double on block frequency, and add check for +Inf - +Inf operation Reviewed-by:

7 lines changed: 4 ins; 0 del; 3 mod; 853 unchg

[Cdiffs](src/share/vm/runtime/vmStructs.cpp.cdiff.html) [Udiffs](src/share/vm/runtime/vmStructs.cpp.udiff.html) [Sdiffs](src/share/vm/runtime/vmStructs.cpp.sdiff.html) [Frames](src/share/vm/runtime/vmStructs.cpp.frames.html) [Old](src/share/vm/runtime/vmStructs.cpp-.html) [New](src/share/vm/runtime/vmStructs.cpp.html) [Patch](src/share/vm/runtime/vmStructs.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/vmStructs.cpp) src/share/vm/runtime/vmStructs.cpp

rev 5903 : 8033260: assert(lrg._area >= 0.0) failed: negative spill area Summary: Change type from float to double on block frequency, and add check for +Inf - +Inf operation Reviewed-by:

2 lines changed: 0 ins; 0 del; 2 mod; 3329 unchg


This code review page was prepared using /bin/webrev.ksh(vers 23.18-hg-never-dev).