jdk (original) (raw)

Code Review for jdk

Prepared by: alanb on Tue Dec 18 12:25:14 GMT 2012
Workspace: /Users/alanb/ws/jdk8/tl/jdk
Summary of changes: 10062 lines changed: 10007 ins; 44 del; 11 mod; 1396 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](make/jdk/Makefile.cdiff.html) [Udiffs](make/jdk/Makefile.udiff.html) [Sdiffs](make/jdk/Makefile.sdiff.html) [Frames](make/jdk/Makefile.frames.html) [Old](make/jdk/Makefile-.html) [New](make/jdk/Makefile.html) [Patch](make/jdk/Makefile.patch) [Raw](raw%5Ffiles/new/make/jdk/Makefile) make/jdk/Makefile

15 lines changed: 6 ins; 4 del; 5 mod; 29 unchg

[Cdiffs](src/share/classes/java/util/Properties.java.cdiff.html) [Udiffs](src/share/classes/java/util/Properties.java.udiff.html) [Sdiffs](src/share/classes/java/util/Properties.java.sdiff.html) [Frames](src/share/classes/java/util/Properties.java.frames.html) [Old](src/share/classes/java/util/Properties.java-.html) [New](src/share/classes/java/util/Properties.java.html) [Patch](src/share/classes/java/util/Properties.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/Properties.java) src/share/classes/java/util/Properties.java

1 line changed: 0 ins; 0 del; 1 mod; 1209 unchg

[Cdiffs](test/java/util/Properties/LoadAndStoreXML.java.cdiff.html) [Udiffs](test/java/util/Properties/LoadAndStoreXML.java.udiff.html) [Sdiffs](test/java/util/Properties/LoadAndStoreXML.java.sdiff.html) [Frames](test/java/util/Properties/LoadAndStoreXML.java.frames.html) [Old](test/java/util/Properties/LoadAndStoreXML.java-.html) [New](test/java/util/Properties/LoadAndStoreXML.java.html) [Patch](test/java/util/Properties/LoadAndStoreXML.java.patch) [Raw](raw%5Ffiles/new/test/java/util/Properties/LoadAndStoreXML.java) test/java/util/Properties/LoadAndStoreXML.java

40 lines changed: 35 ins; 0 del; 5 mod; 158 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/Attributes.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/Attributes.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/Attributes.java) src/share/classes/jdk/internal/org/xml/sax/Attributes.java

281 lines changed: 281 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java) src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java

443 lines changed: 443 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java) src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java

141 lines changed: 141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java) src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java

143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java) src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java

163 lines changed: 163 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/InputSource.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/InputSource.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/InputSource.java) src/share/classes/jdk/internal/org/xml/sax/InputSource.java

360 lines changed: 360 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/Locator.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/Locator.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/Locator.java) src/share/classes/jdk/internal/org/xml/sax/Locator.java

160 lines changed: 160 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/SAXException.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/SAXException.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/SAXException.java) src/share/classes/jdk/internal/org/xml/sax/SAXException.java

188 lines changed: 188 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java) src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java) src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java) src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java

313 lines changed: 313 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/XMLReader.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/XMLReader.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/XMLReader.java) src/share/classes/jdk/internal/org/xml/sax/XMLReader.java

428 lines changed: 428 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java.html) [Patch](src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java) src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java

491 lines changed: 491 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java.html) [Patch](src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java) src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.html) [Patch](src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java) src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java

232 lines changed: 232 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/SAXParser.java.html) [Patch](src/share/classes/jdk/internal/util/xml/SAXParser.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/SAXParser.java) src/share/classes/jdk/internal/util/xml/SAXParser.java

246 lines changed: 246 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/XMLStreamException.java.html) [Patch](src/share/classes/jdk/internal/util/xml/XMLStreamException.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/XMLStreamException.java) src/share/classes/jdk/internal/util/xml/XMLStreamException.java

88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java.html) [Patch](src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java) src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java

154 lines changed: 154 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/Attrs.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/Attrs.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/Attrs.java) src/share/classes/jdk/internal/util/xml/impl/Attrs.java

430 lines changed: 430 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/Input.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/Input.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/Input.java) src/share/classes/jdk/internal/util/xml/impl/Input.java

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/Pair.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/Pair.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/Pair.java) src/share/classes/jdk/internal/util/xml/impl/Pair.java

122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/Parser.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/Parser.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/Parser.java) src/share/classes/jdk/internal/util/xml/impl/Parser.java

3372 lines changed: 3372 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java) src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java

696 lines changed: 696 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java) src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java

122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java) src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java

138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java) src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java

118 lines changed: 118 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java) src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java

633 lines changed: 633 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java.html) [Patch](src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java) src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java

152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/Properties/invalidxml/BadCase.xml.html) [Patch](test/java/util/Properties/invalidxml/BadCase.xml.patch) [Raw](raw%5Ffiles/new/test/java/util/Properties/invalidxml/BadCase.xml) test/java/util/Properties/invalidxml/BadCase.xml

9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/Properties/invalidxml/BadDocType.xml.excluded.html) [Patch](test/java/util/Properties/invalidxml/BadDocType.xml.excluded.patch) [Raw](raw%5Ffiles/new/test/java/util/Properties/invalidxml/BadDocType.xml.excluded) test/java/util/Properties/invalidxml/BadDocType.xml.excluded

9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/Properties/invalidxml/NoClosingTag.xml.html) [Patch](test/java/util/Properties/invalidxml/NoClosingTag.xml.patch) [Raw](raw%5Ffiles/new/test/java/util/Properties/invalidxml/NoClosingTag.xml) test/java/util/Properties/invalidxml/NoClosingTag.xml

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/Properties/invalidxml/NoDocType.xml.excluded.html) [Patch](test/java/util/Properties/invalidxml/NoDocType.xml.excluded.patch) [Raw](raw%5Ffiles/new/test/java/util/Properties/invalidxml/NoDocType.xml.excluded) test/java/util/Properties/invalidxml/NoDocType.xml.excluded

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/Properties/invalidxml/NoRoot.xml.html) [Patch](test/java/util/Properties/invalidxml/NoRoot.xml.patch) [Raw](raw%5Ffiles/new/test/java/util/Properties/invalidxml/NoRoot.xml) test/java/util/Properties/invalidxml/NoRoot.xml

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/Properties/invalidxml/NotQuoted.xml.html) [Patch](test/java/util/Properties/invalidxml/NotQuoted.xml.patch) [Raw](raw%5Ffiles/new/test/java/util/Properties/invalidxml/NotQuoted.xml) test/java/util/Properties/invalidxml/NotQuoted.xml

9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/Properties/invalidxml/README.txt.html) [Patch](test/java/util/Properties/invalidxml/README.txt.patch) [Raw](raw%5Ffiles/new/test/java/util/Properties/invalidxml/README.txt) test/java/util/Properties/invalidxml/README.txt

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](make/jdk/asm/Makefile-.html) ---[Patch](make/jdk/asm/Makefile.patch) --- make/jdk/asm/Makefile

40 lines changed: 0 ins; 40 del; 0 mod; 0 unchg


This code review page was prepared using ../make/scripts/webrev.ksh(vers 23.18-hg).