hs24-b35-jdk7u14-b16 (original) (raw)

Code Review for hs24-b35-jdk7u14-b16

[Cdiffs](.hgtags.cdiff.html) [Udiffs](.hgtags.udiff.html) [Wdiffs](.hgtags.wdiff.html) [Sdiffs](.hgtags.sdiff.html) [Frames](.hgtags.frames.html) [Old](.hgtags-.html) [New](.hgtags.html) [Patch](.hgtags.patch) [Raw](raw%5Ffiles/new/.hgtags) .hgtags

rev 4268 : Added tag hs24-b35 for changeset be21f8a4d42c

2 lines changed: 2 ins; 0 del; 0 mod; 446 unchg

[Cdiffs](make/hotspot%5Fversion.cdiff.html) [Udiffs](make/hotspot%5Fversion.udiff.html) [Wdiffs](make/hotspot%5Fversion.wdiff.html) [Sdiffs](make/hotspot%5Fversion.sdiff.html) [Frames](make/hotspot%5Fversion.frames.html) [Old](make/hotspot%5Fversion-.html) [New](make/hotspot%5Fversion.html) [Patch](make/hotspot%5Fversion.patch) [Raw](raw%5Ffiles/new/make/hotspot%5Fversion) make/hotspot_version

rev 4254 : 8009225: new hotspot build - hs24-b35 Reviewed-by: jcoomes

1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

[Cdiffs](src/os/bsd/vm/os%5Fbsd.cpp.cdiff.html) [Udiffs](src/os/bsd/vm/os%5Fbsd.cpp.udiff.html) [Wdiffs](src/os/bsd/vm/os%5Fbsd.cpp.wdiff.html) [Sdiffs](src/os/bsd/vm/os%5Fbsd.cpp.sdiff.html) [Frames](src/os/bsd/vm/os%5Fbsd.cpp.frames.html) [Old](src/os/bsd/vm/os%5Fbsd.cpp-.html) [New](src/os/bsd/vm/os%5Fbsd.cpp.html) [Patch](src/os/bsd/vm/os%5Fbsd.cpp.patch) [Raw](raw%5Ffiles/new/src/os/bsd/vm/os%5Fbsd.cpp) src/os/bsd/vm/os_bsd.cpp

rev 4261 : 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice@oracle.com

66 lines changed: 27 ins; 17 del; 22 mod; 5862 unchg

[Cdiffs](src/os/linux/vm/os%5Flinux.cpp.cdiff.html) [Udiffs](src/os/linux/vm/os%5Flinux.cpp.udiff.html) [Wdiffs](src/os/linux/vm/os%5Flinux.cpp.wdiff.html) [Sdiffs](src/os/linux/vm/os%5Flinux.cpp.sdiff.html) [Frames](src/os/linux/vm/os%5Flinux.cpp.frames.html) [Old](src/os/linux/vm/os%5Flinux.cpp-.html) [New](src/os/linux/vm/os%5Flinux.cpp.html) [Patch](src/os/linux/vm/os%5Flinux.cpp.patch) [Raw](raw%5Ffiles/new/src/os/linux/vm/os%5Flinux.cpp) src/os/linux/vm/os_linux.cpp

rev 4261 : 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice@oracle.com

66 lines changed: 27 ins; 17 del; 22 mod; 5566 unchg

[Cdiffs](src/os/solaris/vm/os%5Fsolaris.cpp.cdiff.html) [Udiffs](src/os/solaris/vm/os%5Fsolaris.cpp.udiff.html) [Wdiffs](src/os/solaris/vm/os%5Fsolaris.cpp.wdiff.html) [Sdiffs](src/os/solaris/vm/os%5Fsolaris.cpp.sdiff.html) [Frames](src/os/solaris/vm/os%5Fsolaris.cpp.frames.html) [Old](src/os/solaris/vm/os%5Fsolaris.cpp-.html) [New](src/os/solaris/vm/os%5Fsolaris.cpp.html) [Patch](src/os/solaris/vm/os%5Fsolaris.cpp.patch) [Raw](raw%5Ffiles/new/src/os/solaris/vm/os%5Fsolaris.cpp) src/os/solaris/vm/os_solaris.cpp

rev 4261 : 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice@oracle.com

70 lines changed: 26 ins; 27 del; 17 mod; 6610 unchg

[Cdiffs](src/os/windows/vm/os%5Fwindows.cpp.cdiff.html) [Udiffs](src/os/windows/vm/os%5Fwindows.cpp.udiff.html) [Wdiffs](src/os/windows/vm/os%5Fwindows.cpp.wdiff.html) [Sdiffs](src/os/windows/vm/os%5Fwindows.cpp.sdiff.html) [Frames](src/os/windows/vm/os%5Fwindows.cpp.frames.html) [Old](src/os/windows/vm/os%5Fwindows.cpp-.html) [New](src/os/windows/vm/os%5Fwindows.cpp.html) [Patch](src/os/windows/vm/os%5Fwindows.cpp.patch) [Raw](raw%5Ffiles/new/src/os/windows/vm/os%5Fwindows.cpp) src/os/windows/vm/os_windows.cpp

rev 4261 : 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice@oracle.com

21 lines changed: 1 ins; 0 del; 20 mod; 5451 unchg

[Cdiffs](src/share/vm/c1/c1%5FLIR.cpp.cdiff.html) [Udiffs](src/share/vm/c1/c1%5FLIR.cpp.udiff.html) [Wdiffs](src/share/vm/c1/c1%5FLIR.cpp.wdiff.html) [Sdiffs](src/share/vm/c1/c1%5FLIR.cpp.sdiff.html) [Frames](src/share/vm/c1/c1%5FLIR.cpp.frames.html) [Old](src/share/vm/c1/c1%5FLIR.cpp-.html) [New](src/share/vm/c1/c1%5FLIR.cpp.html) [Patch](src/share/vm/c1/c1%5FLIR.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/c1/c1%5FLIR.cpp) src/share/vm/c1/c1_LIR.cpp

rev 4263 : 8005722: Assert in c1_LIR.hpp incorrect wrt to number of register operands Summary: In LIR_OpVisitState::visit() the receiver operand is processed twice Reviewed-by: roland, vladidan

1 line changed: 0 ins; 0 del; 1 mod; 2052 unchg

[Cdiffs](src/share/vm/classfile/javaClasses.cpp.cdiff.html) [Udiffs](src/share/vm/classfile/javaClasses.cpp.udiff.html) [Wdiffs](src/share/vm/classfile/javaClasses.cpp.wdiff.html) [Sdiffs](src/share/vm/classfile/javaClasses.cpp.sdiff.html) [Frames](src/share/vm/classfile/javaClasses.cpp.frames.html) [Old](src/share/vm/classfile/javaClasses.cpp-.html) [New](src/share/vm/classfile/javaClasses.cpp.html) [Patch](src/share/vm/classfile/javaClasses.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/classfile/javaClasses.cpp) src/share/vm/classfile/javaClasses.cpp

rev 4261 : 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice@oracle.com

2 lines changed: 0 ins; 1 del; 1 mod; 3220 unchg

[Cdiffs](src/share/vm/runtime/atomic.hpp.cdiff.html) [Udiffs](src/share/vm/runtime/atomic.hpp.udiff.html) [Wdiffs](src/share/vm/runtime/atomic.hpp.wdiff.html) [Sdiffs](src/share/vm/runtime/atomic.hpp.sdiff.html) [Frames](src/share/vm/runtime/atomic.hpp.frames.html) [Old](src/share/vm/runtime/atomic.hpp-.html) [New](src/share/vm/runtime/atomic.hpp.html) [Patch](src/share/vm/runtime/atomic.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/atomic.hpp) src/share/vm/runtime/atomic.hpp

rev 4255 : 8008314: Unimplemented() Atomic::load breaks the applications Summary: jlong atomics isn't fully implemented on all 32-bit platforms so we try to avoid it. In this case the atomic add wasn't needed. Reviewed-by: dholmes, dlong

11 lines changed: 10 ins; 0 del; 1 mod; 88 unchg

[Cdiffs](src/share/vm/runtime/mutexLocker.cpp.cdiff.html) [Udiffs](src/share/vm/runtime/mutexLocker.cpp.udiff.html) [Wdiffs](src/share/vm/runtime/mutexLocker.cpp.wdiff.html) [Sdiffs](src/share/vm/runtime/mutexLocker.cpp.sdiff.html) [Frames](src/share/vm/runtime/mutexLocker.cpp.frames.html) [Old](src/share/vm/runtime/mutexLocker.cpp-.html) [New](src/share/vm/runtime/mutexLocker.cpp.html) [Patch](src/share/vm/runtime/mutexLocker.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/mutexLocker.cpp) src/share/vm/runtime/mutexLocker.cpp

rev 4266 : 8005572: fatal error: acquiring lock JfrBuffer_lock/19 out of order with lock MethodData_lock/19 -- possible deadlock Reviewed-by: mgronlun, dholmes

2 lines changed: 0 ins; 0 del; 2 mod; 315 unchg

[Cdiffs](src/share/vm/runtime/objectMonitor.cpp.cdiff.html) [Udiffs](src/share/vm/runtime/objectMonitor.cpp.udiff.html) [Wdiffs](src/share/vm/runtime/objectMonitor.cpp.wdiff.html) [Sdiffs](src/share/vm/runtime/objectMonitor.cpp.sdiff.html) [Frames](src/share/vm/runtime/objectMonitor.cpp.frames.html) [Old](src/share/vm/runtime/objectMonitor.cpp-.html) [New](src/share/vm/runtime/objectMonitor.cpp.html) [Patch](src/share/vm/runtime/objectMonitor.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/objectMonitor.cpp) src/share/vm/runtime/objectMonitor.cpp

rev 4261 : 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice@oracle.com

7 lines changed: 0 ins; 5 del; 2 mod; 2523 unchg

[Cdiffs](src/share/vm/runtime/objectMonitor.inline.hpp.cdiff.html) [Udiffs](src/share/vm/runtime/objectMonitor.inline.hpp.udiff.html) [Wdiffs](src/share/vm/runtime/objectMonitor.inline.hpp.wdiff.html) [Sdiffs](src/share/vm/runtime/objectMonitor.inline.hpp.sdiff.html) [Frames](src/share/vm/runtime/objectMonitor.inline.hpp.frames.html) [Old](src/share/vm/runtime/objectMonitor.inline.hpp-.html) [New](src/share/vm/runtime/objectMonitor.inline.hpp.html) [Patch](src/share/vm/runtime/objectMonitor.inline.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/objectMonitor.inline.hpp) src/share/vm/runtime/objectMonitor.inline.hpp

rev 4261 : 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice@oracle.com

5 lines changed: 3 ins; 1 del; 1 mod; 109 unchg

[Cdiffs](src/share/vm/runtime/synchronizer.cpp.cdiff.html) [Udiffs](src/share/vm/runtime/synchronizer.cpp.udiff.html) [Wdiffs](src/share/vm/runtime/synchronizer.cpp.wdiff.html) [Sdiffs](src/share/vm/runtime/synchronizer.cpp.sdiff.html) [Frames](src/share/vm/runtime/synchronizer.cpp.frames.html) [Old](src/share/vm/runtime/synchronizer.cpp-.html) [New](src/share/vm/runtime/synchronizer.cpp.html) [Patch](src/share/vm/runtime/synchronizer.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/synchronizer.cpp) src/share/vm/runtime/synchronizer.cpp

rev 4260 : 6444286: Possible naked oop related to biased locking revocation safepoint in jni_exit() Summary: Add missing Handle. Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear@oracle.com

4 lines changed: 2 ins; 0 del; 2 mod; 1683 unchg

[Cdiffs](src/share/vm/runtime/thread.cpp.cdiff.html) [Udiffs](src/share/vm/runtime/thread.cpp.udiff.html) [Wdiffs](src/share/vm/runtime/thread.cpp.wdiff.html) [Sdiffs](src/share/vm/runtime/thread.cpp.sdiff.html) [Frames](src/share/vm/runtime/thread.cpp.frames.html) [Old](src/share/vm/runtime/thread.cpp-.html) [New](src/share/vm/runtime/thread.cpp.html) [Patch](src/share/vm/runtime/thread.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/thread.cpp) src/share/vm/runtime/thread.cpp

rev 4258 : 8001384: G1: assert(!is_null(v)) failed: narrow oop value can never be zero Summary: Flush any deferred card mark before a Java thread exits. Reviewed-by: brutisso, jmasa

11 lines changed: 8 ins; 1 del; 2 mod; 4626 unchg

[Cdiffs](src/share/vm/runtime/vmThread.cpp.cdiff.html) [Udiffs](src/share/vm/runtime/vmThread.cpp.udiff.html) [Wdiffs](src/share/vm/runtime/vmThread.cpp.wdiff.html) [Sdiffs](src/share/vm/runtime/vmThread.cpp.sdiff.html) [Frames](src/share/vm/runtime/vmThread.cpp.frames.html) [Old](src/share/vm/runtime/vmThread.cpp-.html) [New](src/share/vm/runtime/vmThread.cpp.html) [Patch](src/share/vm/runtime/vmThread.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/vmThread.cpp) src/share/vm/runtime/vmThread.cpp

rev 4262 : 8004903: VMThread::execute() calls Thread::check_for_valid_safepoint_state() on concurrent VM ops Summary: check_for_valid_safepoint_state() only applies to blocking VM ops Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear@oracle.com

7 lines changed: 4 ins; 1 del; 2 mod; 719 unchg

[Cdiffs](src/share/vm/utilities/ostream.cpp.cdiff.html) [Udiffs](src/share/vm/utilities/ostream.cpp.udiff.html) [Wdiffs](src/share/vm/utilities/ostream.cpp.wdiff.html) [Sdiffs](src/share/vm/utilities/ostream.cpp.sdiff.html) [Frames](src/share/vm/utilities/ostream.cpp.frames.html) [Old](src/share/vm/utilities/ostream.cpp-.html) [New](src/share/vm/utilities/ostream.cpp.html) [Patch](src/share/vm/utilities/ostream.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/utilities/ostream.cpp) src/share/vm/utilities/ostream.cpp

rev 4255 : 8008314: Unimplemented() Atomic::load breaks the applications Summary: jlong atomics isn't fully implemented on all 32-bit platforms so we try to avoid it. In this case the atomic add wasn't needed. Reviewed-by: dholmes, dlong

12 lines changed: 3 ins; 1 del; 8 mod; 1097 unchg

[Cdiffs](src/share/vm/utilities/ostream.hpp.cdiff.html) [Udiffs](src/share/vm/utilities/ostream.hpp.udiff.html) [Wdiffs](src/share/vm/utilities/ostream.hpp.wdiff.html) [Sdiffs](src/share/vm/utilities/ostream.hpp.sdiff.html) [Frames](src/share/vm/utilities/ostream.hpp.frames.html) [Old](src/share/vm/utilities/ostream.hpp-.html) [New](src/share/vm/utilities/ostream.hpp.html) [Patch](src/share/vm/utilities/ostream.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/utilities/ostream.hpp) src/share/vm/utilities/ostream.hpp

rev 4255 : 8008314: Unimplemented() Atomic::load breaks the applications Summary: jlong atomics isn't fully implemented on all 32-bit platforms so we try to avoid it. In this case the atomic add wasn't needed. Reviewed-by: dholmes, dlong

1 line changed: 0 ins; 0 del; 1 mod; 311 unchg

This code review page was prepared using /java/jdk/bin/webrev(vers 23.18-hg).