hs24-b51-jdk7u40-b32 (original) (raw)

Code Review for hs24-b51-jdk7u40-b32

[Cdiffs](.hgtags.cdiff.html) [Udiffs](.hgtags.udiff.html) [Wdiffs](.hgtags.wdiff.html) [Sdiffs](.hgtags.sdiff.html) [Frames](.hgtags.frames.html) [Old](.hgtags-.html) [New](.hgtags.html) [Patch](.hgtags.patch) [Raw](raw%5Ffiles/new/.hgtags) .hgtags

rev 4609 : Added tag hs24-b51 for changeset 2417fa1acf2b

2 lines changed: 2 ins; 0 del; 0 mod; 511 unchg

[Cdiffs](make/hotspot%5Fversion.cdiff.html) [Udiffs](make/hotspot%5Fversion.udiff.html) [Wdiffs](make/hotspot%5Fversion.wdiff.html) [Sdiffs](make/hotspot%5Fversion.sdiff.html) [Frames](make/hotspot%5Fversion.frames.html) [Old](make/hotspot%5Fversion-.html) [New](make/hotspot%5Fversion.html) [Patch](make/hotspot%5Fversion.patch) [Raw](raw%5Ffiles/new/make/hotspot%5Fversion) make/hotspot_version

rev 4588 : 8017252: new hotspot build - hs24-b51 Reviewed-by: jcoomes

1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

[Cdiffs](src/share/vm/adlc/formssel.cpp.cdiff.html) [Udiffs](src/share/vm/adlc/formssel.cpp.udiff.html) [Wdiffs](src/share/vm/adlc/formssel.cpp.wdiff.html) [Sdiffs](src/share/vm/adlc/formssel.cpp.sdiff.html) [Frames](src/share/vm/adlc/formssel.cpp.frames.html) [Old](src/share/vm/adlc/formssel.cpp-.html) [New](src/share/vm/adlc/formssel.cpp.html) [Patch](src/share/vm/adlc/formssel.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/adlc/formssel.cpp) src/share/vm/adlc/formssel.cpp

rev 4591 : 8016157: During CTW: C2: assert(!def_outside->member(r)) failed: Use of external LRG overlaps the same LRG defined in this block Summary: Disable rematerialization for negD node Reviewed-by: kvn, roland

9 lines changed: 9 ins; 0 del; 0 mod; 4205 unchg

[Cdiffs](src/share/vm/adlc/formssel.hpp.cdiff.html) [Udiffs](src/share/vm/adlc/formssel.hpp.udiff.html) [Wdiffs](src/share/vm/adlc/formssel.hpp.wdiff.html) [Sdiffs](src/share/vm/adlc/formssel.hpp.sdiff.html) [Frames](src/share/vm/adlc/formssel.hpp.frames.html) [Old](src/share/vm/adlc/formssel.hpp-.html) [New](src/share/vm/adlc/formssel.hpp.html) [Patch](src/share/vm/adlc/formssel.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/adlc/formssel.hpp) src/share/vm/adlc/formssel.hpp

rev 4591 : 8016157: During CTW: C2: assert(!def_outside->member(r)) failed: Use of external LRG overlaps the same LRG defined in this block Summary: Disable rematerialization for negD node Reviewed-by: kvn, roland

1 line changed: 1 ins; 0 del; 0 mod; 1079 unchg

[Cdiffs](src/share/vm/classfile/symbolTable.cpp.cdiff.html) [Udiffs](src/share/vm/classfile/symbolTable.cpp.udiff.html) [Wdiffs](src/share/vm/classfile/symbolTable.cpp.wdiff.html) [Sdiffs](src/share/vm/classfile/symbolTable.cpp.sdiff.html) [Frames](src/share/vm/classfile/symbolTable.cpp.frames.html) [Old](src/share/vm/classfile/symbolTable.cpp-.html) [New](src/share/vm/classfile/symbolTable.cpp.html) [Patch](src/share/vm/classfile/symbolTable.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/classfile/symbolTable.cpp) src/share/vm/classfile/symbolTable.cpp

rev 4592 : 8015237: Parallelize string table scanning during strong root processing Summary: Parallelize the scanning of the intern string table by having each GC worker claim a given number of buckets. Changes were also reviewed by Per Liden per.liden@oracle.com. Reviewed-by: tschatzl, stefank, twisti

36 lines changed: 33 ins; 0 del; 3 mod; 842 unchg

[Cdiffs](src/share/vm/classfile/symbolTable.hpp.cdiff.html) [Udiffs](src/share/vm/classfile/symbolTable.hpp.udiff.html) [Wdiffs](src/share/vm/classfile/symbolTable.hpp.wdiff.html) [Sdiffs](src/share/vm/classfile/symbolTable.hpp.sdiff.html) [Frames](src/share/vm/classfile/symbolTable.hpp.frames.html) [Old](src/share/vm/classfile/symbolTable.hpp-.html) [New](src/share/vm/classfile/symbolTable.hpp.html) [Patch](src/share/vm/classfile/symbolTable.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/classfile/symbolTable.hpp) src/share/vm/classfile/symbolTable.hpp

rev 4592 : 8015237: Parallelize string table scanning during strong root processing Summary: Parallelize the scanning of the intern string table by having each GC worker claim a given number of buckets. Changes were also reviewed by Per Liden per.liden@oracle.com. Reviewed-by: tschatzl, stefank, twisti

15 lines changed: 13 ins; 0 del; 2 mod; 317 unchg

[Cdiffs](src/share/vm/gc%5Fimplementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp.cdiff.html) [Udiffs](src/share/vm/gc%5Fimplementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp.udiff.html) [Wdiffs](src/share/vm/gc%5Fimplementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp.wdiff.html) [Sdiffs](src/share/vm/gc%5Fimplementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp.sdiff.html) [Frames](src/share/vm/gc%5Fimplementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp.frames.html) [Old](src/share/vm/gc%5Fimplementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp-.html) [New](src/share/vm/gc%5Fimplementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp.html) [Patch](src/share/vm/gc%5Fimplementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/gc%5Fimplementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp) src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp

rev 4589 : 8016734: Remove extra code due to duplicated push Reviewed-by: brutisso, tschatzl

4 lines changed: 0 ins; 4 del; 0 mod; 9435 unchg

[Cdiffs](src/share/vm/gc%5Fimplementation/g1/g1CollectorPolicy.cpp.cdiff.html) [Udiffs](src/share/vm/gc%5Fimplementation/g1/g1CollectorPolicy.cpp.udiff.html) [Wdiffs](src/share/vm/gc%5Fimplementation/g1/g1CollectorPolicy.cpp.wdiff.html) [Sdiffs](src/share/vm/gc%5Fimplementation/g1/g1CollectorPolicy.cpp.sdiff.html) [Frames](src/share/vm/gc%5Fimplementation/g1/g1CollectorPolicy.cpp.frames.html) [Old](src/share/vm/gc%5Fimplementation/g1/g1CollectorPolicy.cpp-.html) [New](src/share/vm/gc%5Fimplementation/g1/g1CollectorPolicy.cpp.html) [Patch](src/share/vm/gc%5Fimplementation/g1/g1CollectorPolicy.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/gc%5Fimplementation/g1/g1CollectorPolicy.cpp) src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp

rev 4602 : 8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment Summary: Make sure max alignemnt is at least as large as min alignment Reviewed-by: johnc, jmasa, tschatzl

2 lines changed: 1 ins; 0 del; 1 mod; 2234 unchg

[Cdiffs](src/share/vm/gc%5Fimplementation/parallelScavenge/psOldGen.cpp.cdiff.html) [Udiffs](src/share/vm/gc%5Fimplementation/parallelScavenge/psOldGen.cpp.udiff.html) [Wdiffs](src/share/vm/gc%5Fimplementation/parallelScavenge/psOldGen.cpp.wdiff.html) [Sdiffs](src/share/vm/gc%5Fimplementation/parallelScavenge/psOldGen.cpp.sdiff.html) [Frames](src/share/vm/gc%5Fimplementation/parallelScavenge/psOldGen.cpp.frames.html) [Old](src/share/vm/gc%5Fimplementation/parallelScavenge/psOldGen.cpp-.html) [New](src/share/vm/gc%5Fimplementation/parallelScavenge/psOldGen.cpp.html) [Patch](src/share/vm/gc%5Fimplementation/parallelScavenge/psOldGen.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/gc%5Fimplementation/parallelScavenge/psOldGen.cpp) src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp

rev 4595 : 8016740: assert in GC_locker from PSOldGen::expand with -XX:+PrintGCDetails and Verbose Summary: Use GC_locker::is_active_and_needs_gc() instead of GC_locker::is_active() for providing information about the reason of heap expansion. Reviewed-by: johnc, tamao

1 line changed: 0 ins; 0 del; 1 mod; 507 unchg

[Cdiffs](src/share/vm/memory/collectorPolicy.cpp.cdiff.html) [Udiffs](src/share/vm/memory/collectorPolicy.cpp.udiff.html) [Wdiffs](src/share/vm/memory/collectorPolicy.cpp.wdiff.html) [Sdiffs](src/share/vm/memory/collectorPolicy.cpp.sdiff.html) [Frames](src/share/vm/memory/collectorPolicy.cpp.frames.html) [Old](src/share/vm/memory/collectorPolicy.cpp-.html) [New](src/share/vm/memory/collectorPolicy.cpp.html) [Patch](src/share/vm/memory/collectorPolicy.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/memory/collectorPolicy.cpp) src/share/vm/memory/collectorPolicy.cpp

rev 4602 : 8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment Summary: Make sure max alignemnt is at least as large as min alignment Reviewed-by: johnc, jmasa, tschatzl

10 lines changed: 7 ins; 3 del; 0 mod; 802 unchg

[Cdiffs](src/share/vm/memory/sharedHeap.cpp.cdiff.html) [Udiffs](src/share/vm/memory/sharedHeap.cpp.udiff.html) [Wdiffs](src/share/vm/memory/sharedHeap.cpp.wdiff.html) [Sdiffs](src/share/vm/memory/sharedHeap.cpp.sdiff.html) [Frames](src/share/vm/memory/sharedHeap.cpp.frames.html) [Old](src/share/vm/memory/sharedHeap.cpp-.html) [New](src/share/vm/memory/sharedHeap.cpp.html) [Patch](src/share/vm/memory/sharedHeap.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/memory/sharedHeap.cpp) src/share/vm/memory/sharedHeap.cpp

rev 4592 : 8015237: Parallelize string table scanning during strong root processing Summary: Parallelize the scanning of the intern string table by having each GC worker claim a given number of buckets. Changes were also reviewed by Per Liden per.liden@oracle.com. Reviewed-by: tschatzl, stefank, twisti

19 lines changed: 12 ins; 1 del; 6 mod; 302 unchg

[Cdiffs](src/share/vm/opto/escape.cpp.cdiff.html) [Udiffs](src/share/vm/opto/escape.cpp.udiff.html) [Wdiffs](src/share/vm/opto/escape.cpp.wdiff.html) [Sdiffs](src/share/vm/opto/escape.cpp.sdiff.html) [Frames](src/share/vm/opto/escape.cpp.frames.html) [Old](src/share/vm/opto/escape.cpp-.html) [New](src/share/vm/opto/escape.cpp.html) [Patch](src/share/vm/opto/escape.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/escape.cpp) src/share/vm/opto/escape.cpp

rev 4607 : 8015441: runThese crashed with assert(opcode == Op_ConP || opcode == Op_ThreadLocal || opcode == Op_CastX2P ..) failed: sanity Summary: Relax the assert to accept any raw ptr types. Reviewed-by: roland

1 line changed: 0 ins; 0 del; 1 mod; 3258 unchg

[Cdiffs](src/share/vm/opto/memnode.cpp.cdiff.html) [Udiffs](src/share/vm/opto/memnode.cpp.udiff.html) [Wdiffs](src/share/vm/opto/memnode.cpp.wdiff.html) [Sdiffs](src/share/vm/opto/memnode.cpp.sdiff.html) [Frames](src/share/vm/opto/memnode.cpp.frames.html) [Old](src/share/vm/opto/memnode.cpp-.html) [New](src/share/vm/opto/memnode.cpp.html) [Patch](src/share/vm/opto/memnode.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/memnode.cpp) src/share/vm/opto/memnode.cpp

rev 4600 : 8001345: VM crashes with assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc Summary: Remove unnecessary LoadN / DecodeN nodes at MemBarAcquire nodes. Reviewed-by: kvn, roland

19 lines changed: 17 ins; 0 del; 2 mod; 4414 unchg

[Cdiffs](src/share/vm/services/memReporter.cpp.cdiff.html) [Udiffs](src/share/vm/services/memReporter.cpp.udiff.html) [Wdiffs](src/share/vm/services/memReporter.cpp.wdiff.html) [Sdiffs](src/share/vm/services/memReporter.cpp.sdiff.html) [Frames](src/share/vm/services/memReporter.cpp.frames.html) [Old](src/share/vm/services/memReporter.cpp-.html) [New](src/share/vm/services/memReporter.cpp.html) [Patch](src/share/vm/services/memReporter.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/services/memReporter.cpp) src/share/vm/services/memReporter.cpp

rev 4605 : 8017478: Kitchensink crashed with SIGSEGV in BaselineReporter::diff_callsites Summary: Fixed possible NULL pointer that caused SIGSEGV Reviewed-by: coleenp, acorn, ctornqvi

33 lines changed: 20 ins; 0 del; 13 mod; 604 unchg

[Cdiffs](src/share/vm/trace/trace.xml.cdiff.html) [Udiffs](src/share/vm/trace/trace.xml.udiff.html) [Wdiffs](src/share/vm/trace/trace.xml.wdiff.html) [Sdiffs](src/share/vm/trace/trace.xml.sdiff.html) [Frames](src/share/vm/trace/trace.xml.frames.html) [Old](src/share/vm/trace/trace.xml-.html) [New](src/share/vm/trace/trace.xml.html) [Patch](src/share/vm/trace/trace.xml.patch) [Raw](raw%5Ffiles/new/src/share/vm/trace/trace.xml) src/share/vm/trace/trace.xml

rev 4598 : 8016331: Minor issues in event tracing metadata Reviewed-by: stefank, brutisso, mgronlun

6 lines changed: 0 ins; 0 del; 6 mod; 355 unchg

------ ------ ------ ------ ------ ---[New](test/compiler/8005956/PolynomialRoot.java.html) [Patch](test/compiler/8005956/PolynomialRoot.java.patch) [Raw](raw%5Ffiles/new/test/compiler/8005956/PolynomialRoot.java) test/compiler/8005956/PolynomialRoot.java

rev 4597 : 8017510: Add a regression test for 8005956 Summary: Regression test for 8005956 Reviewed-by: kvn, twisti

776 lines changed: 776 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/gc/g1/TestRegionAlignment.java.html) [Patch](test/gc/g1/TestRegionAlignment.java.patch) [Raw](raw%5Ffiles/new/test/gc/g1/TestRegionAlignment.java) test/gc/g1/TestRegionAlignment.java

rev 4602 : 8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment Summary: Make sure max alignemnt is at least as large as min alignment Reviewed-by: johnc, jmasa, tschatzl

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------[Old](test/compiler/8011901/Test8011901.java-.html) ---[Patch](test/compiler/8011901/Test8011901.java.patch) --- test/compiler/8011901/Test8011901.java

68 lines changed: 0 ins; 68 del; 0 mod; 0 unchg

This code review page was prepared using /java/jdk/bin/webrev(vers 23.18-hg).