jdk (original) (raw)

Code Review for jdk

Prepared by: andrew on Wed Sep 19 00:43:36 BST 2012
Workspace: /home/andrew/projects/openjdk/upstream/jdk7/jdk
Compare against: ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk/
Compare against version: 5320
Summary of changes: 161 lines changed: 112 ins; 38 del; 11 mod; 4331 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](make/java/zip/mapfile-vers.cdiff.html) [Udiffs](make/java/zip/mapfile-vers.udiff.html) [Sdiffs](make/java/zip/mapfile-vers.sdiff.html) [Frames](make/java/zip/mapfile-vers.frames.html) [Old](make/java/zip/mapfile-vers-.html) [New](make/java/zip/mapfile-vers.html) [Patch](make/java/zip/mapfile-vers.patch) [Raw](raw%5Ffiles/new/make/java/zip/mapfile-vers) make/java/zip/mapfile-vers

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

4 lines changed: 0 ins; 4 del; 0 mod; 81 unchg

[Cdiffs](src/share/classes/java/util/zip/Deflater.java.cdiff.html) [Udiffs](src/share/classes/java/util/zip/Deflater.java.udiff.html) [Sdiffs](src/share/classes/java/util/zip/Deflater.java.sdiff.html) [Frames](src/share/classes/java/util/zip/Deflater.java.frames.html) [Old](src/share/classes/java/util/zip/Deflater.java-.html) [New](src/share/classes/java/util/zip/Deflater.java.html) [Patch](src/share/classes/java/util/zip/Deflater.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/zip/Deflater.java) src/share/classes/java/util/zip/Deflater.java

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

14 lines changed: 8 ins; 2 del; 4 mod; 544 unchg

[Cdiffs](src/share/classes/java/util/zip/Inflater.java.cdiff.html) [Udiffs](src/share/classes/java/util/zip/Inflater.java.udiff.html) [Sdiffs](src/share/classes/java/util/zip/Inflater.java.sdiff.html) [Frames](src/share/classes/java/util/zip/Inflater.java.frames.html) [Old](src/share/classes/java/util/zip/Inflater.java-.html) [New](src/share/classes/java/util/zip/Inflater.java.html) [Patch](src/share/classes/java/util/zip/Inflater.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/zip/Inflater.java) src/share/classes/java/util/zip/Inflater.java

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

12 lines changed: 7 ins; 2 del; 3 mod; 397 unchg

[Cdiffs](src/share/native/java/util/zip/Deflater.c.cdiff.html) [Udiffs](src/share/native/java/util/zip/Deflater.c.udiff.html) [Sdiffs](src/share/native/java/util/zip/Deflater.c.sdiff.html) [Frames](src/share/native/java/util/zip/Deflater.c.frames.html) [Old](src/share/native/java/util/zip/Deflater.c-.html) [New](src/share/native/java/util/zip/Deflater.c.html) [Patch](src/share/native/java/util/zip/Deflater.c.patch) [Raw](raw%5Ffiles/new/src/share/native/java/util/zip/Deflater.c) src/share/native/java/util/zip/Deflater.c

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

12 lines changed: 0 ins; 12 del; 0 mod; 234 unchg

[Cdiffs](src/share/native/java/util/zip/Inflater.c.cdiff.html) [Udiffs](src/share/native/java/util/zip/Inflater.c.udiff.html) [Sdiffs](src/share/native/java/util/zip/Inflater.c.sdiff.html) [Frames](src/share/native/java/util/zip/Inflater.c.frames.html) [Old](src/share/native/java/util/zip/Inflater.c-.html) [New](src/share/native/java/util/zip/Inflater.c.html) [Patch](src/share/native/java/util/zip/Inflater.c.patch) [Raw](raw%5Ffiles/new/src/share/native/java/util/zip/Inflater.c) src/share/native/java/util/zip/Inflater.c

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

12 lines changed: 0 ins; 12 del; 0 mod; 193 unchg

[Cdiffs](src/share/native/java/util/zip/zlib-1.2.3/compress.c.cdiff.html) [Udiffs](src/share/native/java/util/zip/zlib-1.2.3/compress.c.udiff.html) [Sdiffs](src/share/native/java/util/zip/zlib-1.2.3/compress.c.sdiff.html) [Frames](src/share/native/java/util/zip/zlib-1.2.3/compress.c.frames.html) [Old](src/share/native/java/util/zip/zlib-1.2.3/compress.c-.html) [New](src/share/native/java/util/zip/zlib-1.2.3/compress.c.html) [Patch](src/share/native/java/util/zip/zlib-1.2.3/compress.c.patch) [Raw](raw%5Ffiles/new/src/share/native/java/util/zip/zlib-1.2.3/compress.c) src/share/native/java/util/zip/zlib-1.2.3/compress.c

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

1 line changed: 0 ins; 0 del; 1 mod; 102 unchg

[Cdiffs](src/share/native/java/util/zip/zlib-1.2.3/inflate.c.cdiff.html) [Udiffs](src/share/native/java/util/zip/zlib-1.2.3/inflate.c.udiff.html) [Sdiffs](src/share/native/java/util/zip/zlib-1.2.3/inflate.c.sdiff.html) [Frames](src/share/native/java/util/zip/zlib-1.2.3/inflate.c.frames.html) [Old](src/share/native/java/util/zip/zlib-1.2.3/inflate.c-.html) [New](src/share/native/java/util/zip/zlib-1.2.3/inflate.c.html) [Patch](src/share/native/java/util/zip/zlib-1.2.3/inflate.c.patch) [Raw](raw%5Ffiles/new/src/share/native/java/util/zip/zlib-1.2.3/inflate.c) src/share/native/java/util/zip/zlib-1.2.3/inflate.c

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

1 line changed: 0 ins; 0 del; 1 mod; 1391 unchg

[Cdiffs](src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog%5Fjava.cdiff.html) [Udiffs](src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog%5Fjava.udiff.html) [Sdiffs](src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog%5Fjava.sdiff.html) [Frames](src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog%5Fjava.frames.html) [Old](src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog%5Fjava-.html) [New](src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog%5Fjava.html) [Patch](src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog%5Fjava.patch) [Raw](raw%5Ffiles/new/src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog%5Fjava) src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

6 lines changed: 0 ins; 6 del; 0 mod; 10 unchg

[Cdiffs](src/share/native/java/util/zip/zlib-1.2.3/zlib.h.cdiff.html) [Udiffs](src/share/native/java/util/zip/zlib-1.2.3/zlib.h.udiff.html) [Sdiffs](src/share/native/java/util/zip/zlib-1.2.3/zlib.h.sdiff.html) [Frames](src/share/native/java/util/zip/zlib-1.2.3/zlib.h.frames.html) [Old](src/share/native/java/util/zip/zlib-1.2.3/zlib.h-.html) [New](src/share/native/java/util/zip/zlib-1.2.3/zlib.h.html) [Patch](src/share/native/java/util/zip/zlib-1.2.3/zlib.h.patch) [Raw](raw%5Ffiles/new/src/share/native/java/util/zip/zlib-1.2.3/zlib.h) src/share/native/java/util/zip/zlib-1.2.3/zlib.h

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

2 lines changed: 0 ins; 0 del; 2 mod; 1379 unchg

------ ------ ------ ------ ---[New](test/java/util/zip/TotalInOut.java.html) [Patch](test/java/util/zip/TotalInOut.java.patch) [Raw](raw%5Ffiles/new/test/java/util/zip/TotalInOut.java) test/java/util/zip/TotalInOut.java

rev 5321 : 7188852: Move implementation of De/Inflater.getBytesRead/Writtten() to java from native Summary: re-implemented getBytesRead/Writtten() at java level Reviewed-by: andrew, alanb

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/andrew/bin/webrev(vers 23.18-hg).