open (original) (raw)

Code Review for open

Prepared by: bobv on Wed Jan 17 11🔞59 EST 2018
Workspace: /export/users/bobv/jdk11hs/open
Compare against: ssh://hg.openjdk.java.net/jdk/hs
Summary of changes: 860 lines changed: 708 ins; 61 del; 91 mod; 2496 unchg
Patch of changes: <open.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/hotspot/os/linux/perfMemory%5Flinux.cpp.cdiff.html) [Udiffs](src/hotspot/os/linux/perfMemory%5Flinux.cpp.udiff.html) [Sdiffs](src/hotspot/os/linux/perfMemory%5Flinux.cpp.sdiff.html) [Frames](src/hotspot/os/linux/perfMemory%5Flinux.cpp.frames.html) [Old](src/hotspot/os/linux/perfMemory%5Flinux.cpp-.html) [New](src/hotspot/os/linux/perfMemory%5Flinux.cpp.html) [Patch](src/hotspot/os/linux/perfMemory%5Flinux.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/os/linux/perfMemory%5Flinux.cpp) src/hotspot/os/linux/perfMemory_linux.cpp

90 lines changed: 73 ins; 1 del; 16 mod; 1267 unchg

[Cdiffs](src/java.base/share/classes/jdk/internal/vm/VMSupport.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/vm/VMSupport.java.udiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/vm/VMSupport.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/vm/VMSupport.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/vm/VMSupport.java-.html) [New](src/java.base/share/classes/jdk/internal/vm/VMSupport.java.html) [Patch](src/java.base/share/classes/jdk/internal/vm/VMSupport.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/vm/VMSupport.java) src/java.base/share/classes/jdk/internal/vm/VMSupport.java

54 lines changed: 53 ins; 0 del; 1 mod; 109 unchg

[Cdiffs](src/java.base/share/classes/module-info.java.cdiff.html) [Udiffs](src/java.base/share/classes/module-info.java.udiff.html) [Sdiffs](src/java.base/share/classes/module-info.java.sdiff.html) [Frames](src/java.base/share/classes/module-info.java.frames.html) [Old](src/java.base/share/classes/module-info.java-.html) [New](src/java.base/share/classes/module-info.java.html) [Patch](src/java.base/share/classes/module-info.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/module-info.java) src/java.base/share/classes/module-info.java

2 lines changed: 1 ins; 0 del; 1 mod; 362 unchg

[Cdiffs](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.cdiff.html) [Udiffs](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.udiff.html) [Sdiffs](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.sdiff.html) [Frames](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.frames.html) [Old](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java-.html) [New](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.html) [Patch](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.patch) [Raw](raw%5Ffiles/new/src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java) src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java

38 lines changed: 1 ins; 35 del; 2 mod; 348 unchg

[Cdiffs](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java.cdiff.html) [Udiffs](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java.udiff.html) [Sdiffs](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java.sdiff.html) [Frames](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java.frames.html) [Old](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java-.html) [New](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java.html) [Patch](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java.patch) [Raw](raw%5Ffiles/new/src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java) src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java

71 lines changed: 28 ins; 20 del; 23 mod; 155 unchg

[Cdiffs](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java.cdiff.html) [Udiffs](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java.udiff.html) [Sdiffs](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java.sdiff.html) [Frames](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java.frames.html) [Old](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java-.html) [New](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java.html) [Patch](src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java.patch) [Raw](raw%5Ffiles/new/src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java) src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java

101 lines changed: 48 ins; 5 del; 48 mod; 255 unchg

------ ------ ------ ------ ---[New](src/java.base/aix/classes/jdk/internal/vm/VMSupportImpl.java.html) [Patch](src/java.base/aix/classes/jdk/internal/vm/VMSupportImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/aix/classes/jdk/internal/vm/VMSupportImpl.java) src/java.base/aix/classes/jdk/internal/vm/VMSupportImpl.java

69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/java.base/linux/classes/jdk/internal/vm/VMSupportImpl.java.html) [Patch](src/java.base/linux/classes/jdk/internal/vm/VMSupportImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/linux/classes/jdk/internal/vm/VMSupportImpl.java) src/java.base/linux/classes/jdk/internal/vm/VMSupportImpl.java

228 lines changed: 228 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/java.base/macosx/classes/jdk/internal/vm/VMSupportImpl.java.html) [Patch](src/java.base/macosx/classes/jdk/internal/vm/VMSupportImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/macosx/classes/jdk/internal/vm/VMSupportImpl.java) src/java.base/macosx/classes/jdk/internal/vm/VMSupportImpl.java

69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/java.base/solaris/classes/jdk/internal/vm/VMSupportImpl.java.html) [Patch](src/java.base/solaris/classes/jdk/internal/vm/VMSupportImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/solaris/classes/jdk/internal/vm/VMSupportImpl.java) src/java.base/solaris/classes/jdk/internal/vm/VMSupportImpl.java

69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/java.base/windows/classes/jdk/internal/vm/VMSupportImpl.java.html) [Patch](src/java.base/windows/classes/jdk/internal/vm/VMSupportImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/windows/classes/jdk/internal/vm/VMSupportImpl.java) src/java.base/windows/classes/jdk/internal/vm/VMSupportImpl.java

69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/bobv/bin/webrev(vers 23.18-hg-never).