open (original) (raw)
Code Review for open
| Prepared by: | bpb on Wed Dec 6 10:55:21 PST 2017 |
|---|---|
| Workspace: | /Users/bpb/Work/CoreLibs/jdk/jdk10/master-closed/open |
| Compare against: | http://hg.openjdk.java.net/jdk/jdk |
| Compare against version: | 48081 |
| Summary of changes: | 363 lines changed: 359 ins; 0 del; 4 mod; 1069 unchg |
| Patch of changes: | <open.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/java.base/share/classes/java/io/InputStream.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/io/InputStream.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/io/InputStream.java.sdiff.html) [Frames](src/java.base/share/classes/java/io/InputStream.java.frames.html) [Old](src/java.base/share/classes/java/io/InputStream.java-.html) [New](src/java.base/share/classes/java/io/InputStream.java.html) [Patch](src/java.base/share/classes/java/io/InputStream.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/io/InputStream.java) src/java.base/share/classes/java/io/InputStream.java
rev 48083 : [mq]: 4358774-nullISAndOS.01 rev 48082 : 4358774: Add null InputStream and OutputStream Reviewed-by: XXX rev 47920 : 8191516: OutputStream.write(byte[],int,int) could have fewer parameter bounds checks Summary: Reduce parameter bounds checks from five to three as in InputStream::read Reviewed-by: psandoz rev 47216 : 8187443: Forest Consolidation: Move files to unified layout Reviewed-by: darcy, ihse
100 lines changed: 100 ins; 0 del; 0 mod; 527 unchg
[Cdiffs](src/java.base/share/classes/java/io/OutputStream.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/io/OutputStream.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/io/OutputStream.java.sdiff.html) [Frames](src/java.base/share/classes/java/io/OutputStream.java.frames.html) [Old](src/java.base/share/classes/java/io/OutputStream.java-.html) [New](src/java.base/share/classes/java/io/OutputStream.java.html) [Patch](src/java.base/share/classes/java/io/OutputStream.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/io/OutputStream.java) src/java.base/share/classes/java/io/OutputStream.java
rev 48083 : [mq]: 4358774-nullISAndOS.01 rev 48082 : 4358774: Add null InputStream and OutputStream Reviewed-by: XXX rev 47920 : 8191516: OutputStream.write(byte[],int,int) could have fewer parameter bounds checks Summary: Reduce parameter bounds checks from five to three as in InputStream::read Reviewed-by: psandoz rev 47216 : 8187443: Forest Consolidation: Move files to unified layout Reviewed-by: darcy, ihse
45 lines changed: 45 ins; 0 del; 0 mod; 151 unchg
[Cdiffs](test/jdk/java/io/InputStream/ReadParams.java.cdiff.html) [Udiffs](test/jdk/java/io/InputStream/ReadParams.java.udiff.html) [Sdiffs](test/jdk/java/io/InputStream/ReadParams.java.sdiff.html) [Frames](test/jdk/java/io/InputStream/ReadParams.java.frames.html) [Old](test/jdk/java/io/InputStream/ReadParams.java-.html) [New](test/jdk/java/io/InputStream/ReadParams.java.html) [Patch](test/jdk/java/io/InputStream/ReadParams.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/io/InputStream/ReadParams.java) test/jdk/java/io/InputStream/ReadParams.java
rev 48082 : 4358774: Add null InputStream and OutputStream Reviewed-by: XXX rev 47216 : 8187443: Forest Consolidation: Move files to unified layout Reviewed-by: darcy, ihse
7 lines changed: 5 ins; 0 del; 2 mod; 224 unchg
[Cdiffs](test/jdk/java/io/OutputStream/WriteParams.java.cdiff.html) [Udiffs](test/jdk/java/io/OutputStream/WriteParams.java.udiff.html) [Sdiffs](test/jdk/java/io/OutputStream/WriteParams.java.sdiff.html) [Frames](test/jdk/java/io/OutputStream/WriteParams.java.frames.html) [Old](test/jdk/java/io/OutputStream/WriteParams.java-.html) [New](test/jdk/java/io/OutputStream/WriteParams.java.html) [Patch](test/jdk/java/io/OutputStream/WriteParams.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/io/OutputStream/WriteParams.java) test/jdk/java/io/OutputStream/WriteParams.java
rev 48082 : 4358774: Add null InputStream and OutputStream Reviewed-by: XXX rev 47216 : 8187443: Forest Consolidation: Move files to unified layout Reviewed-by: darcy, ihse
7 lines changed: 5 ins; 0 del; 2 mod; 167 unchg
------ ------ ------ ------ ---[New](test/jdk/java/io/InputStream/NullInputStream.java.html) [Patch](test/jdk/java/io/InputStream/NullInputStream.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/io/InputStream/NullInputStream.java) test/jdk/java/io/InputStream/NullInputStream.java
rev 48083 : [mq]: 4358774-nullISAndOS.01 rev 48082 : 4358774: Add null InputStream and OutputStream Reviewed-by: XXX
131 lines changed: 131 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ---[New](test/jdk/java/io/OutputStream/NullOutputStream.java.html) [Patch](test/jdk/java/io/OutputStream/NullOutputStream.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/io/OutputStream/NullOutputStream.java) test/jdk/java/io/OutputStream/NullOutputStream.java
rev 48083 : [mq]: 4358774-nullISAndOS.01 rev 48082 : 4358774: Add null InputStream and OutputStream Reviewed-by: XXX
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using /usr/local/bin/webrev.ksh(vers 25.16-hg+openjdk.java.net).