jdk (original) (raw)

Code Review for jdk

Prepared by: bpb on Mon Jun 24 11:02:19 PDT 2013
Workspace: /Users/bpb/Work/JSL/jdk/jdk8/tl8/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl/jdk
Compare against version: 7489
Summary of changes: 95 lines changed: 90 ins; 1 del; 4 mod; 15052 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/java/util/Formatter.java.cdiff.html) [Udiffs](src/share/classes/java/util/Formatter.java.udiff.html) [Sdiffs](src/share/classes/java/util/Formatter.java.sdiff.html) [Frames](src/share/classes/java/util/Formatter.java.frames.html) [Old](src/share/classes/java/util/Formatter.java-.html) [New](src/share/classes/java/util/Formatter.java.html) [Patch](src/share/classes/java/util/Formatter.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/Formatter.java) src/share/classes/java/util/Formatter.java

rev 7490 : 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: TBD Contributed-by: Brian Burkhalter brian.burkhalter@oracle.com

16 lines changed: 12 ins; 1 del; 3 mod; 4664 unchg

[Cdiffs](test/java/util/Formatter/Basic-X.java.template.cdiff.html) [Udiffs](test/java/util/Formatter/Basic-X.java.template.udiff.html) [Sdiffs](test/java/util/Formatter/Basic-X.java.template.sdiff.html) [Frames](test/java/util/Formatter/Basic-X.java.template.frames.html) [Old](test/java/util/Formatter/Basic-X.java.template-.html) [New](test/java/util/Formatter/Basic-X.java.template.html) [Patch](test/java/util/Formatter/Basic-X.java.template.patch) [Raw](raw%5Ffiles/new/test/java/util/Formatter/Basic-X.java.template) test/java/util/Formatter/Basic-X.java.template

rev 7490 : 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: TBD Contributed-by: Brian Burkhalter brian.burkhalter@oracle.com

7 lines changed: 7 ins; 0 del; 0 mod; 1720 unchg

[Cdiffs](test/java/util/Formatter/Basic.java.cdiff.html) [Udiffs](test/java/util/Formatter/Basic.java.udiff.html) [Sdiffs](test/java/util/Formatter/Basic.java.sdiff.html) [Frames](test/java/util/Formatter/Basic.java.frames.html) [Old](test/java/util/Formatter/Basic.java-.html) [New](test/java/util/Formatter/Basic.java.html) [Patch](test/java/util/Formatter/Basic.java.patch) [Raw](raw%5Ffiles/new/test/java/util/Formatter/Basic.java) test/java/util/Formatter/Basic.java

rev 7490 : 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: TBD Contributed-by: Brian Burkhalter brian.burkhalter@oracle.com

1 line changed: 0 ins; 0 del; 1 mod; 104 unchg

[Cdiffs](test/java/util/Formatter/BasicBigDecimal.java.cdiff.html) [Udiffs](test/java/util/Formatter/BasicBigDecimal.java.udiff.html) [Sdiffs](test/java/util/Formatter/BasicBigDecimal.java.sdiff.html) [Frames](test/java/util/Formatter/BasicBigDecimal.java.frames.html) [Old](test/java/util/Formatter/BasicBigDecimal.java-.html) [New](test/java/util/Formatter/BasicBigDecimal.java.html) [Patch](test/java/util/Formatter/BasicBigDecimal.java.patch) [Raw](raw%5Ffiles/new/test/java/util/Formatter/BasicBigDecimal.java) test/java/util/Formatter/BasicBigDecimal.java

rev 7490 : 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: TBD Contributed-by: Brian Burkhalter brian.burkhalter@oracle.com

7 lines changed: 7 ins; 0 del; 0 mod; 1720 unchg

[Cdiffs](test/java/util/Formatter/BasicDouble.java.cdiff.html) [Udiffs](test/java/util/Formatter/BasicDouble.java.udiff.html) [Sdiffs](test/java/util/Formatter/BasicDouble.java.sdiff.html) [Frames](test/java/util/Formatter/BasicDouble.java.frames.html) [Old](test/java/util/Formatter/BasicDouble.java-.html) [New](test/java/util/Formatter/BasicDouble.java.html) [Patch](test/java/util/Formatter/BasicDouble.java.patch) [Raw](raw%5Ffiles/new/test/java/util/Formatter/BasicDouble.java) test/java/util/Formatter/BasicDouble.java

rev 7490 : 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: TBD Contributed-by: Brian Burkhalter brian.burkhalter@oracle.com

16 lines changed: 16 ins; 0 del; 0 mod; 1711 unchg

[Cdiffs](test/java/util/Formatter/BasicDoubleObject.java.cdiff.html) [Udiffs](test/java/util/Formatter/BasicDoubleObject.java.udiff.html) [Sdiffs](test/java/util/Formatter/BasicDoubleObject.java.sdiff.html) [Frames](test/java/util/Formatter/BasicDoubleObject.java.frames.html) [Old](test/java/util/Formatter/BasicDoubleObject.java-.html) [New](test/java/util/Formatter/BasicDoubleObject.java.html) [Patch](test/java/util/Formatter/BasicDoubleObject.java.patch) [Raw](raw%5Ffiles/new/test/java/util/Formatter/BasicDoubleObject.java) test/java/util/Formatter/BasicDoubleObject.java

rev 7490 : 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: TBD Contributed-by: Brian Burkhalter brian.burkhalter@oracle.com

16 lines changed: 16 ins; 0 del; 0 mod; 1711 unchg

[Cdiffs](test/java/util/Formatter/BasicFloat.java.cdiff.html) [Udiffs](test/java/util/Formatter/BasicFloat.java.udiff.html) [Sdiffs](test/java/util/Formatter/BasicFloat.java.sdiff.html) [Frames](test/java/util/Formatter/BasicFloat.java.frames.html) [Old](test/java/util/Formatter/BasicFloat.java-.html) [New](test/java/util/Formatter/BasicFloat.java.html) [Patch](test/java/util/Formatter/BasicFloat.java.patch) [Raw](raw%5Ffiles/new/test/java/util/Formatter/BasicFloat.java) test/java/util/Formatter/BasicFloat.java

rev 7490 : 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: TBD Contributed-by: Brian Burkhalter brian.burkhalter@oracle.com

16 lines changed: 16 ins; 0 del; 0 mod; 1711 unchg

[Cdiffs](test/java/util/Formatter/BasicFloatObject.java.cdiff.html) [Udiffs](test/java/util/Formatter/BasicFloatObject.java.udiff.html) [Sdiffs](test/java/util/Formatter/BasicFloatObject.java.sdiff.html) [Frames](test/java/util/Formatter/BasicFloatObject.java.frames.html) [Old](test/java/util/Formatter/BasicFloatObject.java-.html) [New](test/java/util/Formatter/BasicFloatObject.java.html) [Patch](test/java/util/Formatter/BasicFloatObject.java.patch) [Raw](raw%5Ffiles/new/test/java/util/Formatter/BasicFloatObject.java) test/java/util/Formatter/BasicFloatObject.java

rev 7490 : 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: TBD Contributed-by: Brian Burkhalter brian.burkhalter@oracle.com

16 lines changed: 16 ins; 0 del; 0 mod; 1711 unchg


This code review page was prepared using ../make/scripts/webrev.ksh(vers 24.0-hg+jbs).