jdk (original) (raw)

Code Review for jdk

Prepared by: khazra on 2011-Sep-13 11:09 -0700 PDT
Workspace: /export/home/khazra/dev/JDK/jdk8_warn/tl/jdk (at e0c1282a0ead)
Compare against: http://hg.openjdk.java.net/jdk8/tl/jdk (at e0c1282a0ead)
Summary of changes: 402 lines changed: 113 ins; 80 del; 209 mod; 24777 unchg
Patch of changes: <jdk.patch>

make/com/sun/net/httpserver/Makefile | 4 make/com/sun/net/ssl/Makefile | 3 make/java/Makefile | 1 make/java/net/Makefile | 3 make/javax/Makefile | 7 + make/javax/others/Makefile | 1 make/sun/net/Makefile | 4 make/sun/net/others/Makefile | 4 make/sun/net/spi/Makefile | 4 make/sun/net/spi/nameservice/dns/Makefile | 3 src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java | 8 - src/share/classes/com/sun/net/httpserver/Headers.java | 4 src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java | 20 +--- src/share/classes/com/sun/net/ssl/SSLSecurity.java | 11 +- src/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java | 6 - src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java | 4 src/share/classes/java/net/ContentHandler.java | 4 src/share/classes/java/net/CookieManager.java | 3 src/share/classes/java/net/DatagramSocket.java | 17 +-- src/share/classes/java/net/HttpURLConnection.java | 1 src/share/classes/java/net/Inet4Address.java | 4 src/share/classes/java/net/Inet4AddressImpl.java | 6 - src/share/classes/java/net/Inet6Address.java | 6 - src/share/classes/java/net/Inet6AddressImpl.java | 6 - src/share/classes/java/net/MulticastSocket.java | 14 -- src/share/classes/java/net/Proxy.java | 4 src/share/classes/java/net/ProxySelector.java | 4 src/share/classes/java/net/SocketPermission.java | 24 ++-- src/share/classes/java/net/URL.java | 11 +- src/share/classes/java/net/URLClassLoader.java | 15 --- src/share/classes/java/net/URLConnection.java | 11 +- src/share/classes/javax/net/ssl/HttpsURLConnection.java | 4 src/share/classes/javax/net/ssl/SSLServerSocketFactory.java | 4 src/share/classes/javax/net/ssl/SSLSocketFactory.java | 4 src/share/classes/sun/misc/REException.java | 3 src/share/classes/sun/net/TransferProtocolClient.java | 10 -- src/share/classes/sun/net/ftp/FtpClientProvider.java | 15 +-- src/share/classes/sun/net/httpserver/Request.java | 9 - src/share/classes/sun/net/httpserver/SSLStreams.java | 6 - src/share/classes/sun/net/httpserver/ServerImpl.java | 6 - src/share/classes/sun/net/idn/UCharacterDirection.java | 1 src/share/classes/sun/net/idn/UCharacterEnums.java | 43 ++++++++ src/share/classes/sun/net/spi/nameservice/dns/DNSNameService.java | 12 +- src/share/classes/sun/net/www/HeaderParser.java | 14 +- src/share/classes/sun/net/www/MessageHeader.java | 20 ++-- src/share/classes/sun/net/www/MimeTable.java | 12 -- src/share/classes/sun/net/www/URLConnection.java | 9 - src/share/classes/sun/net/www/content/image/gif.java | 7 - src/share/classes/sun/net/www/content/image/jpeg.java | 7 - src/share/classes/sun/net/www/content/image/png.java | 7 - src/share/classes/sun/net/www/content/image/x_xbitmap.java | 4 src/share/classes/sun/net/www/content/image/x_xpixmap.java | 4 src/share/classes/sun/net/www/http/KeepAliveStream.java | 2 src/share/classes/sun/net/www/protocol/http/AuthCacheImpl.java | 30 ++---- src/share/classes/sun/net/www/protocol/http/AuthenticationHeader.java | 28 ++--- src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java | 49 +++++----- src/share/classes/sun/net/www/protocol/http/Negotiator.java | 6 - src/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java | 10 +- src/share/classes/sun/net/www/protocol/https/HttpsClient.java | 14 +- src/solaris/classes/java/net/DefaultDatagramSocketImplFactory.java | 4 src/solaris/classes/java/net/PlainDatagramSocketImpl.java | 4 src/solaris/classes/sun/net/dns/ResolverConfigurationImpl.java | 18 ++- src/windows/classes/java/net/DefaultDatagramSocketImplFactory.java | 4 src/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java | 8 - src/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java | 2 src/windows/classes/sun/net/dns/ResolverConfigurationImpl.java | 10 +- src/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java | 4 67 files changed, 322 insertions(+), 289 deletions(-)

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/com/sun/net/httpserver/Makefile

*** NO COMMENTS ***

3 lines changed: 2 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/com/sun/net/ssl/Makefile

*** NO COMMENTS ***

3 lines changed: 3 ins; 0 del; 0 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/java/Makefile

*** NO COMMENTS ***

1 line changed: 0 ins; 1 del; 0 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/java/net/Makefile

*** NO COMMENTS ***

3 lines changed: 3 ins; 0 del; 0 mod; 131 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/javax/Makefile

*** NO COMMENTS ***

6 lines changed: 5 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/javax/others/Makefile

*** NO COMMENTS ***

1 line changed: 1 ins; 0 del; 0 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/sun/net/Makefile

*** NO COMMENTS ***

3 lines changed: 2 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/sun/net/others/Makefile

*** NO COMMENTS ***

4 lines changed: 4 ins; 0 del; 0 mod; 75 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/sun/net/spi/Makefile

*** NO COMMENTS ***

4 lines changed: 4 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/sun/net/spi/nameservice/dns/Makefile

*** NO COMMENTS ***

2 lines changed: 1 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java

*** NO COMMENTS ***

4 lines changed: 0 ins; 0 del; 4 mod; 305 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/net/httpserver/Headers.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 181 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java

*** NO COMMENTS ***

15 lines changed: 4 ins; 6 del; 5 mod; 160 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/net/ssl/SSLSecurity.java

*** NO COMMENTS ***

6 lines changed: 0 ins; 1 del; 5 mod; 686 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java

*** NO COMMENTS ***

3 lines changed: 0 ins; 0 del; 3 mod; 196 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java

*** NO COMMENTS ***

4 lines changed: 2 ins; 2 del; 0 mod; 350 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/ContentHandler.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/CookieManager.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 1 del; 1 mod; 444 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/DatagramSocket.java

*** NO COMMENTS ***

13 lines changed: 2 ins; 7 del; 4 mod; 1243 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/HttpURLConnection.java

*** NO COMMENTS ***

1 line changed: 1 ins; 0 del; 0 mod; 804 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/Inet4Address.java

*** NO COMMENTS ***

3 lines changed: 0 ins; 2 del; 1 mod; 371 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/Inet4AddressImpl.java

*** NO COMMENTS ***

3 lines changed: 0 ins; 0 del; 3 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/Inet6Address.java

*** NO COMMENTS ***

3 lines changed: 0 ins; 0 del; 3 mod; 771 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/Inet6AddressImpl.java

*** NO COMMENTS ***

3 lines changed: 0 ins; 0 del; 3 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/MulticastSocket.java

*** NO COMMENTS ***

10 lines changed: 0 ins; 6 del; 4 mod; 681 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/Proxy.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/ProxySelector.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 164 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/SocketPermission.java

*** NO COMMENTS ***

14 lines changed: 4 ins; 0 del; 10 mod; 1372 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/URL.java

*** NO COMMENTS ***

6 lines changed: 0 ins; 1 del; 5 mod; 1304 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/URLClassLoader.java

*** NO COMMENTS ***

11 lines changed: 0 ins; 7 del; 4 mod; 780 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/URLConnection.java

*** NO COMMENTS ***

6 lines changed: 1 ins; 0 del; 5 mod; 1792 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/net/ssl/HttpsURLConnection.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 369 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/net/ssl/SSLServerSocketFactory.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 192 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/net/ssl/SSLSocketFactory.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 246 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/misc/REException.java

*** NO COMMENTS ***

3 lines changed: 3 ins; 0 del; 0 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/TransferProtocolClient.java

*** NO COMMENTS ***

6 lines changed: 0 ins; 2 del; 4 mod; 135 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/ftp/FtpClientProvider.java

*** NO COMMENTS ***

12 lines changed: 3 ins; 6 del; 3 mod; 149 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/httpserver/Request.java

*** NO COMMENTS ***

7 lines changed: 1 ins; 4 del; 2 mod; 396 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/httpserver/SSLStreams.java

*** NO COMMENTS ***

5 lines changed: 1 ins; 3 del; 1 mod; 658 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/httpserver/ServerImpl.java

*** NO COMMENTS ***

3 lines changed: 0 ins; 0 del; 3 mod; 870 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/idn/UCharacterDirection.java

*** NO COMMENTS ***

1 line changed: 1 ins; 0 del; 0 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/idn/UCharacterEnums.java

*** NO COMMENTS ***

43 lines changed: 43 ins; 0 del; 0 mod; 544 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/spi/nameservice/dns/DNSNameService.java

*** NO COMMENTS ***

6 lines changed: 0 ins; 0 del; 6 mod; 495 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/HeaderParser.java

*** NO COMMENTS ***

7 lines changed: 0 ins; 0 del; 7 mod; 256 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/MessageHeader.java

*** NO COMMENTS ***

13 lines changed: 3 ins; 3 del; 7 mod; 469 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/MimeTable.java

*** NO COMMENTS ***

8 lines changed: 0 ins; 4 del; 4 mod; 455 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/URLConnection.java

*** NO COMMENTS ***

7 lines changed: 0 ins; 5 del; 2 mod; 244 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/content/image/gif.java

*** NO COMMENTS ***

5 lines changed: 0 ins; 3 del; 2 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/content/image/jpeg.java

*** NO COMMENTS ***

5 lines changed: 0 ins; 3 del; 2 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/content/image/png.java

*** NO COMMENTS ***

5 lines changed: 0 ins; 3 del; 2 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/content/image/x_xbitmap.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/content/image/x_xpixmap.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/http/KeepAliveStream.java

*** NO COMMENTS ***

1 line changed: 0 ins; 0 del; 1 mod; 236 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/protocol/http/AuthCacheImpl.java

*** NO COMMENTS ***

17 lines changed: 0 ins; 4 del; 13 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/protocol/http/AuthenticationHeader.java

*** NO COMMENTS ***

14 lines changed: 0 ins; 0 del; 14 mod; 244 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java

*** NO COMMENTS ***

30 lines changed: 8 ins; 3 del; 19 mod; 3269 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/protocol/http/Negotiator.java

*** NO COMMENTS ***

3 lines changed: 0 ins; 0 del; 3 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java

*** NO COMMENTS ***

5 lines changed: 0 ins; 0 del; 5 mod; 307 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/net/www/protocol/https/HttpsClient.java

*** NO COMMENTS ***

8 lines changed: 0 ins; 2 del; 6 mod; 741 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/java/net/DefaultDatagramSocketImplFactory.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/java/net/PlainDatagramSocketImpl.java

*** NO COMMENTS ***

3 lines changed: 2 ins; 0 del; 1 mod; 83 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/net/dns/ResolverConfigurationImpl.java

*** NO COMMENTS ***

11 lines changed: 4 ins; 0 del; 7 mod; 252 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/windows/classes/java/net/DefaultDatagramSocketImplFactory.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java

*** NO COMMENTS ***

5 lines changed: 1 ins; 1 del; 3 mod; 261 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java

*** NO COMMENTS ***

2 lines changed: 2 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/windows/classes/sun/net/dns/ResolverConfigurationImpl.java

*** NO COMMENTS ***

6 lines changed: 2 ins; 0 del; 4 mod; 172 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java

*** NO COMMENTS ***

2 lines changed: 0 ins; 0 del; 2 mod; 158 unchg


This code review page was prepared using /pkg/local/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtainedhere.