jdk-hs (original) (raw)

Code Review for jdk-hs

Prepared by: clanger on Fri Apr 6 16:54:04 CEST 2018
Workspace:
Compare against: http://hg.openjdk.java.net/jdk/hs
Compare against version: 49616
Summary of changes: 367 lines changed: 76 ins; 220 del; 71 mod; 5948 unchg
Changeset: <jdk-hs.changeset>
Bug id: JDK-8201247
Legend: Modified file Deleted file New file

[Cdiffs](src/hotspot/os/aix/attachListener%5Faix.cpp.cdiff.html) [Udiffs](src/hotspot/os/aix/attachListener%5Faix.cpp.udiff.html) [Sdiffs](src/hotspot/os/aix/attachListener%5Faix.cpp.sdiff.html) [Frames](src/hotspot/os/aix/attachListener%5Faix.cpp.frames.html) [Old](src/hotspot/os/aix/attachListener%5Faix.cpp-.html) [New](src/hotspot/os/aix/attachListener%5Faix.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/os/aix/attachListener%5Faix.cpp) src/hotspot/os/aix/attachListener_aix.cpp

rev 49617 : attach stuff

32 lines changed: 9 ins; 14 del; 9 mod; 561 unchg

[Cdiffs](src/hotspot/os/aix/globals%5Faix.hpp.cdiff.html) [Udiffs](src/hotspot/os/aix/globals%5Faix.hpp.udiff.html) [Sdiffs](src/hotspot/os/aix/globals%5Faix.hpp.sdiff.html) [Frames](src/hotspot/os/aix/globals%5Faix.hpp.frames.html) [Old](src/hotspot/os/aix/globals%5Faix.hpp-.html) [New](src/hotspot/os/aix/globals%5Faix.hpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/os/aix/globals%5Faix.hpp) src/hotspot/os/aix/globals_aix.hpp

rev 49617 : attach stuff

6 lines changed: 0 ins; 4 del; 2 mod; 95 unchg

[Cdiffs](src/hotspot/os/bsd/attachListener%5Fbsd.cpp.cdiff.html) [Udiffs](src/hotspot/os/bsd/attachListener%5Fbsd.cpp.udiff.html) [Sdiffs](src/hotspot/os/bsd/attachListener%5Fbsd.cpp.sdiff.html) [Frames](src/hotspot/os/bsd/attachListener%5Fbsd.cpp.frames.html) [Old](src/hotspot/os/bsd/attachListener%5Fbsd.cpp-.html) [New](src/hotspot/os/bsd/attachListener%5Fbsd.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/os/bsd/attachListener%5Fbsd.cpp) src/hotspot/os/bsd/attachListener_bsd.cpp

rev 49617 : attach stuff

13 lines changed: 9 ins; 3 del; 1 mod; 537 unchg

[Cdiffs](src/hotspot/os/linux/attachListener%5Flinux.cpp.cdiff.html) [Udiffs](src/hotspot/os/linux/attachListener%5Flinux.cpp.udiff.html) [Sdiffs](src/hotspot/os/linux/attachListener%5Flinux.cpp.sdiff.html) [Frames](src/hotspot/os/linux/attachListener%5Flinux.cpp.frames.html) [Old](src/hotspot/os/linux/attachListener%5Flinux.cpp-.html) [New](src/hotspot/os/linux/attachListener%5Flinux.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/os/linux/attachListener%5Flinux.cpp) src/hotspot/os/linux/attachListener_linux.cpp

rev 49617 : attach stuff

18 lines changed: 8 ins; 3 del; 7 mod; 533 unchg

[Cdiffs](src/hotspot/os/solaris/attachListener%5Fsolaris.cpp.cdiff.html) [Udiffs](src/hotspot/os/solaris/attachListener%5Fsolaris.cpp.udiff.html) [Sdiffs](src/hotspot/os/solaris/attachListener%5Fsolaris.cpp.sdiff.html) [Frames](src/hotspot/os/solaris/attachListener%5Fsolaris.cpp.frames.html) [Old](src/hotspot/os/solaris/attachListener%5Fsolaris.cpp-.html) [New](src/hotspot/os/solaris/attachListener%5Fsolaris.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/os/solaris/attachListener%5Fsolaris.cpp) src/hotspot/os/solaris/attachListener_solaris.cpp

rev 49617 : attach stuff

10 lines changed: 8 ins; 1 del; 1 mod; 746 unchg

[Cdiffs](src/hotspot/os/windows/attachListener%5Fwindows.cpp.cdiff.html) [Udiffs](src/hotspot/os/windows/attachListener%5Fwindows.cpp.udiff.html) [Sdiffs](src/hotspot/os/windows/attachListener%5Fwindows.cpp.sdiff.html) [Frames](src/hotspot/os/windows/attachListener%5Fwindows.cpp.frames.html) [Old](src/hotspot/os/windows/attachListener%5Fwindows.cpp-.html) [New](src/hotspot/os/windows/attachListener%5Fwindows.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/os/windows/attachListener%5Fwindows.cpp) src/hotspot/os/windows/attachListener_windows.cpp

rev 49617 : attach stuff

13 lines changed: 8 ins; 0 del; 5 mod; 413 unchg

[Cdiffs](src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java.cdiff.html) [Udiffs](src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java.udiff.html) [Sdiffs](src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java.sdiff.html) [Frames](src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java.frames.html) [Old](src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java-.html) [New](src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java.html) -----[Raw](raw%5Ffiles/new/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java) src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java

rev 49617 : attach stuff

6 lines changed: 0 ins; 2 del; 4 mod; 314 unchg

[Cdiffs](src/jdk.attach/aix/native/libattach/VirtualMachineImpl.c.cdiff.html) [Udiffs](src/jdk.attach/aix/native/libattach/VirtualMachineImpl.c.udiff.html) [Sdiffs](src/jdk.attach/aix/native/libattach/VirtualMachineImpl.c.sdiff.html) [Frames](src/jdk.attach/aix/native/libattach/VirtualMachineImpl.c.frames.html) [Old](src/jdk.attach/aix/native/libattach/VirtualMachineImpl.c-.html) [New](src/jdk.attach/aix/native/libattach/VirtualMachineImpl.c.html) -----[Raw](raw%5Ffiles/new/src/jdk.attach/aix/native/libattach/VirtualMachineImpl.c) src/jdk.attach/aix/native/libattach/VirtualMachineImpl.c

rev 49617 : attach stuff

59 lines changed: 6 ins; 45 del; 8 mod; 246 unchg

[Cdiffs](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.cdiff.html) [Udiffs](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.udiff.html) [Sdiffs](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.sdiff.html) [Frames](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.frames.html) [Old](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java-.html) [New](src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.html) -----[Raw](raw%5Ffiles/new/src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java) src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java

rev 49617 : attach stuff

5 lines changed: 0 ins; 2 del; 3 mod; 373 unchg

[Cdiffs](src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c.cdiff.html) [Udiffs](src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c.udiff.html) [Sdiffs](src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c.sdiff.html) [Frames](src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c.frames.html) [Old](src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c-.html) [New](src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c.html) -----[Raw](raw%5Ffiles/new/src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c) src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c

rev 49617 : attach stuff

139 lines changed: 9 ins; 123 del; 7 mod; 247 unchg

[Cdiffs](src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java.cdiff.html) [Udiffs](src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java.udiff.html) [Sdiffs](src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java.sdiff.html) [Frames](src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java.frames.html) [Old](src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java-.html) [New](src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java.html) -----[Raw](raw%5Ffiles/new/src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java) src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java

rev 49617 : attach stuff

3 lines changed: 0 ins; 1 del; 2 mod; 311 unchg

[Cdiffs](src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c.cdiff.html) [Udiffs](src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c.udiff.html) [Sdiffs](src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c.sdiff.html) [Frames](src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c.frames.html) [Old](src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c-.html) [New](src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c.html) -----[Raw](raw%5Ffiles/new/src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c) src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c

rev 49617 : attach stuff

28 lines changed: 10 ins; 11 del; 7 mod; 312 unchg

[Cdiffs](src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java.cdiff.html) [Udiffs](src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java.udiff.html) [Sdiffs](src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java.sdiff.html) [Frames](src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java.frames.html) [Old](src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java-.html) [New](src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java.html) -----[Raw](raw%5Ffiles/new/src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java) src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java

rev 49617 : attach stuff

2 lines changed: 0 ins; 0 del; 2 mod; 262 unchg

[Cdiffs](src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c.cdiff.html) [Udiffs](src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c.udiff.html) [Sdiffs](src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c.sdiff.html) [Frames](src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c.frames.html) [Old](src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c-.html) [New](src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c.html) -----[Raw](raw%5Ffiles/new/src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c) src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c

rev 49617 : attach stuff

20 lines changed: 6 ins; 5 del; 9 mod; 372 unchg

[Cdiffs](src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c.cdiff.html) [Udiffs](src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c.udiff.html) [Sdiffs](src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c.sdiff.html) [Frames](src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c.frames.html) [Old](src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c-.html) [New](src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c.html) -----[Raw](raw%5Ffiles/new/src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c) src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c

rev 49617 : attach stuff

13 lines changed: 3 ins; 6 del; 4 mod; 626 unchg


This code review page was prepared using /cygdrive/c/SAPDevelop/mercurial/webrev/webrev.ksh(vers 25.16-hg+openjdk.java.net).