jdk (original) (raw)

Code Review for jdk

Prepared by: coffeys on Fri Aug 18 14:51:39 IST 2017
Workspace: /net/t4.uk.oracle.com/export2/home/scoffey/ws/CPU/jdk8u-cpu.2/jdk
Compare against: ssh://closedjdk.us.oracle.com/jdk8u/jdk8u-cpu/jdk
Compare against version: 12644
Summary of changes: 385 lines changed: 254 ins; 45 del; 86 mod; 5902 unchg
Changeset: <jdk.changeset>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/javax/crypto/JceSecurity.java.cdiff.html) [Udiffs](src/share/classes/javax/crypto/JceSecurity.java.udiff.html) [Sdiffs](src/share/classes/javax/crypto/JceSecurity.java.sdiff.html) [Frames](src/share/classes/javax/crypto/JceSecurity.java.frames.html) [Old](src/share/classes/javax/crypto/JceSecurity.java-.html) [New](src/share/classes/javax/crypto/JceSecurity.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/javax/crypto/JceSecurity.java) src/share/classes/javax/crypto/JceSecurity.java

rev 12646 : 8170157: Enable unlimited cryptographic policy by default in OracleJDK Reviewed-by: duke

4 lines changed: 0 ins; 0 del; 4 mod; 392 unchg

[Cdiffs](src/share/lib/security/java.security-aix.cdiff.html) [Udiffs](src/share/lib/security/java.security-aix.udiff.html) [Sdiffs](src/share/lib/security/java.security-aix.sdiff.html) [Frames](src/share/lib/security/java.security-aix.frames.html) [Old](src/share/lib/security/java.security-aix-.html) [New](src/share/lib/security/java.security-aix.html) -----[Raw](raw%5Ffiles/new/src/share/lib/security/java.security-aix) src/share/lib/security/java.security-aix

rev 12646 : 8170157: Enable unlimited cryptographic policy by default in OracleJDK Reviewed-by: duke

9 lines changed: 4 ins; 0 del; 5 mod; 905 unchg

[Cdiffs](src/share/lib/security/java.security-linux.cdiff.html) [Udiffs](src/share/lib/security/java.security-linux.udiff.html) [Sdiffs](src/share/lib/security/java.security-linux.sdiff.html) [Frames](src/share/lib/security/java.security-linux.frames.html) [Old](src/share/lib/security/java.security-linux-.html) [New](src/share/lib/security/java.security-linux.html) -----[Raw](raw%5Ffiles/new/src/share/lib/security/java.security-linux) src/share/lib/security/java.security-linux

rev 12646 : 8170157: Enable unlimited cryptographic policy by default in OracleJDK Reviewed-by: duke

9 lines changed: 4 ins; 0 del; 5 mod; 912 unchg

[Cdiffs](src/share/lib/security/java.security-macosx.cdiff.html) [Udiffs](src/share/lib/security/java.security-macosx.udiff.html) [Sdiffs](src/share/lib/security/java.security-macosx.sdiff.html) [Frames](src/share/lib/security/java.security-macosx.frames.html) [Old](src/share/lib/security/java.security-macosx-.html) [New](src/share/lib/security/java.security-macosx.html) -----[Raw](raw%5Ffiles/new/src/share/lib/security/java.security-macosx) src/share/lib/security/java.security-macosx

rev 12646 : 8170157: Enable unlimited cryptographic policy by default in OracleJDK Reviewed-by: duke

9 lines changed: 4 ins; 0 del; 5 mod; 908 unchg

[Cdiffs](src/share/lib/security/java.security-solaris.cdiff.html) [Udiffs](src/share/lib/security/java.security-solaris.udiff.html) [Sdiffs](src/share/lib/security/java.security-solaris.sdiff.html) [Frames](src/share/lib/security/java.security-solaris.frames.html) [Old](src/share/lib/security/java.security-solaris-.html) [New](src/share/lib/security/java.security-solaris.html) -----[Raw](raw%5Ffiles/new/src/share/lib/security/java.security-solaris) src/share/lib/security/java.security-solaris

rev 12646 : 8170157: Enable unlimited cryptographic policy by default in OracleJDK Reviewed-by: duke

9 lines changed: 4 ins; 0 del; 5 mod; 907 unchg

[Cdiffs](src/share/lib/security/java.security-windows.cdiff.html) [Udiffs](src/share/lib/security/java.security-windows.udiff.html) [Sdiffs](src/share/lib/security/java.security-windows.sdiff.html) [Frames](src/share/lib/security/java.security-windows.frames.html) [Old](src/share/lib/security/java.security-windows-.html) [New](src/share/lib/security/java.security-windows.html) -----[Raw](raw%5Ffiles/new/src/share/lib/security/java.security-windows) src/share/lib/security/java.security-windows

rev 12646 : 8170157: Enable unlimited cryptographic policy by default in OracleJDK Reviewed-by: duke

9 lines changed: 4 ins; 0 del; 5 mod; 908 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/AES/TestAESCiphers/Dynamic.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/AES/TestAESCiphers/Dynamic.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/AES/TestAESCiphers/Dynamic.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/AES/TestAESCiphers/Dynamic.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/AES/TestAESCiphers/Dynamic.java-.html) [New](test/com/sun/crypto/provider/Cipher/AES/TestAESCiphers/Dynamic.java.html) -----[Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/AES/TestAESCiphers/Dynamic.java) test/com/sun/crypto/provider/Cipher/AES/TestAESCiphers/Dynamic.java

rev 12645 : 8170245: [TEST_BUG] Cipher tests fail when running with unlimited policy Summary: Updated the failed cipher tests to work under unlimited policy Reviewed-by: xuelei

19 lines changed: 4 ins; 13 del; 2 mod; 171 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/Blowfish/TestCipherBlowfish.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/Blowfish/TestCipherBlowfish.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/Blowfish/TestCipherBlowfish.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/Blowfish/TestCipherBlowfish.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/Blowfish/TestCipherBlowfish.java-.html) [New](test/com/sun/crypto/provider/Cipher/Blowfish/TestCipherBlowfish.java.html) -----[Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/Blowfish/TestCipherBlowfish.java) test/com/sun/crypto/provider/Cipher/Blowfish/TestCipherBlowfish.java

rev 12645 : 8170245: [TEST_BUG] Cipher tests fail when running with unlimited policy Summary: Updated the failed cipher tests to work under unlimited policy Reviewed-by: xuelei

2 lines changed: 0 ins; 0 del; 2 mod; 49 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/AESPBEWrapper.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/AESPBEWrapper.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/AESPBEWrapper.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/AESPBEWrapper.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/AESPBEWrapper.java-.html) [New](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/AESPBEWrapper.java.html) -----[Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/AESPBEWrapper.java) test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/AESPBEWrapper.java

rev 12645 : 8170245: [TEST_BUG] Cipher tests fail when running with unlimited policy Summary: Updated the failed cipher tests to work under unlimited policy Reviewed-by: xuelei

36 lines changed: 19 ins; 14 del; 3 mod; 97 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/PBECipherWrapper.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/PBECipherWrapper.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/PBECipherWrapper.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/PBECipherWrapper.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/PBECipherWrapper.java-.html) [New](test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/PBECipherWrapper.java.html) -----[Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/PBECipherWrapper.java) test/com/sun/crypto/provider/Cipher/PBE/PBESameBuffer/PBECipherWrapper.java

rev 12645 : 8170245: [TEST_BUG] Cipher tests fail when running with unlimited policy Summary: Updated the failed cipher tests to work under unlimited policy Reviewed-by: xuelei

41 lines changed: 21 ins; 13 del; 7 mod; 90 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java-.html) [New](test/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java.html) -----[Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java) test/com/sun/crypto/provider/Cipher/PBE/TestCipherKeyWrapperPBEKey.java

rev 12645 : 8170245: [TEST_BUG] Cipher tests fail when running with unlimited policy Summary: Updated the failed cipher tests to work under unlimited policy Reviewed-by: xuelei

11 lines changed: 4 ins; 1 del; 6 mod; 161 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/PBE/TestCipherPBE.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/PBE/TestCipherPBE.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/PBE/TestCipherPBE.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/PBE/TestCipherPBE.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/PBE/TestCipherPBE.java-.html) [New](test/com/sun/crypto/provider/Cipher/PBE/TestCipherPBE.java.html) -----[Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/PBE/TestCipherPBE.java) test/com/sun/crypto/provider/Cipher/PBE/TestCipherPBE.java

rev 12645 : 8170245: [TEST_BUG] Cipher tests fail when running with unlimited policy Summary: Updated the failed cipher tests to work under unlimited policy Reviewed-by: xuelei

8 lines changed: 3 ins; 0 del; 5 mod; 123 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/TestCipher.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/TestCipher.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/TestCipher.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/TestCipher.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/TestCipher.java-.html) [New](test/com/sun/crypto/provider/Cipher/TestCipher.java.html) -----[Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/TestCipher.java) test/com/sun/crypto/provider/Cipher/TestCipher.java

rev 12645 : 8170245: [TEST_BUG] Cipher tests fail when running with unlimited policy Summary: Updated the failed cipher tests to work under unlimited policy Reviewed-by: xuelei

25 lines changed: 7 ins; 3 del; 15 mod; 201 unchg

[Cdiffs](test/javax/crypto/CryptoPermission/TestUnlimited.java.cdiff.html) [Udiffs](test/javax/crypto/CryptoPermission/TestUnlimited.java.udiff.html) [Sdiffs](test/javax/crypto/CryptoPermission/TestUnlimited.java.sdiff.html) [Frames](test/javax/crypto/CryptoPermission/TestUnlimited.java.frames.html) [Old](test/javax/crypto/CryptoPermission/TestUnlimited.java-.html) [New](test/javax/crypto/CryptoPermission/TestUnlimited.java.html) -----[Raw](raw%5Ffiles/new/test/javax/crypto/CryptoPermission/TestUnlimited.java) test/javax/crypto/CryptoPermission/TestUnlimited.java

rev 12646 : 8170157: Enable unlimited cryptographic policy by default in OracleJDK Reviewed-by: duke

71 lines changed: 53 ins; 1 del; 17 mod; 78 unchg

------ ------ ------ ------ ---[New](test/javax/crypto/CryptoPermission/CryptoPolicyFallback.java.html) -----[Raw](raw%5Ffiles/new/test/javax/crypto/CryptoPermission/CryptoPolicyFallback.java) test/javax/crypto/CryptoPermission/CryptoPolicyFallback.java

rev 12646 : 8170157: Enable unlimited cryptographic policy by default in OracleJDK Reviewed-by: duke

123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/scoffey/h1/bin/webrev.ksh(vers 25.16-hg+openjdk.java.net).