jaxp (original) (raw)

Code Review for jaxp

Prepared by: dfuchs on Wed Apr 17 15:24:00 CEST 2013
Workspace: /Users/danielfuchs/workspaces/jdk/jdk8-tl-jaxp-merge/jaxp
Compare against: http://hg.openjdk.java.net/jdk8/tl/jaxp
Compare against version: 405
Summary of changes: 2596 lines changed: 424 ins; 731 del; 1441 mod; 5307 unchg
Changeset: <jaxp.changeset>
Legend: Modified file Deleted file New file

[Cdiffs](src/javax/xml/datatype/DatatypeFactory.java.cdiff.html) [Udiffs](src/javax/xml/datatype/DatatypeFactory.java.udiff.html) [Sdiffs](src/javax/xml/datatype/DatatypeFactory.java.sdiff.html) [Frames](src/javax/xml/datatype/DatatypeFactory.java.frames.html) [Old](src/javax/xml/datatype/DatatypeFactory.java-.html) [New](src/javax/xml/datatype/DatatypeFactory.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/datatype/DatatypeFactory.java) src/javax/xml/datatype/DatatypeFactory.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

809 lines changed: 36 ins; 32 del; 741 mod; 291 unchg

[Cdiffs](src/javax/xml/datatype/FactoryFinder.java.cdiff.html) [Udiffs](src/javax/xml/datatype/FactoryFinder.java.udiff.html) [Sdiffs](src/javax/xml/datatype/FactoryFinder.java.sdiff.html) [Frames](src/javax/xml/datatype/FactoryFinder.java.frames.html) [Old](src/javax/xml/datatype/FactoryFinder.java-.html) [New](src/javax/xml/datatype/FactoryFinder.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/datatype/FactoryFinder.java) src/javax/xml/datatype/FactoryFinder.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

139 lines changed: 15 ins; 71 del; 53 mod; 243 unchg

[Cdiffs](src/javax/xml/parsers/DocumentBuilderFactory.java.cdiff.html) [Udiffs](src/javax/xml/parsers/DocumentBuilderFactory.java.udiff.html) [Sdiffs](src/javax/xml/parsers/DocumentBuilderFactory.java.sdiff.html) [Frames](src/javax/xml/parsers/DocumentBuilderFactory.java.frames.html) [Old](src/javax/xml/parsers/DocumentBuilderFactory.java-.html) [New](src/javax/xml/parsers/DocumentBuilderFactory.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/parsers/DocumentBuilderFactory.java) src/javax/xml/parsers/DocumentBuilderFactory.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

108 lines changed: 1 ins; 39 del; 68 mod; 507 unchg

[Cdiffs](src/javax/xml/parsers/FactoryFinder.java.cdiff.html) [Udiffs](src/javax/xml/parsers/FactoryFinder.java.udiff.html) [Sdiffs](src/javax/xml/parsers/FactoryFinder.java.sdiff.html) [Frames](src/javax/xml/parsers/FactoryFinder.java.frames.html) [Old](src/javax/xml/parsers/FactoryFinder.java-.html) [New](src/javax/xml/parsers/FactoryFinder.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/parsers/FactoryFinder.java) src/javax/xml/parsers/FactoryFinder.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

142 lines changed: 17 ins; 65 del; 60 mod; 239 unchg

[Cdiffs](src/javax/xml/parsers/SAXParserFactory.java.cdiff.html) [Udiffs](src/javax/xml/parsers/SAXParserFactory.java.udiff.html) [Sdiffs](src/javax/xml/parsers/SAXParserFactory.java.sdiff.html) [Frames](src/javax/xml/parsers/SAXParserFactory.java.frames.html) [Old](src/javax/xml/parsers/SAXParserFactory.java-.html) [New](src/javax/xml/parsers/SAXParserFactory.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/parsers/SAXParserFactory.java) src/javax/xml/parsers/SAXParserFactory.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

66 lines changed: 1 ins; 36 del; 29 mod; 407 unchg

[Cdiffs](src/javax/xml/stream/FactoryFinder.java.cdiff.html) [Udiffs](src/javax/xml/stream/FactoryFinder.java.udiff.html) [Sdiffs](src/javax/xml/stream/FactoryFinder.java.sdiff.html) [Frames](src/javax/xml/stream/FactoryFinder.java.frames.html) [Old](src/javax/xml/stream/FactoryFinder.java-.html) [New](src/javax/xml/stream/FactoryFinder.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/stream/FactoryFinder.java) src/javax/xml/stream/FactoryFinder.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

164 lines changed: 33 ins; 65 del; 66 mod; 267 unchg

[Cdiffs](src/javax/xml/stream/XMLEventFactory.java.cdiff.html) [Udiffs](src/javax/xml/stream/XMLEventFactory.java.udiff.html) [Sdiffs](src/javax/xml/stream/XMLEventFactory.java.sdiff.html) [Frames](src/javax/xml/stream/XMLEventFactory.java.frames.html) [Old](src/javax/xml/stream/XMLEventFactory.java-.html) [New](src/javax/xml/stream/XMLEventFactory.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/stream/XMLEventFactory.java) src/javax/xml/stream/XMLEventFactory.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

80 lines changed: 44 ins; 14 del; 22 mod; 380 unchg

[Cdiffs](src/javax/xml/stream/XMLInputFactory.java.cdiff.html) [Udiffs](src/javax/xml/stream/XMLInputFactory.java.udiff.html) [Sdiffs](src/javax/xml/stream/XMLInputFactory.java.sdiff.html) [Frames](src/javax/xml/stream/XMLInputFactory.java.frames.html) [Old](src/javax/xml/stream/XMLInputFactory.java-.html) [New](src/javax/xml/stream/XMLInputFactory.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/stream/XMLInputFactory.java) src/javax/xml/stream/XMLInputFactory.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

79 lines changed: 46 ins; 15 del; 18 mod; 411 unchg

[Cdiffs](src/javax/xml/stream/XMLOutputFactory.java.cdiff.html) [Udiffs](src/javax/xml/stream/XMLOutputFactory.java.udiff.html) [Sdiffs](src/javax/xml/stream/XMLOutputFactory.java.sdiff.html) [Frames](src/javax/xml/stream/XMLOutputFactory.java.frames.html) [Old](src/javax/xml/stream/XMLOutputFactory.java-.html) [New](src/javax/xml/stream/XMLOutputFactory.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/stream/XMLOutputFactory.java) src/javax/xml/stream/XMLOutputFactory.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

76 lines changed: 41 ins; 12 del; 23 mod; 278 unchg

[Cdiffs](src/javax/xml/transform/FactoryFinder.java.cdiff.html) [Udiffs](src/javax/xml/transform/FactoryFinder.java.udiff.html) [Sdiffs](src/javax/xml/transform/FactoryFinder.java.sdiff.html) [Frames](src/javax/xml/transform/FactoryFinder.java.frames.html) [Old](src/javax/xml/transform/FactoryFinder.java-.html) [New](src/javax/xml/transform/FactoryFinder.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/transform/FactoryFinder.java) src/javax/xml/transform/FactoryFinder.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

197 lines changed: 42 ins; 88 del; 67 mod; 240 unchg

[Cdiffs](src/javax/xml/transform/TransformerFactory.java.cdiff.html) [Udiffs](src/javax/xml/transform/TransformerFactory.java.udiff.html) [Sdiffs](src/javax/xml/transform/TransformerFactory.java.sdiff.html) [Frames](src/javax/xml/transform/TransformerFactory.java.frames.html) [Old](src/javax/xml/transform/TransformerFactory.java-.html) [New](src/javax/xml/transform/TransformerFactory.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/transform/TransformerFactory.java) src/javax/xml/transform/TransformerFactory.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

29 lines changed: 1 ins; 11 del; 17 mod; 355 unchg

[Cdiffs](src/javax/xml/validation/SchemaFactory.java.cdiff.html) [Udiffs](src/javax/xml/validation/SchemaFactory.java.udiff.html) [Sdiffs](src/javax/xml/validation/SchemaFactory.java.sdiff.html) [Frames](src/javax/xml/validation/SchemaFactory.java.frames.html) [Old](src/javax/xml/validation/SchemaFactory.java-.html) [New](src/javax/xml/validation/SchemaFactory.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/validation/SchemaFactory.java) src/javax/xml/validation/SchemaFactory.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

31 lines changed: 6 ins; 2 del; 23 mod; 728 unchg

[Cdiffs](src/javax/xml/validation/SchemaFactoryFinder.java.cdiff.html) [Udiffs](src/javax/xml/validation/SchemaFactoryFinder.java.udiff.html) [Sdiffs](src/javax/xml/validation/SchemaFactoryFinder.java.sdiff.html) [Frames](src/javax/xml/validation/SchemaFactoryFinder.java.frames.html) [Old](src/javax/xml/validation/SchemaFactoryFinder.java-.html) [New](src/javax/xml/validation/SchemaFactoryFinder.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/validation/SchemaFactoryFinder.java) src/javax/xml/validation/SchemaFactoryFinder.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

239 lines changed: 13 ins; 121 del; 105 mod; 330 unchg

[Cdiffs](src/javax/xml/xpath/XPathFactory.java.cdiff.html) [Udiffs](src/javax/xml/xpath/XPathFactory.java.udiff.html) [Sdiffs](src/javax/xml/xpath/XPathFactory.java.sdiff.html) [Frames](src/javax/xml/xpath/XPathFactory.java.frames.html) [Old](src/javax/xml/xpath/XPathFactory.java-.html) [New](src/javax/xml/xpath/XPathFactory.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/xpath/XPathFactory.java) src/javax/xml/xpath/XPathFactory.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

78 lines changed: 6 ins; 6 del; 66 mod; 312 unchg

[Cdiffs](src/javax/xml/xpath/XPathFactoryFinder.java.cdiff.html) [Udiffs](src/javax/xml/xpath/XPathFactoryFinder.java.udiff.html) [Sdiffs](src/javax/xml/xpath/XPathFactoryFinder.java.sdiff.html) [Frames](src/javax/xml/xpath/XPathFactoryFinder.java.frames.html) [Old](src/javax/xml/xpath/XPathFactoryFinder.java-.html) [New](src/javax/xml/xpath/XPathFactoryFinder.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/xpath/XPathFactoryFinder.java) src/javax/xml/xpath/XPathFactoryFinder.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

279 lines changed: 42 ins; 154 del; 83 mod; 319 unchg

------ ------ ------ ------ ---[New](src/javax/xml/validation/SchemaFactoryConfigurationError.java.html) -----[Raw](raw%5Ffiles/new/src/javax/xml/validation/SchemaFactoryConfigurationError.java) src/javax/xml/validation/SchemaFactoryConfigurationError.java

rev 406 : 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung

80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using ../make/scripts/webrev.ksh(vers 24.0-hg+jbs).