jdk (original) (raw)

Code Review for jdk

Prepared by: dholmes on Sun Dec 23 06:01:46 EST 2012
Workspace: /export/users/dh198349/profiles-staging/jdk
Compare against: http://embedsrc.us.oracle.com/hg/jdk8/profiles-staging/jdk
Summary of changes: 3802 lines changed: 3511 ins; 238 del; 53 mod; 9753 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](make/java/version/Makefile.cdiff.html) [Udiffs](make/java/version/Makefile.udiff.html) [Sdiffs](make/java/version/Makefile.sdiff.html) [Frames](make/java/version/Makefile.frames.html) [Old](make/java/version/Makefile-.html) [New](make/java/version/Makefile.html) [Patch](make/java/version/Makefile.patch) [Raw](raw%5Ffiles/new/make/java/version/Makefile) make/java/version/Makefile

2 lines changed: 1 ins; 0 del; 1 mod; 46 unchg

[Cdiffs](make/tools/src/build/tools/jarreorder/JarReorder.java.cdiff.html) [Udiffs](make/tools/src/build/tools/jarreorder/JarReorder.java.udiff.html) [Sdiffs](make/tools/src/build/tools/jarreorder/JarReorder.java.sdiff.html) [Frames](make/tools/src/build/tools/jarreorder/JarReorder.java.frames.html) [Old](make/tools/src/build/tools/jarreorder/JarReorder.java-.html) [New](make/tools/src/build/tools/jarreorder/JarReorder.java.html) [Patch](make/tools/src/build/tools/jarreorder/JarReorder.java.patch) [Raw](raw%5Ffiles/new/make/tools/src/build/tools/jarreorder/JarReorder.java) make/tools/src/build/tools/jarreorder/JarReorder.java

1 line changed: 0 ins; 0 del; 1 mod; 312 unchg

[Cdiffs](makefiles/BuildJdk.gmk.cdiff.html) [Udiffs](makefiles/BuildJdk.gmk.udiff.html) [Sdiffs](makefiles/BuildJdk.gmk.sdiff.html) [Frames](makefiles/BuildJdk.gmk.frames.html) [Old](makefiles/BuildJdk.gmk-.html) [New](makefiles/BuildJdk.gmk.html) [Patch](makefiles/BuildJdk.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/BuildJdk.gmk) makefiles/BuildJdk.gmk

15 lines changed: 15 ins; 0 del; 0 mod; 124 unchg

[Cdiffs](makefiles/CreateJars.gmk.cdiff.html) [Udiffs](makefiles/CreateJars.gmk.udiff.html) [Sdiffs](makefiles/CreateJars.gmk.sdiff.html) [Frames](makefiles/CreateJars.gmk.frames.html) [Old](makefiles/CreateJars.gmk-.html) [New](makefiles/CreateJars.gmk.html) [Patch](makefiles/CreateJars.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/CreateJars.gmk) makefiles/CreateJars.gmk

272 lines changed: 60 ins; 189 del; 23 mod; 762 unchg

[Cdiffs](makefiles/GensrcMisc.gmk.cdiff.html) [Udiffs](makefiles/GensrcMisc.gmk.udiff.html) [Sdiffs](makefiles/GensrcMisc.gmk.sdiff.html) [Frames](makefiles/GensrcMisc.gmk.frames.html) [Old](makefiles/GensrcMisc.gmk-.html) [New](makefiles/GensrcMisc.gmk.html) [Patch](makefiles/GensrcMisc.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/GensrcMisc.gmk) makefiles/GensrcMisc.gmk

9 lines changed: 5 ins; 0 del; 4 mod; 188 unchg

[Cdiffs](makefiles/GensrcX11Wrappers.gmk.cdiff.html) [Udiffs](makefiles/GensrcX11Wrappers.gmk.udiff.html) [Sdiffs](makefiles/GensrcX11Wrappers.gmk.sdiff.html) [Frames](makefiles/GensrcX11Wrappers.gmk.frames.html) [Old](makefiles/GensrcX11Wrappers.gmk-.html) [New](makefiles/GensrcX11Wrappers.gmk.html) [Patch](makefiles/GensrcX11Wrappers.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/GensrcX11Wrappers.gmk) makefiles/GensrcX11Wrappers.gmk

2 lines changed: 0 ins; 2 del; 0 mod; 104 unchg

[Cdiffs](makefiles/Images.gmk.cdiff.html) [Udiffs](makefiles/Images.gmk.udiff.html) [Sdiffs](makefiles/Images.gmk.sdiff.html) [Frames](makefiles/Images.gmk.frames.html) [Old](makefiles/Images.gmk-.html) [New](makefiles/Images.gmk.html) [Patch](makefiles/Images.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/Images.gmk) makefiles/Images.gmk

72 lines changed: 23 ins; 46 del; 3 mod; 681 unchg

[Cdiffs](makefiles/Import.gmk.cdiff.html) [Udiffs](makefiles/Import.gmk.udiff.html) [Sdiffs](makefiles/Import.gmk.sdiff.html) [Frames](makefiles/Import.gmk.frames.html) [Old](makefiles/Import.gmk-.html) [New](makefiles/Import.gmk.html) [Patch](makefiles/Import.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/Import.gmk) makefiles/Import.gmk

24 lines changed: 24 ins; 0 del; 0 mod; 236 unchg

[Cdiffs](makefiles/Tools.gmk.cdiff.html) [Udiffs](makefiles/Tools.gmk.udiff.html) [Sdiffs](makefiles/Tools.gmk.sdiff.html) [Frames](makefiles/Tools.gmk.frames.html) [Old](makefiles/Tools.gmk-.html) [New](makefiles/Tools.gmk.html) [Patch](makefiles/Tools.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/Tools.gmk) makefiles/Tools.gmk

4 lines changed: 4 ins; 0 del; 0 mod; 151 unchg

[Cdiffs](src/share/classes/java/net/URLClassLoader.java.cdiff.html) [Udiffs](src/share/classes/java/net/URLClassLoader.java.udiff.html) [Sdiffs](src/share/classes/java/net/URLClassLoader.java.sdiff.html) [Frames](src/share/classes/java/net/URLClassLoader.java.frames.html) [Old](src/share/classes/java/net/URLClassLoader.java-.html) [New](src/share/classes/java/net/URLClassLoader.java.html) [Patch](src/share/classes/java/net/URLClassLoader.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/net/URLClassLoader.java) src/share/classes/java/net/URLClassLoader.java

6 lines changed: 6 ins; 0 del; 0 mod; 784 unchg

[Cdiffs](src/share/classes/java/util/jar/Attributes.java.cdiff.html) [Udiffs](src/share/classes/java/util/jar/Attributes.java.udiff.html) [Sdiffs](src/share/classes/java/util/jar/Attributes.java.sdiff.html) [Frames](src/share/classes/java/util/jar/Attributes.java.frames.html) [Old](src/share/classes/java/util/jar/Attributes.java-.html) [New](src/share/classes/java/util/jar/Attributes.java.html) [Patch](src/share/classes/java/util/jar/Attributes.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/jar/Attributes.java) src/share/classes/java/util/jar/Attributes.java

9 lines changed: 9 ins; 0 del; 0 mod; 663 unchg

[Cdiffs](src/share/classes/java/util/jar/Pack200.java.cdiff.html) [Udiffs](src/share/classes/java/util/jar/Pack200.java.udiff.html) [Sdiffs](src/share/classes/java/util/jar/Pack200.java.sdiff.html) [Frames](src/share/classes/java/util/jar/Pack200.java.frames.html) [Old](src/share/classes/java/util/jar/Pack200.java-.html) [New](src/share/classes/java/util/jar/Pack200.java.html) [Patch](src/share/classes/java/util/jar/Pack200.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/jar/Pack200.java) src/share/classes/java/util/jar/Pack200.java

29 lines changed: 24 ins; 0 del; 5 mod; 785 unchg

[Cdiffs](src/share/classes/java/util/logging/LogManager.java.cdiff.html) [Udiffs](src/share/classes/java/util/logging/LogManager.java.udiff.html) [Sdiffs](src/share/classes/java/util/logging/LogManager.java.sdiff.html) [Frames](src/share/classes/java/util/logging/LogManager.java.frames.html) [Old](src/share/classes/java/util/logging/LogManager.java-.html) [New](src/share/classes/java/util/logging/LogManager.java.html) [Patch](src/share/classes/java/util/logging/LogManager.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/logging/LogManager.java) src/share/classes/java/util/logging/LogManager.java

8 lines changed: 8 ins; 0 del; 0 mod; 1370 unchg

[Cdiffs](src/share/classes/sun/launcher/LauncherHelper.java.cdiff.html) [Udiffs](src/share/classes/sun/launcher/LauncherHelper.java.udiff.html) [Sdiffs](src/share/classes/sun/launcher/LauncherHelper.java.sdiff.html) [Frames](src/share/classes/sun/launcher/LauncherHelper.java.frames.html) [Old](src/share/classes/sun/launcher/LauncherHelper.java-.html) [New](src/share/classes/sun/launcher/LauncherHelper.java.html) [Patch](src/share/classes/sun/launcher/LauncherHelper.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/launcher/LauncherHelper.java) src/share/classes/sun/launcher/LauncherHelper.java

24 lines changed: 23 ins; 1 del; 0 mod; 705 unchg

[Cdiffs](src/share/classes/sun/launcher/resources/launcher.properties.cdiff.html) [Udiffs](src/share/classes/sun/launcher/resources/launcher.properties.udiff.html) [Sdiffs](src/share/classes/sun/launcher/resources/launcher.properties.sdiff.html) [Frames](src/share/classes/sun/launcher/resources/launcher.properties.frames.html) [Old](src/share/classes/sun/launcher/resources/launcher.properties-.html) [New](src/share/classes/sun/launcher/resources/launcher.properties.html) [Patch](src/share/classes/sun/launcher/resources/launcher.properties.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/launcher/resources/launcher.properties) src/share/classes/sun/launcher/resources/launcher.properties

2 lines changed: 2 ins; 0 del; 0 mod; 142 unchg

[Cdiffs](src/share/classes/sun/misc/URLClassPath.java.cdiff.html) [Udiffs](src/share/classes/sun/misc/URLClassPath.java.udiff.html) [Sdiffs](src/share/classes/sun/misc/URLClassPath.java.sdiff.html) [Frames](src/share/classes/sun/misc/URLClassPath.java.frames.html) [Old](src/share/classes/sun/misc/URLClassPath.java-.html) [New](src/share/classes/sun/misc/URLClassPath.java.html) [Patch](src/share/classes/sun/misc/URLClassPath.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/misc/URLClassPath.java) src/share/classes/sun/misc/URLClassPath.java

43 lines changed: 43 ins; 0 del; 0 mod; 1073 unchg

[Cdiffs](src/share/classes/sun/misc/Version.java.template.cdiff.html) [Udiffs](src/share/classes/sun/misc/Version.java.template.udiff.html) [Sdiffs](src/share/classes/sun/misc/Version.java.template.sdiff.html) [Frames](src/share/classes/sun/misc/Version.java.template.frames.html) [Old](src/share/classes/sun/misc/Version.java.template-.html) [New](src/share/classes/sun/misc/Version.java.template.html) [Patch](src/share/classes/sun/misc/Version.java.template.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/misc/Version.java.template) src/share/classes/sun/misc/Version.java.template

82 lines changed: 70 ins; 0 del; 12 mod; 329 unchg

[Cdiffs](src/share/classes/sun/tools/jar/Main.java.cdiff.html) [Udiffs](src/share/classes/sun/tools/jar/Main.java.udiff.html) [Sdiffs](src/share/classes/sun/tools/jar/Main.java.sdiff.html) [Frames](src/share/classes/sun/tools/jar/Main.java.frames.html) [Old](src/share/classes/sun/tools/jar/Main.java-.html) [New](src/share/classes/sun/tools/jar/Main.java.html) [Patch](src/share/classes/sun/tools/jar/Main.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/tools/jar/Main.java) src/share/classes/sun/tools/jar/Main.java

20 lines changed: 16 ins; 0 del; 4 mod; 1207 unchg

[Cdiffs](src/share/classes/sun/tools/jar/resources/jar.properties.cdiff.html) [Udiffs](src/share/classes/sun/tools/jar/resources/jar.properties.udiff.html) [Sdiffs](src/share/classes/sun/tools/jar/resources/jar.properties.sdiff.html) [Frames](src/share/classes/sun/tools/jar/resources/jar.properties.frames.html) [Old](src/share/classes/sun/tools/jar/resources/jar.properties-.html) [New](src/share/classes/sun/tools/jar/resources/jar.properties.html) [Patch](src/share/classes/sun/tools/jar/resources/jar.properties.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/tools/jar/resources/jar.properties) src/share/classes/sun/tools/jar/resources/jar.properties

1 line changed: 1 ins; 0 del; 0 mod; 91 unchg

------ ------ ------ ------ ---[New](make/tools/src/build/tools/RemoveMethods.java.html) [Patch](make/tools/src/build/tools/RemoveMethods.java.patch) [Raw](raw%5Ffiles/new/make/tools/src/build/tools/RemoveMethods.java) make/tools/src/build/tools/RemoveMethods.java

115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](makefiles/ProfileNames.gmk.html) [Patch](makefiles/ProfileNames.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/ProfileNames.gmk) makefiles/ProfileNames.gmk

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](makefiles/Profiles.gmk.html) [Patch](makefiles/Profiles.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/Profiles.gmk) makefiles/Profiles.gmk

476 lines changed: 476 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](makefiles/profile-includes.txt.html) [Patch](makefiles/profile-includes.txt.patch) [Raw](raw%5Ffiles/new/makefiles/profile-includes.txt) makefiles/profile-includes.txt

687 lines changed: 687 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](makefiles/profile-rtjar-includes.txt.html) [Patch](makefiles/profile-rtjar-includes.txt.patch) [Raw](raw%5Ffiles/new/makefiles/profile-rtjar-includes.txt) makefiles/profile-rtjar-includes.txt

900 lines changed: 900 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/java/util/jar/UnsupportedProfileException.java.html) [Patch](src/share/classes/java/util/jar/UnsupportedProfileException.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/jar/UnsupportedProfileException.java) src/share/classes/java/util/jar/UnsupportedProfileException.java

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/net/URLClassLoader/profiles/Basic.java.html) [Patch](test/java/net/URLClassLoader/profiles/Basic.java.patch) [Raw](raw%5Ffiles/new/test/java/net/URLClassLoader/profiles/Basic.java) test/java/net/URLClassLoader/profiles/Basic.java

95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/net/URLClassLoader/profiles/Lib.java.html) [Patch](test/java/net/URLClassLoader/profiles/Lib.java.patch) [Raw](raw%5Ffiles/new/test/java/net/URLClassLoader/profiles/Lib.java) test/java/net/URLClassLoader/profiles/Lib.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/net/URLClassLoader/profiles/basic.sh.html) [Patch](test/java/net/URLClassLoader/profiles/basic.sh.patch) [Raw](raw%5Ffiles/new/test/java/net/URLClassLoader/profiles/basic.sh) test/java/net/URLClassLoader/profiles/basic.sh

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/logging/Reflect.java.html) [Patch](test/java/util/logging/Reflect.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/Reflect.java) test/java/util/logging/Reflect.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jar/AddAndUpdateProfile.java.html) [Patch](test/tools/jar/AddAndUpdateProfile.java.patch) [Raw](raw%5Ffiles/new/test/tools/jar/AddAndUpdateProfile.java) test/tools/jar/AddAndUpdateProfile.java

108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/launcher/profiles/Basic.java.html) [Patch](test/tools/launcher/profiles/Basic.java.patch) [Raw](raw%5Ffiles/new/test/tools/launcher/profiles/Basic.java) test/tools/launcher/profiles/Basic.java

225 lines changed: 225 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/launcher/profiles/Logging.java.html) [Patch](test/tools/launcher/profiles/Logging.java.patch) [Raw](raw%5Ffiles/new/test/tools/launcher/profiles/Logging.java) test/tools/launcher/profiles/Logging.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/launcher/profiles/Main.java.html) [Patch](test/tools/launcher/profiles/Main.java.patch) [Raw](raw%5Ffiles/new/test/tools/launcher/profiles/Main.java) test/tools/launcher/profiles/Main.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/launcher/profiles/VersionCheck.java.html) [Patch](test/tools/launcher/profiles/VersionCheck.java.patch) [Raw](raw%5Ffiles/new/test/tools/launcher/profiles/VersionCheck.java) test/tools/launcher/profiles/VersionCheck.java

169 lines changed: 169 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/pack200/NoBeans.java.html) [Patch](test/tools/pack200/NoBeans.java.patch) [Raw](raw%5Ffiles/new/test/tools/pack200/NoBeans.java) test/tools/pack200/NoBeans.java

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/pack200/Reflect.java.html) [Patch](test/tools/pack200/Reflect.java.patch) [Raw](raw%5Ffiles/new/test/tools/pack200/Reflect.java) test/tools/pack200/Reflect.java

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/dholmes /bin/webrev(vers 23.18-hg-never).