jdk (original) (raw)
Code Review for jdk
Prepared by: | fparain on Fri May 3 09:28:19 PDT 2013 |
---|---|
Workspace: | /home/fparain/amertume/RDCMD-final/JDK8-final/tl/jdk |
Compare against: | http://hg.openjdk.java.net/jdk8/tl/jdk |
Summary of changes: | 1738 lines changed: 1700 ins; 0 del; 38 mod; 2938 unchg |
Patch of changes: | <jdk.patch> |
Printable review: | <jdk.pdf> |
Legend: | Modified file Deleted file New file |
[Cdiffs](make/java/management/Exportedfiles.gmk.cdiff.html) [Udiffs](make/java/management/Exportedfiles.gmk.udiff.html) [Wdiffs](make/java/management/Exportedfiles.gmk.wdiff.html) [Sdiffs](make/java/management/Exportedfiles.gmk.sdiff.html) [Frames](make/java/management/Exportedfiles.gmk.frames.html) [Old](make/java/management/Exportedfiles.gmk-.html) [New](make/java/management/Exportedfiles.gmk.html) [Patch](make/java/management/Exportedfiles.gmk.patch) [Raw](raw%5Ffiles/new/make/java/management/Exportedfiles.gmk)
make/java/management/Exportedfiles.gmk
3 lines changed: 2 ins; 0 del; 1 mod; 41 unchg
[Cdiffs](make/java/management/FILES%5Fc.gmk.cdiff.html) [Udiffs](make/java/management/FILES%5Fc.gmk.udiff.html) [Wdiffs](make/java/management/FILES%5Fc.gmk.wdiff.html) [Sdiffs](make/java/management/FILES%5Fc.gmk.sdiff.html) [Frames](make/java/management/FILES%5Fc.gmk.frames.html) [Old](make/java/management/FILES%5Fc.gmk-.html) [New](make/java/management/FILES%5Fc.gmk.html) [Patch](make/java/management/FILES%5Fc.gmk.patch) [Raw](raw%5Ffiles/new/make/java/management/FILES%5Fc.gmk)
make/java/management/FILES_c.gmk
2 lines changed: 1 ins; 0 del; 1 mod; 39 unchg
[Cdiffs](make/java/management/mapfile-vers.cdiff.html) [Udiffs](make/java/management/mapfile-vers.udiff.html) [Wdiffs](make/java/management/mapfile-vers.wdiff.html) [Sdiffs](make/java/management/mapfile-vers.sdiff.html) [Frames](make/java/management/mapfile-vers.frames.html) [Old](make/java/management/mapfile-vers-.html) [New](make/java/management/mapfile-vers.html) [Patch](make/java/management/mapfile-vers.patch) [Raw](raw%5Ffiles/new/make/java/management/mapfile-vers)
make/java/management/mapfile-vers
6 lines changed: 4 ins; 0 del; 2 mod; 118 unchg
[Cdiffs](makefiles/mapfiles/libmanagement/mapfile-vers.cdiff.html) [Udiffs](makefiles/mapfiles/libmanagement/mapfile-vers.udiff.html) [Wdiffs](makefiles/mapfiles/libmanagement/mapfile-vers.wdiff.html) [Sdiffs](makefiles/mapfiles/libmanagement/mapfile-vers.sdiff.html) [Frames](makefiles/mapfiles/libmanagement/mapfile-vers.frames.html) [Old](makefiles/mapfiles/libmanagement/mapfile-vers-.html) [New](makefiles/mapfiles/libmanagement/mapfile-vers.html) [Patch](makefiles/mapfiles/libmanagement/mapfile-vers.patch) [Raw](raw%5Ffiles/new/makefiles/mapfiles/libmanagement/mapfile-vers)
makefiles/mapfiles/libmanagement/mapfile-vers
5 lines changed: 4 ins; 0 del; 1 mod; 119 unchg
[Cdiffs](src/share/classes/java/lang/management/ManagementFactory.java.cdiff.html) [Udiffs](src/share/classes/java/lang/management/ManagementFactory.java.udiff.html) [Wdiffs](src/share/classes/java/lang/management/ManagementFactory.java.wdiff.html) [Sdiffs](src/share/classes/java/lang/management/ManagementFactory.java.sdiff.html) [Frames](src/share/classes/java/lang/management/ManagementFactory.java.frames.html) [Old](src/share/classes/java/lang/management/ManagementFactory.java-.html) [New](src/share/classes/java/lang/management/ManagementFactory.java.html) [Patch](src/share/classes/java/lang/management/ManagementFactory.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/management/ManagementFactory.java)
src/share/classes/java/lang/management/ManagementFactory.java
28 lines changed: 27 ins; 0 del; 1 mod; 827 unchg
[Cdiffs](src/share/classes/sun/management/ManagementFactoryHelper.java.cdiff.html) [Udiffs](src/share/classes/sun/management/ManagementFactoryHelper.java.udiff.html) [Wdiffs](src/share/classes/sun/management/ManagementFactoryHelper.java.wdiff.html) [Sdiffs](src/share/classes/sun/management/ManagementFactoryHelper.java.sdiff.html) [Frames](src/share/classes/sun/management/ManagementFactoryHelper.java.frames.html) [Old](src/share/classes/sun/management/ManagementFactoryHelper.java-.html) [New](src/share/classes/sun/management/ManagementFactoryHelper.java.html) [Patch](src/share/classes/sun/management/ManagementFactoryHelper.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/management/ManagementFactoryHelper.java)
src/share/classes/sun/management/ManagementFactoryHelper.java
24 lines changed: 23 ins; 0 del; 1 mod; 452 unchg
[Cdiffs](src/share/classes/sun/management/VMManagement.java.cdiff.html) [Udiffs](src/share/classes/sun/management/VMManagement.java.udiff.html) [Wdiffs](src/share/classes/sun/management/VMManagement.java.wdiff.html) [Sdiffs](src/share/classes/sun/management/VMManagement.java.sdiff.html) [Frames](src/share/classes/sun/management/VMManagement.java.frames.html) [Old](src/share/classes/sun/management/VMManagement.java-.html) [New](src/share/classes/sun/management/VMManagement.java.html) [Patch](src/share/classes/sun/management/VMManagement.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/management/VMManagement.java)
src/share/classes/sun/management/VMManagement.java
2 lines changed: 1 ins; 0 del; 1 mod; 105 unchg
[Cdiffs](src/share/classes/sun/management/VMManagementImpl.java.cdiff.html) [Udiffs](src/share/classes/sun/management/VMManagementImpl.java.udiff.html) [Wdiffs](src/share/classes/sun/management/VMManagementImpl.java.wdiff.html) [Sdiffs](src/share/classes/sun/management/VMManagementImpl.java.sdiff.html) [Frames](src/share/classes/sun/management/VMManagementImpl.java.frames.html) [Old](src/share/classes/sun/management/VMManagementImpl.java-.html) [New](src/share/classes/sun/management/VMManagementImpl.java.html) [Patch](src/share/classes/sun/management/VMManagementImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/management/VMManagementImpl.java)
src/share/classes/sun/management/VMManagementImpl.java
6 lines changed: 5 ins; 0 del; 1 mod; 270 unchg
[Cdiffs](src/share/javavm/export/jmm.h.cdiff.html) [Udiffs](src/share/javavm/export/jmm.h.udiff.html) [Wdiffs](src/share/javavm/export/jmm.h.wdiff.html) [Sdiffs](src/share/javavm/export/jmm.h.sdiff.html) [Frames](src/share/javavm/export/jmm.h.frames.html) [Old](src/share/javavm/export/jmm.h-.html) [New](src/share/javavm/export/jmm.h.html) [Patch](src/share/javavm/export/jmm.h.patch) [Raw](raw%5Ffiles/new/src/share/javavm/export/jmm.h)
src/share/javavm/export/jmm.h
27 lines changed: 12 ins; 0 del; 15 mod; 321 unchg
[Cdiffs](src/share/native/sun/management/VMManagementImpl.c.cdiff.html) [Udiffs](src/share/native/sun/management/VMManagementImpl.c.udiff.html) [Wdiffs](src/share/native/sun/management/VMManagementImpl.c.wdiff.html) [Sdiffs](src/share/native/sun/management/VMManagementImpl.c.sdiff.html) [Frames](src/share/native/sun/management/VMManagementImpl.c.frames.html) [Old](src/share/native/sun/management/VMManagementImpl.c-.html) [New](src/share/native/sun/management/VMManagementImpl.c.html) [Patch](src/share/native/sun/management/VMManagementImpl.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/management/VMManagementImpl.c)
src/share/native/sun/management/VMManagementImpl.c
5 lines changed: 4 ins; 0 del; 1 mod; 322 unchg
[Cdiffs](test/java/lang/management/MXBean/MXBeanBehavior.java.cdiff.html) [Udiffs](test/java/lang/management/MXBean/MXBeanBehavior.java.udiff.html) [Wdiffs](test/java/lang/management/MXBean/MXBeanBehavior.java.wdiff.html) [Sdiffs](test/java/lang/management/MXBean/MXBeanBehavior.java.sdiff.html) [Frames](test/java/lang/management/MXBean/MXBeanBehavior.java.frames.html) [Old](test/java/lang/management/MXBean/MXBeanBehavior.java-.html) [New](test/java/lang/management/MXBean/MXBeanBehavior.java.html) [Patch](test/java/lang/management/MXBean/MXBeanBehavior.java.patch) [Raw](raw%5Ffiles/new/test/java/lang/management/MXBean/MXBeanBehavior.java)
test/java/lang/management/MXBean/MXBeanBehavior.java
11 lines changed: 8 ins; 0 del; 3 mod; 169 unchg
[Cdiffs](test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java.cdiff.html) [Udiffs](test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java.udiff.html) [Wdiffs](test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java.wdiff.html) [Sdiffs](test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java.sdiff.html) [Frames](test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java.frames.html) [Old](test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java-.html) [New](test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java.html) [Patch](test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java.patch) [Raw](raw%5Ffiles/new/test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java)
test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java
17 lines changed: 7 ins; 0 del; 10 mod; 155 unchg
------ ------ ------ ------ ------ ---[New](src/share/classes/com/sun/management/DiagnosticCommandMBean.java.html) [Patch](src/share/classes/com/sun/management/DiagnosticCommandMBean.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/management/DiagnosticCommandMBean.java)
src/share/classes/com/sun/management/DiagnosticCommandMBean.java
218 lines changed: 218 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ------ ---[New](src/share/classes/sun/management/DiagnosticCommandArgumentInfo.java.html) [Patch](src/share/classes/sun/management/DiagnosticCommandArgumentInfo.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/management/DiagnosticCommandArgumentInfo.java)
src/share/classes/sun/management/DiagnosticCommandArgumentInfo.java
159 lines changed: 159 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ------ ---[New](src/share/classes/sun/management/DiagnosticCommandImpl.java.html) [Patch](src/share/classes/sun/management/DiagnosticCommandImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/management/DiagnosticCommandImpl.java)
src/share/classes/sun/management/DiagnosticCommandImpl.java
373 lines changed: 373 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ------ ---[New](src/share/classes/sun/management/DiagnosticCommandInfo.java.html) [Patch](src/share/classes/sun/management/DiagnosticCommandInfo.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/management/DiagnosticCommandInfo.java)
src/share/classes/sun/management/DiagnosticCommandInfo.java
151 lines changed: 151 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ------ ---[New](src/share/native/sun/management/DiagnosticCommandImpl.c.html) [Patch](src/share/native/sun/management/DiagnosticCommandImpl.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/management/DiagnosticCommandImpl.c)
src/share/native/sun/management/DiagnosticCommandImpl.c
169 lines changed: 169 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ------ ---[New](test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanDoubleInvocationTest.java.html) [Patch](test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanDoubleInvocationTest.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanDoubleInvocationTest.java)
test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanDoubleInvocationTest.java
91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ------ ---[New](test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanInvocationTest.java.html) [Patch](test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanInvocationTest.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanInvocationTest.java)
test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanInvocationTest.java
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ------ ---[New](test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java.html) [Patch](test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java)
test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java
244 lines changed: 244 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ------ ---[New](test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTest.java.html) [Patch](test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTest.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTest.java)
test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTest.java
115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using /java/devtools/share/bin/webrev(vers 23.18-hg+jbs).