main-hotspot-stubs (original) (raw)

Code Review for main-hotspot-stubs

Prepared by: Goetz Lindenmaier on Mon Sep 24 15:58:00 CEST 2012
Workspace: /net/usr.work/d045726/oJ/8/main-hotspot-stubs
Compare against: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot
Compare against version: 3638
Summary of changes: 82 lines changed: 40 ins; 9 del; 33 mod; 11193 unchg
Patch of changes: <main-hotspot-stubs.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/vm/asm/codeBuffer.cpp.cdiff.html) [Udiffs](src/share/vm/asm/codeBuffer.cpp.udiff.html) [Wdiffs](src/share/vm/asm/codeBuffer.cpp.wdiff.html) [Sdiffs](src/share/vm/asm/codeBuffer.cpp.sdiff.html) [Frames](src/share/vm/asm/codeBuffer.cpp.frames.html) [Old](src/share/vm/asm/codeBuffer.cpp-.html) [New](src/share/vm/asm/codeBuffer.cpp.html) [Patch](src/share/vm/asm/codeBuffer.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/asm/codeBuffer.cpp) src/share/vm/asm/codeBuffer.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

30 lines changed: 14 ins; 8 del; 8 mod; 1122 unchg

[Cdiffs](src/share/vm/asm/codeBuffer.hpp.cdiff.html) [Udiffs](src/share/vm/asm/codeBuffer.hpp.udiff.html) [Wdiffs](src/share/vm/asm/codeBuffer.hpp.wdiff.html) [Sdiffs](src/share/vm/asm/codeBuffer.hpp.sdiff.html) [Frames](src/share/vm/asm/codeBuffer.hpp.frames.html) [Old](src/share/vm/asm/codeBuffer.hpp-.html) [New](src/share/vm/asm/codeBuffer.hpp.html) [Patch](src/share/vm/asm/codeBuffer.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/asm/codeBuffer.hpp) src/share/vm/asm/codeBuffer.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

1 line changed: 0 ins; 0 del; 1 mod; 597 unchg

[Cdiffs](src/share/vm/code/codeBlob.cpp.cdiff.html) [Udiffs](src/share/vm/code/codeBlob.cpp.udiff.html) [Wdiffs](src/share/vm/code/codeBlob.cpp.wdiff.html) [Sdiffs](src/share/vm/code/codeBlob.cpp.sdiff.html) [Frames](src/share/vm/code/codeBlob.cpp.frames.html) [Old](src/share/vm/code/codeBlob.cpp-.html) [New](src/share/vm/code/codeBlob.cpp.html) [Patch](src/share/vm/code/codeBlob.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/code/codeBlob.cpp) src/share/vm/code/codeBlob.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

4 lines changed: 4 ins; 0 del; 0 mod; 577 unchg

[Cdiffs](src/share/vm/code/codeBlob.hpp.cdiff.html) [Udiffs](src/share/vm/code/codeBlob.hpp.udiff.html) [Wdiffs](src/share/vm/code/codeBlob.hpp.wdiff.html) [Sdiffs](src/share/vm/code/codeBlob.hpp.sdiff.html) [Frames](src/share/vm/code/codeBlob.hpp.frames.html) [Old](src/share/vm/code/codeBlob.hpp-.html) [New](src/share/vm/code/codeBlob.hpp.html) [Patch](src/share/vm/code/codeBlob.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/code/codeBlob.hpp) src/share/vm/code/codeBlob.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

1 line changed: 0 ins; 0 del; 1 mod; 506 unchg

[Cdiffs](src/share/vm/code/icBuffer.hpp.cdiff.html) [Udiffs](src/share/vm/code/icBuffer.hpp.udiff.html) [Wdiffs](src/share/vm/code/icBuffer.hpp.wdiff.html) [Sdiffs](src/share/vm/code/icBuffer.hpp.sdiff.html) [Frames](src/share/vm/code/icBuffer.hpp.frames.html) [Old](src/share/vm/code/icBuffer.hpp-.html) [New](src/share/vm/code/icBuffer.hpp.html) [Patch](src/share/vm/code/icBuffer.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/code/icBuffer.hpp) src/share/vm/code/icBuffer.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

3 lines changed: 2 ins; 0 del; 1 mod; 142 unchg

[Cdiffs](src/share/vm/code/nmethod.cpp.cdiff.html) [Udiffs](src/share/vm/code/nmethod.cpp.udiff.html) [Wdiffs](src/share/vm/code/nmethod.cpp.wdiff.html) [Sdiffs](src/share/vm/code/nmethod.cpp.sdiff.html) [Frames](src/share/vm/code/nmethod.cpp.frames.html) [Old](src/share/vm/code/nmethod.cpp-.html) [New](src/share/vm/code/nmethod.cpp.html) [Patch](src/share/vm/code/nmethod.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/code/nmethod.cpp) src/share/vm/code/nmethod.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

1 line changed: 0 ins; 0 del; 1 mod; 2921 unchg

[Cdiffs](src/share/vm/code/nmethod.hpp.cdiff.html) [Udiffs](src/share/vm/code/nmethod.hpp.udiff.html) [Wdiffs](src/share/vm/code/nmethod.hpp.wdiff.html) [Sdiffs](src/share/vm/code/nmethod.hpp.sdiff.html) [Frames](src/share/vm/code/nmethod.hpp.frames.html) [Old](src/share/vm/code/nmethod.hpp-.html) [New](src/share/vm/code/nmethod.hpp.html) [Patch](src/share/vm/code/nmethod.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/code/nmethod.hpp) src/share/vm/code/nmethod.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

2 lines changed: 0 ins; 0 del; 2 mod; 743 unchg

[Cdiffs](src/share/vm/code/stubs.cpp.cdiff.html) [Udiffs](src/share/vm/code/stubs.cpp.udiff.html) [Wdiffs](src/share/vm/code/stubs.cpp.wdiff.html) [Sdiffs](src/share/vm/code/stubs.cpp.sdiff.html) [Frames](src/share/vm/code/stubs.cpp.frames.html) [Old](src/share/vm/code/stubs.cpp-.html) [New](src/share/vm/code/stubs.cpp.html) [Patch](src/share/vm/code/stubs.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/code/stubs.cpp) src/share/vm/code/stubs.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

8 lines changed: 3 ins; 0 del; 5 mod; 255 unchg

[Cdiffs](src/share/vm/code/stubs.hpp.cdiff.html) [Udiffs](src/share/vm/code/stubs.hpp.udiff.html) [Wdiffs](src/share/vm/code/stubs.hpp.wdiff.html) [Sdiffs](src/share/vm/code/stubs.hpp.sdiff.html) [Frames](src/share/vm/code/stubs.hpp.frames.html) [Old](src/share/vm/code/stubs.hpp-.html) [New](src/share/vm/code/stubs.hpp.html) [Patch](src/share/vm/code/stubs.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/code/stubs.hpp) src/share/vm/code/stubs.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

11 lines changed: 6 ins; 0 del; 5 mod; 222 unchg

[Cdiffs](src/share/vm/compiler/disassembler.cpp.cdiff.html) [Udiffs](src/share/vm/compiler/disassembler.cpp.udiff.html) [Wdiffs](src/share/vm/compiler/disassembler.cpp.wdiff.html) [Sdiffs](src/share/vm/compiler/disassembler.cpp.sdiff.html) [Frames](src/share/vm/compiler/disassembler.cpp.frames.html) [Old](src/share/vm/compiler/disassembler.cpp-.html) [New](src/share/vm/compiler/disassembler.cpp.html) [Patch](src/share/vm/compiler/disassembler.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/compiler/disassembler.cpp) src/share/vm/compiler/disassembler.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

8 lines changed: 3 ins; 1 del; 4 mod; 515 unchg

[Cdiffs](src/share/vm/compiler/disassembler.hpp.cdiff.html) [Udiffs](src/share/vm/compiler/disassembler.hpp.udiff.html) [Wdiffs](src/share/vm/compiler/disassembler.hpp.wdiff.html) [Sdiffs](src/share/vm/compiler/disassembler.hpp.sdiff.html) [Frames](src/share/vm/compiler/disassembler.hpp.frames.html) [Old](src/share/vm/compiler/disassembler.hpp-.html) [New](src/share/vm/compiler/disassembler.hpp.html) [Patch](src/share/vm/compiler/disassembler.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/compiler/disassembler.hpp) src/share/vm/compiler/disassembler.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

2 lines changed: 1 ins; 0 del; 1 mod; 92 unchg

[Cdiffs](src/share/vm/interpreter/interpreter.cpp.cdiff.html) [Udiffs](src/share/vm/interpreter/interpreter.cpp.udiff.html) [Wdiffs](src/share/vm/interpreter/interpreter.cpp.wdiff.html) [Sdiffs](src/share/vm/interpreter/interpreter.cpp.sdiff.html) [Frames](src/share/vm/interpreter/interpreter.cpp.frames.html) [Old](src/share/vm/interpreter/interpreter.cpp-.html) [New](src/share/vm/interpreter/interpreter.cpp.html) [Patch](src/share/vm/interpreter/interpreter.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/interpreter/interpreter.cpp) src/share/vm/interpreter/interpreter.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

3 lines changed: 2 ins; 0 del; 1 mod; 463 unchg

[Cdiffs](src/share/vm/interpreter/interpreter.hpp.cdiff.html) [Udiffs](src/share/vm/interpreter/interpreter.hpp.udiff.html) [Wdiffs](src/share/vm/interpreter/interpreter.hpp.wdiff.html) [Sdiffs](src/share/vm/interpreter/interpreter.hpp.sdiff.html) [Frames](src/share/vm/interpreter/interpreter.hpp.frames.html) [Old](src/share/vm/interpreter/interpreter.hpp-.html) [New](src/share/vm/interpreter/interpreter.hpp.html) [Patch](src/share/vm/interpreter/interpreter.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/interpreter/interpreter.hpp) src/share/vm/interpreter/interpreter.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

4 lines changed: 2 ins; 0 del; 2 mod; 162 unchg

[Cdiffs](src/share/vm/runtime/sharedRuntime.cpp.cdiff.html) [Udiffs](src/share/vm/runtime/sharedRuntime.cpp.udiff.html) [Wdiffs](src/share/vm/runtime/sharedRuntime.cpp.wdiff.html) [Sdiffs](src/share/vm/runtime/sharedRuntime.cpp.sdiff.html) [Frames](src/share/vm/runtime/sharedRuntime.cpp.frames.html) [Old](src/share/vm/runtime/sharedRuntime.cpp-.html) [New](src/share/vm/runtime/sharedRuntime.cpp.html) [Patch](src/share/vm/runtime/sharedRuntime.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/sharedRuntime.cpp) src/share/vm/runtime/sharedRuntime.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which are stored as stubs. The output of +PrintInterpreter is unstructured und thus not easy to read. This can be improved with CodeComments of the MacroAssembler. So far they were lost when the code is turned into a Stub, while they were kept if the code is copied to a CodeBlob. Implemented storing the CodeComments in stubs and added support to pass them to the disasembler. Also added some ttyLocks and to format output.

4 lines changed: 3 ins; 0 del; 1 mod; 2876 unchg


This code review page was prepared using /usr/local/bin/webrev.ksh(vers 23.18-hg).