jdk (original) (raw)

Code Review for jdk

Prepared by: henryjen on Tue Jun 11 13:42:00 PDT 2013
Workspace: /home/hjen/ws/tl-work/jdk
Compare against: /home/hjen/ws/tl/jdk
Compare against version: 7301
Summary of changes: 1782 lines changed: 1061 ins; 611 del; 110 mod; 8684 unchg
Changeset: <jdk.changeset>
Bug id: JDK-8009736 : Comparator API cleanup - Java Bug System
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/java/util/Comparator.java.cdiff.html) [Udiffs](src/share/classes/java/util/Comparator.java.udiff.html) [Wdiffs](src/share/classes/java/util/Comparator.java.wdiff.html) [Sdiffs](src/share/classes/java/util/Comparator.java.sdiff.html) [Frames](src/share/classes/java/util/Comparator.java.frames.html) [Old](src/share/classes/java/util/Comparator.java-.html) [New](src/share/classes/java/util/Comparator.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/Comparator.java) src/share/classes/java/util/Comparator.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

307 lines changed: 276 ins; 4 del; 27 mod; 231 unchg

[Cdiffs](src/share/classes/java/util/Comparators.java.cdiff.html) [Udiffs](src/share/classes/java/util/Comparators.java.udiff.html) [Wdiffs](src/share/classes/java/util/Comparators.java.wdiff.html) [Sdiffs](src/share/classes/java/util/Comparators.java.sdiff.html) [Frames](src/share/classes/java/util/Comparators.java.frames.html) [Old](src/share/classes/java/util/Comparators.java-.html) [New](src/share/classes/java/util/Comparators.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/Comparators.java) src/share/classes/java/util/Comparators.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

223 lines changed: 0 ins; 190 del; 33 mod; 58 unchg

[Cdiffs](src/share/classes/java/util/Map.java.cdiff.html) [Udiffs](src/share/classes/java/util/Map.java.udiff.html) [Wdiffs](src/share/classes/java/util/Map.java.wdiff.html) [Sdiffs](src/share/classes/java/util/Map.java.sdiff.html) [Frames](src/share/classes/java/util/Map.java.frames.html) [Old](src/share/classes/java/util/Map.java-.html) [New](src/share/classes/java/util/Map.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/Map.java) src/share/classes/java/util/Map.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

71 lines changed: 71 ins; 0 del; 0 mod; 1091 unchg

[Cdiffs](src/share/classes/java/util/TreeMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/TreeMap.java.udiff.html) [Wdiffs](src/share/classes/java/util/TreeMap.java.wdiff.html) [Sdiffs](src/share/classes/java/util/TreeMap.java.sdiff.html) [Frames](src/share/classes/java/util/TreeMap.java.frames.html) [Old](src/share/classes/java/util/TreeMap.java-.html) [New](src/share/classes/java/util/TreeMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/TreeMap.java) src/share/classes/java/util/TreeMap.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

2 lines changed: 0 ins; 0 del; 2 mod; 2919 unchg

[Cdiffs](src/share/classes/java/util/function/BinaryOperator.java.cdiff.html) [Udiffs](src/share/classes/java/util/function/BinaryOperator.java.udiff.html) [Wdiffs](src/share/classes/java/util/function/BinaryOperator.java.wdiff.html) [Sdiffs](src/share/classes/java/util/function/BinaryOperator.java.sdiff.html) [Frames](src/share/classes/java/util/function/BinaryOperator.java.frames.html) [Old](src/share/classes/java/util/function/BinaryOperator.java-.html) [New](src/share/classes/java/util/function/BinaryOperator.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/function/BinaryOperator.java) src/share/classes/java/util/function/BinaryOperator.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

28 lines changed: 28 ins; 0 del; 0 mod; 38 unchg

[Cdiffs](src/share/classes/java/util/stream/Collectors.java.cdiff.html) [Udiffs](src/share/classes/java/util/stream/Collectors.java.udiff.html) [Wdiffs](src/share/classes/java/util/stream/Collectors.java.wdiff.html) [Sdiffs](src/share/classes/java/util/stream/Collectors.java.sdiff.html) [Frames](src/share/classes/java/util/stream/Collectors.java.frames.html) [Old](src/share/classes/java/util/stream/Collectors.java-.html) [New](src/share/classes/java/util/stream/Collectors.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/stream/Collectors.java) src/share/classes/java/util/stream/Collectors.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

11 lines changed: 0 ins; 1 del; 10 mod; 1309 unchg

[Cdiffs](src/share/classes/java/util/stream/ReferencePipeline.java.cdiff.html) [Udiffs](src/share/classes/java/util/stream/ReferencePipeline.java.udiff.html) [Wdiffs](src/share/classes/java/util/stream/ReferencePipeline.java.wdiff.html) [Sdiffs](src/share/classes/java/util/stream/ReferencePipeline.java.sdiff.html) [Frames](src/share/classes/java/util/stream/ReferencePipeline.java.frames.html) [Old](src/share/classes/java/util/stream/ReferencePipeline.java-.html) [New](src/share/classes/java/util/stream/ReferencePipeline.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/stream/ReferencePipeline.java) src/share/classes/java/util/stream/ReferencePipeline.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

3 lines changed: 0 ins; 1 del; 2 mod; 629 unchg

[Cdiffs](src/share/classes/java/util/stream/SortedOps.java.cdiff.html) [Udiffs](src/share/classes/java/util/stream/SortedOps.java.udiff.html) [Wdiffs](src/share/classes/java/util/stream/SortedOps.java.wdiff.html) [Sdiffs](src/share/classes/java/util/stream/SortedOps.java.sdiff.html) [Frames](src/share/classes/java/util/stream/SortedOps.java.frames.html) [Old](src/share/classes/java/util/stream/SortedOps.java-.html) [New](src/share/classes/java/util/stream/SortedOps.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/stream/SortedOps.java) src/share/classes/java/util/stream/SortedOps.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

2 lines changed: 0 ins; 1 del; 1 mod; 545 unchg

[Cdiffs](test/java/nio/file/Files/StreamTest.java.cdiff.html) [Udiffs](test/java/nio/file/Files/StreamTest.java.udiff.html) [Wdiffs](test/java/nio/file/Files/StreamTest.java.wdiff.html) [Sdiffs](test/java/nio/file/Files/StreamTest.java.sdiff.html) [Frames](test/java/nio/file/Files/StreamTest.java.frames.html) [Old](test/java/nio/file/Files/StreamTest.java-.html) [New](test/java/nio/file/Files/StreamTest.java.html) -----[Raw](raw%5Ffiles/new/test/java/nio/file/Files/StreamTest.java) test/java/nio/file/Files/StreamTest.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

8 lines changed: 0 ins; 0 del; 8 mod; 653 unchg

[Cdiffs](test/java/util/Collection/ListDefaults.java.cdiff.html) [Udiffs](test/java/util/Collection/ListDefaults.java.udiff.html) [Wdiffs](test/java/util/Collection/ListDefaults.java.wdiff.html) [Sdiffs](test/java/util/Collection/ListDefaults.java.sdiff.html) [Frames](test/java/util/Collection/ListDefaults.java.frames.html) [Old](test/java/util/Collection/ListDefaults.java-.html) [New](test/java/util/Collection/ListDefaults.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collection/ListDefaults.java) test/java/util/Collection/ListDefaults.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

10 lines changed: 0 ins; 1 del; 9 mod; 520 unchg

[Cdiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java.cdiff.html) [Udiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java.udiff.html) [Wdiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java.wdiff.html) [Sdiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java.sdiff.html) [Frames](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java.frames.html) [Old](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java-.html) [New](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java) test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

5 lines changed: 1 ins; 1 del; 3 mod; 114 unchg

[Cdiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java.cdiff.html) [Udiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java.udiff.html) [Wdiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java.wdiff.html) [Sdiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java.sdiff.html) [Frames](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java.frames.html) [Old](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java-.html) [New](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java) test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

1 line changed: 0 ins; 0 del; 1 mod; 246 unchg

[Cdiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java.cdiff.html) [Udiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java.udiff.html) [Wdiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java.wdiff.html) [Sdiffs](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java.sdiff.html) [Frames](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java.frames.html) [Old](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java-.html) [New](test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java) test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

10 lines changed: 0 ins; 0 del; 10 mod; 249 unchg

[Cdiffs](test/sun/misc/JavaLangAccess/NewUnsafeString.java.cdiff.html) [Udiffs](test/sun/misc/JavaLangAccess/NewUnsafeString.java.udiff.html) [Wdiffs](test/sun/misc/JavaLangAccess/NewUnsafeString.java.wdiff.html) [Sdiffs](test/sun/misc/JavaLangAccess/NewUnsafeString.java.sdiff.html) [Frames](test/sun/misc/JavaLangAccess/NewUnsafeString.java.frames.html) [Old](test/sun/misc/JavaLangAccess/NewUnsafeString.java-.html) [New](test/sun/misc/JavaLangAccess/NewUnsafeString.java.html) -----[Raw](raw%5Ffiles/new/test/sun/misc/JavaLangAccess/NewUnsafeString.java) test/sun/misc/JavaLangAccess/NewUnsafeString.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

4 lines changed: 0 ins; 0 del; 4 mod; 82 unchg

------ ------ ------ ------ ------ ---[New](test/java/util/Comparator/BasicTest.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Comparator/BasicTest.java) test/java/util/Comparator/BasicTest.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

344 lines changed: 344 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/java/util/Comparator/TypeTest.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Comparator/TypeTest.java) test/java/util/Comparator/TypeTest.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/java/util/Map/EntryComparators.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Map/EntryComparators.java) test/java/util/Map/EntryComparators.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/java/util/function/BinaryOperator/BasicTest.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/function/BinaryOperator/BasicTest.java) test/java/util/function/BinaryOperator/BasicTest.java

rev 7302 : 8009736: Comparator API cleanup Reviewed-by: Contributed-by: henry.jen@oracle.com

104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------[Old](test/java/util/Comparators/BasicTest.java-.html) --- ----- --- test/java/util/Comparators/BasicTest.java

412 lines changed: 0 ins; 412 del; 0 mod; 0 unchg


This code review page was prepared using ../make/scripts/webrev.ksh(vers 24.0-hg+jbs).