jdk.jdk (original) (raw)

Code Review for jdk.jdk

[Cdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/BandStructure.java.cdiff.html) [Udiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/BandStructure.java.udiff.html) [Sdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/BandStructure.java.sdiff.html) [Frames](src/java.base/share/classes/com/sun/java/util/jar/pack/BandStructure.java.frames.html) [Old](src/java.base/share/classes/com/sun/java/util/jar/pack/BandStructure.java-.html) [New](src/java.base/share/classes/com/sun/java/util/jar/pack/BandStructure.java.html) [Patch](src/java.base/share/classes/com/sun/java/util/jar/pack/BandStructure.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/com/sun/java/util/jar/pack/BandStructure.java) src/java.base/share/classes/com/sun/java/util/jar/pack/BandStructure.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

1 line changed: 1 ins; 0 del; 0 mod; 2761 unchg

[Cdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java.cdiff.html) [Udiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java.udiff.html) [Sdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java.sdiff.html) [Frames](src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java.frames.html) [Old](src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java-.html) [New](src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java.html) [Patch](src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java) src/java.base/share/classes/com/sun/java/util/jar/pack/Driver.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

21 lines changed: 19 ins; 0 del; 2 mod; 727 unchg

[Cdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource.java.cdiff.html) [Udiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource.java.udiff.html) [Sdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource.java.sdiff.html) [Frames](src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource.java.frames.html) [Old](src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource.java-.html) [New](src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource.java.html) [Patch](src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource.java) src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

2 lines changed: 2 ins; 0 del; 0 mod; 134 unchg

[Cdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java.cdiff.html) [Udiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java.udiff.html) [Sdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java.sdiff.html) [Frames](src/java.base/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java.frames.html) [Old](src/java.base/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java-.html) [New](src/java.base/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java.html) [Patch](src/java.base/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java) src/java.base/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

1 line changed: 1 ins; 0 del; 0 mod; 331 unchg

[Cdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java.cdiff.html) [Udiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java.udiff.html) [Sdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java.sdiff.html) [Frames](src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java.frames.html) [Old](src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java-.html) [New](src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java.html) [Patch](src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java) src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

1 line changed: 0 ins; 0 del; 1 mod; 610 unchg

[Cdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/PropMap.java.cdiff.html) [Udiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/PropMap.java.udiff.html) [Sdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/PropMap.java.sdiff.html) [Frames](src/java.base/share/classes/com/sun/java/util/jar/pack/PropMap.java.frames.html) [Old](src/java.base/share/classes/com/sun/java/util/jar/pack/PropMap.java-.html) [New](src/java.base/share/classes/com/sun/java/util/jar/pack/PropMap.java.html) [Patch](src/java.base/share/classes/com/sun/java/util/jar/pack/PropMap.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/com/sun/java/util/jar/pack/PropMap.java) src/java.base/share/classes/com/sun/java/util/jar/pack/PropMap.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

1 line changed: 1 ins; 0 del; 0 mod; 331 unchg

[Cdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java.cdiff.html) [Udiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java.udiff.html) [Sdiffs](src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java.sdiff.html) [Frames](src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java.frames.html) [Old](src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java-.html) [New](src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java.html) [Patch](src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java) src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

1 line changed: 1 ins; 0 del; 0 mod; 262 unchg

[Cdiffs](src/java.base/share/classes/java/util/jar/Pack200.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/jar/Pack200.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/jar/Pack200.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/jar/Pack200.java.frames.html) [Old](src/java.base/share/classes/java/util/jar/Pack200.java-.html) [New](src/java.base/share/classes/java/util/jar/Pack200.java.html) [Patch](src/java.base/share/classes/java/util/jar/Pack200.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/jar/Pack200.java) src/java.base/share/classes/java/util/jar/Pack200.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

4 lines changed: 4 ins; 0 del; 0 mod; 724 unchg

[Cdiffs](src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java.cdiff.html) [Udiffs](src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java.udiff.html) [Sdiffs](src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java.sdiff.html) [Frames](src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java.frames.html) [Old](src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java-.html) [New](src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java.html) [Patch](src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java.patch) [Raw](raw%5Ffiles/new/src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java) src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

7 lines changed: 4 ins; 3 del; 0 mod; 369 unchg

[Cdiffs](src/jdk.jartool/share/classes/sun/tools/jar/Main.java.cdiff.html) [Udiffs](src/jdk.jartool/share/classes/sun/tools/jar/Main.java.udiff.html) [Sdiffs](src/jdk.jartool/share/classes/sun/tools/jar/Main.java.sdiff.html) [Frames](src/jdk.jartool/share/classes/sun/tools/jar/Main.java.frames.html) [Old](src/jdk.jartool/share/classes/sun/tools/jar/Main.java-.html) [New](src/jdk.jartool/share/classes/sun/tools/jar/Main.java.html) [Patch](src/jdk.jartool/share/classes/sun/tools/jar/Main.java.patch) [Raw](raw%5Ffiles/new/src/jdk.jartool/share/classes/sun/tools/jar/Main.java) src/jdk.jartool/share/classes/sun/tools/jar/Main.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

27 lines changed: 11 ins; 4 del; 12 mod; 2252 unchg

[Cdiffs](src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties.cdiff.html) [Udiffs](src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties.udiff.html) [Sdiffs](src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties.sdiff.html) [Frames](src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties.frames.html) [Old](src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties-.html) [New](src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties.html) [Patch](src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties.patch) [Raw](raw%5Ffiles/new/src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties) src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

6 lines changed: 4 ins; 0 del; 2 mod; 300 unchg

[Cdiffs](src/jdk.pack/share/classes/module-info.java.cdiff.html) [Udiffs](src/jdk.pack/share/classes/module-info.java.udiff.html) [Sdiffs](src/jdk.pack/share/classes/module-info.java.sdiff.html) [Frames](src/jdk.pack/share/classes/module-info.java.frames.html) [Old](src/jdk.pack/share/classes/module-info.java-.html) [New](src/jdk.pack/share/classes/module-info.java.html) [Patch](src/jdk.pack/share/classes/module-info.java.patch) [Raw](raw%5Ffiles/new/src/jdk.pack/share/classes/module-info.java) src/jdk.pack/share/classes/module-info.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

1 line changed: 1 ins; 0 del; 0 mod; 42 unchg

[Cdiffs](src/jdk.pack/share/native/common-unpack/defines.h.cdiff.html) [Udiffs](src/jdk.pack/share/native/common-unpack/defines.h.udiff.html) [Sdiffs](src/jdk.pack/share/native/common-unpack/defines.h.sdiff.html) [Frames](src/jdk.pack/share/native/common-unpack/defines.h.frames.html) [Old](src/jdk.pack/share/native/common-unpack/defines.h-.html) [New](src/jdk.pack/share/native/common-unpack/defines.h.html) [Patch](src/jdk.pack/share/native/common-unpack/defines.h.patch) [Raw](raw%5Ffiles/new/src/jdk.pack/share/native/common-unpack/defines.h) src/jdk.pack/share/native/common-unpack/defines.h

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

2 lines changed: 2 ins; 0 del; 0 mod; 176 unchg

[Cdiffs](src/jdk.pack/share/native/unpack200/main.cpp.cdiff.html) [Udiffs](src/jdk.pack/share/native/unpack200/main.cpp.udiff.html) [Sdiffs](src/jdk.pack/share/native/unpack200/main.cpp.sdiff.html) [Frames](src/jdk.pack/share/native/unpack200/main.cpp.frames.html) [Old](src/jdk.pack/share/native/unpack200/main.cpp-.html) [New](src/jdk.pack/share/native/unpack200/main.cpp.html) [Patch](src/jdk.pack/share/native/unpack200/main.cpp.patch) [Raw](raw%5Ffiles/new/src/jdk.pack/share/native/unpack200/main.cpp) src/jdk.pack/share/native/unpack200/main.cpp

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

22 lines changed: 19 ins; 0 del; 3 mod; 447 unchg

[Cdiffs](test/jdk/tools/pack200/Utils.java.cdiff.html) [Udiffs](test/jdk/tools/pack200/Utils.java.udiff.html) [Sdiffs](test/jdk/tools/pack200/Utils.java.sdiff.html) [Frames](test/jdk/tools/pack200/Utils.java.frames.html) [Old](test/jdk/tools/pack200/Utils.java-.html) [New](test/jdk/tools/pack200/Utils.java.html) [Patch](test/jdk/tools/pack200/Utils.java.patch) [Raw](raw%5Ffiles/new/test/jdk/tools/pack200/Utils.java) test/jdk/tools/pack200/Utils.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

5 lines changed: 4 ins; 0 del; 1 mod; 665 unchg

------ ------ ------ ------ ---[New](test/jdk/tools/jar/DeprecateOptionN.java.html) [Patch](test/jdk/tools/jar/DeprecateOptionN.java.patch) [Raw](raw%5Ffiles/new/test/jdk/tools/jar/DeprecateOptionN.java) test/jdk/tools/jar/DeprecateOptionN.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/jdk/tools/pack200/DeprecatePack200.java.html) [Patch](test/jdk/tools/pack200/DeprecatePack200.java.patch) [Raw](raw%5Ffiles/new/test/jdk/tools/pack200/DeprecatePack200.java) test/jdk/tools/pack200/DeprecatePack200.java

rev 50498 : 8199871: Deprecate pack200 and unpack200 tools Reviewed-by:

75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/hjen/bin/webrev.ksh(vers 25.16-hg+openjdk.java.net).