jdk (original) (raw)

Code Review for jdk

[Cdiffs](src/macosx/classes/apple/security/KeychainStore.java.cdiff.html) [Udiffs](src/macosx/classes/apple/security/KeychainStore.java.udiff.html) [Sdiffs](src/macosx/classes/apple/security/KeychainStore.java.sdiff.html) [Frames](src/macosx/classes/apple/security/KeychainStore.java.frames.html) [Old](src/macosx/classes/apple/security/KeychainStore.java-.html) [New](src/macosx/classes/apple/security/KeychainStore.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/apple/security/KeychainStore.java) src/macosx/classes/apple/security/KeychainStore.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

16 lines changed: 0 ins; 0 del; 16 mod; 1114 unchg

[Cdiffs](src/macosx/classes/com/apple/eawt/%5FAppDockIconHandler.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/eawt/%5FAppDockIconHandler.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/eawt/%5FAppDockIconHandler.java.sdiff.html) [Frames](src/macosx/classes/com/apple/eawt/%5FAppDockIconHandler.java.frames.html) [Old](src/macosx/classes/com/apple/eawt/%5FAppDockIconHandler.java-.html) [New](src/macosx/classes/com/apple/eawt/%5FAppDockIconHandler.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/eawt/%5FAppDockIconHandler.java) src/macosx/classes/com/apple/eawt/_AppDockIconHandler.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

1 line changed: 0 ins; 0 del; 1 mod; 116 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaBorder.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaBorder.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaBorder.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaBorder.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaBorder.java-.html) [New](src/macosx/classes/com/apple/laf/AquaBorder.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaBorder.java) src/macosx/classes/com/apple/laf/AquaBorder.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

1 line changed: 0 ins; 0 del; 1 mod; 141 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxButton.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaComboBoxButton.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxButton.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaComboBoxButton.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaComboBoxButton.java-.html) [New](src/macosx/classes/com/apple/laf/AquaComboBoxButton.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaComboBoxButton.java) src/macosx/classes/com/apple/laf/AquaComboBoxButton.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

7 lines changed: 3 ins; 0 del; 4 mod; 222 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxPopup.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaComboBoxPopup.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxPopup.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaComboBoxPopup.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaComboBoxPopup.java-.html) [New](src/macosx/classes/com/apple/laf/AquaComboBoxPopup.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaComboBoxPopup.java) src/macosx/classes/com/apple/laf/AquaComboBoxPopup.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

4 lines changed: 0 ins; 0 del; 4 mod; 377 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java-.html) [New](src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java) src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

2 lines changed: 0 ins; 0 del; 2 mod; 34 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java-.html) [New](src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java) src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

7 lines changed: 3 ins; 0 del; 4 mod; 154 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxUI.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaComboBoxUI.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaComboBoxUI.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaComboBoxUI.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaComboBoxUI.java-.html) [New](src/macosx/classes/com/apple/laf/AquaComboBoxUI.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaComboBoxUI.java) src/macosx/classes/com/apple/laf/AquaComboBoxUI.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

15 lines changed: 1 ins; 0 del; 14 mod; 633 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaFileChooserUI.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaFileChooserUI.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaFileChooserUI.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaFileChooserUI.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaFileChooserUI.java-.html) [New](src/macosx/classes/com/apple/laf/AquaFileChooserUI.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaFileChooserUI.java) src/macosx/classes/com/apple/laf/AquaFileChooserUI.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

24 lines changed: 7 ins; 0 del; 17 mod; 2342 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaFocusHandler.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaFocusHandler.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaFocusHandler.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaFocusHandler.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaFocusHandler.java-.html) [New](src/macosx/classes/com/apple/laf/AquaFocusHandler.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaFocusHandler.java) src/macosx/classes/com/apple/laf/AquaFocusHandler.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

2 lines changed: 0 ins; 0 del; 2 mod; 161 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaListUI.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaListUI.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaListUI.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaListUI.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaListUI.java-.html) [New](src/macosx/classes/com/apple/laf/AquaListUI.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaListUI.java) src/macosx/classes/com/apple/laf/AquaListUI.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

3 lines changed: 0 ins; 0 del; 3 mod; 205 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java-.html) [New](src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java) src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

1 line changed: 0 ins; 0 del; 1 mod; 3836 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaTableHeaderUI.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaTableHeaderUI.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaTableHeaderUI.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaTableHeaderUI.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaTableHeaderUI.java-.html) [New](src/macosx/classes/com/apple/laf/AquaTableHeaderUI.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaTableHeaderUI.java) src/macosx/classes/com/apple/laf/AquaTableHeaderUI.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

1 line changed: 1 ins; 0 del; 0 mod; 257 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaUtilControlSize.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaUtilControlSize.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaUtilControlSize.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaUtilControlSize.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaUtilControlSize.java-.html) [New](src/macosx/classes/com/apple/laf/AquaUtilControlSize.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaUtilControlSize.java) src/macosx/classes/com/apple/laf/AquaUtilControlSize.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

1 line changed: 0 ins; 0 del; 1 mod; 288 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/AquaUtils.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/AquaUtils.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/AquaUtils.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/AquaUtils.java.frames.html) [Old](src/macosx/classes/com/apple/laf/AquaUtils.java-.html) [New](src/macosx/classes/com/apple/laf/AquaUtils.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/AquaUtils.java) src/macosx/classes/com/apple/laf/AquaUtils.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

4 lines changed: 2 ins; 0 del; 2 mod; 452 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/ClientPropertyApplicator.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/ClientPropertyApplicator.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/ClientPropertyApplicator.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/ClientPropertyApplicator.java.frames.html) [Old](src/macosx/classes/com/apple/laf/ClientPropertyApplicator.java-.html) [New](src/macosx/classes/com/apple/laf/ClientPropertyApplicator.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/ClientPropertyApplicator.java) src/macosx/classes/com/apple/laf/ClientPropertyApplicator.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

1 line changed: 1 ins; 0 del; 0 mod; 92 unchg

[Cdiffs](src/macosx/classes/com/apple/laf/ScreenMenuBar.java.cdiff.html) [Udiffs](src/macosx/classes/com/apple/laf/ScreenMenuBar.java.udiff.html) [Sdiffs](src/macosx/classes/com/apple/laf/ScreenMenuBar.java.sdiff.html) [Frames](src/macosx/classes/com/apple/laf/ScreenMenuBar.java.frames.html) [Old](src/macosx/classes/com/apple/laf/ScreenMenuBar.java-.html) [New](src/macosx/classes/com/apple/laf/ScreenMenuBar.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/com/apple/laf/ScreenMenuBar.java) src/macosx/classes/com/apple/laf/ScreenMenuBar.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

1 line changed: 1 ins; 0 del; 0 mod; 297 unchg

[Cdiffs](src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java.cdiff.html) [Udiffs](src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java.udiff.html) [Sdiffs](src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java.sdiff.html) [Frames](src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java.frames.html) [Old](src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java-.html) [New](src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java) src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

3 lines changed: 0 ins; 0 del; 3 mod; 490 unchg

[Cdiffs](src/macosx/classes/sun/lwawt/macosx/CInputMethod.java.cdiff.html) [Udiffs](src/macosx/classes/sun/lwawt/macosx/CInputMethod.java.udiff.html) [Sdiffs](src/macosx/classes/sun/lwawt/macosx/CInputMethod.java.sdiff.html) [Frames](src/macosx/classes/sun/lwawt/macosx/CInputMethod.java.frames.html) [Old](src/macosx/classes/sun/lwawt/macosx/CInputMethod.java-.html) [New](src/macosx/classes/sun/lwawt/macosx/CInputMethod.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/sun/lwawt/macosx/CInputMethod.java) src/macosx/classes/sun/lwawt/macosx/CInputMethod.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

7 lines changed: 1 ins; 0 del; 6 mod; 806 unchg

[Cdiffs](src/macosx/classes/sun/lwawt/macosx/CInputMethodDescriptor.java.cdiff.html) [Udiffs](src/macosx/classes/sun/lwawt/macosx/CInputMethodDescriptor.java.udiff.html) [Sdiffs](src/macosx/classes/sun/lwawt/macosx/CInputMethodDescriptor.java.sdiff.html) [Frames](src/macosx/classes/sun/lwawt/macosx/CInputMethodDescriptor.java.frames.html) [Old](src/macosx/classes/sun/lwawt/macosx/CInputMethodDescriptor.java-.html) [New](src/macosx/classes/sun/lwawt/macosx/CInputMethodDescriptor.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/sun/lwawt/macosx/CInputMethodDescriptor.java) src/macosx/classes/sun/lwawt/macosx/CInputMethodDescriptor.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

2 lines changed: 0 ins; 0 del; 2 mod; 121 unchg

[Cdiffs](src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java.cdiff.html) [Udiffs](src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java.udiff.html) [Sdiffs](src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java.sdiff.html) [Frames](src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java.frames.html) [Old](src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java-.html) [New](src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java) src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

1 line changed: 0 ins; 0 del; 1 mod; 1087 unchg

[Cdiffs](src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java.cdiff.html) [Udiffs](src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java.udiff.html) [Sdiffs](src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java.sdiff.html) [Frames](src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java.frames.html) [Old](src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java-.html) [New](src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java.html) -----[Raw](raw%5Ffiles/new/src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java) src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java

rev 10208 : 8044862: Fix raw and unchecked lint warnings in macosx specific code Reviewed-by: darcy, pchelko

3 lines changed: 2 ins; 0 del; 1 mod; 901 unchg

This code review page was prepared using /home/hjen/ws/webrev/webrev.ksh(vers 25.2-hg+openjdk.java.net).