open (original) (raw)

Code Review for open

Prepared by: iklam on Tue Oct 30 10:16:00 PDT 2018
Workspace: /jdk/eva/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version: qparent
Summary of changes: 281 lines changed: 140 ins; 118 del; 23 mod; 836 unchg
Patch of changes: <open.patch>
Legend: Modified file Deleted file New file

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java

8 lines changed: 3 ins; 4 del; 1 mod; 44 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java

44 lines changed: 38 ins; 0 del; 6 mod; 162 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java

9 lines changed: 4 ins; 4 del; 1 mod; 50 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java

9 lines changed: 4 ins; 4 del; 1 mod; 68 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java

10 lines changed: 5 ins; 4 del; 1 mod; 48 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java

9 lines changed: 4 ins; 4 del; 1 mod; 51 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java

17 lines changed: 9 ins; 4 del; 4 mod; 63 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java

11 lines changed: 5 ins; 4 del; 2 mod; 43 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java

12 lines changed: 8 ins; 2 del; 2 mod; 62 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java

48 lines changed: 47 ins; 0 del; 1 mod; 142 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java

9 lines changed: 4 ins; 4 del; 1 mod; 47 unchg

[Cdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java.cdiff.html) [Udiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java.udiff.html) [Sdiffs](test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java.sdiff.html) [Frames](test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java.frames.html) [Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java-.html) [New](test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java.html) [Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java) test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java

15 lines changed: 9 ins; 4 del; 2 mod; 56 unchg

------ ------ ------ ------[Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions%5FnoCompactStrings.java-.html) ---[Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions%5FnoCompactStrings.java.patch) --- test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions_noCompactStrings.java

40 lines changed: 0 ins; 40 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions%5FstringDedup.java-.html) ---[Patch](test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions%5FstringDedup.java.patch) --- test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions_stringDedup.java

40 lines changed: 0 ins; 40 del; 0 mod; 0 unchg


This code review page was prepared using /home/iklam/jdk/proj/ioisvn/scripts/webrev.ksh(vers 25.16-hg+openjdk.java.net).