jdk (original) (raw)

Code Review for jdk

Prepared by: jfranck on Mon Jan 21 20:36:29 CET 2013
Workspace: /localhome/hgsrc/8004698/type-annotations/jdk
Summary of changes: 1998 lines changed: 1968 ins; 2 del; 28 mod; 10565 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/java/lang/Class.java.cdiff.html) [Udiffs](src/share/classes/java/lang/Class.java.udiff.html) [Sdiffs](src/share/classes/java/lang/Class.java.sdiff.html) [Frames](src/share/classes/java/lang/Class.java.frames.html) [Old](src/share/classes/java/lang/Class.java-.html) [New](src/share/classes/java/lang/Class.java.html) [Patch](src/share/classes/java/lang/Class.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/Class.java) src/share/classes/java/lang/Class.java

58 lines changed: 58 ins; 0 del; 0 mod; 3199 unchg

[Cdiffs](src/share/classes/java/lang/System.java.cdiff.html) [Udiffs](src/share/classes/java/lang/System.java.udiff.html) [Sdiffs](src/share/classes/java/lang/System.java.sdiff.html) [Frames](src/share/classes/java/lang/System.java.frames.html) [Old](src/share/classes/java/lang/System.java-.html) [New](src/share/classes/java/lang/System.java.html) [Patch](src/share/classes/java/lang/System.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/System.java) src/share/classes/java/lang/System.java

8 lines changed: 7 ins; 0 del; 1 mod; 1225 unchg

[Cdiffs](src/share/classes/java/lang/reflect/Constructor.java.cdiff.html) [Udiffs](src/share/classes/java/lang/reflect/Constructor.java.udiff.html) [Sdiffs](src/share/classes/java/lang/reflect/Constructor.java.sdiff.html) [Frames](src/share/classes/java/lang/reflect/Constructor.java.frames.html) [Old](src/share/classes/java/lang/reflect/Constructor.java-.html) [New](src/share/classes/java/lang/reflect/Constructor.java.html) [Patch](src/share/classes/java/lang/reflect/Constructor.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/Constructor.java) src/share/classes/java/lang/reflect/Constructor.java

9 lines changed: 8 ins; 0 del; 1 mod; 520 unchg

[Cdiffs](src/share/classes/java/lang/reflect/Executable.java.cdiff.html) [Udiffs](src/share/classes/java/lang/reflect/Executable.java.udiff.html) [Sdiffs](src/share/classes/java/lang/reflect/Executable.java.sdiff.html) [Frames](src/share/classes/java/lang/reflect/Executable.java.frames.html) [Old](src/share/classes/java/lang/reflect/Executable.java-.html) [New](src/share/classes/java/lang/reflect/Executable.java.html) [Patch](src/share/classes/java/lang/reflect/Executable.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/Executable.java) src/share/classes/java/lang/reflect/Executable.java

77 lines changed: 76 ins; 0 del; 1 mod; 405 unchg

[Cdiffs](src/share/classes/java/lang/reflect/Field.java.cdiff.html) [Udiffs](src/share/classes/java/lang/reflect/Field.java.udiff.html) [Sdiffs](src/share/classes/java/lang/reflect/Field.java.sdiff.html) [Frames](src/share/classes/java/lang/reflect/Field.java.frames.html) [Old](src/share/classes/java/lang/reflect/Field.java-.html) [New](src/share/classes/java/lang/reflect/Field.java.html) [Patch](src/share/classes/java/lang/reflect/Field.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/Field.java) src/share/classes/java/lang/reflect/Field.java

19 lines changed: 17 ins; 0 del; 2 mod; 1054 unchg

[Cdiffs](src/share/classes/java/lang/reflect/Method.java.cdiff.html) [Udiffs](src/share/classes/java/lang/reflect/Method.java.udiff.html) [Sdiffs](src/share/classes/java/lang/reflect/Method.java.sdiff.html) [Frames](src/share/classes/java/lang/reflect/Method.java.frames.html) [Old](src/share/classes/java/lang/reflect/Method.java-.html) [New](src/share/classes/java/lang/reflect/Method.java.html) [Patch](src/share/classes/java/lang/reflect/Method.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/Method.java) src/share/classes/java/lang/reflect/Method.java

9 lines changed: 8 ins; 0 del; 1 mod; 621 unchg

[Cdiffs](src/share/classes/java/lang/reflect/ReflectAccess.java.cdiff.html) [Udiffs](src/share/classes/java/lang/reflect/ReflectAccess.java.udiff.html) [Sdiffs](src/share/classes/java/lang/reflect/ReflectAccess.java.sdiff.html) [Frames](src/share/classes/java/lang/reflect/ReflectAccess.java.frames.html) [Old](src/share/classes/java/lang/reflect/ReflectAccess.java-.html) [New](src/share/classes/java/lang/reflect/ReflectAccess.java.html) [Patch](src/share/classes/java/lang/reflect/ReflectAccess.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/ReflectAccess.java) src/share/classes/java/lang/reflect/ReflectAccess.java

5 lines changed: 4 ins; 0 del; 1 mod; 145 unchg

[Cdiffs](src/share/classes/java/lang/reflect/TypeVariable.java.cdiff.html) [Udiffs](src/share/classes/java/lang/reflect/TypeVariable.java.udiff.html) [Sdiffs](src/share/classes/java/lang/reflect/TypeVariable.java.sdiff.html) [Frames](src/share/classes/java/lang/reflect/TypeVariable.java.frames.html) [Old](src/share/classes/java/lang/reflect/TypeVariable.java-.html) [New](src/share/classes/java/lang/reflect/TypeVariable.java.html) [Patch](src/share/classes/java/lang/reflect/TypeVariable.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/TypeVariable.java) src/share/classes/java/lang/reflect/TypeVariable.java

13 lines changed: 12 ins; 0 del; 1 mod; 88 unchg

[Cdiffs](src/share/classes/sun/misc/JavaLangAccess.java.cdiff.html) [Udiffs](src/share/classes/sun/misc/JavaLangAccess.java.udiff.html) [Sdiffs](src/share/classes/sun/misc/JavaLangAccess.java.sdiff.html) [Frames](src/share/classes/sun/misc/JavaLangAccess.java.frames.html) [Old](src/share/classes/sun/misc/JavaLangAccess.java-.html) [New](src/share/classes/sun/misc/JavaLangAccess.java.html) [Patch](src/share/classes/sun/misc/JavaLangAccess.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/misc/JavaLangAccess.java) src/share/classes/sun/misc/JavaLangAccess.java

14 lines changed: 13 ins; 0 del; 1 mod; 91 unchg

[Cdiffs](src/share/classes/sun/reflect/LangReflectAccess.java.cdiff.html) [Udiffs](src/share/classes/sun/reflect/LangReflectAccess.java.udiff.html) [Sdiffs](src/share/classes/sun/reflect/LangReflectAccess.java.sdiff.html) [Frames](src/share/classes/sun/reflect/LangReflectAccess.java.frames.html) [Old](src/share/classes/sun/reflect/LangReflectAccess.java-.html) [New](src/share/classes/sun/reflect/LangReflectAccess.java.html) [Patch](src/share/classes/sun/reflect/LangReflectAccess.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/reflect/LangReflectAccess.java) src/share/classes/sun/reflect/LangReflectAccess.java

4 lines changed: 3 ins; 0 del; 1 mod; 108 unchg

[Cdiffs](src/share/classes/sun/reflect/ReflectionFactory.java.cdiff.html) [Udiffs](src/share/classes/sun/reflect/ReflectionFactory.java.udiff.html) [Sdiffs](src/share/classes/sun/reflect/ReflectionFactory.java.sdiff.html) [Frames](src/share/classes/sun/reflect/ReflectionFactory.java.frames.html) [Old](src/share/classes/sun/reflect/ReflectionFactory.java-.html) [New](src/share/classes/sun/reflect/ReflectionFactory.java.html) [Patch](src/share/classes/sun/reflect/ReflectionFactory.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/reflect/ReflectionFactory.java) src/share/classes/sun/reflect/ReflectionFactory.java

8 lines changed: 7 ins; 0 del; 1 mod; 415 unchg

[Cdiffs](src/share/classes/sun/reflect/annotation/AnnotationParser.java.cdiff.html) [Udiffs](src/share/classes/sun/reflect/annotation/AnnotationParser.java.udiff.html) [Sdiffs](src/share/classes/sun/reflect/annotation/AnnotationParser.java.sdiff.html) [Frames](src/share/classes/sun/reflect/annotation/AnnotationParser.java.frames.html) [Old](src/share/classes/sun/reflect/annotation/AnnotationParser.java-.html) [New](src/share/classes/sun/reflect/annotation/AnnotationParser.java.html) [Patch](src/share/classes/sun/reflect/annotation/AnnotationParser.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/reflect/annotation/AnnotationParser.java) src/share/classes/sun/reflect/annotation/AnnotationParser.java

2 lines changed: 0 ins; 0 del; 2 mod; 809 unchg

[Cdiffs](src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java.cdiff.html) [Udiffs](src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java.udiff.html) [Sdiffs](src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java.sdiff.html) [Frames](src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java.frames.html) [Old](src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java-.html) [New](src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java.html) [Patch](src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java) src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java

52 lines changed: 38 ins; 2 del; 12 mod; 212 unchg

[Cdiffs](src/share/javavm/export/jvm.h.cdiff.html) [Udiffs](src/share/javavm/export/jvm.h.udiff.html) [Sdiffs](src/share/javavm/export/jvm.h.sdiff.html) [Frames](src/share/javavm/export/jvm.h.frames.html) [Old](src/share/javavm/export/jvm.h-.html) [New](src/share/javavm/export/jvm.h.html) [Patch](src/share/javavm/export/jvm.h.patch) [Raw](raw%5Ffiles/new/src/share/javavm/export/jvm.h) src/share/javavm/export/jvm.h

7 lines changed: 6 ins; 0 del; 1 mod; 1486 unchg

[Cdiffs](src/share/native/java/lang/Class.c.cdiff.html) [Udiffs](src/share/native/java/lang/Class.c.udiff.html) [Sdiffs](src/share/native/java/lang/Class.c.sdiff.html) [Frames](src/share/native/java/lang/Class.c.frames.html) [Old](src/share/native/java/lang/Class.c-.html) [New](src/share/native/java/lang/Class.c.html) [Patch](src/share/native/java/lang/Class.c.patch) [Raw](raw%5Ffiles/new/src/share/native/java/lang/Class.c) src/share/native/java/lang/Class.c

3 lines changed: 1 ins; 0 del; 2 mod; 187 unchg

------ ------ ------ ------ ---[New](src/share/classes/java/lang/reflect/AnnotatedArrayType.java.html) [Patch](src/share/classes/java/lang/reflect/AnnotatedArrayType.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/AnnotatedArrayType.java) src/share/classes/java/lang/reflect/AnnotatedArrayType.java

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/java/lang/reflect/AnnotatedParameterizedType.java.html) [Patch](src/share/classes/java/lang/reflect/AnnotatedParameterizedType.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/AnnotatedParameterizedType.java) src/share/classes/java/lang/reflect/AnnotatedParameterizedType.java

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/java/lang/reflect/AnnotatedType.java.html) [Patch](src/share/classes/java/lang/reflect/AnnotatedType.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/AnnotatedType.java) src/share/classes/java/lang/reflect/AnnotatedType.java

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/java/lang/reflect/AnnotatedTypeVariable.java.html) [Patch](src/share/classes/java/lang/reflect/AnnotatedTypeVariable.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/AnnotatedTypeVariable.java) src/share/classes/java/lang/reflect/AnnotatedTypeVariable.java

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/java/lang/reflect/AnnotatedWildcardType.java.html) [Patch](src/share/classes/java/lang/reflect/AnnotatedWildcardType.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/reflect/AnnotatedWildcardType.java) src/share/classes/java/lang/reflect/AnnotatedWildcardType.java

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java.html) [Patch](src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java) src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java

291 lines changed: 291 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/sun/reflect/annotation/TypeAnnotation.java.html) [Patch](src/share/classes/sun/reflect/annotation/TypeAnnotation.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/reflect/annotation/TypeAnnotation.java) src/share/classes/sun/reflect/annotation/TypeAnnotation.java

225 lines changed: 225 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java.html) [Patch](src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java) src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java

473 lines changed: 473 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/lang/annotation/TypeAnnotationReflection.java.html) [Patch](test/java/lang/annotation/TypeAnnotationReflection.java.patch) [Raw](raw%5Ffiles/new/test/java/lang/annotation/TypeAnnotationReflection.java) test/java/lang/annotation/TypeAnnotationReflection.java

428 lines changed: 428 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/lang/annotation/TypeParamAnnotation.java.html) [Patch](test/java/lang/annotation/TypeParamAnnotation.java.patch) [Raw](raw%5Ffiles/new/test/java/lang/annotation/TypeParamAnnotation.java) test/java/lang/annotation/TypeParamAnnotation.java

120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/appeal/bin/webrev.sh(vers 23.18-hg).