jdk (original) (raw)
Code Review for jdk
| Prepared by: | jgish on Tue Jan 22 14:36:35 EST 2013 |
|---|---|
| Workspace: | /jdk/jdk8/tl/jdk |
| Compare against: | ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk |
| Compare against version: | 6405 |
| Summary of changes: | 58 lines changed: 15 ins; 40 del; 3 mod; 5685 unchg |
| Patch of changes: | <jdk.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/classes/java/lang/AbstractStringBuilder.java.cdiff.html) [Udiffs](src/share/classes/java/lang/AbstractStringBuilder.java.udiff.html) [Sdiffs](src/share/classes/java/lang/AbstractStringBuilder.java.sdiff.html) [Frames](src/share/classes/java/lang/AbstractStringBuilder.java.frames.html) [Old](src/share/classes/java/lang/AbstractStringBuilder.java-.html) [New](src/share/classes/java/lang/AbstractStringBuilder.java.html) [Patch](src/share/classes/java/lang/AbstractStringBuilder.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/AbstractStringBuilder.java) src/share/classes/java/lang/AbstractStringBuilder.java
rev 6406 : 4247235: (spec str) StringBuffer.insert(int, char[]) specification is inconsistent Summary: Add blanket null-handling statement to StringBuilder and StringBuffer Reviewed-by: mduigou
14 lines changed: 4 ins; 10 del; 0 mod; 1417 unchg
[Cdiffs](src/share/classes/java/lang/String.java.cdiff.html) [Udiffs](src/share/classes/java/lang/String.java.udiff.html) [Sdiffs](src/share/classes/java/lang/String.java.sdiff.html) [Frames](src/share/classes/java/lang/String.java.frames.html) [Old](src/share/classes/java/lang/String.java-.html) [New](src/share/classes/java/lang/String.java.html) [Patch](src/share/classes/java/lang/String.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/String.java) src/share/classes/java/lang/String.java
rev 6406 : 4247235: (spec str) StringBuffer.insert(int, char[]) specification is inconsistent Summary: Add blanket null-handling statement to StringBuilder and StringBuffer Reviewed-by: mduigou
14 lines changed: 3 ins; 9 del; 2 mod; 3162 unchg
[Cdiffs](src/share/classes/java/lang/StringBuffer.java.cdiff.html) [Udiffs](src/share/classes/java/lang/StringBuffer.java.udiff.html) [Sdiffs](src/share/classes/java/lang/StringBuffer.java.sdiff.html) [Frames](src/share/classes/java/lang/StringBuffer.java.frames.html) [Old](src/share/classes/java/lang/StringBuffer.java-.html) [New](src/share/classes/java/lang/StringBuffer.java.html) [Patch](src/share/classes/java/lang/StringBuffer.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/StringBuffer.java) src/share/classes/java/lang/StringBuffer.java
rev 6406 : 4247235: (spec str) StringBuffer.insert(int, char[]) specification is inconsistent Summary: Add blanket null-handling statement to StringBuilder and StringBuffer Reviewed-by: mduigou
12 lines changed: 4 ins; 7 del; 1 mod; 671 unchg
[Cdiffs](src/share/classes/java/lang/StringBuilder.java.cdiff.html) [Udiffs](src/share/classes/java/lang/StringBuilder.java.udiff.html) [Sdiffs](src/share/classes/java/lang/StringBuilder.java.sdiff.html) [Frames](src/share/classes/java/lang/StringBuilder.java.frames.html) [Old](src/share/classes/java/lang/StringBuilder.java-.html) [New](src/share/classes/java/lang/StringBuilder.java.html) [Patch](src/share/classes/java/lang/StringBuilder.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/StringBuilder.java) src/share/classes/java/lang/StringBuilder.java
rev 6406 : 4247235: (spec str) StringBuffer.insert(int, char[]) specification is inconsistent Summary: Add blanket null-handling statement to StringBuilder and StringBuffer Reviewed-by: mduigou
18 lines changed: 4 ins; 14 del; 0 mod; 435 unchg
This code review page was prepared using ../make/scripts/webrev.ksh(vers 23.18-hg).