jdk (original) (raw)

Code Review for jdk

Prepared by: jgish on Wed Oct 10 16:16:38 EDT 2012
Workspace: /jdk/jdk8/tl/jdk
Summary of changes: 1168 lines changed: 1099 ins; 34 del; 35 mod; 2391 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](./src/share/classes/java/lang/AbstractStringBuilder.java.cdiff.html) [Udiffs](./src/share/classes/java/lang/AbstractStringBuilder.java.udiff.html) [Sdiffs](./src/share/classes/java/lang/AbstractStringBuilder.java.sdiff.html) [Frames](./src/share/classes/java/lang/AbstractStringBuilder.java.frames.html) [Old](./src/share/classes/java/lang/AbstractStringBuilder.java-.html) [New](./src/share/classes/java/lang/AbstractStringBuilder.java.html) [Patch](./src/share/classes/java/lang/AbstractStringBuilder.java.patch) [Raw](raw%5Ffiles/new/./src/share/classes/java/lang/AbstractStringBuilder.java) ./src/share/classes/java/lang/AbstractStringBuilder.java

rev 5910 : 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder & StringBuffer to consistently handle forwarding to AbstractStringBuilder. Some additional cleanup (removal of refs to sub-classes from AbstractStringBuilder) Reviewed-by: chegar,alanb

23 lines changed: 21 ins; 0 del; 2 mod; 1407 unchg

[Cdiffs](./src/share/classes/java/lang/StringBuffer.java.cdiff.html) [Udiffs](./src/share/classes/java/lang/StringBuffer.java.udiff.html) [Sdiffs](./src/share/classes/java/lang/StringBuffer.java.sdiff.html) [Frames](./src/share/classes/java/lang/StringBuffer.java.frames.html) [Old](./src/share/classes/java/lang/StringBuffer.java-.html) [New](./src/share/classes/java/lang/StringBuffer.java.html) [Patch](./src/share/classes/java/lang/StringBuffer.java.patch) [Raw](raw%5Ffiles/new/./src/share/classes/java/lang/StringBuffer.java) ./src/share/classes/java/lang/StringBuffer.java

rev 5910 : 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder & StringBuffer to consistently handle forwarding to AbstractStringBuilder. Some additional cleanup (removal of refs to sub-classes from AbstractStringBuilder) Reviewed-by: chegar,alanb

100 lines changed: 73 ins; 8 del; 19 mod; 587 unchg

[Cdiffs](./src/share/classes/java/lang/StringBuilder.java.cdiff.html) [Udiffs](./src/share/classes/java/lang/StringBuilder.java.udiff.html) [Sdiffs](./src/share/classes/java/lang/StringBuilder.java.sdiff.html) [Frames](./src/share/classes/java/lang/StringBuilder.java.frames.html) [Old](./src/share/classes/java/lang/StringBuilder.java-.html) [New](./src/share/classes/java/lang/StringBuilder.java.html) [Patch](./src/share/classes/java/lang/StringBuilder.java.patch) [Raw](raw%5Ffiles/new/./src/share/classes/java/lang/StringBuilder.java) ./src/share/classes/java/lang/StringBuilder.java

rev 5910 : 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder & StringBuffer to consistently handle forwarding to AbstractStringBuilder. Some additional cleanup (removal of refs to sub-classes from AbstractStringBuilder) Reviewed-by: chegar,alanb

78 lines changed: 38 ins; 26 del; 14 mod; 397 unchg

------ ------ ------ ------ ---[New](./test/java/lang/StringBuffer/AppendStringBuilder.java.html) [Patch](./test/java/lang/StringBuffer/AppendStringBuilder.java.patch) [Raw](raw%5Ffiles/new/./test/java/lang/StringBuffer/AppendStringBuilder.java) ./test/java/lang/StringBuffer/AppendStringBuilder.java

rev 5910 : 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder & StringBuffer to consistently handle forwarding to AbstractStringBuilder. Some additional cleanup (removal of refs to sub-classes from AbstractStringBuilder) Reviewed-by: chegar,alanb

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](./test/java/lang/StringBuffer/BufferForwarding.java.html) [Patch](./test/java/lang/StringBuffer/BufferForwarding.java.patch) [Raw](raw%5Ffiles/new/./test/java/lang/StringBuffer/BufferForwarding.java) ./test/java/lang/StringBuffer/BufferForwarding.java

rev 5910 : 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder & StringBuffer to consistently handle forwarding to AbstractStringBuilder. Some additional cleanup (removal of refs to sub-classes from AbstractStringBuilder) Reviewed-by: chegar,alanb

242 lines changed: 242 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](./test/java/lang/StringBuffer/TestSynchronization.java.html) [Patch](./test/java/lang/StringBuffer/TestSynchronization.java.patch) [Raw](raw%5Ffiles/new/./test/java/lang/StringBuffer/TestSynchronization.java) ./test/java/lang/StringBuffer/TestSynchronization.java

rev 5910 : 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder & StringBuffer to consistently handle forwarding to AbstractStringBuilder. Some additional cleanup (removal of refs to sub-classes from AbstractStringBuilder) Reviewed-by: chegar,alanb

315 lines changed: 315 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](./test/java/lang/StringBuilder/AppendStringBuffer.java.html) [Patch](./test/java/lang/StringBuilder/AppendStringBuffer.java.patch) [Raw](raw%5Ffiles/new/./test/java/lang/StringBuilder/AppendStringBuffer.java) ./test/java/lang/StringBuilder/AppendStringBuffer.java

rev 5910 : 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder & StringBuffer to consistently handle forwarding to AbstractStringBuilder. Some additional cleanup (removal of refs to sub-classes from AbstractStringBuilder) Reviewed-by: chegar,alanb

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](./test/java/lang/StringBuilder/BuilderForwarding.java.html) [Patch](./test/java/lang/StringBuilder/BuilderForwarding.java.patch) [Raw](raw%5Ffiles/new/./test/java/lang/StringBuilder/BuilderForwarding.java) ./test/java/lang/StringBuilder/BuilderForwarding.java

rev 5910 : 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder & StringBuffer to consistently handle forwarding to AbstractStringBuilder. Some additional cleanup (removal of refs to sub-classes from AbstractStringBuilder) Reviewed-by: chegar,alanb

269 lines changed: 269 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using ../make/scripts/webrev.ksh(vers 23.18-hg).