jdk (original) (raw)

Code Review for jdk

Prepared by: jgish on Thu Oct 25 10:33:13 EDT 2012
Workspace: /jdk/jdk8/tl/jdk
Summary of changes: 324 lines changed: 241 ins; 3 del; 80 mod; 1409 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](./src/share/classes/java/util/logging/ConsoleHandler.java.cdiff.html) [Udiffs](./src/share/classes/java/util/logging/ConsoleHandler.java.udiff.html) [Sdiffs](./src/share/classes/java/util/logging/ConsoleHandler.java.sdiff.html) [Frames](./src/share/classes/java/util/logging/ConsoleHandler.java.frames.html) [Old](./src/share/classes/java/util/logging/ConsoleHandler.java-.html) [New](./src/share/classes/java/util/logging/ConsoleHandler.java.html) [Patch](./src/share/classes/java/util/logging/ConsoleHandler.java.patch) [Raw](raw%5Ffiles/new/./src/share/classes/java/util/logging/ConsoleHandler.java) ./src/share/classes/java/util/logging/ConsoleHandler.java

rev 5910 : 7159567: inconsistent configuration for MemoryHandler Summary: allow handler class name-specific target property to be set and clarify property naming Reviewed-by: mchung

25 lines changed: 14 ins; 1 del; 10 mod; 106 unchg

[Cdiffs](./src/share/classes/java/util/logging/FileHandler.java.cdiff.html) [Udiffs](./src/share/classes/java/util/logging/FileHandler.java.udiff.html) [Sdiffs](./src/share/classes/java/util/logging/FileHandler.java.sdiff.html) [Frames](./src/share/classes/java/util/logging/FileHandler.java.frames.html) [Old](./src/share/classes/java/util/logging/FileHandler.java-.html) [New](./src/share/classes/java/util/logging/FileHandler.java.html) [Patch](./src/share/classes/java/util/logging/FileHandler.java.patch) [Raw](raw%5Ffiles/new/./src/share/classes/java/util/logging/FileHandler.java) ./src/share/classes/java/util/logging/FileHandler.java

rev 5910 : 7159567: inconsistent configuration for MemoryHandler Summary: allow handler class name-specific target property to be set and clarify property naming Reviewed-by: mchung

37 lines changed: 13 ins; 0 del; 24 mod; 604 unchg

[Cdiffs](./src/share/classes/java/util/logging/MemoryHandler.java.cdiff.html) [Udiffs](./src/share/classes/java/util/logging/MemoryHandler.java.udiff.html) [Sdiffs](./src/share/classes/java/util/logging/MemoryHandler.java.sdiff.html) [Frames](./src/share/classes/java/util/logging/MemoryHandler.java.frames.html) [Old](./src/share/classes/java/util/logging/MemoryHandler.java-.html) [New](./src/share/classes/java/util/logging/MemoryHandler.java.html) [Patch](./src/share/classes/java/util/logging/MemoryHandler.java.patch) [Raw](raw%5Ffiles/new/./src/share/classes/java/util/logging/MemoryHandler.java) ./src/share/classes/java/util/logging/MemoryHandler.java

rev 5910 : 7159567: inconsistent configuration for MemoryHandler Summary: allow handler class name-specific target property to be set and clarify property naming Reviewed-by: mchung

44 lines changed: 21 ins; 2 del; 21 mod; 247 unchg

[Cdiffs](./src/share/classes/java/util/logging/SocketHandler.java.cdiff.html) [Udiffs](./src/share/classes/java/util/logging/SocketHandler.java.udiff.html) [Sdiffs](./src/share/classes/java/util/logging/SocketHandler.java.sdiff.html) [Frames](./src/share/classes/java/util/logging/SocketHandler.java.frames.html) [Old](./src/share/classes/java/util/logging/SocketHandler.java-.html) [New](./src/share/classes/java/util/logging/SocketHandler.java.html) [Patch](./src/share/classes/java/util/logging/SocketHandler.java.patch) [Raw](raw%5Ffiles/new/./src/share/classes/java/util/logging/SocketHandler.java) ./src/share/classes/java/util/logging/SocketHandler.java

rev 5910 : 7159567: inconsistent configuration for MemoryHandler Summary: allow handler class name-specific target property to be set and clarify property naming Reviewed-by: mchung

28 lines changed: 14 ins; 0 del; 14 mod; 177 unchg

[Cdiffs](./src/share/classes/java/util/logging/StreamHandler.java.cdiff.html) [Udiffs](./src/share/classes/java/util/logging/StreamHandler.java.udiff.html) [Sdiffs](./src/share/classes/java/util/logging/StreamHandler.java.sdiff.html) [Frames](./src/share/classes/java/util/logging/StreamHandler.java.frames.html) [Old](./src/share/classes/java/util/logging/StreamHandler.java-.html) [New](./src/share/classes/java/util/logging/StreamHandler.java.html) [Patch](./src/share/classes/java/util/logging/StreamHandler.java.patch) [Raw](raw%5Ffiles/new/./src/share/classes/java/util/logging/StreamHandler.java) ./src/share/classes/java/util/logging/StreamHandler.java

rev 5910 : 7159567: inconsistent configuration for MemoryHandler Summary: allow handler class name-specific target property to be set and clarify property naming Reviewed-by: mchung

25 lines changed: 14 ins; 0 del; 11 mod; 275 unchg

------ ------ ------ ------ ---[New](./test/java/util/logging/MemoryHandlerTest.java.html) [Patch](./test/java/util/logging/MemoryHandlerTest.java.patch) [Raw](raw%5Ffiles/new/./test/java/util/logging/MemoryHandlerTest.java) ./test/java/util/logging/MemoryHandlerTest.java

156 lines changed: 156 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](./test/java/util/logging/MemoryHandlerTest.props.html) [Patch](./test/java/util/logging/MemoryHandlerTest.props.patch) [Raw](raw%5Ffiles/new/./test/java/util/logging/MemoryHandlerTest.props) ./test/java/util/logging/MemoryHandlerTest.props

rev 5910 : 7159567: inconsistent configuration for MemoryHandler Summary: allow handler class name-specific target property to be set and clarify property naming Reviewed-by: mchung

9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using ../make/scripts/webrev.ksh(vers 23.18-hg).