jdk (original) (raw)
Code Review for jdk
| Prepared by: | jgish on Wed Nov 28 13:48:20 EST 2012 |
|---|---|
| Workspace: | /jdk/jdk8/tl/jdk |
| Compare against: | ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk |
| Compare against version: | 6098 |
| Summary of changes: | 60 lines changed: 27 ins; 7 del; 26 mod; 1926 unchg |
| Patch of changes: | <jdk.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](test/java/util/logging/ClassLoaderLeakTest.java.cdiff.html) [Udiffs](test/java/util/logging/ClassLoaderLeakTest.java.udiff.html) [Sdiffs](test/java/util/logging/ClassLoaderLeakTest.java.sdiff.html) [Frames](test/java/util/logging/ClassLoaderLeakTest.java.frames.html) [Old](test/java/util/logging/ClassLoaderLeakTest.java-.html) [New](test/java/util/logging/ClassLoaderLeakTest.java.html) [Patch](test/java/util/logging/ClassLoaderLeakTest.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/ClassLoaderLeakTest.java) test/java/util/logging/ClassLoaderLeakTest.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
7 lines changed: 0 ins; 2 del; 5 mod; 183 unchg
[Cdiffs](test/java/util/logging/Listeners.java.cdiff.html) [Udiffs](test/java/util/logging/Listeners.java.udiff.html) [Sdiffs](test/java/util/logging/Listeners.java.sdiff.html) [Frames](test/java/util/logging/Listeners.java.frames.html) [Old](test/java/util/logging/Listeners.java-.html) [New](test/java/util/logging/Listeners.java.html) [Patch](test/java/util/logging/Listeners.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/Listeners.java) test/java/util/logging/Listeners.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
1 line changed: 1 ins; 0 del; 0 mod; 134 unchg
[Cdiffs](test/java/util/logging/ListenersWithSM.java.cdiff.html) [Udiffs](test/java/util/logging/ListenersWithSM.java.udiff.html) [Sdiffs](test/java/util/logging/ListenersWithSM.java.sdiff.html) [Frames](test/java/util/logging/ListenersWithSM.java.frames.html) [Old](test/java/util/logging/ListenersWithSM.java-.html) [New](test/java/util/logging/ListenersWithSM.java.html) [Patch](test/java/util/logging/ListenersWithSM.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/ListenersWithSM.java) test/java/util/logging/ListenersWithSM.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
1 line changed: 1 ins; 0 del; 0 mod; 76 unchg
[Cdiffs](test/java/util/logging/LoggerResourceBundleRace.java.cdiff.html) [Udiffs](test/java/util/logging/LoggerResourceBundleRace.java.udiff.html) [Sdiffs](test/java/util/logging/LoggerResourceBundleRace.java.sdiff.html) [Frames](test/java/util/logging/LoggerResourceBundleRace.java.frames.html) [Old](test/java/util/logging/LoggerResourceBundleRace.java-.html) [New](test/java/util/logging/LoggerResourceBundleRace.java.html) [Patch](test/java/util/logging/LoggerResourceBundleRace.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/LoggerResourceBundleRace.java) test/java/util/logging/LoggerResourceBundleRace.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
5 lines changed: 1 ins; 2 del; 2 mod; 199 unchg
[Cdiffs](test/java/util/logging/LoggingDeadlock2.java.cdiff.html) [Udiffs](test/java/util/logging/LoggingDeadlock2.java.udiff.html) [Sdiffs](test/java/util/logging/LoggingDeadlock2.java.sdiff.html) [Frames](test/java/util/logging/LoggingDeadlock2.java.frames.html) [Old](test/java/util/logging/LoggingDeadlock2.java-.html) [New](test/java/util/logging/LoggingDeadlock2.java.html) [Patch](test/java/util/logging/LoggingDeadlock2.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/LoggingDeadlock2.java) test/java/util/logging/LoggingDeadlock2.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
3 lines changed: 0 ins; 1 del; 2 mod; 237 unchg
[Cdiffs](test/java/util/logging/LoggingDeadlock3.java.cdiff.html) [Udiffs](test/java/util/logging/LoggingDeadlock3.java.udiff.html) [Sdiffs](test/java/util/logging/LoggingDeadlock3.java.sdiff.html) [Frames](test/java/util/logging/LoggingDeadlock3.java.frames.html) [Old](test/java/util/logging/LoggingDeadlock3.java-.html) [New](test/java/util/logging/LoggingDeadlock3.java.html) [Patch](test/java/util/logging/LoggingDeadlock3.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/LoggingDeadlock3.java) test/java/util/logging/LoggingDeadlock3.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
2 lines changed: 0 ins; 0 del; 2 mod; 79 unchg
[Cdiffs](test/java/util/logging/LoggingDeadlock4.java.cdiff.html) [Udiffs](test/java/util/logging/LoggingDeadlock4.java.udiff.html) [Sdiffs](test/java/util/logging/LoggingDeadlock4.java.sdiff.html) [Frames](test/java/util/logging/LoggingDeadlock4.java.frames.html) [Old](test/java/util/logging/LoggingDeadlock4.java-.html) [New](test/java/util/logging/LoggingDeadlock4.java.html) [Patch](test/java/util/logging/LoggingDeadlock4.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/LoggingDeadlock4.java) test/java/util/logging/LoggingDeadlock4.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
3 lines changed: 0 ins; 1 del; 2 mod; 108 unchg
[Cdiffs](test/java/util/logging/LoggingMXBeanTest.java.cdiff.html) [Udiffs](test/java/util/logging/LoggingMXBeanTest.java.udiff.html) [Sdiffs](test/java/util/logging/LoggingMXBeanTest.java.sdiff.html) [Frames](test/java/util/logging/LoggingMXBeanTest.java.frames.html) [Old](test/java/util/logging/LoggingMXBeanTest.java-.html) [New](test/java/util/logging/LoggingMXBeanTest.java.html) [Patch](test/java/util/logging/LoggingMXBeanTest.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/LoggingMXBeanTest.java) test/java/util/logging/LoggingMXBeanTest.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
3 lines changed: 0 ins; 0 del; 3 mod; 249 unchg
[Cdiffs](test/java/util/logging/LoggingMXBeanTest2.java.cdiff.html) [Udiffs](test/java/util/logging/LoggingMXBeanTest2.java.udiff.html) [Sdiffs](test/java/util/logging/LoggingMXBeanTest2.java.sdiff.html) [Frames](test/java/util/logging/LoggingMXBeanTest2.java.frames.html) [Old](test/java/util/logging/LoggingMXBeanTest2.java-.html) [New](test/java/util/logging/LoggingMXBeanTest2.java.html) [Patch](test/java/util/logging/LoggingMXBeanTest2.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/LoggingMXBeanTest2.java) test/java/util/logging/LoggingMXBeanTest2.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
5 lines changed: 0 ins; 1 del; 4 mod; 187 unchg
[Cdiffs](test/java/util/logging/MemoryHandlerTest.java.cdiff.html) [Udiffs](test/java/util/logging/MemoryHandlerTest.java.udiff.html) [Sdiffs](test/java/util/logging/MemoryHandlerTest.java.sdiff.html) [Frames](test/java/util/logging/MemoryHandlerTest.java.frames.html) [Old](test/java/util/logging/MemoryHandlerTest.java-.html) [New](test/java/util/logging/MemoryHandlerTest.java.html) [Patch](test/java/util/logging/MemoryHandlerTest.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/MemoryHandlerTest.java) test/java/util/logging/MemoryHandlerTest.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
1 line changed: 0 ins; 0 del; 1 mod; 155 unchg
[Cdiffs](test/java/util/logging/ParentLoggersTest.java.cdiff.html) [Udiffs](test/java/util/logging/ParentLoggersTest.java.udiff.html) [Sdiffs](test/java/util/logging/ParentLoggersTest.java.sdiff.html) [Frames](test/java/util/logging/ParentLoggersTest.java.frames.html) [Old](test/java/util/logging/ParentLoggersTest.java-.html) [New](test/java/util/logging/ParentLoggersTest.java.html) [Patch](test/java/util/logging/ParentLoggersTest.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/ParentLoggersTest.java) test/java/util/logging/ParentLoggersTest.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
25 lines changed: 23 ins; 0 del; 2 mod; 163 unchg
[Cdiffs](test/java/util/logging/SimpleFormatterFormat.java.cdiff.html) [Udiffs](test/java/util/logging/SimpleFormatterFormat.java.udiff.html) [Sdiffs](test/java/util/logging/SimpleFormatterFormat.java.sdiff.html) [Frames](test/java/util/logging/SimpleFormatterFormat.java.frames.html) [Old](test/java/util/logging/SimpleFormatterFormat.java-.html) [New](test/java/util/logging/SimpleFormatterFormat.java.html) [Patch](test/java/util/logging/SimpleFormatterFormat.java.patch) [Raw](raw%5Ffiles/new/test/java/util/logging/SimpleFormatterFormat.java) test/java/util/logging/SimpleFormatterFormat.java
rev 6099 : 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar
4 lines changed: 1 ins; 0 del; 3 mod; 156 unchg
This code review page was prepared using ../make/scripts/webrev.ksh(vers 23.18-hg).