jdk (original) (raw)

Code Review for jdk

Prepared by: jgish on Tue Apr 30 12:42:18 EDT 2013
Workspace: /jdk/jdk8/tl/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk
Compare against version: 7021
Summary of changes: 346 lines changed: 297 ins; 16 del; 33 mod; 3752 unchg
Changeset: <jdk.changeset>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/java/util/logging/LogManager.java.cdiff.html) [Udiffs](src/share/classes/java/util/logging/LogManager.java.udiff.html) [Sdiffs](src/share/classes/java/util/logging/LogManager.java.sdiff.html) [Frames](src/share/classes/java/util/logging/LogManager.java.frames.html) [Old](src/share/classes/java/util/logging/LogManager.java-.html) [New](src/share/classes/java/util/logging/LogManager.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/logging/LogManager.java) src/share/classes/java/util/logging/LogManager.java

rev 7022 : 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: duke

5 lines changed: 2 ins; 0 del; 3 mod; 1553 unchg

[Cdiffs](src/share/classes/java/util/logging/Logger.java.cdiff.html) [Udiffs](src/share/classes/java/util/logging/Logger.java.udiff.html) [Sdiffs](src/share/classes/java/util/logging/Logger.java.sdiff.html) [Frames](src/share/classes/java/util/logging/Logger.java.frames.html) [Old](src/share/classes/java/util/logging/Logger.java-.html) [New](src/share/classes/java/util/logging/Logger.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/logging/Logger.java) src/share/classes/java/util/logging/Logger.java

rev 7022 : 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: duke

49 lines changed: 38 ins; 0 del; 11 mod; 1829 unchg

[Cdiffs](test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java.cdiff.html) [Udiffs](test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java.udiff.html) [Sdiffs](test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java.sdiff.html) [Frames](test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java.frames.html) [Old](test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java-.html) [New](test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java) test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java

rev 7022 : 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: duke

5 lines changed: 0 ins; 1 del; 4 mod; 87 unchg

[Cdiffs](test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java.cdiff.html) [Udiffs](test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java.udiff.html) [Sdiffs](test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java.sdiff.html) [Frames](test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java.frames.html) [Old](test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java-.html) [New](test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java) test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java

rev 7022 : 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: duke

37 lines changed: 18 ins; 7 del; 12 mod; 232 unchg

[Cdiffs](test/java/util/logging/bundlesearch/LoadItUp1.java.cdiff.html) [Udiffs](test/java/util/logging/bundlesearch/LoadItUp1.java.udiff.html) [Sdiffs](test/java/util/logging/bundlesearch/LoadItUp1.java.sdiff.html) [Frames](test/java/util/logging/bundlesearch/LoadItUp1.java.frames.html) [Old](test/java/util/logging/bundlesearch/LoadItUp1.java-.html) [New](test/java/util/logging/bundlesearch/LoadItUp1.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/logging/bundlesearch/LoadItUp1.java) test/java/util/logging/bundlesearch/LoadItUp1.java (was test/java/util/logging/bundlesearch/LoadItUp.java)

rev 7022 : 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: duke

12 lines changed: 1 ins; 8 del; 3 mod; 51 unchg

------ ------ ------ ------ ---[New](test/java/util/logging/bundlesearch/LoadItUp2.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/logging/bundlesearch/LoadItUp2.java) test/java/util/logging/bundlesearch/LoadItUp2.java

rev 7022 : 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: duke

62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/logging/bundlesearch/LoadItUp2Invoker.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/logging/bundlesearch/LoadItUp2Invoker.java) test/java/util/logging/bundlesearch/LoadItUp2Invoker.java

rev 7022 : 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: duke

60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/logging/bundlesearch/TwiceIndirectlyLoadABundle.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/logging/bundlesearch/TwiceIndirectlyLoadABundle.java) test/java/util/logging/bundlesearch/TwiceIndirectlyLoadABundle.java

rev 7022 : 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: duke

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/java/util/logging/bundlesearch/resources/CallerSearchableResource%5Fen.properties.html) -----[Raw](raw%5Ffiles/new/test/java/util/logging/bundlesearch/resources/CallerSearchableResource%5Fen.properties) test/java/util/logging/bundlesearch/resources/CallerSearchableResource_en.properties

rev 7022 : 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: duke

25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /jdk/jdk8/tl/make/scripts/webrev.ksh(vers 24.0-hg+jbs).