open (original) (raw)

Code Review for open

[Cdiffs](src/java.base/share/classes/java/io/ByteArrayOutputStream.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/io/ByteArrayOutputStream.java.udiff.html) [Wdiffs](src/java.base/share/classes/java/io/ByteArrayOutputStream.java.wdiff.html) [Sdiffs](src/java.base/share/classes/java/io/ByteArrayOutputStream.java.sdiff.html) [Frames](src/java.base/share/classes/java/io/ByteArrayOutputStream.java.frames.html) [Old](src/java.base/share/classes/java/io/ByteArrayOutputStream.java-.html) [New](src/java.base/share/classes/java/io/ByteArrayOutputStream.java.html) [Patch](src/java.base/share/classes/java/io/ByteArrayOutputStream.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/io/ByteArrayOutputStream.java) src/java.base/share/classes/java/io/ByteArrayOutputStream.java

50 lines changed: 39 ins; 4 del; 7 mod; 272 unchg

[Cdiffs](src/java.base/share/classes/java/io/PrintStream.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/io/PrintStream.java.udiff.html) [Wdiffs](src/java.base/share/classes/java/io/PrintStream.java.wdiff.html) [Sdiffs](src/java.base/share/classes/java/io/PrintStream.java.sdiff.html) [Frames](src/java.base/share/classes/java/io/PrintStream.java.frames.html) [Old](src/java.base/share/classes/java/io/PrintStream.java-.html) [New](src/java.base/share/classes/java/io/PrintStream.java.html) [Patch](src/java.base/share/classes/java/io/PrintStream.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/io/PrintStream.java) src/java.base/share/classes/java/io/PrintStream.java

104 lines changed: 88 ins; 9 del; 7 mod; 1118 unchg

[Cdiffs](src/java.base/share/classes/java/io/PrintWriter.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/io/PrintWriter.java.udiff.html) [Wdiffs](src/java.base/share/classes/java/io/PrintWriter.java.wdiff.html) [Sdiffs](src/java.base/share/classes/java/io/PrintWriter.java.sdiff.html) [Frames](src/java.base/share/classes/java/io/PrintWriter.java.frames.html) [Old](src/java.base/share/classes/java/io/PrintWriter.java-.html) [New](src/java.base/share/classes/java/io/PrintWriter.java.html) [Patch](src/java.base/share/classes/java/io/PrintWriter.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/io/PrintWriter.java) src/java.base/share/classes/java/io/PrintWriter.java

86 lines changed: 84 ins; 0 del; 2 mod; 1067 unchg

[Cdiffs](src/java.base/share/classes/java/net/URLDecoder.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/net/URLDecoder.java.udiff.html) [Wdiffs](src/java.base/share/classes/java/net/URLDecoder.java.wdiff.html) [Sdiffs](src/java.base/share/classes/java/net/URLDecoder.java.sdiff.html) [Frames](src/java.base/share/classes/java/net/URLDecoder.java.frames.html) [Old](src/java.base/share/classes/java/net/URLDecoder.java-.html) [New](src/java.base/share/classes/java/net/URLDecoder.java.html) [Patch](src/java.base/share/classes/java/net/URLDecoder.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/net/URLDecoder.java) src/java.base/share/classes/java/net/URLDecoder.java

62 lines changed: 44 ins; 6 del; 12 mod; 189 unchg

[Cdiffs](src/java.base/share/classes/java/net/URLEncoder.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/net/URLEncoder.java.udiff.html) [Wdiffs](src/java.base/share/classes/java/net/URLEncoder.java.wdiff.html) [Sdiffs](src/java.base/share/classes/java/net/URLEncoder.java.sdiff.html) [Frames](src/java.base/share/classes/java/net/URLEncoder.java.frames.html) [Old](src/java.base/share/classes/java/net/URLEncoder.java-.html) [New](src/java.base/share/classes/java/net/URLEncoder.java.html) [Patch](src/java.base/share/classes/java/net/URLEncoder.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/net/URLEncoder.java) src/java.base/share/classes/java/net/URLEncoder.java

49 lines changed: 28 ins; 11 del; 10 mod; 262 unchg

[Cdiffs](src/java.base/share/classes/java/nio/channels/Channels.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/nio/channels/Channels.java.udiff.html) [Wdiffs](src/java.base/share/classes/java/nio/channels/Channels.java.wdiff.html) [Sdiffs](src/java.base/share/classes/java/nio/channels/Channels.java.sdiff.html) [Frames](src/java.base/share/classes/java/nio/channels/Channels.java.frames.html) [Old](src/java.base/share/classes/java/nio/channels/Channels.java-.html) [New](src/java.base/share/classes/java/nio/channels/Channels.java.html) [Patch](src/java.base/share/classes/java/nio/channels/Channels.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/nio/channels/Channels.java) src/java.base/share/classes/java/nio/channels/Channels.java

68 lines changed: 66 ins; 0 del; 2 mod; 617 unchg

[Cdiffs](src/java.base/share/classes/java/util/Formatter.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/Formatter.java.udiff.html) [Wdiffs](src/java.base/share/classes/java/util/Formatter.java.wdiff.html) [Sdiffs](src/java.base/share/classes/java/util/Formatter.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/Formatter.java.frames.html) [Old](src/java.base/share/classes/java/util/Formatter.java-.html) [New](src/java.base/share/classes/java/util/Formatter.java.html) [Patch](src/java.base/share/classes/java/util/Formatter.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/Formatter.java) src/java.base/share/classes/java/util/Formatter.java

90 lines changed: 90 ins; 0 del; 0 mod; 4740 unchg

[Cdiffs](src/java.base/share/classes/java/util/Properties.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/Properties.java.udiff.html) [Wdiffs](src/java.base/share/classes/java/util/Properties.java.wdiff.html) [Sdiffs](src/java.base/share/classes/java/util/Properties.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/Properties.java.frames.html) [Old](src/java.base/share/classes/java/util/Properties.java-.html) [New](src/java.base/share/classes/java/util/Properties.java.html) [Patch](src/java.base/share/classes/java/util/Properties.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/Properties.java) src/java.base/share/classes/java/util/Properties.java

63 lines changed: 58 ins; 2 del; 3 mod; 1488 unchg

[Cdiffs](src/java.base/share/classes/java/util/Scanner.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/Scanner.java.udiff.html) [Wdiffs](src/java.base/share/classes/java/util/Scanner.java.wdiff.html) [Sdiffs](src/java.base/share/classes/java/util/Scanner.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/Scanner.java.frames.html) [Old](src/java.base/share/classes/java/util/Scanner.java-.html) [New](src/java.base/share/classes/java/util/Scanner.java.html) [Patch](src/java.base/share/classes/java/util/Scanner.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/Scanner.java) src/java.base/share/classes/java/util/Scanner.java

79 lines changed: 76 ins; 0 del; 3 mod; 2953 unchg

[Cdiffs](src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.udiff.html) [Wdiffs](src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.wdiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java-.html) [New](src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.html) [Patch](src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java) src/java.base/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java

4 lines changed: 1 ins; 0 del; 3 mod; 235 unchg

[Cdiffs](src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java.udiff.html) [Wdiffs](src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java.wdiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java-.html) [New](src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java.html) [Patch](src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java) src/java.base/share/classes/jdk/internal/util/xml/XMLStreamWriter.java

5 lines changed: 4 ins; 0 del; 1 mod; 153 unchg

[Cdiffs](src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java.udiff.html) [Wdiffs](src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java.wdiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java-.html) [New](src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java.html) [Patch](src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java) src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java

28 lines changed: 14 ins; 3 del; 11 mod; 619 unchg

[Cdiffs](test/jdk/java/io/PrintStream/FailingConstructors.java.cdiff.html) [Udiffs](test/jdk/java/io/PrintStream/FailingConstructors.java.udiff.html) [Wdiffs](test/jdk/java/io/PrintStream/FailingConstructors.java.wdiff.html) [Sdiffs](test/jdk/java/io/PrintStream/FailingConstructors.java.sdiff.html) [Frames](test/jdk/java/io/PrintStream/FailingConstructors.java.frames.html) [Old](test/jdk/java/io/PrintStream/FailingConstructors.java-.html) [New](test/jdk/java/io/PrintStream/FailingConstructors.java.html) [Patch](test/jdk/java/io/PrintStream/FailingConstructors.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/io/PrintStream/FailingConstructors.java) test/jdk/java/io/PrintStream/FailingConstructors.java

4 lines changed: 0 ins; 0 del; 4 mod; 130 unchg

[Cdiffs](test/jdk/java/io/PrintWriter/FailingConstructors.java.cdiff.html) [Udiffs](test/jdk/java/io/PrintWriter/FailingConstructors.java.udiff.html) [Wdiffs](test/jdk/java/io/PrintWriter/FailingConstructors.java.wdiff.html) [Sdiffs](test/jdk/java/io/PrintWriter/FailingConstructors.java.sdiff.html) [Frames](test/jdk/java/io/PrintWriter/FailingConstructors.java.frames.html) [Old](test/jdk/java/io/PrintWriter/FailingConstructors.java-.html) [New](test/jdk/java/io/PrintWriter/FailingConstructors.java.html) [Patch](test/jdk/java/io/PrintWriter/FailingConstructors.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/io/PrintWriter/FailingConstructors.java) test/jdk/java/io/PrintWriter/FailingConstructors.java

2 lines changed: 0 ins; 0 del; 2 mod; 131 unchg

[Cdiffs](test/jdk/java/net/URLDecoder/URLDecoderArgs.java.cdiff.html) [Udiffs](test/jdk/java/net/URLDecoder/URLDecoderArgs.java.udiff.html) [Wdiffs](test/jdk/java/net/URLDecoder/URLDecoderArgs.java.wdiff.html) [Sdiffs](test/jdk/java/net/URLDecoder/URLDecoderArgs.java.sdiff.html) [Frames](test/jdk/java/net/URLDecoder/URLDecoderArgs.java.frames.html) [Old](test/jdk/java/net/URLDecoder/URLDecoderArgs.java-.html) [New](test/jdk/java/net/URLDecoder/URLDecoderArgs.java.html) [Patch](test/jdk/java/net/URLDecoder/URLDecoderArgs.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/net/URLDecoder/URLDecoderArgs.java) test/jdk/java/net/URLDecoder/URLDecoderArgs.java

3 lines changed: 0 ins; 0 del; 3 mod; 45 unchg

[Cdiffs](test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java.cdiff.html) [Udiffs](test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java.udiff.html) [Wdiffs](test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java.wdiff.html) [Sdiffs](test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java.sdiff.html) [Frames](test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java.frames.html) [Old](test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java-.html) [New](test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java.html) [Patch](test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java) test/jdk/java/net/URLEncoder/URLEncoderEncodeArgs.java

1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

[Cdiffs](test/jdk/java/nio/channels/Channels/Basic.java.cdiff.html) [Udiffs](test/jdk/java/nio/channels/Channels/Basic.java.udiff.html) [Wdiffs](test/jdk/java/nio/channels/Channels/Basic.java.wdiff.html) [Sdiffs](test/jdk/java/nio/channels/Channels/Basic.java.sdiff.html) [Frames](test/jdk/java/nio/channels/Channels/Basic.java.frames.html) [Old](test/jdk/java/nio/channels/Channels/Basic.java-.html) [New](test/jdk/java/nio/channels/Channels/Basic.java.html) [Patch](test/jdk/java/nio/channels/Channels/Basic.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/nio/channels/Channels/Basic.java) test/jdk/java/nio/channels/Channels/Basic.java

24 lines changed: 20 ins; 0 del; 4 mod; 390 unchg

[Cdiffs](test/jdk/java/util/Formatter/Constructors.java.cdiff.html) [Udiffs](test/jdk/java/util/Formatter/Constructors.java.udiff.html) [Wdiffs](test/jdk/java/util/Formatter/Constructors.java.wdiff.html) [Sdiffs](test/jdk/java/util/Formatter/Constructors.java.sdiff.html) [Frames](test/jdk/java/util/Formatter/Constructors.java.frames.html) [Old](test/jdk/java/util/Formatter/Constructors.java-.html) [New](test/jdk/java/util/Formatter/Constructors.java.html) [Patch](test/jdk/java/util/Formatter/Constructors.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/util/Formatter/Constructors.java) test/jdk/java/util/Formatter/Constructors.java

66 lines changed: 51 ins; 0 del; 15 mod; 491 unchg

[Cdiffs](test/jdk/java/util/Scanner/FailingConstructors.java.cdiff.html) [Udiffs](test/jdk/java/util/Scanner/FailingConstructors.java.udiff.html) [Wdiffs](test/jdk/java/util/Scanner/FailingConstructors.java.wdiff.html) [Sdiffs](test/jdk/java/util/Scanner/FailingConstructors.java.sdiff.html) [Frames](test/jdk/java/util/Scanner/FailingConstructors.java.frames.html) [Old](test/jdk/java/util/Scanner/FailingConstructors.java-.html) [New](test/jdk/java/util/Scanner/FailingConstructors.java.html) [Patch](test/jdk/java/util/Scanner/FailingConstructors.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/util/Scanner/FailingConstructors.java) test/jdk/java/util/Scanner/FailingConstructors.java

19 lines changed: 15 ins; 0 del; 4 mod; 127 unchg

------ ------ ------ ------ ------ ---[New](test/jdk/java/io/ByteArrayOutputStream/EncodingTest.java.html) [Patch](test/jdk/java/io/ByteArrayOutputStream/EncodingTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/io/ByteArrayOutputStream/EncodingTest.java) test/jdk/java/io/ByteArrayOutputStream/EncodingTest.java

84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/jdk/java/io/PrintStream/EncodingTest.java.html) [Patch](test/jdk/java/io/PrintStream/EncodingTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/io/PrintStream/EncodingTest.java) test/jdk/java/io/PrintStream/EncodingTest.java

134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/jdk/java/io/PrintWriter/EncodingTest.java.html) [Patch](test/jdk/java/io/PrintWriter/EncodingTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/io/PrintWriter/EncodingTest.java) test/jdk/java/io/PrintWriter/EncodingTest.java

135 lines changed: 135 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/jdk/java/net/URLDecoder/EncodingTest.java.html) [Patch](test/jdk/java/net/URLDecoder/EncodingTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/net/URLDecoder/EncodingTest.java) test/jdk/java/net/URLDecoder/EncodingTest.java

122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/jdk/java/net/URLEncoder/EncodingTest.java.html) [Patch](test/jdk/java/net/URLEncoder/EncodingTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/net/URLEncoder/EncodingTest.java) test/jdk/java/net/URLEncoder/EncodingTest.java

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/jdk/java/nio/channels/Channels/EncodingTest.java.html) [Patch](test/jdk/java/nio/channels/Channels/EncodingTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/nio/channels/Channels/EncodingTest.java) test/jdk/java/nio/channels/Channels/EncodingTest.java

266 lines changed: 266 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/jdk/java/util/Formatter/EncodingTest.java.html) [Patch](test/jdk/java/util/Formatter/EncodingTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/util/Formatter/EncodingTest.java) test/jdk/java/util/Formatter/EncodingTest.java

133 lines changed: 133 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/jdk/java/util/Properties/EncodingTest.java.html) [Patch](test/jdk/java/util/Properties/EncodingTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/util/Properties/EncodingTest.java) test/jdk/java/util/Properties/EncodingTest.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/jdk/java/util/Scanner/EncodingTest.java.html) [Patch](test/jdk/java/util/Scanner/EncodingTest.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/util/Scanner/EncodingTest.java) test/jdk/java/util/Scanner/EncodingTest.java

135 lines changed: 135 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/w/huizwang/java/jdk/bin/webrev.ksh(vers 25.16-hg+openjdk.java.net).