open (original) (raw)

Code Review for open

Prepared by: joehw on Thu Nov 30 22:14:45 PST 2017
Workspace: /jaxp/openjdk/jdk/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Summary of changes: 28 lines changed: 16 ins; 1 del; 11 mod; 2246 unchg
Patch of changes: <open.patch>
Legend: Modified file Deleted file New file

[Cdiffs](make/CompileJavaModules.gmk.cdiff.html) [Udiffs](make/CompileJavaModules.gmk.udiff.html) [Sdiffs](make/CompileJavaModules.gmk.sdiff.html) [Frames](make/CompileJavaModules.gmk.frames.html) [Old](make/CompileJavaModules.gmk-.html) [New](make/CompileJavaModules.gmk.html) [Patch](make/CompileJavaModules.gmk.patch) [Raw](raw%5Ffiles/new/make/CompileJavaModules.gmk) make/CompileJavaModules.gmk

3 lines changed: 2 ins; 0 del; 1 mod; 702 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java.udiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java) src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java

2 lines changed: 1 ins; 0 del; 1 mod; 125 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java.udiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java) src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java

2 lines changed: 1 ins; 0 del; 1 mod; 126 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java.udiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java) src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java

2 lines changed: 1 ins; 0 del; 1 mod; 85 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java.udiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java) src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java

2 lines changed: 1 ins; 0 del; 1 mod; 87 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEDYNAMIC.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEDYNAMIC.java.udiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEDYNAMIC.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEDYNAMIC.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEDYNAMIC.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEDYNAMIC.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEDYNAMIC.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEDYNAMIC.java) src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEDYNAMIC.java

9 lines changed: 7 ins; 1 del; 1 mod; 132 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java.udiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java) src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java

2 lines changed: 1 ins; 0 del; 1 mod; 746 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java.udiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java) src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java

3 lines changed: 1 ins; 0 del; 2 mod; 158 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2%5FW.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2%5FW.java.udiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2%5FW.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2%5FW.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2%5FW.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2%5FW.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2%5FW.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2%5FW.java) src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2_W.java

3 lines changed: 1 ins; 0 del; 2 mod; 85 unchg


This code review page was prepared using /java/webrev/webrev.ksh(vers 25.16-hg+openjdk.java.net).