jaxp (original) (raw)

Code Review for jaxp

Prepared by: joehw on Wed Sep 30 14:27:45 PDT 2015
Workspace: /scratch/w/huizwang/openjdk/9-dev/jaxp
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jaxp
Summary of changes: 919 lines changed: 581 ins; 141 del; 197 mod; 10619 unchg
Patch of changes: <jaxp.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java

19 lines changed: 18 ins; 0 del; 1 mod; 1098 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java

41 lines changed: 32 ins; 2 del; 7 mod; 3323 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java

18 lines changed: 11 ins; 1 del; 6 mod; 736 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java

25 lines changed: 17 ins; 1 del; 7 mod; 577 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java

15 lines changed: 14 ins; 0 del; 1 mod; 1596 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java

233 lines changed: 84 ins; 67 del; 82 mod; 1185 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java

225 lines changed: 84 ins; 67 del; 74 mod; 1088 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java

25 lines changed: 18 ins; 1 del; 6 mod; 147 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java

24 lines changed: 17 ins; 1 del; 6 mod; 68 unchg

[Cdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java.cdiff.html) [Udiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java.udiff.html) [Wdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java.sdiff.html) [Frames](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java.frames.html) [Old](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java-.html) [New](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java.html) [Patch](src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java) src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java

24 lines changed: 17 ins; 1 del; 6 mod; 246 unchg

[Cdiffs](src/java.xml/share/classes/javax/xml/parsers/SAXParser.java.cdiff.html) [Udiffs](src/java.xml/share/classes/javax/xml/parsers/SAXParser.java.udiff.html) [Wdiffs](src/java.xml/share/classes/javax/xml/parsers/SAXParser.java.wdiff.html) [Sdiffs](src/java.xml/share/classes/javax/xml/parsers/SAXParser.java.sdiff.html) [Frames](src/java.xml/share/classes/javax/xml/parsers/SAXParser.java.frames.html) [Old](src/java.xml/share/classes/javax/xml/parsers/SAXParser.java-.html) [New](src/java.xml/share/classes/javax/xml/parsers/SAXParser.java.html) [Patch](src/java.xml/share/classes/javax/xml/parsers/SAXParser.java.patch) [Raw](raw%5Ffiles/new/src/java.xml/share/classes/javax/xml/parsers/SAXParser.java) src/java.xml/share/classes/javax/xml/parsers/SAXParser.java

50 lines changed: 49 ins; 0 del; 1 mod; 555 unchg

------ ------ ------ ------ ------ ---[New](test/javax/xml/jaxp/unittest/parsers/SaxParserStop.java.html) [Patch](test/javax/xml/jaxp/unittest/parsers/SaxParserStop.java.patch) [Raw](raw%5Ffiles/new/test/javax/xml/jaxp/unittest/parsers/SaxParserStop.java) test/javax/xml/jaxp/unittest/parsers/SaxParserStop.java

196 lines changed: 196 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ ---[New](test/javax/xml/jaxp/unittest/parsers/SaxParserStop.xml.html) [Patch](test/javax/xml/jaxp/unittest/parsers/SaxParserStop.xml.patch) [Raw](raw%5Ffiles/new/test/javax/xml/jaxp/unittest/parsers/SaxParserStop.xml) test/javax/xml/jaxp/unittest/parsers/SaxParserStop.xml

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using ../make/scripts/webrev.ksh(vers 25.1-hg+openjdk.java.net).