6814943 (original) (raw)
Code Review for 6814943
Prepared by: | kamg on Mon Jan 10 12:16:13 EST 2011 |
---|---|
Workspace: | /java/east/u3/kamg/ws/svc/6814943 |
Compare against: | http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot |
Compare against version: | 1961 |
Summary of changes: | 12 lines changed: 5 ins; 2 del; 5 mod; 7210 unchg |
Patch of changes: | <6814943.patch> |
Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/vm/prims/jvmtiEventController.cpp.cdiff.html) [Udiffs](src/share/vm/prims/jvmtiEventController.cpp.udiff.html) [Sdiffs](src/share/vm/prims/jvmtiEventController.cpp.sdiff.html) [Frames](src/share/vm/prims/jvmtiEventController.cpp.frames.html) [Old](src/share/vm/prims/jvmtiEventController.cpp-.html) [New](src/share/vm/prims/jvmtiEventController.cpp.html) [Patch](src/share/vm/prims/jvmtiEventController.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/prims/jvmtiEventController.cpp)
src/share/vm/prims/jvmtiEventController.cpp
rev 1962 : 6814943: getcpool001 catches more than one JvmtiThreadState problem Summary: Mark field volatile, use membars, and change access order to close race Reviewed-by:
5 lines changed: 1 ins; 2 del; 2 mod; 1069 unchg
[Cdiffs](src/share/vm/runtime/thread.cpp.cdiff.html) [Udiffs](src/share/vm/runtime/thread.cpp.udiff.html) [Sdiffs](src/share/vm/runtime/thread.cpp.sdiff.html) [Frames](src/share/vm/runtime/thread.cpp.frames.html) [Old](src/share/vm/runtime/thread.cpp-.html) [New](src/share/vm/runtime/thread.cpp.html) [Patch](src/share/vm/runtime/thread.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/thread.cpp)
src/share/vm/runtime/thread.cpp
rev 1962 : 6814943: getcpool001 catches more than one JvmtiThreadState problem Summary: Mark field volatile, use membars, and change access order to close race Reviewed-by:
6 lines changed: 4 ins; 0 del; 2 mod; 4307 unchg
[Cdiffs](src/share/vm/runtime/thread.hpp.cdiff.html) [Udiffs](src/share/vm/runtime/thread.hpp.udiff.html) [Sdiffs](src/share/vm/runtime/thread.hpp.sdiff.html) [Frames](src/share/vm/runtime/thread.hpp.frames.html) [Old](src/share/vm/runtime/thread.hpp-.html) [New](src/share/vm/runtime/thread.hpp.html) [Patch](src/share/vm/runtime/thread.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/runtime/thread.hpp)
src/share/vm/runtime/thread.hpp
rev 1962 : 6814943: getcpool001 catches more than one JvmtiThreadState problem Summary: Mark field volatile, use membars, and change access order to close race Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 1834 unchg
This code review page was prepared using /home/kamg/bin/hg_webrev(vers 23.18-hg-never).