open (original) (raw)

Code Review for open

Prepared by: lancea on Wed Feb 28 16:17:34 EST 2018
Workspace: /Users/ljanders/Documents/hg-workspaces/openjdk10/jdk10-Feb10/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 90 lines changed: 80 ins; 1 del; 9 mod; 3252 unchg
Patch of changes: <open.patch>
Legend: Modified file Deleted file New file

[Cdiffs](make/CompileJavaModules.gmk.cdiff.html) [Udiffs](make/CompileJavaModules.gmk.udiff.html) [Sdiffs](make/CompileJavaModules.gmk.sdiff.html) [Frames](make/CompileJavaModules.gmk.frames.html) [Old](make/CompileJavaModules.gmk-.html) [New](make/CompileJavaModules.gmk.html) [Patch](make/CompileJavaModules.gmk.patch) [Raw](raw%5Ffiles/new/make/CompileJavaModules.gmk) make/CompileJavaModules.gmk

4 lines changed: 4 ins; 0 del; 0 mod; 646 unchg

[Cdiffs](make/common/Modules.gmk.cdiff.html) [Udiffs](make/common/Modules.gmk.udiff.html) [Sdiffs](make/common/Modules.gmk.sdiff.html) [Frames](make/common/Modules.gmk.frames.html) [Old](make/common/Modules.gmk-.html) [New](make/common/Modules.gmk.html) [Patch](make/common/Modules.gmk.patch) [Raw](raw%5Ffiles/new/make/common/Modules.gmk) make/common/Modules.gmk

1 line changed: 1 ins; 0 del; 0 mod; 452 unchg

[Cdiffs](make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java.cdiff.html) [Udiffs](make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java.udiff.html) [Sdiffs](make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java.sdiff.html) [Frames](make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java.frames.html) [Old](make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java-.html) [New](make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java.html) [Patch](make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java.patch) [Raw](raw%5Ffiles/new/make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java) make/jdk/src/classes/build/tools/jigsaw/GenGraphs.java

1 line changed: 1 ins; 0 del; 0 mod; 258 unchg

[Cdiffs](make/jdk/src/classes/build/tools/jigsaw/technology-summary.html.cdiff.html) [Udiffs](make/jdk/src/classes/build/tools/jigsaw/technology-summary.html.udiff.html) [Sdiffs](make/jdk/src/classes/build/tools/jigsaw/technology-summary.html.sdiff.html) [Frames](make/jdk/src/classes/build/tools/jigsaw/technology-summary.html.frames.html) [Old](make/jdk/src/classes/build/tools/jigsaw/technology-summary.html-.html) [New](make/jdk/src/classes/build/tools/jigsaw/technology-summary.html.html) [Patch](make/jdk/src/classes/build/tools/jigsaw/technology-summary.html.patch) [Raw](raw%5Ffiles/new/make/jdk/src/classes/build/tools/jigsaw/technology-summary.html) make/jdk/src/classes/build/tools/jigsaw/technology-summary.html

5 lines changed: 0 ins; 0 del; 5 mod; 442 unchg

[Cdiffs](src/java.se/share/classes/module-info.java.cdiff.html) [Udiffs](src/java.se/share/classes/module-info.java.udiff.html) [Sdiffs](src/java.se/share/classes/module-info.java.sdiff.html) [Frames](src/java.se/share/classes/module-info.java.frames.html) [Old](src/java.se/share/classes/module-info.java-.html) [New](src/java.se/share/classes/module-info.java.html) [Patch](src/java.se/share/classes/module-info.java.patch) [Raw](raw%5Ffiles/new/src/java.se/share/classes/module-info.java) src/java.se/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 60 unchg

[Cdiffs](src/java.sql/share/classes/module-info.java.cdiff.html) [Udiffs](src/java.sql/share/classes/module-info.java.udiff.html) [Sdiffs](src/java.sql/share/classes/module-info.java.sdiff.html) [Frames](src/java.sql/share/classes/module-info.java.frames.html) [Old](src/java.sql/share/classes/module-info.java-.html) [New](src/java.sql/share/classes/module-info.java.html) [Patch](src/java.sql/share/classes/module-info.java.patch) [Raw](raw%5Ffiles/new/src/java.sql/share/classes/module-info.java) src/java.sql/share/classes/module-info.java

3 lines changed: 1 ins; 1 del; 1 mod; 41 unchg

[Cdiffs](test/jdk/TEST.groups.cdiff.html) [Udiffs](test/jdk/TEST.groups.udiff.html) [Sdiffs](test/jdk/TEST.groups.sdiff.html) [Frames](test/jdk/TEST.groups.frames.html) [Old](test/jdk/TEST.groups-.html) [New](test/jdk/TEST.groups.html) [Patch](test/jdk/TEST.groups.patch) [Raw](raw%5Ffiles/new/test/jdk/TEST.groups) test/jdk/TEST.groups

1 line changed: 1 ins; 0 del; 0 mod; 440 unchg

------ ------ ------ ------ ---[New](src/java.transaction.xa/share/classes/javax/transaction/xa/XAException.java.html) [Patch](src/java.transaction.xa/share/classes/javax/transaction/xa/XAException.java.patch) [Raw](raw%5Ffiles/new/src/java.transaction.xa/share/classes/javax/transaction/xa/XAException.java) src/java.transaction.xa/share/classes/javax/transaction/xa/XAException.java (was src/java.sql/share/classes/javax/transaction/xa/XAException.java)

0 lines changed: 0 ins; 0 del; 0 mod; 201 unchg

------ ------ ------ ------ ---[New](src/java.transaction.xa/share/classes/javax/transaction/xa/XAResource.java.html) [Patch](src/java.transaction.xa/share/classes/javax/transaction/xa/XAResource.java.patch) [Raw](raw%5Ffiles/new/src/java.transaction.xa/share/classes/javax/transaction/xa/XAResource.java) src/java.transaction.xa/share/classes/javax/transaction/xa/XAResource.java (was src/java.sql/share/classes/javax/transaction/xa/XAResource.java)

0 lines changed: 0 ins; 0 del; 0 mod; 306 unchg

------ ------ ------ ------ ---[New](src/java.transaction.xa/share/classes/javax/transaction/xa/Xid.java.html) [Patch](src/java.transaction.xa/share/classes/javax/transaction/xa/Xid.java.patch) [Raw](raw%5Ffiles/new/src/java.transaction.xa/share/classes/javax/transaction/xa/Xid.java) src/java.transaction.xa/share/classes/javax/transaction/xa/Xid.java (was src/java.sql/share/classes/javax/transaction/xa/Xid.java)

0 lines changed: 0 ins; 0 del; 0 mod; 72 unchg

------ ------ ------ ------ ---[New](src/java.transaction.xa/share/classes/javax/transaction/xa/package.html.html) [Patch](src/java.transaction.xa/share/classes/javax/transaction/xa/package.html.patch) [Raw](raw%5Ffiles/new/src/java.transaction.xa/share/classes/javax/transaction/xa/package.html) src/java.transaction.xa/share/classes/javax/transaction/xa/package.html (was src/java.sql/share/classes/javax/transaction/xa/package.html)

0 lines changed: 0 ins; 0 del; 0 mod; 41 unchg

------ ------ ------ ------ ---[New](src/java.transaction.xa/share/classes/module-info.java.html) [Patch](src/java.transaction.xa/share/classes/module-info.java.patch) [Raw](raw%5Ffiles/new/src/java.transaction.xa/share/classes/module-info.java) src/java.transaction.xa/share/classes/module-info.java

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

[Cdiffs](test/jdk/javax/transaction/xa/testng/Driver.java.cdiff.html) [Udiffs](test/jdk/javax/transaction/xa/testng/Driver.java.udiff.html) [Sdiffs](test/jdk/javax/transaction/xa/testng/Driver.java.sdiff.html) [Frames](test/jdk/javax/transaction/xa/testng/Driver.java.frames.html) [Old](test/jdk/javax/transaction/xa/testng/Driver.java-.html) [New](test/jdk/javax/transaction/xa/testng/Driver.java.html) [Patch](test/jdk/javax/transaction/xa/testng/Driver.java.patch) [Raw](raw%5Ffiles/new/test/jdk/javax/transaction/xa/testng/Driver.java) test/jdk/javax/transaction/xa/testng/Driver.java (was test/jdk/javax/transaction/testng/Driver.java)

5 lines changed: 2 ins; 0 del; 3 mod; 28 unchg

------ ------ ------ ------ ---[New](test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java.html) [Patch](test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java.patch) [Raw](raw%5Ffiles/new/test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java) test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/jdk/javax/transaction/xa/testng/test/transaction/XAExceptionTests.java.html) [Patch](test/jdk/javax/transaction/xa/testng/test/transaction/XAExceptionTests.java.patch) [Raw](raw%5Ffiles/new/test/jdk/javax/transaction/xa/testng/test/transaction/XAExceptionTests.java) test/jdk/javax/transaction/xa/testng/test/transaction/XAExceptionTests.java (was test/jdk/javax/transaction/testng/test/transaction/XAExceptionTests.java)

0 lines changed: 0 ins; 0 del; 0 mod; 98 unchg

------ ------ ------ ------ ---[New](test/jdk/javax/transaction/xa/testng/util/SerializedTransactionExceptions.java.html) [Patch](test/jdk/javax/transaction/xa/testng/util/SerializedTransactionExceptions.java.patch) [Raw](raw%5Ffiles/new/test/jdk/javax/transaction/xa/testng/util/SerializedTransactionExceptions.java) test/jdk/javax/transaction/xa/testng/util/SerializedTransactionExceptions.java (was test/jdk/javax/transaction/testng/util/SerializedTransactionExceptions.java)

0 lines changed: 0 ins; 0 del; 0 mod; 167 unchg


This code review page was prepared using /Users/ljanders/Downloads/webrev.ksh(vers 25.16-hg+openjdk.java.net).