open (original) (raw)

Code Review for open

Prepared by: lkorinth on Mon Dec 11 14:49:17 CET 2017
Workspace: /home/lkorinth/repos/hs/open
Compare against version: .^
Summary of changes: 76 lines changed: 1 ins; 28 del; 47 mod; 1240 unchg
Patch of changes: <open.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/hotspot/share/gc/g1/g1AllocRegion.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1AllocRegion.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1AllocRegion.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1AllocRegion.cpp.frames.html) [Old](src/hotspot/share/gc/g1/g1AllocRegion.cpp-.html) [New](src/hotspot/share/gc/g1/g1AllocRegion.cpp.html) [Patch](src/hotspot/share/gc/g1/g1AllocRegion.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1AllocRegion.cpp) src/hotspot/share/gc/g1/g1AllocRegion.cpp

rev 48170 : Use templates to const fold if statements rev 48171 : 8133805: Remove the bot_updates parameter from G1Allocator's allocation methods

12 lines changed: 1 ins; 1 del; 10 mod; 299 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1AllocRegion.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1AllocRegion.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1AllocRegion.hpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1AllocRegion.hpp.frames.html) [Old](src/hotspot/share/gc/g1/g1AllocRegion.hpp-.html) [New](src/hotspot/share/gc/g1/g1AllocRegion.hpp.html) [Patch](src/hotspot/share/gc/g1/g1AllocRegion.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1AllocRegion.hpp) src/hotspot/share/gc/g1/g1AllocRegion.hpp

rev 48170 : Use templates to const fold if statements rev 48171 : 8133805: Remove the bot_updates parameter from G1Allocator's allocation methods

29 lines changed: 0 ins; 15 del; 14 mod; 236 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp.frames.html) [Old](src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp-.html) [New](src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp.html) [Patch](src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp) src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp

rev 48170 : Use templates to const fold if statements rev 48171 : 8133805: Remove the bot_updates parameter from G1Allocator's allocation methods

24 lines changed: 0 ins; 8 del; 16 mod; 113 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1Allocator.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1Allocator.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1Allocator.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1Allocator.cpp.frames.html) [Old](src/hotspot/share/gc/g1/g1Allocator.cpp-.html) [New](src/hotspot/share/gc/g1/g1Allocator.cpp.html) [Patch](src/hotspot/share/gc/g1/g1Allocator.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1Allocator.cpp) src/hotspot/share/gc/g1/g1Allocator.cpp

rev 48170 : Use templates to const fold if statements rev 48171 : 8133805: Remove the bot_updates parameter from G1Allocator's allocation methods

8 lines changed: 0 ins; 4 del; 4 mod; 481 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1Allocator.inline.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1Allocator.inline.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1Allocator.inline.hpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1Allocator.inline.hpp.frames.html) [Old](src/hotspot/share/gc/g1/g1Allocator.inline.hpp-.html) [New](src/hotspot/share/gc/g1/g1Allocator.inline.hpp.html) [Patch](src/hotspot/share/gc/g1/g1Allocator.inline.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1Allocator.inline.hpp) src/hotspot/share/gc/g1/g1Allocator.inline.hpp

rev 48170 : Use templates to const fold if statements rev 48171 : 8133805: Remove the bot_updates parameter from G1Allocator's allocation methods

3 lines changed: 0 ins; 0 del; 3 mod; 111 unchg


This code review page was prepared using /home/lkorinth/local/bin/webrev.ksh(vers 25.16-hg+openjdk.java.net).