jdk_tls12_sunpkcs11 (original) (raw)

Code Review for jdk_tls12_sunpkcs11

[Cdiffs](src/java.base/share/classes/module-info.java.cdiff.html) [Udiffs](src/java.base/share/classes/module-info.java.udiff.html) [Sdiffs](src/java.base/share/classes/module-info.java.sdiff.html) [Frames](src/java.base/share/classes/module-info.java.frames.html) [Old](src/java.base/share/classes/module-info.java-.html) [New](src/java.base/share/classes/module-info.java.html) [Patch](src/java.base/share/classes/module-info.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/module-info.java) src/java.base/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 363 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java-.html) [New](src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java) src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java

32 lines changed: 14 ins; 0 del; 18 mod; 297 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java

5 lines changed: 2 ins; 2 del; 1 mod; 1007 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java

39 lines changed: 27 ins; 0 del; 12 mod; 212 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java

43 lines changed: 23 ins; 4 del; 16 mod; 149 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java

41 lines changed: 39 ins; 0 del; 2 mod; 167 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java

18 lines changed: 10 ins; 1 del; 7 mod; 129 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java

39 lines changed: 19 ins; 19 del; 1 mod; 1485 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FATTRIBUTE.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FATTRIBUTE.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FATTRIBUTE.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FATTRIBUTE.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FATTRIBUTE.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FATTRIBUTE.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FATTRIBUTE.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FATTRIBUTE.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_ATTRIBUTE.java

3 lines changed: 3 ins; 0 del; 0 mod; 229 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FMECHANISM.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FMECHANISM.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FMECHANISM.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FMECHANISM.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FMECHANISM.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FMECHANISM.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FMECHANISM.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FMECHANISM.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM.java

12 lines changed: 12 ins; 0 del; 0 mod; 166 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java

3 lines changed: 3 ins; 0 del; 0 mod; 905 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java.frames.html) [Old](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java-.html) [New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java

8 lines changed: 8 ins; 0 del; 0 mod; 966 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fconvert.c.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fconvert.c.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fconvert.c.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fconvert.c.frames.html) [Old](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fconvert.c-.html) [New](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fconvert.c.html) [Patch](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fconvert.c.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fconvert.c) src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c

459 lines changed: 302 ins; 110 del; 47 mod; 1685 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fkeymgmt.c.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fkeymgmt.c.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fkeymgmt.c.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fkeymgmt.c.frames.html) [Old](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fkeymgmt.c-.html) [New](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fkeymgmt.c.html) [Patch](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fkeymgmt.c.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11%5Fkeymgmt.c) src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c

185 lines changed: 87 ins; 24 del; 74 mod; 675 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h.frames.html) [Old](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h-.html) [New](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h.html) [Patch](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h) src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h

36 lines changed: 36 ins; 0 del; 0 mod; 1685 unchg

[Cdiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h.cdiff.html) [Udiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h.udiff.html) [Sdiffs](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h.sdiff.html) [Frames](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h.frames.html) [Old](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h-.html) [New](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h.html) [Patch](src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h) src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h

8 lines changed: 5 ins; 0 del; 3 mod; 470 unchg

------ ------ ------ ------ ---[New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FTLS12%5FKEY%5FMAT%5FPARAMS.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FTLS12%5FKEY%5FMAT%5FPARAMS.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FTLS12%5FKEY%5FMAT%5FPARAMS.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS12_KEY_MAT_PARAMS.java

153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FTLS12%5FMASTER%5FKEY%5FDERIVE%5FPARAMS.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FTLS12%5FMASTER%5FKEY%5FDERIVE%5FPARAMS.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FTLS12%5FMASTER%5FKEY%5FDERIVE%5FPARAMS.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS12_MASTER_KEY_DERIVE_PARAMS.java

67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FTLS%5FMAC%5FPARAMS.java.html) [Patch](src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FTLS%5FMAC%5FPARAMS.java.patch) [Raw](raw%5Ffiles/new/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK%5FTLS%5FMAC%5FPARAMS.java) src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS_MAC_PARAMS.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/jdk/sun/security/pkcs11/tls/TestTLS12.java.html) [Patch](test/jdk/sun/security/pkcs11/tls/TestTLS12.java.patch) [Raw](raw%5Ffiles/new/test/jdk/sun/security/pkcs11/tls/TestTLS12.java) test/jdk/sun/security/pkcs11/tls/TestTLS12.java

2273 lines changed: 2273 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/martin/Programs/webrev.ksh(vers 25.16-hg+openjdk.java.net).