jdk (original) (raw)

Code Review for jdk

Prepared by: mchung on Wed Feb 13 12:30:51 PST 2013
Workspace: /export/mchung/ws/jdk8/TL/jdk8-servicetag/jdk
Compare against: http://hg.openjdk.java.net/jdk8/tl/jdk
Summary of changes: 7906 lines changed: 0 ins; 7903 del; 3 mod; 4695 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](make/com/sun/Makefile.cdiff.html) [Udiffs](make/com/sun/Makefile.udiff.html) [Sdiffs](make/com/sun/Makefile.sdiff.html) [Frames](make/com/sun/Makefile.frames.html) [Old](make/com/sun/Makefile-.html) [New](make/com/sun/Makefile.html) [Patch](make/com/sun/Makefile.patch) [Raw](raw%5Ffiles/new/make/com/sun/Makefile) make/com/sun/Makefile

1 line changed: 0 ins; 0 del; 1 mod; 55 unchg

[Cdiffs](make/common/Release.gmk.cdiff.html) [Udiffs](make/common/Release.gmk.udiff.html) [Sdiffs](make/common/Release.gmk.sdiff.html) [Frames](make/common/Release.gmk.frames.html) [Old](make/common/Release.gmk-.html) [New](make/common/Release.gmk.html) [Patch](make/common/Release.gmk.patch) [Raw](raw%5Ffiles/new/make/common/Release.gmk) make/common/Release.gmk

2 lines changed: 0 ins; 1 del; 1 mod; 1399 unchg

[Cdiffs](makefiles/CopyFiles.gmk.cdiff.html) [Udiffs](makefiles/CopyFiles.gmk.udiff.html) [Sdiffs](makefiles/CopyFiles.gmk.sdiff.html) [Frames](makefiles/CopyFiles.gmk.frames.html) [Old](makefiles/CopyFiles.gmk-.html) [New](makefiles/CopyFiles.gmk.html) [Patch](makefiles/CopyFiles.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/CopyFiles.gmk) makefiles/CopyFiles.gmk

11 lines changed: 0 ins; 11 del; 0 mod; 605 unchg

[Cdiffs](makefiles/CopyIntoClasses.gmk.cdiff.html) [Udiffs](makefiles/CopyIntoClasses.gmk.udiff.html) [Sdiffs](makefiles/CopyIntoClasses.gmk.sdiff.html) [Frames](makefiles/CopyIntoClasses.gmk.frames.html) [Old](makefiles/CopyIntoClasses.gmk-.html) [New](makefiles/CopyIntoClasses.gmk.html) [Patch](makefiles/CopyIntoClasses.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/CopyIntoClasses.gmk) makefiles/CopyIntoClasses.gmk

9 lines changed: 0 ins; 9 del; 0 mod; 250 unchg

[Cdiffs](makefiles/CreateJars.gmk.cdiff.html) [Udiffs](makefiles/CreateJars.gmk.udiff.html) [Sdiffs](makefiles/CreateJars.gmk.sdiff.html) [Frames](makefiles/CreateJars.gmk.frames.html) [Old](makefiles/CreateJars.gmk-.html) [New](makefiles/CreateJars.gmk.html) [Patch](makefiles/CreateJars.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/CreateJars.gmk) makefiles/CreateJars.gmk

2 lines changed: 0 ins; 1 del; 1 mod; 1095 unchg

[Cdiffs](makefiles/GensrcProperties.gmk.cdiff.html) [Udiffs](makefiles/GensrcProperties.gmk.udiff.html) [Sdiffs](makefiles/GensrcProperties.gmk.sdiff.html) [Frames](makefiles/GensrcProperties.gmk.frames.html) [Old](makefiles/GensrcProperties.gmk-.html) [New](makefiles/GensrcProperties.gmk.html) [Patch](makefiles/GensrcProperties.gmk.patch) [Raw](raw%5Ffiles/new/makefiles/GensrcProperties.gmk) makefiles/GensrcProperties.gmk

1 line changed: 0 ins; 1 del; 0 mod; 388 unchg

[Cdiffs](test/Makefile.cdiff.html) [Udiffs](test/Makefile.udiff.html) [Sdiffs](test/Makefile.sdiff.html) [Frames](test/Makefile.frames.html) [Old](test/Makefile-.html) [New](test/Makefile.html) [Patch](test/Makefile.patch) [Raw](raw%5Ffiles/new/test/Makefile) test/Makefile

1 line changed: 0 ins; 1 del; 0 mod; 903 unchg

------ ------ ------ ------[Old](make/com/sun/servicetag/Makefile-.html) ---[Patch](make/com/sun/servicetag/Makefile.patch) --- make/com/sun/servicetag/Makefile

80 lines changed: 0 ins; 80 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/BrowserSupport.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/BrowserSupport.java.patch) --- src/share/classes/com/sun/servicetag/BrowserSupport.java

176 lines changed: 0 ins; 176 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/Installer.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/Installer.java.patch) --- src/share/classes/com/sun/servicetag/Installer.java

937 lines changed: 0 ins; 937 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java.patch) --- src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java

193 lines changed: 0 ins; 193 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/RegistrationData.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/RegistrationData.java.patch) --- src/share/classes/com/sun/servicetag/RegistrationData.java

475 lines changed: 0 ins; 475 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/RegistrationDocument.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/RegistrationDocument.java.patch) --- src/share/classes/com/sun/servicetag/RegistrationDocument.java

358 lines changed: 0 ins; 358 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/Registry.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/Registry.java.patch) --- src/share/classes/com/sun/servicetag/Registry.java

556 lines changed: 0 ins; 556 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/ServiceTag.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/ServiceTag.java.patch) --- src/share/classes/com/sun/servicetag/ServiceTag.java

634 lines changed: 0 ins; 634 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/SolarisServiceTag.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/SolarisServiceTag.java.patch) --- src/share/classes/com/sun/servicetag/SolarisServiceTag.java

62 lines changed: 0 ins; 62 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java.patch) --- src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java

159 lines changed: 0 ins; 159 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/SunConnection.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/SunConnection.java.patch) --- src/share/classes/com/sun/servicetag/SunConnection.java

297 lines changed: 0 ins; 297 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/SystemEnvironment.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/SystemEnvironment.java.patch) --- src/share/classes/com/sun/servicetag/SystemEnvironment.java

338 lines changed: 0 ins; 338 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java.patch) --- src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java

53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/Util.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/Util.java.patch) --- src/share/classes/com/sun/servicetag/Util.java

339 lines changed: 0 ins; 339 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java-.html) ---[Patch](src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java.patch) --- src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java

150 lines changed: 0 ins; 150 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/package.html-.html) ---[Patch](src/share/classes/com/sun/servicetag/package.html.patch) --- src/share/classes/com/sun/servicetag/package.html

71 lines changed: 0 ins; 71 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt.patch) --- src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt

25 lines changed: 0 ins; 25 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/javase%5F5%5Fswordfish.properties-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/javase%5F5%5Fswordfish.properties.patch) --- src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties

29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/javase%5F6%5Fswordfish.properties-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/javase%5F6%5Fswordfish.properties.patch) --- src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties

29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/javase%5F7%5Fswordfish.properties-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/javase%5F7%5Fswordfish.properties.patch) --- src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties

29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/javase%5Fservicetag.properties-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/javase%5Fservicetag.properties.patch) --- src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties

29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/jdk%5Fheader.png-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/jdk%5Fheader.png.patch) --- src/share/classes/com/sun/servicetag/resources/jdk_header.png

Unexpected Error occurred reading `diff -e old/src/share/classes/com/sun/servicetag/resources/jdk_header.png /dev/null`: $?=0, err= 1

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/product%5Fregistration.xsd-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/product%5Fregistration.xsd.patch) --- src/share/classes/com/sun/servicetag/resources/product_registration.xsd

301 lines changed: 0 ins; 301 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/register.html-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/register.html.patch) --- src/share/classes/com/sun/servicetag/resources/register.html

105 lines changed: 0 ins; 105 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/register%5Fja.html-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/register%5Fja.html.patch) --- src/share/classes/com/sun/servicetag/resources/register_ja.html

91 lines changed: 0 ins; 91 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](src/share/classes/com/sun/servicetag/resources/register%5Fzh%5FCN.html-.html) ---[Patch](src/share/classes/com/sun/servicetag/resources/register%5Fzh%5FCN.html.patch) --- src/share/classes/com/sun/servicetag/resources/register_zh_CN.html

92 lines changed: 0 ins; 92 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/DeleteServiceTag.java-.html) ---[Patch](test/com/sun/servicetag/DeleteServiceTag.java.patch) --- test/com/sun/servicetag/DeleteServiceTag.java

129 lines changed: 0 ins; 129 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/DuplicateNotFound.java-.html) ---[Patch](test/com/sun/servicetag/DuplicateNotFound.java.patch) --- test/com/sun/servicetag/DuplicateNotFound.java

97 lines changed: 0 ins; 97 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/FindServiceTags.java-.html) ---[Patch](test/com/sun/servicetag/FindServiceTags.java.patch) --- test/com/sun/servicetag/FindServiceTags.java

141 lines changed: 0 ins; 141 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/InstanceUrnCheck.java-.html) ---[Patch](test/com/sun/servicetag/InstanceUrnCheck.java.patch) --- test/com/sun/servicetag/InstanceUrnCheck.java

76 lines changed: 0 ins; 76 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/InvalidRegistrationData.java-.html) ---[Patch](test/com/sun/servicetag/InvalidRegistrationData.java.patch) --- test/com/sun/servicetag/InvalidRegistrationData.java

65 lines changed: 0 ins; 65 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/InvalidServiceTag.java-.html) ---[Patch](test/com/sun/servicetag/InvalidServiceTag.java.patch) --- test/com/sun/servicetag/InvalidServiceTag.java

96 lines changed: 0 ins; 96 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/JavaServiceTagTest.java-.html) ---[Patch](test/com/sun/servicetag/JavaServiceTagTest.java.patch) --- test/com/sun/servicetag/JavaServiceTagTest.java

191 lines changed: 0 ins; 191 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/JavaServiceTagTest1.java-.html) ---[Patch](test/com/sun/servicetag/JavaServiceTagTest1.java.patch) --- test/com/sun/servicetag/JavaServiceTagTest1.java

265 lines changed: 0 ins; 265 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/NewRegistrationData.java-.html) ---[Patch](test/com/sun/servicetag/NewRegistrationData.java.patch) --- test/com/sun/servicetag/NewRegistrationData.java

105 lines changed: 0 ins; 105 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/SvcTagClient.java-.html) ---[Patch](test/com/sun/servicetag/SvcTagClient.java.patch) --- test/com/sun/servicetag/SvcTagClient.java

200 lines changed: 0 ins; 200 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/SystemRegistryTest.java-.html) ---[Patch](test/com/sun/servicetag/SystemRegistryTest.java.patch) --- test/com/sun/servicetag/SystemRegistryTest.java

139 lines changed: 0 ins; 139 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/TestLoadFromXML.java-.html) ---[Patch](test/com/sun/servicetag/TestLoadFromXML.java.patch) --- test/com/sun/servicetag/TestLoadFromXML.java

69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/UpdateServiceTagTest.java-.html) ---[Patch](test/com/sun/servicetag/UpdateServiceTagTest.java.patch) --- test/com/sun/servicetag/UpdateServiceTagTest.java

109 lines changed: 0 ins; 109 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/Util.java-.html) ---[Patch](test/com/sun/servicetag/Util.java.patch) --- test/com/sun/servicetag/Util.java

265 lines changed: 0 ins; 265 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/ValidRegistrationData.java-.html) ---[Patch](test/com/sun/servicetag/ValidRegistrationData.java.patch) --- test/com/sun/servicetag/ValidRegistrationData.java

112 lines changed: 0 ins; 112 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/environ.properties-.html) ---[Patch](test/com/sun/servicetag/environ.properties.patch) --- test/com/sun/servicetag/environ.properties

9 lines changed: 0 ins; 9 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/missing-environ-field.xml-.html) ---[Patch](test/com/sun/servicetag/missing-environ-field.xml.patch) --- test/com/sun/servicetag/missing-environ-field.xml

45 lines changed: 0 ins; 45 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/newer-registry-version.xml-.html) ---[Patch](test/com/sun/servicetag/newer-registry-version.xml.patch) --- test/com/sun/servicetag/newer-registry-version.xml

32 lines changed: 0 ins; 32 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/registration.xml-.html) ---[Patch](test/com/sun/servicetag/registration.xml.patch) --- test/com/sun/servicetag/registration.xml

61 lines changed: 0 ins; 61 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/servicetag1.properties-.html) ---[Patch](test/com/sun/servicetag/servicetag1.properties.patch) --- test/com/sun/servicetag/servicetag1.properties

13 lines changed: 0 ins; 13 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/servicetag2.properties-.html) ---[Patch](test/com/sun/servicetag/servicetag2.properties.patch) --- test/com/sun/servicetag/servicetag2.properties

13 lines changed: 0 ins; 13 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/servicetag3.properties-.html) ---[Patch](test/com/sun/servicetag/servicetag3.properties.patch) --- test/com/sun/servicetag/servicetag3.properties

13 lines changed: 0 ins; 13 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/servicetag4.properties-.html) ---[Patch](test/com/sun/servicetag/servicetag4.properties.patch) --- test/com/sun/servicetag/servicetag4.properties

13 lines changed: 0 ins; 13 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](test/com/sun/servicetag/servicetag5.properties-.html) ---[Patch](test/com/sun/servicetag/servicetag5.properties.patch) --- test/com/sun/servicetag/servicetag5.properties

13 lines changed: 0 ins; 13 del; 0 mod; 0 unchg


This code review page was prepared using /java/devtools/share/bin/webrev(vers 23.18-hg).