langtools (original) (raw)

Code Review for langtools

Prepared by: mchung on Thu Oct 10 23:35:47 PDT 2013
Workspace: /export/mchung/ws/jdeps/jdk8-tl/langtools
Compare against: http://hg.openjdk.java.net/jdk8/tl/langtools
Summary of changes: 1231 lines changed: 798 ins; 151 del; 282 mod; 1461 unchg
Patch of changes: <langtools.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/com/sun/tools/jdeps/Analyzer.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/jdeps/Analyzer.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/jdeps/Analyzer.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/jdeps/Analyzer.java.frames.html) [Old](src/share/classes/com/sun/tools/jdeps/Analyzer.java-.html) [New](src/share/classes/com/sun/tools/jdeps/Analyzer.java.html) [Patch](src/share/classes/com/sun/tools/jdeps/Analyzer.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/jdeps/Analyzer.java) src/share/classes/com/sun/tools/jdeps/Analyzer.java

94 lines changed: 25 ins; 33 del; 36 mod; 169 unchg

[Cdiffs](src/share/classes/com/sun/tools/jdeps/Archive.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/jdeps/Archive.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/jdeps/Archive.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/jdeps/Archive.java.frames.html) [Old](src/share/classes/com/sun/tools/jdeps/Archive.java-.html) [New](src/share/classes/com/sun/tools/jdeps/Archive.java.html) [Patch](src/share/classes/com/sun/tools/jdeps/Archive.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/jdeps/Archive.java) src/share/classes/com/sun/tools/jdeps/Archive.java

11 lines changed: 0 ins; 1 del; 10 mod; 86 unchg

[Cdiffs](src/share/classes/com/sun/tools/jdeps/ClassFileReader.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/jdeps/ClassFileReader.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/jdeps/ClassFileReader.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/jdeps/ClassFileReader.java.frames.html) [Old](src/share/classes/com/sun/tools/jdeps/ClassFileReader.java-.html) [New](src/share/classes/com/sun/tools/jdeps/ClassFileReader.java.html) [Patch](src/share/classes/com/sun/tools/jdeps/ClassFileReader.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/jdeps/ClassFileReader.java) src/share/classes/com/sun/tools/jdeps/ClassFileReader.java

12 lines changed: 0 ins; 0 del; 12 mod; 324 unchg

[Cdiffs](src/share/classes/com/sun/tools/jdeps/JdepsTask.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/jdeps/JdepsTask.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/jdeps/JdepsTask.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/jdeps/JdepsTask.java.frames.html) [Old](src/share/classes/com/sun/tools/jdeps/JdepsTask.java-.html) [New](src/share/classes/com/sun/tools/jdeps/JdepsTask.java.html) [Patch](src/share/classes/com/sun/tools/jdeps/JdepsTask.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/jdeps/JdepsTask.java) src/share/classes/com/sun/tools/jdeps/JdepsTask.java

319 lines changed: 202 ins; 50 del; 67 mod; 458 unchg

[Cdiffs](src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java.frames.html) [Old](src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java-.html) [New](src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java.html) [Patch](src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java) src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java

29 lines changed: 5 ins; 7 del; 17 mod; 83 unchg

[Cdiffs](src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties.sdiff.html) [Frames](src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties.frames.html) [Old](src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties-.html) [New](src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties.html) [Patch](src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties) src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties

42 lines changed: 22 ins; 4 del; 16 mod; 39 unchg

[Cdiffs](test/tools/jdeps/Basic.java.cdiff.html) [Udiffs](test/tools/jdeps/Basic.java.udiff.html) [Sdiffs](test/tools/jdeps/Basic.java.sdiff.html) [Frames](test/tools/jdeps/Basic.java.frames.html) [Old](test/tools/jdeps/Basic.java-.html) [New](test/tools/jdeps/Basic.java.html) [Patch](test/tools/jdeps/Basic.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/Basic.java) test/tools/jdeps/Basic.java

22 lines changed: 0 ins; 7 del; 15 mod; 191 unchg

[Cdiffs](test/tools/jdeps/Test.java.cdiff.html) [Udiffs](test/tools/jdeps/Test.java.udiff.html) [Sdiffs](test/tools/jdeps/Test.java.sdiff.html) [Frames](test/tools/jdeps/Test.java.frames.html) [Old](test/tools/jdeps/Test.java-.html) [New](test/tools/jdeps/Test.java.html) [Patch](test/tools/jdeps/Test.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/Test.java) test/tools/jdeps/Test.java

3 lines changed: 3 ins; 0 del; 0 mod; 28 unchg

[Cdiffs](src/share/classes/com/sun/tools/jdeps/Profile.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/jdeps/Profile.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/jdeps/Profile.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/jdeps/Profile.java.frames.html) [Old](src/share/classes/com/sun/tools/jdeps/Profile.java-.html) [New](src/share/classes/com/sun/tools/jdeps/Profile.java.html) [Patch](src/share/classes/com/sun/tools/jdeps/Profile.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/jdeps/Profile.java) src/share/classes/com/sun/tools/jdeps/Profile.java (was src/share/classes/com/sun/tools/jdeps/Profiles.java)

193 lines changed: 35 ins; 49 del; 109 mod; 83 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/APIDeps.java.html) [Patch](test/tools/jdeps/APIDeps.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/APIDeps.java) test/tools/jdeps/APIDeps.java

191 lines changed: 191 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/b/B.java.html) [Patch](test/tools/jdeps/b/B.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/b/B.java) test/tools/jdeps/b/B.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/c/C.java.html) [Patch](test/tools/jdeps/c/C.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/c/C.java) test/tools/jdeps/c/C.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/c/I.java.html) [Patch](test/tools/jdeps/c/I.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/c/I.java) test/tools/jdeps/c/I.java

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/d/D.java.html) [Patch](test/tools/jdeps/d/D.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/d/D.java) test/tools/jdeps/d/D.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/e/E.java.html) [Patch](test/tools/jdeps/e/E.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/e/E.java) test/tools/jdeps/e/E.java

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/f/F.java.html) [Patch](test/tools/jdeps/f/F.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/f/F.java) test/tools/jdeps/f/F.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/g/G.java.html) [Patch](test/tools/jdeps/g/G.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/g/G.java) test/tools/jdeps/g/G.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/m/Bar.java.html) [Patch](test/tools/jdeps/m/Bar.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/m/Bar.java) test/tools/jdeps/m/Bar.java

50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/m/Foo.java.html) [Patch](test/tools/jdeps/m/Foo.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/m/Foo.java) test/tools/jdeps/m/Foo.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/tools/jdeps/m/Gee.java.html) [Patch](test/tools/jdeps/m/Gee.java.patch) [Raw](raw%5Ffiles/new/test/tools/jdeps/m/Gee.java) test/tools/jdeps/m/Gee.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /Users/mlchung/bin/webrev(vers 23.18-hg).