jdk (original) (raw)

Code Review for jdk

Prepared by: mduigou on Fri Jun 14 16:29:10 PDT 2013
Workspace: /home/mike/code/jdk/tl8/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk
Compare against version: 7312
Summary of changes: 1549 lines changed: 1025 ins; 245 del; 279 mod; 5723 unchg
Changeset: <jdk.changeset>
Bug id: JDK-7129185 : (coll) Please add Collections.emptyNavigableSet()
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/java/util/AbstractMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/AbstractMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/AbstractMap.java.sdiff.html) [Frames](src/share/classes/java/util/AbstractMap.java.frames.html) [Old](src/share/classes/java/util/AbstractMap.java-.html) [New](src/share/classes/java/util/AbstractMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/AbstractMap.java) src/share/classes/java/util/AbstractMap.java

rev 7313 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

2 lines changed: 2 ins; 0 del; 0 mod; 822 unchg

[Cdiffs](src/share/classes/java/util/Collections.java.cdiff.html) [Udiffs](src/share/classes/java/util/Collections.java.udiff.html) [Sdiffs](src/share/classes/java/util/Collections.java.sdiff.html) [Frames](src/share/classes/java/util/Collections.java.frames.html) [Old](src/share/classes/java/util/Collections.java-.html) [New](src/share/classes/java/util/Collections.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/Collections.java) src/share/classes/java/util/Collections.java

rev 7313 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

878 lines changed: 724 ins; 103 del; 51 mod; 4568 unchg

[Cdiffs](test/java/util/Collections/CheckedMapBash.java.cdiff.html) [Udiffs](test/java/util/Collections/CheckedMapBash.java.udiff.html) [Sdiffs](test/java/util/Collections/CheckedMapBash.java.sdiff.html) [Frames](test/java/util/Collections/CheckedMapBash.java.frames.html) [Old](test/java/util/Collections/CheckedMapBash.java-.html) [New](test/java/util/Collections/CheckedMapBash.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/CheckedMapBash.java) test/java/util/Collections/CheckedMapBash.java

rev 7313 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

141 lines changed: 72 ins; 45 del; 24 mod; 80 unchg

[Cdiffs](test/java/util/Collections/CheckedSetBash.java.cdiff.html) [Udiffs](test/java/util/Collections/CheckedSetBash.java.udiff.html) [Sdiffs](test/java/util/Collections/CheckedSetBash.java.sdiff.html) [Frames](test/java/util/Collections/CheckedSetBash.java.frames.html) [Old](test/java/util/Collections/CheckedSetBash.java-.html) [New](test/java/util/Collections/CheckedSetBash.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/CheckedSetBash.java) test/java/util/Collections/CheckedSetBash.java

rev 7313 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

107 lines changed: 33 ins; 7 del; 67 mod; 69 unchg

[Cdiffs](test/java/util/Collections/EmptyCollectionSerialization.java.cdiff.html) [Udiffs](test/java/util/Collections/EmptyCollectionSerialization.java.udiff.html) [Sdiffs](test/java/util/Collections/EmptyCollectionSerialization.java.sdiff.html) [Frames](test/java/util/Collections/EmptyCollectionSerialization.java.frames.html) [Old](test/java/util/Collections/EmptyCollectionSerialization.java-.html) [New](test/java/util/Collections/EmptyCollectionSerialization.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/EmptyCollectionSerialization.java) test/java/util/Collections/EmptyCollectionSerialization.java

rev 7313 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

49 lines changed: 39 ins; 0 del; 10 mod; 50 unchg

[Cdiffs](test/java/util/Collections/EmptyNavigableSet.java.cdiff.html) [Udiffs](test/java/util/Collections/EmptyNavigableSet.java.udiff.html) [Sdiffs](test/java/util/Collections/EmptyNavigableSet.java.sdiff.html) [Frames](test/java/util/Collections/EmptyNavigableSet.java.frames.html) [Old](test/java/util/Collections/EmptyNavigableSet.java-.html) [New](test/java/util/Collections/EmptyNavigableSet.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/EmptyNavigableSet.java) test/java/util/Collections/EmptyNavigableSet.java (was test/java/util/Collections/EmptySortedSet.java)

rev 7313 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

372 lines changed: 155 ins; 90 del; 127 mod; 134 unchg


This code review page was prepared using ../make/scripts/webrev.ksh(vers 24.0-hg+jbs).