jdk (original) (raw)

Code Review for jdk

[Cdiffs](src/share/classes/java/util/AbstractMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/AbstractMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/AbstractMap.java.sdiff.html) [Frames](src/share/classes/java/util/AbstractMap.java.frames.html) [Old](src/share/classes/java/util/AbstractMap.java-.html) [New](src/share/classes/java/util/AbstractMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/AbstractMap.java) src/share/classes/java/util/AbstractMap.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

2 lines changed: 2 ins; 0 del; 0 mod; 822 unchg

[Cdiffs](src/share/classes/java/util/Collections.java.cdiff.html) [Udiffs](src/share/classes/java/util/Collections.java.udiff.html) [Sdiffs](src/share/classes/java/util/Collections.java.sdiff.html) [Frames](src/share/classes/java/util/Collections.java.frames.html) [Old](src/share/classes/java/util/Collections.java-.html) [New](src/share/classes/java/util/Collections.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/Collections.java) src/share/classes/java/util/Collections.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

967 lines changed: 808 ins; 103 del; 56 mod; 4563 unchg

[Cdiffs](src/share/classes/java/util/HashMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/HashMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/HashMap.java.sdiff.html) [Frames](src/share/classes/java/util/HashMap.java.frames.html) [Old](src/share/classes/java/util/HashMap.java-.html) [New](src/share/classes/java/util/HashMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/HashMap.java) src/share/classes/java/util/HashMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap Reviewed-by: forax, duigou, psandoz Contributed-by: Mike Duigou mike.duigou@oracle.com, Remi Forax forax@univ-mlv.fr

112 lines changed: 106 ins; 3 del; 3 mod; 3006 unchg

[Cdiffs](src/share/classes/java/util/Hashtable.java.cdiff.html) [Udiffs](src/share/classes/java/util/Hashtable.java.udiff.html) [Sdiffs](src/share/classes/java/util/Hashtable.java.sdiff.html) [Frames](src/share/classes/java/util/Hashtable.java.frames.html) [Old](src/share/classes/java/util/Hashtable.java-.html) [New](src/share/classes/java/util/Hashtable.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/Hashtable.java) src/share/classes/java/util/Hashtable.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap Reviewed-by: forax, duigou, psandoz Contributed-by: Mike Duigou mike.duigou@oracle.com, Remi Forax forax@univ-mlv.fr

28 lines changed: 20 ins; 0 del; 8 mod; 1439 unchg

[Cdiffs](src/share/classes/java/util/IdentityHashMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/IdentityHashMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/IdentityHashMap.java.sdiff.html) [Frames](src/share/classes/java/util/IdentityHashMap.java.frames.html) [Old](src/share/classes/java/util/IdentityHashMap.java-.html) [New](src/share/classes/java/util/IdentityHashMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/IdentityHashMap.java) src/share/classes/java/util/IdentityHashMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap Reviewed-by: forax, duigou, psandoz Contributed-by: Mike Duigou mike.duigou@oracle.com, Remi Forax forax@univ-mlv.fr

34 lines changed: 34 ins; 0 del; 0 mod; 1558 unchg

[Cdiffs](src/share/classes/java/util/LinkedHashMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/LinkedHashMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/LinkedHashMap.java.sdiff.html) [Frames](src/share/classes/java/util/LinkedHashMap.java.frames.html) [Old](src/share/classes/java/util/LinkedHashMap.java-.html) [New](src/share/classes/java/util/LinkedHashMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/LinkedHashMap.java) src/share/classes/java/util/LinkedHashMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap Reviewed-by: forax, duigou, psandoz Contributed-by: Mike Duigou mike.duigou@oracle.com, Remi Forax forax@univ-mlv.fr

28 lines changed: 28 ins; 0 del; 0 mod; 473 unchg

[Cdiffs](src/share/classes/java/util/Map.java.cdiff.html) [Udiffs](src/share/classes/java/util/Map.java.udiff.html) [Sdiffs](src/share/classes/java/util/Map.java.sdiff.html) [Frames](src/share/classes/java/util/Map.java.frames.html) [Old](src/share/classes/java/util/Map.java-.html) [New](src/share/classes/java/util/Map.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/Map.java) src/share/classes/java/util/Map.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap Reviewed-by: forax, duigou, psandoz Contributed-by: Mike Duigou mike.duigou@oracle.com, Remi Forax forax@univ-mlv.fr

13 lines changed: 12 ins; 1 del; 0 mod; 1090 unchg

[Cdiffs](src/share/classes/java/util/NavigableSet.java.cdiff.html) [Udiffs](src/share/classes/java/util/NavigableSet.java.udiff.html) [Sdiffs](src/share/classes/java/util/NavigableSet.java.sdiff.html) [Frames](src/share/classes/java/util/NavigableSet.java.frames.html) [Old](src/share/classes/java/util/NavigableSet.java-.html) [New](src/share/classes/java/util/NavigableSet.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/NavigableSet.java) src/share/classes/java/util/NavigableSet.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

1 line changed: 0 ins; 0 del; 1 mod; 318 unchg

[Cdiffs](src/share/classes/java/util/TreeMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/TreeMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/TreeMap.java.sdiff.html) [Frames](src/share/classes/java/util/TreeMap.java.frames.html) [Old](src/share/classes/java/util/TreeMap.java-.html) [New](src/share/classes/java/util/TreeMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/TreeMap.java) src/share/classes/java/util/TreeMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap Reviewed-by: forax, duigou, psandoz Contributed-by: Mike Duigou mike.duigou@oracle.com, Remi Forax forax@univ-mlv.fr

29 lines changed: 29 ins; 0 del; 0 mod; 2921 unchg

[Cdiffs](src/share/classes/java/util/WeakHashMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/WeakHashMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/WeakHashMap.java.sdiff.html) [Frames](src/share/classes/java/util/WeakHashMap.java.frames.html) [Old](src/share/classes/java/util/WeakHashMap.java-.html) [New](src/share/classes/java/util/WeakHashMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/WeakHashMap.java) src/share/classes/java/util/WeakHashMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap Reviewed-by: forax, duigou, psandoz Contributed-by: Mike Duigou mike.duigou@oracle.com, Remi Forax forax@univ-mlv.fr

44 lines changed: 44 ins; 0 del; 0 mod; 1320 unchg

[Cdiffs](src/share/classes/java/util/concurrent/ConcurrentMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/concurrent/ConcurrentMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/concurrent/ConcurrentMap.java.sdiff.html) [Frames](src/share/classes/java/util/concurrent/ConcurrentMap.java.frames.html) [Old](src/share/classes/java/util/concurrent/ConcurrentMap.java-.html) [New](src/share/classes/java/util/concurrent/ConcurrentMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/concurrent/ConcurrentMap.java) src/share/classes/java/util/concurrent/ConcurrentMap.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap Reviewed-by: forax, duigou, psandoz Contributed-by: Mike Duigou mike.duigou@oracle.com, Remi Forax forax@univ-mlv.fr

34 lines changed: 34 ins; 0 del; 0 mod; 186 unchg

[Cdiffs](test/java/util/Collections/CheckedIdentityMap.java.cdiff.html) [Udiffs](test/java/util/Collections/CheckedIdentityMap.java.udiff.html) [Sdiffs](test/java/util/Collections/CheckedIdentityMap.java.sdiff.html) [Frames](test/java/util/Collections/CheckedIdentityMap.java.frames.html) [Old](test/java/util/Collections/CheckedIdentityMap.java-.html) [New](test/java/util/Collections/CheckedIdentityMap.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/CheckedIdentityMap.java) test/java/util/Collections/CheckedIdentityMap.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

42 lines changed: 10 ins; 27 del; 5 mod; 50 unchg

[Cdiffs](test/java/util/Collections/CheckedMapBash.java.cdiff.html) [Udiffs](test/java/util/Collections/CheckedMapBash.java.udiff.html) [Sdiffs](test/java/util/Collections/CheckedMapBash.java.sdiff.html) [Frames](test/java/util/Collections/CheckedMapBash.java.frames.html) [Old](test/java/util/Collections/CheckedMapBash.java-.html) [New](test/java/util/Collections/CheckedMapBash.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/CheckedMapBash.java) test/java/util/Collections/CheckedMapBash.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

141 lines changed: 72 ins; 45 del; 24 mod; 80 unchg

[Cdiffs](test/java/util/Collections/CheckedSetBash.java.cdiff.html) [Udiffs](test/java/util/Collections/CheckedSetBash.java.udiff.html) [Sdiffs](test/java/util/Collections/CheckedSetBash.java.sdiff.html) [Frames](test/java/util/Collections/CheckedSetBash.java.frames.html) [Old](test/java/util/Collections/CheckedSetBash.java-.html) [New](test/java/util/Collections/CheckedSetBash.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/CheckedSetBash.java) test/java/util/Collections/CheckedSetBash.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

107 lines changed: 33 ins; 7 del; 67 mod; 69 unchg

[Cdiffs](test/java/util/Collections/EmptyCollectionSerialization.java.cdiff.html) [Udiffs](test/java/util/Collections/EmptyCollectionSerialization.java.udiff.html) [Sdiffs](test/java/util/Collections/EmptyCollectionSerialization.java.sdiff.html) [Frames](test/java/util/Collections/EmptyCollectionSerialization.java.frames.html) [Old](test/java/util/Collections/EmptyCollectionSerialization.java-.html) [New](test/java/util/Collections/EmptyCollectionSerialization.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/EmptyCollectionSerialization.java) test/java/util/Collections/EmptyCollectionSerialization.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

49 lines changed: 39 ins; 0 del; 10 mod; 50 unchg

[Cdiffs](test/java/util/Map/Defaults.java.cdiff.html) [Udiffs](test/java/util/Map/Defaults.java.udiff.html) [Sdiffs](test/java/util/Map/Defaults.java.sdiff.html) [Frames](test/java/util/Map/Defaults.java.frames.html) [Old](test/java/util/Map/Defaults.java-.html) [New](test/java/util/Map/Defaults.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Map/Defaults.java) test/java/util/Map/Defaults.java

rev 7360 : 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap Reviewed-by: forax, duigou, psandoz Contributed-by: Mike Duigou mike.duigou@oracle.com, Remi Forax forax@univ-mlv.fr

169 lines changed: 102 ins; 8 del; 59 mod; 527 unchg

[Cdiffs](test/java/util/NavigableMap/LockStep.java.cdiff.html) [Udiffs](test/java/util/NavigableMap/LockStep.java.udiff.html) [Sdiffs](test/java/util/NavigableMap/LockStep.java.sdiff.html) [Frames](test/java/util/NavigableMap/LockStep.java.frames.html) [Old](test/java/util/NavigableMap/LockStep.java-.html) [New](test/java/util/NavigableMap/LockStep.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/NavigableMap/LockStep.java) test/java/util/NavigableMap/LockStep.java

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

24 lines changed: 19 ins; 1 del; 4 mod; 835 unchg

[Cdiffs](test/java/util/Collections/EmptyNavigableMap.java.cdiff.html) [Udiffs](test/java/util/Collections/EmptyNavigableMap.java.udiff.html) [Sdiffs](test/java/util/Collections/EmptyNavigableMap.java.sdiff.html) [Frames](test/java/util/Collections/EmptyNavigableMap.java.frames.html) [Old](test/java/util/Collections/EmptyNavigableMap.java-.html) [New](test/java/util/Collections/EmptyNavigableMap.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/EmptyNavigableMap.java) test/java/util/Collections/EmptyNavigableMap.java (was test/java/util/Collections/EmptySortedSet.java)

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

438 lines changed: 178 ins; 156 del; 104 mod; 91 unchg

[Cdiffs](test/java/util/Collections/EmptyNavigableSet.java.cdiff.html) [Udiffs](test/java/util/Collections/EmptyNavigableSet.java.udiff.html) [Sdiffs](test/java/util/Collections/EmptyNavigableSet.java.sdiff.html) [Frames](test/java/util/Collections/EmptyNavigableSet.java.frames.html) [Old](test/java/util/Collections/EmptyNavigableSet.java-.html) [New](test/java/util/Collections/EmptyNavigableSet.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/EmptyNavigableSet.java) test/java/util/Collections/EmptyNavigableSet.java (was test/java/util/Collections/EmptySortedSet.java)

rev 7361 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks

389 lines changed: 163 ins; 104 del; 122 mod; 125 unchg

This code review page was prepared using ../make/scripts/webrev.ksh(vers 24.0-hg+jbs).