jdk (original) (raw)
Code Review for jdk
Prepared by: | mduigou on Tue Jun 18 17:46:07 PDT 2013 |
---|---|
Workspace: | /home/mike/code/jdk/tl8/jdk |
Compare against: | ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk |
Compare against version: | 7460 |
Summary of changes: | 2206 lines changed: 1369 ins; 443 del; 394 mod; 8260 unchg |
Changeset: | <jdk.changeset> |
Bug id: | JDK-7129185 : (coll) Please add Collections.emptyNavigableSet() |
Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/classes/java/util/AbstractMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/AbstractMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/AbstractMap.java.sdiff.html) [Frames](src/share/classes/java/util/AbstractMap.java.frames.html) [Old](src/share/classes/java/util/AbstractMap.java-.html) [New](src/share/classes/java/util/AbstractMap.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/AbstractMap.java)
src/share/classes/java/util/AbstractMap.java
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
2 lines changed: 2 ins; 0 del; 0 mod; 822 unchg
[Cdiffs](src/share/classes/java/util/Collections.java.cdiff.html) [Udiffs](src/share/classes/java/util/Collections.java.udiff.html) [Sdiffs](src/share/classes/java/util/Collections.java.sdiff.html) [Frames](src/share/classes/java/util/Collections.java.frames.html) [Old](src/share/classes/java/util/Collections.java-.html) [New](src/share/classes/java/util/Collections.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/Collections.java)
src/share/classes/java/util/Collections.java
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
967 lines changed: 808 ins; 103 del; 56 mod; 4563 unchg
[Cdiffs](src/share/classes/java/util/NavigableSet.java.cdiff.html) [Udiffs](src/share/classes/java/util/NavigableSet.java.udiff.html) [Sdiffs](src/share/classes/java/util/NavigableSet.java.sdiff.html) [Frames](src/share/classes/java/util/NavigableSet.java.frames.html) [Old](src/share/classes/java/util/NavigableSet.java-.html) [New](src/share/classes/java/util/NavigableSet.java.html) -----[Raw](raw%5Ffiles/new/src/share/classes/java/util/NavigableSet.java)
src/share/classes/java/util/NavigableSet.java
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
1 line changed: 0 ins; 0 del; 1 mod; 318 unchg
[Cdiffs](test/java/util/Collection/MOAT.java.cdiff.html) [Udiffs](test/java/util/Collection/MOAT.java.udiff.html) [Sdiffs](test/java/util/Collection/MOAT.java.sdiff.html) [Frames](test/java/util/Collection/MOAT.java.frames.html) [Old](test/java/util/Collection/MOAT.java-.html) [New](test/java/util/Collection/MOAT.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collection/MOAT.java)
test/java/util/Collection/MOAT.java
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
24 lines changed: 24 ins; 0 del; 0 mod; 1258 unchg
[Cdiffs](test/java/util/Collections/CheckedIdentityMap.java.cdiff.html) [Udiffs](test/java/util/Collections/CheckedIdentityMap.java.udiff.html) [Sdiffs](test/java/util/Collections/CheckedIdentityMap.java.sdiff.html) [Frames](test/java/util/Collections/CheckedIdentityMap.java.frames.html) [Old](test/java/util/Collections/CheckedIdentityMap.java-.html) [New](test/java/util/Collections/CheckedIdentityMap.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/CheckedIdentityMap.java)
test/java/util/Collections/CheckedIdentityMap.java
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
42 lines changed: 10 ins; 27 del; 5 mod; 50 unchg
[Cdiffs](test/java/util/Collections/CheckedMapBash.java.cdiff.html) [Udiffs](test/java/util/Collections/CheckedMapBash.java.udiff.html) [Sdiffs](test/java/util/Collections/CheckedMapBash.java.sdiff.html) [Frames](test/java/util/Collections/CheckedMapBash.java.frames.html) [Old](test/java/util/Collections/CheckedMapBash.java-.html) [New](test/java/util/Collections/CheckedMapBash.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/CheckedMapBash.java)
test/java/util/Collections/CheckedMapBash.java
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
141 lines changed: 72 ins; 45 del; 24 mod; 80 unchg
[Cdiffs](test/java/util/Collections/CheckedSetBash.java.cdiff.html) [Udiffs](test/java/util/Collections/CheckedSetBash.java.udiff.html) [Sdiffs](test/java/util/Collections/CheckedSetBash.java.sdiff.html) [Frames](test/java/util/Collections/CheckedSetBash.java.frames.html) [Old](test/java/util/Collections/CheckedSetBash.java-.html) [New](test/java/util/Collections/CheckedSetBash.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/CheckedSetBash.java)
test/java/util/Collections/CheckedSetBash.java
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
107 lines changed: 33 ins; 7 del; 67 mod; 69 unchg
[Cdiffs](test/java/util/Collections/EmptyCollectionSerialization.java.cdiff.html) [Udiffs](test/java/util/Collections/EmptyCollectionSerialization.java.udiff.html) [Sdiffs](test/java/util/Collections/EmptyCollectionSerialization.java.sdiff.html) [Frames](test/java/util/Collections/EmptyCollectionSerialization.java.frames.html) [Old](test/java/util/Collections/EmptyCollectionSerialization.java-.html) [New](test/java/util/Collections/EmptyCollectionSerialization.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/EmptyCollectionSerialization.java)
test/java/util/Collections/EmptyCollectionSerialization.java
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
49 lines changed: 39 ins; 0 del; 10 mod; 50 unchg
[Cdiffs](test/java/util/NavigableMap/LockStep.java.cdiff.html) [Udiffs](test/java/util/NavigableMap/LockStep.java.udiff.html) [Sdiffs](test/java/util/NavigableMap/LockStep.java.sdiff.html) [Frames](test/java/util/NavigableMap/LockStep.java.frames.html) [Old](test/java/util/NavigableMap/LockStep.java-.html) [New](test/java/util/NavigableMap/LockStep.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/NavigableMap/LockStep.java)
test/java/util/NavigableMap/LockStep.java
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
46 lines changed: 40 ins; 1 del; 5 mod; 834 unchg
[Cdiffs](test/java/util/Collections/EmptyNavigableMap.java.cdiff.html) [Udiffs](test/java/util/Collections/EmptyNavigableMap.java.udiff.html) [Sdiffs](test/java/util/Collections/EmptyNavigableMap.java.sdiff.html) [Frames](test/java/util/Collections/EmptyNavigableMap.java.frames.html) [Old](test/java/util/Collections/EmptyNavigableMap.java-.html) [New](test/java/util/Collections/EmptyNavigableMap.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/EmptyNavigableMap.java)
test/java/util/Collections/EmptyNavigableMap.java (was test/java/util/Collections/EmptySortedSet.java)
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
438 lines changed: 178 ins; 156 del; 104 mod; 91 unchg
[Cdiffs](test/java/util/Collections/EmptyNavigableSet.java.cdiff.html) [Udiffs](test/java/util/Collections/EmptyNavigableSet.java.udiff.html) [Sdiffs](test/java/util/Collections/EmptyNavigableSet.java.sdiff.html) [Frames](test/java/util/Collections/EmptyNavigableSet.java.frames.html) [Old](test/java/util/Collections/EmptyNavigableSet.java-.html) [New](test/java/util/Collections/EmptyNavigableSet.java.html) -----[Raw](raw%5Ffiles/new/test/java/util/Collections/EmptyNavigableSet.java)
test/java/util/Collections/EmptyNavigableSet.java (was test/java/util/Collections/EmptySortedSet.java)
rev 7461 : 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks
389 lines changed: 163 ins; 104 del; 122 mod; 125 unchg
This code review page was prepared using ../make/scripts/webrev.ksh(vers 24.0-hg+jbs).