jdk (original) (raw)
Code Review for jdk
| Prepared by: | mduigou on Mon Mar 4 11:57:40 PST 2013 |
|---|---|
| Workspace: | /home/mike/code/jdk/jdk7u-dev/jdk |
| Compare against: | ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk |
| Compare against version: | 5809 |
| Summary of changes: | 91 lines changed: 42 ins; 29 del; 20 mod; 2622 unchg |
| Patch of changes: | <jdk.patch> |
| Bug id: | JDK-8006593 : Initialization bottleneck in Maps due to use of j.u.Random |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/classes/java/util/HashMap.java.cdiff.html) [Udiffs](src/share/classes/java/util/HashMap.java.udiff.html) [Sdiffs](src/share/classes/java/util/HashMap.java.sdiff.html) [Frames](src/share/classes/java/util/HashMap.java.frames.html) [Old](src/share/classes/java/util/HashMap.java-.html) [New](src/share/classes/java/util/HashMap.java.html) [Patch](src/share/classes/java/util/HashMap.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/HashMap.java) src/share/classes/java/util/HashMap.java
rev 5810 : 8006593: Performance and compatibility improvements to hash based Map implementations. Summary: Use ThreadLocalRandom for hash seed rather than shared Random. Initialize {HashMap|Hashtable}.hashSeed only as needed. Minor optimizations. Reviewed-by: alanb, bchristi
35 lines changed: 20 ins; 6 del; 9 mod; 1148 unchg
[Cdiffs](src/share/classes/java/util/Hashtable.java.cdiff.html) [Udiffs](src/share/classes/java/util/Hashtable.java.udiff.html) [Sdiffs](src/share/classes/java/util/Hashtable.java.sdiff.html) [Frames](src/share/classes/java/util/Hashtable.java.frames.html) [Old](src/share/classes/java/util/Hashtable.java-.html) [New](src/share/classes/java/util/Hashtable.java.html) [Patch](src/share/classes/java/util/Hashtable.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/util/Hashtable.java) src/share/classes/java/util/Hashtable.java
rev 5810 : 8006593: Performance and compatibility improvements to hash based Map implementations. Summary: Use ThreadLocalRandom for hash seed rather than shared Random. Initialize {HashMap|Hashtable}.hashSeed only as needed. Minor optimizations. Reviewed-by: alanb, bchristi
35 lines changed: 15 ins; 11 del; 9 mod; 1214 unchg
[Cdiffs](src/share/classes/sun/misc/Hashing.java.cdiff.html) [Udiffs](src/share/classes/sun/misc/Hashing.java.udiff.html) [Sdiffs](src/share/classes/sun/misc/Hashing.java.sdiff.html) [Frames](src/share/classes/sun/misc/Hashing.java.frames.html) [Old](src/share/classes/sun/misc/Hashing.java-.html) [New](src/share/classes/sun/misc/Hashing.java.html) [Patch](src/share/classes/sun/misc/Hashing.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/misc/Hashing.java) src/share/classes/sun/misc/Hashing.java
rev 5810 : 8006593: Performance and compatibility improvements to hash based Map implementations. Summary: Use ThreadLocalRandom for hash seed rather than shared Random. Initialize {HashMap|Hashtable}.hashSeed only as needed. Minor optimizations. Reviewed-by: alanb, bchristi
21 lines changed: 7 ins; 12 del; 2 mod; 260 unchg
This code review page was prepared using ../make/scripts/webrev.ksh(vers 23.18-hg+jbs).