jdk (original) (raw)

Code Review for jdk

Prepared by: mduigou on Mon Apr 29 18:58:17 PDT 2013
Workspace: /home/mike/code/jdk/tl8/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk
Compare against version: -2
Summary of changes: 40 lines changed: 18 ins; 0 del; 22 mod; 687 unchg
Patch of changes: <jdk.patch>
Bug id: JDK-8011814 : Add testng.jar to Netbeans projects test compile classpath
Legend: Modified file Deleted file New file

[Cdiffs](make/netbeans/common/closed-share-sources.ent.cdiff.html) [Udiffs](make/netbeans/common/closed-share-sources.ent.udiff.html) [Sdiffs](make/netbeans/common/closed-share-sources.ent.sdiff.html) [Frames](make/netbeans/common/closed-share-sources.ent.frames.html) [Old](make/netbeans/common/closed-share-sources.ent-.html) [New](make/netbeans/common/closed-share-sources.ent.html) [Patch](make/netbeans/common/closed-share-sources.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/closed-share-sources.ent) make/netbeans/common/closed-share-sources.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

1 line changed: 1 ins; 0 del; 0 mod; 46 unchg

[Cdiffs](make/netbeans/common/demo-view.ent.cdiff.html) [Udiffs](make/netbeans/common/demo-view.ent.udiff.html) [Sdiffs](make/netbeans/common/demo-view.ent.sdiff.html) [Frames](make/netbeans/common/demo-view.ent.frames.html) [Old](make/netbeans/common/demo-view.ent-.html) [New](make/netbeans/common/demo-view.ent.html) [Patch](make/netbeans/common/demo-view.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/demo-view.ent) make/netbeans/common/demo-view.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

1 line changed: 0 ins; 0 del; 1 mod; 37 unchg

[Cdiffs](make/netbeans/common/java-data-native.ent.cdiff.html) [Udiffs](make/netbeans/common/java-data-native.ent.udiff.html) [Sdiffs](make/netbeans/common/java-data-native.ent.sdiff.html) [Frames](make/netbeans/common/java-data-native.ent.frames.html) [Old](make/netbeans/common/java-data-native.ent-.html) [New](make/netbeans/common/java-data-native.ent.html) [Patch](make/netbeans/common/java-data-native.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/java-data-native.ent) make/netbeans/common/java-data-native.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

4 lines changed: 2 ins; 0 del; 2 mod; 47 unchg

[Cdiffs](make/netbeans/common/java-data-no-native.ent.cdiff.html) [Udiffs](make/netbeans/common/java-data-no-native.ent.udiff.html) [Sdiffs](make/netbeans/common/java-data-no-native.ent.sdiff.html) [Frames](make/netbeans/common/java-data-no-native.ent.frames.html) [Old](make/netbeans/common/java-data-no-native.ent-.html) [New](make/netbeans/common/java-data-no-native.ent.html) [Patch](make/netbeans/common/java-data-no-native.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/java-data-no-native.ent) make/netbeans/common/java-data-no-native.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

2 lines changed: 1 ins; 0 del; 1 mod; 46 unchg

[Cdiffs](make/netbeans/common/jtreg-view.ent.cdiff.html) [Udiffs](make/netbeans/common/jtreg-view.ent.udiff.html) [Sdiffs](make/netbeans/common/jtreg-view.ent.sdiff.html) [Frames](make/netbeans/common/jtreg-view.ent.frames.html) [Old](make/netbeans/common/jtreg-view.ent-.html) [New](make/netbeans/common/jtreg-view.ent.html) [Patch](make/netbeans/common/jtreg-view.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/jtreg-view.ent) make/netbeans/common/jtreg-view.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

2 lines changed: 0 ins; 0 del; 2 mod; 36 unchg

[Cdiffs](make/netbeans/common/properties.ent.cdiff.html) [Udiffs](make/netbeans/common/properties.ent.udiff.html) [Sdiffs](make/netbeans/common/properties.ent.sdiff.html) [Frames](make/netbeans/common/properties.ent.frames.html) [Old](make/netbeans/common/properties.ent-.html) [New](make/netbeans/common/properties.ent.html) [Patch](make/netbeans/common/properties.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/properties.ent) make/netbeans/common/properties.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

2 lines changed: 2 ins; 0 del; 0 mod; 43 unchg

[Cdiffs](make/netbeans/common/sample-view.ent.cdiff.html) [Udiffs](make/netbeans/common/sample-view.ent.udiff.html) [Sdiffs](make/netbeans/common/sample-view.ent.sdiff.html) [Frames](make/netbeans/common/sample-view.ent.frames.html) [Old](make/netbeans/common/sample-view.ent-.html) [New](make/netbeans/common/sample-view.ent.html) [Patch](make/netbeans/common/sample-view.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/sample-view.ent) make/netbeans/common/sample-view.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

2 lines changed: 0 ins; 0 del; 2 mod; 36 unchg

[Cdiffs](make/netbeans/common/share-sources.ent.cdiff.html) [Udiffs](make/netbeans/common/share-sources.ent.udiff.html) [Sdiffs](make/netbeans/common/share-sources.ent.sdiff.html) [Frames](make/netbeans/common/share-sources.ent.frames.html) [Old](make/netbeans/common/share-sources.ent-.html) [New](make/netbeans/common/share-sources.ent.html) [Patch](make/netbeans/common/share-sources.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/share-sources.ent) make/netbeans/common/share-sources.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

1 line changed: 1 ins; 0 del; 0 mod; 44 unchg

[Cdiffs](make/netbeans/common/unix-sources.ent.cdiff.html) [Udiffs](make/netbeans/common/unix-sources.ent.udiff.html) [Sdiffs](make/netbeans/common/unix-sources.ent.sdiff.html) [Frames](make/netbeans/common/unix-sources.ent.frames.html) [Old](make/netbeans/common/unix-sources.ent-.html) [New](make/netbeans/common/unix-sources.ent.html) [Patch](make/netbeans/common/unix-sources.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/unix-sources.ent) make/netbeans/common/unix-sources.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

1 line changed: 1 ins; 0 del; 0 mod; 48 unchg

[Cdiffs](make/netbeans/common/windows-sources.ent.cdiff.html) [Udiffs](make/netbeans/common/windows-sources.ent.udiff.html) [Sdiffs](make/netbeans/common/windows-sources.ent.sdiff.html) [Frames](make/netbeans/common/windows-sources.ent.frames.html) [Old](make/netbeans/common/windows-sources.ent-.html) [New](make/netbeans/common/windows-sources.ent.html) [Patch](make/netbeans/common/windows-sources.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/windows-sources.ent) make/netbeans/common/windows-sources.ent

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

1 line changed: 1 ins; 0 del; 0 mod; 44 unchg

[Cdiffs](make/netbeans/j2se/nbproject/project.xml.cdiff.html) [Udiffs](make/netbeans/j2se/nbproject/project.xml.udiff.html) [Sdiffs](make/netbeans/j2se/nbproject/project.xml.sdiff.html) [Frames](make/netbeans/j2se/nbproject/project.xml.frames.html) [Old](make/netbeans/j2se/nbproject/project.xml-.html) [New](make/netbeans/j2se/nbproject/project.xml.html) [Patch](make/netbeans/j2se/nbproject/project.xml.patch) [Raw](raw%5Ffiles/new/make/netbeans/j2se/nbproject/project.xml) make/netbeans/j2se/nbproject/project.xml

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

5 lines changed: 4 ins; 0 del; 1 mod; 102 unchg

[Cdiffs](make/netbeans/world/nbproject/project.xml.cdiff.html) [Udiffs](make/netbeans/world/nbproject/project.xml.udiff.html) [Sdiffs](make/netbeans/world/nbproject/project.xml.sdiff.html) [Frames](make/netbeans/world/nbproject/project.xml.frames.html) [Old](make/netbeans/world/nbproject/project.xml-.html) [New](make/netbeans/world/nbproject/project.xml.html) [Patch](make/netbeans/world/nbproject/project.xml.patch) [Raw](raw%5Ffiles/new/make/netbeans/world/nbproject/project.xml) make/netbeans/world/nbproject/project.xml

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

5 lines changed: 4 ins; 0 del; 1 mod; 79 unchg

[Cdiffs](make/netbeans/common/macosx-sources.ent.cdiff.html) [Udiffs](make/netbeans/common/macosx-sources.ent.udiff.html) [Sdiffs](make/netbeans/common/macosx-sources.ent.sdiff.html) [Frames](make/netbeans/common/macosx-sources.ent.frames.html) [Old](make/netbeans/common/macosx-sources.ent-.html) [New](make/netbeans/common/macosx-sources.ent.html) [Patch](make/netbeans/common/macosx-sources.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/macosx-sources.ent) make/netbeans/common/macosx-sources.ent (was make/netbeans/common/unix-sources.ent)

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

8 lines changed: 1 ins; 0 del; 7 mod; 41 unchg

[Cdiffs](make/netbeans/common/macosx-view.ent.cdiff.html) [Udiffs](make/netbeans/common/macosx-view.ent.udiff.html) [Sdiffs](make/netbeans/common/macosx-view.ent.sdiff.html) [Frames](make/netbeans/common/macosx-view.ent.frames.html) [Old](make/netbeans/common/macosx-view.ent-.html) [New](make/netbeans/common/macosx-view.ent.html) [Patch](make/netbeans/common/macosx-view.ent.patch) [Raw](raw%5Ffiles/new/make/netbeans/common/macosx-view.ent) make/netbeans/common/macosx-view.ent (was make/netbeans/common/unix-view.ent)

rev 7018 : 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: duke

5 lines changed: 0 ins; 0 del; 5 mod; 38 unchg


This code review page was prepared using /home/mike/code/jdk/tl8/make/scripts/webrev.ksh(vers 24.0-hg+jbs).