hotspot (original) (raw)
Code Review for hotspot
| Prepared by: | Michael Haupt michael.haupt@oracle.com on Thu Jul 9 16:41:55 CEST 2015/michael.haupt@oracle.com |
|---|---|
| Workspace: | /Users/haupt/JPG/hs-comp/hotspot |
| Compare against version: | 8631 |
| Summary of changes: | 1880 lines changed: 1530 ins; 89 del; 261 mod; 4262 unchg |
| Changeset: | <hotspot.changeset> |
| Bug id: | JDK-6900757 |
| Legend: | Modified file Deleted file New file |
[Cdiffs](.hgignore.cdiff.html) [Udiffs](.hgignore.udiff.html) [Sdiffs](.hgignore.sdiff.html) [Frames](.hgignore.frames.html) [Old](.hgignore-.html) [New](.hgignore.html) -----[Raw](raw%5Ffiles/new/.hgignore) .hgignore
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
1 line changed: 1 ins; 0 del; 0 mod; 12 unchg
[Cdiffs](src/share/tools/LogCompilation/Makefile.cdiff.html) [Udiffs](src/share/tools/LogCompilation/Makefile.udiff.html) [Sdiffs](src/share/tools/LogCompilation/Makefile.sdiff.html) [Frames](src/share/tools/LogCompilation/Makefile.frames.html) [Old](src/share/tools/LogCompilation/Makefile-.html) [New](src/share/tools/LogCompilation/Makefile.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/Makefile) src/share/tools/LogCompilation/Makefile
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
2 lines changed: 0 ins; 0 del; 2 mod; 73 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/BasicLogEvent.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/BasicLogEvent.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/BasicLogEvent.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/BasicLogEvent.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/BasicLogEvent.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/BasicLogEvent.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/BasicLogEvent.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/BasicLogEvent.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
30 lines changed: 20 ins; 1 del; 9 mod; 65 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
147 lines changed: 107 ins; 20 del; 20 mod; 244 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Compilation.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Compilation.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Compilation.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Compilation.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Compilation.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Compilation.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Compilation.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Compilation.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
134 lines changed: 110 ins; 2 del; 22 mod; 232 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCleanupReader.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCleanupReader.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCleanupReader.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCleanupReader.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCleanupReader.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCleanupReader.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCleanupReader.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCleanupReader.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
25 lines changed: 8 ins; 3 del; 14 mod; 195 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
375 lines changed: 339 ins; 9 del; 27 mod; 145 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogEvent.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogEvent.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogEvent.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogEvent.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogEvent.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogEvent.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogEvent.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogEvent.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
21 lines changed: 18 ins; 1 del; 2 mod; 35 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
850 lines changed: 672 ins; 43 del; 135 mod; 488 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/MakeNotEntrantEvent.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/MakeNotEntrantEvent.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/MakeNotEntrantEvent.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/MakeNotEntrantEvent.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/MakeNotEntrantEvent.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/MakeNotEntrantEvent.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/MakeNotEntrantEvent.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/MakeNotEntrantEvent.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
15 lines changed: 12 ins; 1 del; 2 mod; 52 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Method.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Method.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Method.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Method.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Method.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Method.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Method.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Method.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
70 lines changed: 60 ins; 1 del; 9 mod; 120 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/NMethod.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/NMethod.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/NMethod.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/NMethod.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/NMethod.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/NMethod.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/NMethod.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/NMethod.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
13 lines changed: 11 ins; 0 del; 2 mod; 58 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
26 lines changed: 22 ins; 0 del; 4 mod; 78 unchg
[Cdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrapEvent.java.cdiff.html) [Udiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrapEvent.java.udiff.html) [Sdiffs](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrapEvent.java.sdiff.html) [Frames](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrapEvent.java.frames.html) [Old](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrapEvent.java-.html) [New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrapEvent.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrapEvent.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrapEvent.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
90 lines changed: 71 ins; 8 del; 11 mod; 65 unchg
[Cdiffs](src/share/vm/compiler/compileBroker.cpp.cdiff.html) [Udiffs](src/share/vm/compiler/compileBroker.cpp.udiff.html) [Sdiffs](src/share/vm/compiler/compileBroker.cpp.sdiff.html) [Frames](src/share/vm/compiler/compileBroker.cpp.frames.html) [Old](src/share/vm/compiler/compileBroker.cpp-.html) [New](src/share/vm/compiler/compileBroker.cpp.html) -----[Raw](raw%5Ffiles/new/src/share/vm/compiler/compileBroker.cpp) src/share/vm/compiler/compileBroker.cpp
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
2 lines changed: 0 ins; 0 del; 2 mod; 2400 unchg
------ ------ ------ ------ ---[New](src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrap.java.html) -----[Raw](raw%5Ffiles/new/src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrap.java) src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/UncommonTrap.java
rev 8632 : 6900757: minor bug fixes to LogCompilation tool
- improve internal error reporting (point to XML element causing trouble)
- fix comparator for sorting by name and start
- make tool more robust wrt. incorrect options and files not found
- make inlining decision output more clear
- adopt uncommon traps history printing
- properly mention compiler in generated logs
- add options for printing time stamps and omitting compilation IDs
- add option for comparing compilation logs
- overall code cleanup and API documentation
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using /Users/haupt/JPG/webrev/webrev.ksh(vers 25.7-hg+openjdk.java.net).