langtools (original) (raw)

Code Review for langtools

Prepared by: ohrstrom on Tue Jul 10 23:52:49 CEST 2012
Workspace: /home/fohrstro/langtools
Compare against: http://hg.openjdk.java.net/jdk8/tl/langtools
Summary of changes: 4905 lines changed: 4890 ins; 8 del; 7 mod; 6983 unchg
Patch of changes: <langtools.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/com/sun/tools/javac/Main.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/javac/Main.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/javac/Main.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/javac/Main.java.frames.html) [Old](src/share/classes/com/sun/tools/javac/Main.java-.html) [New](src/share/classes/com/sun/tools/javac/Main.java.html) [Patch](src/share/classes/com/sun/tools/javac/Main.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/Main.java) src/share/classes/com/sun/tools/javac/Main.java

14 lines changed: 12 ins; 0 del; 2 mod; 94 unchg

[Cdiffs](src/share/classes/com/sun/tools/javac/api/JavacTool.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/javac/api/JavacTool.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/javac/api/JavacTool.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/javac/api/JavacTool.java.frames.html) [Old](src/share/classes/com/sun/tools/javac/api/JavacTool.java-.html) [New](src/share/classes/com/sun/tools/javac/api/JavacTool.java.html) [Patch](src/share/classes/com/sun/tools/javac/api/JavacTool.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/api/JavacTool.java) src/share/classes/com/sun/tools/javac/api/JavacTool.java

3 lines changed: 0 ins; 0 del; 3 mod; 249 unchg

[Cdiffs](src/share/classes/com/sun/tools/javac/comp/Resolve.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/javac/comp/Resolve.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/javac/comp/Resolve.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/javac/comp/Resolve.java.frames.html) [Old](src/share/classes/com/sun/tools/javac/comp/Resolve.java-.html) [New](src/share/classes/com/sun/tools/javac/comp/Resolve.java.html) [Patch](src/share/classes/com/sun/tools/javac/comp/Resolve.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/comp/Resolve.java) src/share/classes/com/sun/tools/javac/comp/Resolve.java

8 lines changed: 7 ins; 0 del; 1 mod; 2749 unchg

[Cdiffs](src/share/classes/com/sun/tools/javac/file/JavacFileManager.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/javac/file/JavacFileManager.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/javac/file/JavacFileManager.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/javac/file/JavacFileManager.java.frames.html) [Old](src/share/classes/com/sun/tools/javac/file/JavacFileManager.java-.html) [New](src/share/classes/com/sun/tools/javac/file/JavacFileManager.java.html) [Patch](src/share/classes/com/sun/tools/javac/file/JavacFileManager.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/file/JavacFileManager.java) src/share/classes/com/sun/tools/javac/file/JavacFileManager.java

8 lines changed: 8 ins; 0 del; 0 mod; 874 unchg

[Cdiffs](src/share/classes/com/sun/tools/javac/main/JavaCompiler.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/javac/main/JavaCompiler.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/javac/main/JavaCompiler.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/javac/main/JavaCompiler.java.frames.html) [Old](src/share/classes/com/sun/tools/javac/main/JavaCompiler.java-.html) [New](src/share/classes/com/sun/tools/javac/main/JavaCompiler.java.html) [Patch](src/share/classes/com/sun/tools/javac/main/JavaCompiler.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/main/JavaCompiler.java) src/share/classes/com/sun/tools/javac/main/JavaCompiler.java

25 lines changed: 24 ins; 0 del; 1 mod; 1660 unchg

[Cdiffs](src/share/classes/com/sun/tools/javac/main/Main.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/javac/main/Main.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/javac/main/Main.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/javac/main/Main.java.frames.html) [Old](src/share/classes/com/sun/tools/javac/main/Main.java-.html) [New](src/share/classes/com/sun/tools/javac/main/Main.java.html) [Patch](src/share/classes/com/sun/tools/javac/main/Main.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/main/Main.java) src/share/classes/com/sun/tools/javac/main/Main.java

11 lines changed: 11 ins; 0 del; 0 mod; 609 unchg

[Cdiffs](src/share/classes/com/sun/tools/javac/util/Log.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/javac/util/Log.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/javac/util/Log.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/javac/util/Log.java.frames.html) [Old](src/share/classes/com/sun/tools/javac/util/Log.java-.html) [New](src/share/classes/com/sun/tools/javac/util/Log.java.html) [Patch](src/share/classes/com/sun/tools/javac/util/Log.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/util/Log.java) src/share/classes/com/sun/tools/javac/util/Log.java

11 lines changed: 11 ins; 0 del; 0 mod; 630 unchg

[Cdiffs](src/share/classes/com/sun/tools/javah/JavahFileManager.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/javah/JavahFileManager.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/javah/JavahFileManager.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/javah/JavahFileManager.java.frames.html) [Old](src/share/classes/com/sun/tools/javah/JavahFileManager.java-.html) [New](src/share/classes/com/sun/tools/javah/JavahFileManager.java.html) [Patch](src/share/classes/com/sun/tools/javah/JavahFileManager.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javah/JavahFileManager.java) src/share/classes/com/sun/tools/javah/JavahFileManager.java

4 lines changed: 0 ins; 4 del; 0 mod; 59 unchg

[Cdiffs](src/share/classes/com/sun/tools/javap/JavapFileManager.java.cdiff.html) [Udiffs](src/share/classes/com/sun/tools/javap/JavapFileManager.java.udiff.html) [Sdiffs](src/share/classes/com/sun/tools/javap/JavapFileManager.java.sdiff.html) [Frames](src/share/classes/com/sun/tools/javap/JavapFileManager.java.frames.html) [Old](src/share/classes/com/sun/tools/javap/JavapFileManager.java-.html) [New](src/share/classes/com/sun/tools/javap/JavapFileManager.java.html) [Patch](src/share/classes/com/sun/tools/javap/JavapFileManager.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javap/JavapFileManager.java) src/share/classes/com/sun/tools/javap/JavapFileManager.java

4 lines changed: 0 ins; 4 del; 0 mod; 59 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/comp/ApiVisitor.java.html) [Patch](src/share/classes/com/sun/tools/javac/comp/ApiVisitor.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/comp/ApiVisitor.java) src/share/classes/com/sun/tools/javac/comp/ApiVisitor.java

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/comp/Dependencies.java.html) [Patch](src/share/classes/com/sun/tools/javac/comp/Dependencies.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/comp/Dependencies.java) src/share/classes/com/sun/tools/javac/comp/Dependencies.java

202 lines changed: 202 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/comp/PubapiVisitor.java.html) [Patch](src/share/classes/com/sun/tools/javac/comp/PubapiVisitor.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/comp/PubapiVisitor.java) src/share/classes/com/sun/tools/javac/comp/PubapiVisitor.java

92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/server/JavacServer.java.html) [Patch](src/share/classes/com/sun/tools/javac/server/JavacServer.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/server/JavacServer.java) src/share/classes/com/sun/tools/javac/server/JavacServer.java

980 lines changed: 980 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/BuildState.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/BuildState.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/BuildState.java) src/share/classes/com/sun/tools/javac/smart/BuildState.java

188 lines changed: 188 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/CleanProperties.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/CleanProperties.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/CleanProperties.java) src/share/classes/com/sun/tools/javac/smart/CleanProperties.java

143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/CompileJavaPackages.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/CompileJavaPackages.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/CompileJavaPackages.java) src/share/classes/com/sun/tools/javac/smart/CompileJavaPackages.java

150 lines changed: 150 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/CompileProperties.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/CompileProperties.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/CompileProperties.java) src/share/classes/com/sun/tools/javac/smart/CompileProperties.java

220 lines changed: 220 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/CopyFile.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/CopyFile.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/CopyFile.java) src/share/classes/com/sun/tools/javac/smart/CopyFile.java

109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/JavacState.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/JavacState.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/JavacState.java) src/share/classes/com/sun/tools/javac/smart/JavacState.java

715 lines changed: 715 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/Log.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/Log.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/Log.java) src/share/classes/com/sun/tools/javac/smart/Log.java

57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/Main.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/Main.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/Main.java) src/share/classes/com/sun/tools/javac/smart/Main.java

686 lines changed: 686 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/Module.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/Module.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/Module.java) src/share/classes/com/sun/tools/javac/smart/Module.java

127 lines changed: 127 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/Package.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/Package.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/Package.java) src/share/classes/com/sun/tools/javac/smart/Package.java

267 lines changed: 267 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/ProblemException.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/ProblemException.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/ProblemException.java) src/share/classes/com/sun/tools/javac/smart/ProblemException.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/Source.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/Source.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/Source.java) src/share/classes/com/sun/tools/javac/smart/Source.java

312 lines changed: 312 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/SyntaxException.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/SyntaxException.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/SyntaxException.java) src/share/classes/com/sun/tools/javac/smart/SyntaxException.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/Transformer.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/Transformer.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/Transformer.java) src/share/classes/com/sun/tools/javac/smart/Transformer.java

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/smart/Util.java.html) [Patch](src/share/classes/com/sun/tools/javac/smart/Util.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/smart/Util.java) src/share/classes/com/sun/tools/javac/smart/Util.java

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/util/OptionParser.java.html) [Patch](src/share/classes/com/sun/tools/javac/util/OptionParser.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/util/OptionParser.java) src/share/classes/com/sun/tools/javac/util/OptionParser.java

75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/tools/javac/util/SmartFileManager.java.html) [Patch](src/share/classes/com/sun/tools/javac/util/SmartFileManager.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/tools/javac/util/SmartFileManager.java) src/share/classes/com/sun/tools/javac/util/SmartFileManager.java

191 lines changed: 191 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/fohrstro/bin/webrev(vers 23.18-hg).