jdk (original) (raw)

Code Review for jdk

Prepared by: Omair Majid omajid@redhat.com on Thu Feb 20 17:00:56 EST 2014/omajid@redhat.com
Workspace: /home/omajid/devel/jdk9-client/jdk
Compare against: ssh://hg.openjdk.java.net/jdk9/client/jdk
Summary of changes: 22 lines changed: 8 ins; 0 del; 14 mod; 37266 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](make/lib/Awt2dLibraries.gmk.cdiff.html) [Udiffs](make/lib/Awt2dLibraries.gmk.udiff.html) [Wdiffs](make/lib/Awt2dLibraries.gmk.wdiff.html) [Sdiffs](make/lib/Awt2dLibraries.gmk.sdiff.html) [Frames](make/lib/Awt2dLibraries.gmk.frames.html) [Old](make/lib/Awt2dLibraries.gmk-.html) [New](make/lib/Awt2dLibraries.gmk.html) [Patch](make/lib/Awt2dLibraries.gmk.patch) [Raw](raw%5Ffiles/new/make/lib/Awt2dLibraries.gmk) make/lib/Awt2dLibraries.gmk

21 lines changed: 8 ins; 0 del; 13 mod; 1505 unchg

[Cdiffs](src/share/classes/sun/java2d/cmm/lcms/LCMS.java.cdiff.html) [Udiffs](src/share/classes/sun/java2d/cmm/lcms/LCMS.java.udiff.html) [Wdiffs](src/share/classes/sun/java2d/cmm/lcms/LCMS.java.wdiff.html) [Sdiffs](src/share/classes/sun/java2d/cmm/lcms/LCMS.java.sdiff.html) [Frames](src/share/classes/sun/java2d/cmm/lcms/LCMS.java.frames.html) [Old](src/share/classes/sun/java2d/cmm/lcms/LCMS.java-.html) [New](src/share/classes/sun/java2d/cmm/lcms/LCMS.java.html) [Patch](src/share/classes/sun/java2d/cmm/lcms/LCMS.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/java2d/cmm/lcms/LCMS.java) src/share/classes/sun/java2d/cmm/lcms/LCMS.java

1 line changed: 0 ins; 0 del; 1 mod; 220 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmscam02.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmscam02.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmscam02.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmscam02.c (was src/share/native/sun/java2d/cmm/lcms/cmscam02.c)

0 lines changed: 0 ins; 0 del; 0 mod; 512 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmscgats.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmscgats.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmscgats.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmscgats.c (was src/share/native/sun/java2d/cmm/lcms/cmscgats.c)

0 lines changed: 0 ins; 0 del; 0 mod; 2785 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmscnvrt.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmscnvrt.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmscnvrt.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmscnvrt.c (was src/share/native/sun/java2d/cmm/lcms/cmscnvrt.c)

0 lines changed: 0 ins; 0 del; 0 mod; 1090 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmserr.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmserr.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmserr.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmserr.c (was src/share/native/sun/java2d/cmm/lcms/cmserr.c)

0 lines changed: 0 ins; 0 del; 0 mod; 459 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsgamma.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsgamma.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsgamma.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsgamma.c (was src/share/native/sun/java2d/cmm/lcms/cmsgamma.c)

0 lines changed: 0 ins; 0 del; 0 mod; 1212 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsgmt.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsgmt.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsgmt.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsgmt.c (was src/share/native/sun/java2d/cmm/lcms/cmsgmt.c)

0 lines changed: 0 ins; 0 del; 0 mod; 619 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmshalf.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmshalf.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmshalf.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmshalf.c (was src/share/native/sun/java2d/cmm/lcms/cmshalf.c)

0 lines changed: 0 ins; 0 del; 0 mod; 564 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsintrp.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsintrp.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsintrp.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsintrp.c (was src/share/native/sun/java2d/cmm/lcms/cmsintrp.c)

0 lines changed: 0 ins; 0 del; 0 mod; 1509 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsio0.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsio0.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsio0.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsio0.c (was src/share/native/sun/java2d/cmm/lcms/cmsio0.c)

0 lines changed: 0 ins; 0 del; 0 mod; 1788 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsio1.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsio1.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsio1.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsio1.c (was src/share/native/sun/java2d/cmm/lcms/cmsio1.c)

0 lines changed: 0 ins; 0 del; 0 mod; 1011 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmslut.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmslut.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmslut.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmslut.c (was src/share/native/sun/java2d/cmm/lcms/cmslut.c)

0 lines changed: 0 ins; 0 del; 0 mod; 1810 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsmd5.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsmd5.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsmd5.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsmd5.c (was src/share/native/sun/java2d/cmm/lcms/cmsmd5.c)

0 lines changed: 0 ins; 0 del; 0 mod; 346 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsmtrx.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsmtrx.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsmtrx.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsmtrx.c (was src/share/native/sun/java2d/cmm/lcms/cmsmtrx.c)

0 lines changed: 0 ins; 0 del; 0 mod; 205 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsnamed.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsnamed.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsnamed.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsnamed.c (was src/share/native/sun/java2d/cmm/lcms/cmsnamed.c)

0 lines changed: 0 ins; 0 del; 0 mod; 934 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsopt.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsopt.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsopt.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsopt.c (was src/share/native/sun/java2d/cmm/lcms/cmsopt.c)

0 lines changed: 0 ins; 0 del; 0 mod; 1734 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmspack.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmspack.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmspack.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmspack.c (was src/share/native/sun/java2d/cmm/lcms/cmspack.c)

0 lines changed: 0 ins; 0 del; 0 mod; 3251 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmspcs.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmspcs.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmspcs.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmspcs.c (was src/share/native/sun/java2d/cmm/lcms/cmspcs.c)

0 lines changed: 0 ins; 0 del; 0 mod; 956 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsplugin.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsplugin.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsplugin.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsplugin.c (was src/share/native/sun/java2d/cmm/lcms/cmsplugin.c)

0 lines changed: 0 ins; 0 del; 0 mod; 646 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsps2.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsps2.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsps2.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsps2.c (was src/share/native/sun/java2d/cmm/lcms/cmsps2.c)

0 lines changed: 0 ins; 0 del; 0 mod; 1629 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmssamp.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmssamp.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmssamp.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmssamp.c (was src/share/native/sun/java2d/cmm/lcms/cmssamp.c)

0 lines changed: 0 ins; 0 del; 0 mod; 597 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmssm.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmssm.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmssm.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmssm.c (was src/share/native/sun/java2d/cmm/lcms/cmssm.c)

0 lines changed: 0 ins; 0 del; 0 mod; 764 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmstypes.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmstypes.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmstypes.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmstypes.c (was src/share/native/sun/java2d/cmm/lcms/cmstypes.c)

0 lines changed: 0 ins; 0 del; 0 mod; 5459 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsvirt.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsvirt.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsvirt.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsvirt.c (was src/share/native/sun/java2d/cmm/lcms/cmsvirt.c)

0 lines changed: 0 ins; 0 del; 0 mod; 1182 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmswtpnt.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmswtpnt.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmswtpnt.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmswtpnt.c (was src/share/native/sun/java2d/cmm/lcms/cmswtpnt.c)

0 lines changed: 0 ins; 0 del; 0 mod; 380 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsxform.c.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/cmsxform.c.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/cmsxform.c) src/share/native/sun/java2d/cmm/lcms/lcms2/cmsxform.c (was src/share/native/sun/java2d/cmm/lcms/cmsxform.c)

0 lines changed: 0 ins; 0 del; 0 mod; 984 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2.h.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2.h.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2.h) src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2.h (was src/share/native/sun/java2d/cmm/lcms/lcms2.h)

0 lines changed: 0 ins; 0 del; 0 mod; 1848 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2%5Finternal.h.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2%5Finternal.h.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2%5Finternal.h) src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2_internal.h (was src/share/native/sun/java2d/cmm/lcms/lcms2_internal.h)

0 lines changed: 0 ins; 0 del; 0 mod; 634 unchg

------ ------ ------ ------ ------ ---[New](src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2%5Fplugin.h.html) [Patch](src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2%5Fplugin.h.patch) [Raw](raw%5Ffiles/new/src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2%5Fplugin.h) src/share/native/sun/java2d/cmm/lcms/lcms2/lcms2_plugin.h (was src/share/native/sun/java2d/cmm/lcms/lcms2_plugin.h)

0 lines changed: 0 ins; 0 del; 0 mod; 633 unchg


This code review page was prepared using /home/omajid/devel/webrev/webrev.ksh(vers 25.2-hg+openjdk.java.net).