rt (original) (raw)

Code Review for rt

Prepared by: rbackman on Wed Feb 13 13:06:52 CET 2013
Workspace: /mnt/unsafe/home/rbackman/code/ws/rt
Compare against: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/
Compare against version: 4132
Summary of changes: 160 lines changed: 92 ins; 24 del; 44 mod; 1864 unchg
Patch of changes: <rt.patch>
Legend: Modified file Deleted file New file

[Cdiffs](agent/src/os/bsd/libproc%5Fimpl.c.cdiff.html) [Udiffs](agent/src/os/bsd/libproc%5Fimpl.c.udiff.html) [Sdiffs](agent/src/os/bsd/libproc%5Fimpl.c.sdiff.html) [Frames](agent/src/os/bsd/libproc%5Fimpl.c.frames.html) [Old](agent/src/os/bsd/libproc%5Fimpl.c-.html) [New](agent/src/os/bsd/libproc%5Fimpl.c.html) [Patch](agent/src/os/bsd/libproc%5Fimpl.c.patch) [Raw](raw%5Ffiles/new/agent/src/os/bsd/libproc%5Fimpl.c) agent/src/os/bsd/libproc_impl.c

rev 4133 : 8008088: SA can hang the VM Reviewed-by: duke

9 lines changed: 8 ins; 0 del; 1 mod; 451 unchg

[Cdiffs](agent/src/os/bsd/libproc%5Fimpl.h.cdiff.html) [Udiffs](agent/src/os/bsd/libproc%5Fimpl.h.udiff.html) [Sdiffs](agent/src/os/bsd/libproc%5Fimpl.h.sdiff.html) [Frames](agent/src/os/bsd/libproc%5Fimpl.h.frames.html) [Old](agent/src/os/bsd/libproc%5Fimpl.h-.html) [New](agent/src/os/bsd/libproc%5Fimpl.h.html) [Patch](agent/src/os/bsd/libproc%5Fimpl.h.patch) [Raw](raw%5Ffiles/new/agent/src/os/bsd/libproc%5Fimpl.h) agent/src/os/bsd/libproc_impl.h

rev 4133 : 8008088: SA can hang the VM Reviewed-by: duke

2 lines changed: 1 ins; 0 del; 1 mod; 129 unchg

[Cdiffs](agent/src/os/bsd/ps%5Fproc.c.cdiff.html) [Udiffs](agent/src/os/bsd/ps%5Fproc.c.udiff.html) [Sdiffs](agent/src/os/bsd/ps%5Fproc.c.sdiff.html) [Frames](agent/src/os/bsd/ps%5Fproc.c.frames.html) [Old](agent/src/os/bsd/ps%5Fproc.c-.html) [New](agent/src/os/bsd/ps%5Fproc.c.html) [Patch](agent/src/os/bsd/ps%5Fproc.c.patch) [Raw](raw%5Ffiles/new/agent/src/os/bsd/ps%5Fproc.c) agent/src/os/bsd/ps_proc.c

rev 4133 : 8008088: SA can hang the VM Reviewed-by: duke

66 lines changed: 36 ins; 12 del; 18 mod; 414 unchg

[Cdiffs](agent/src/os/linux/libproc%5Fimpl.c.cdiff.html) [Udiffs](agent/src/os/linux/libproc%5Fimpl.c.udiff.html) [Sdiffs](agent/src/os/linux/libproc%5Fimpl.c.sdiff.html) [Frames](agent/src/os/linux/libproc%5Fimpl.c.frames.html) [Old](agent/src/os/linux/libproc%5Fimpl.c-.html) [New](agent/src/os/linux/libproc%5Fimpl.c.html) [Patch](agent/src/os/linux/libproc%5Fimpl.c.patch) [Raw](raw%5Ffiles/new/agent/src/os/linux/libproc%5Fimpl.c) agent/src/os/linux/libproc_impl.c

rev 4133 : 8008088: SA can hang the VM Reviewed-by: duke

9 lines changed: 8 ins; 0 del; 1 mod; 434 unchg

[Cdiffs](agent/src/os/linux/libproc%5Fimpl.h.cdiff.html) [Udiffs](agent/src/os/linux/libproc%5Fimpl.h.udiff.html) [Sdiffs](agent/src/os/linux/libproc%5Fimpl.h.sdiff.html) [Frames](agent/src/os/linux/libproc%5Fimpl.h.frames.html) [Old](agent/src/os/linux/libproc%5Fimpl.h-.html) [New](agent/src/os/linux/libproc%5Fimpl.h.html) [Patch](agent/src/os/linux/libproc%5Fimpl.h.patch) [Raw](raw%5Ffiles/new/agent/src/os/linux/libproc%5Fimpl.h) agent/src/os/linux/libproc_impl.h

rev 4133 : 8008088: SA can hang the VM Reviewed-by: duke

2 lines changed: 1 ins; 0 del; 1 mod; 127 unchg

[Cdiffs](agent/src/os/linux/ps%5Fproc.c.cdiff.html) [Udiffs](agent/src/os/linux/ps%5Fproc.c.udiff.html) [Sdiffs](agent/src/os/linux/ps%5Fproc.c.sdiff.html) [Frames](agent/src/os/linux/ps%5Fproc.c.frames.html) [Old](agent/src/os/linux/ps%5Fproc.c-.html) [New](agent/src/os/linux/ps%5Fproc.c.html) [Patch](agent/src/os/linux/ps%5Fproc.c.patch) [Raw](raw%5Ffiles/new/agent/src/os/linux/ps%5Fproc.c) agent/src/os/linux/ps_proc.c

rev 4133 : 8008088: SA can hang the VM Reviewed-by: duke

72 lines changed: 38 ins; 12 del; 22 mod; 309 unchg


This code review page was prepared using /home/rbackman/bin/webrev(vers 23.18-hg-never).