open (original) (raw)
Code Review for open
Prepared by: | redestad on Mon Jan 8 21:41:22 CET 2018 |
---|---|
Workspace: | /home/clredest/src/jdk10/open |
Compare against: | ssh://hg.openjdk.java.net/jdk/jdk |
Compare against version: | 48430 |
Summary of changes: | 645 lines changed: 387 ins; 93 del; 165 mod; 7182 unchg |
Changeset: | <open.changeset> |
Legend: | Modified file Deleted file New file |
[Cdiffs](src/java.base/share/classes/java/util/AbstractSet.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/AbstractSet.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/AbstractSet.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/AbstractSet.java.frames.html) [Old](src/java.base/share/classes/java/util/AbstractSet.java-.html) [New](src/java.base/share/classes/java/util/AbstractSet.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/AbstractSet.java)
src/java.base/share/classes/java/util/AbstractSet.java
rev 48431 : 8193128: Reduce number of implementation classes returned by List/Set/Map.of() 8191418: List.of().indexOf(null) doesn't throw NullPointerException Reviewed-by: smarks, jrose, martin, plevart
3 lines changed: 0 ins; 2 del; 1 mod; 183 unchg
[Cdiffs](src/java.base/share/classes/java/util/ImmutableCollections.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/ImmutableCollections.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/ImmutableCollections.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/ImmutableCollections.java.frames.html) [Old](src/java.base/share/classes/java/util/ImmutableCollections.java-.html) [New](src/java.base/share/classes/java/util/ImmutableCollections.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/ImmutableCollections.java)
src/java.base/share/classes/java/util/ImmutableCollections.java
rev 48431 : 8193128: Reduce number of implementation classes returned by List/Set/Map.of() 8191418: List.of().indexOf(null) doesn't throw NullPointerException Reviewed-by: smarks, jrose, martin, plevart
428 lines changed: 191 ins; 91 del; 146 mod; 729 unchg
[Cdiffs](src/java.base/share/classes/java/util/List.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/List.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/List.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/List.java.frames.html) [Old](src/java.base/share/classes/java/util/List.java-.html) [New](src/java.base/share/classes/java/util/List.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/List.java)
src/java.base/share/classes/java/util/List.java
rev 48431 : 8193128: Reduce number of implementation classes returned by List/Set/Map.of() 8191418: List.of().indexOf(null) doesn't throw NullPointerException Reviewed-by: smarks, jrose, martin, plevart
6 lines changed: 0 ins; 0 del; 6 mod; 1062 unchg
[Cdiffs](src/java.base/share/classes/java/util/Map.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/Map.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/Map.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/Map.java.frames.html) [Old](src/java.base/share/classes/java/util/Map.java-.html) [New](src/java.base/share/classes/java/util/Map.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/Map.java)
src/java.base/share/classes/java/util/Map.java
rev 48431 : 8193128: Reduce number of implementation classes returned by List/Set/Map.of() 8191418: List.of().indexOf(null) doesn't throw NullPointerException Reviewed-by: smarks, jrose, martin, plevart
3 lines changed: 0 ins; 0 del; 3 mod; 1684 unchg
[Cdiffs](src/java.base/share/classes/java/util/Set.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/Set.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/Set.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/Set.java.frames.html) [Old](src/java.base/share/classes/java/util/Set.java-.html) [New](src/java.base/share/classes/java/util/Set.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/Set.java)
src/java.base/share/classes/java/util/Set.java
rev 48431 : 8193128: Reduce number of implementation classes returned by List/Set/Map.of() 8191418: List.of().indexOf(null) doesn't throw NullPointerException Reviewed-by: smarks, jrose, martin, plevart
6 lines changed: 0 ins; 0 del; 6 mod; 724 unchg
[Cdiffs](test/jdk/java/util/Collection/MOAT.java.cdiff.html) [Udiffs](test/jdk/java/util/Collection/MOAT.java.udiff.html) [Sdiffs](test/jdk/java/util/Collection/MOAT.java.sdiff.html) [Frames](test/jdk/java/util/Collection/MOAT.java.frames.html) [Old](test/jdk/java/util/Collection/MOAT.java-.html) [New](test/jdk/java/util/Collection/MOAT.java.html) -----[Raw](raw%5Ffiles/new/test/jdk/java/util/Collection/MOAT.java)
test/jdk/java/util/Collection/MOAT.java
rev 48431 : 8193128: Reduce number of implementation classes returned by List/Set/Map.of() 8191418: List.of().indexOf(null) doesn't throw NullPointerException Reviewed-by: smarks, jrose, martin, plevart
87 lines changed: 86 ins; 0 del; 1 mod; 1690 unchg
[Cdiffs](test/jdk/java/util/Collection/SetFactories.java.cdiff.html) [Udiffs](test/jdk/java/util/Collection/SetFactories.java.udiff.html) [Sdiffs](test/jdk/java/util/Collection/SetFactories.java.sdiff.html) [Frames](test/jdk/java/util/Collection/SetFactories.java.frames.html) [Old](test/jdk/java/util/Collection/SetFactories.java-.html) [New](test/jdk/java/util/Collection/SetFactories.java.html) -----[Raw](raw%5Ffiles/new/test/jdk/java/util/Collection/SetFactories.java)
test/jdk/java/util/Collection/SetFactories.java
rev 48431 : 8193128: Reduce number of implementation classes returned by List/Set/Map.of() 8191418: List.of().indexOf(null) doesn't throw NullPointerException Reviewed-by: smarks, jrose, martin, plevart
5 lines changed: 5 ins; 0 del; 0 mod; 340 unchg
[Cdiffs](test/jdk/java/util/List/ListFactories.java.cdiff.html) [Udiffs](test/jdk/java/util/List/ListFactories.java.udiff.html) [Sdiffs](test/jdk/java/util/List/ListFactories.java.sdiff.html) [Frames](test/jdk/java/util/List/ListFactories.java.frames.html) [Old](test/jdk/java/util/List/ListFactories.java-.html) [New](test/jdk/java/util/List/ListFactories.java.html) -----[Raw](raw%5Ffiles/new/test/jdk/java/util/List/ListFactories.java)
test/jdk/java/util/List/ListFactories.java
rev 48431 : 8193128: Reduce number of implementation classes returned by List/Set/Map.of() 8191418: List.of().indexOf(null) doesn't throw NullPointerException Reviewed-by: smarks, jrose, martin, plevart
97 lines changed: 95 ins; 0 del; 2 mod; 278 unchg
[Cdiffs](test/jdk/java/util/Map/MapFactories.java.cdiff.html) [Udiffs](test/jdk/java/util/Map/MapFactories.java.udiff.html) [Sdiffs](test/jdk/java/util/Map/MapFactories.java.sdiff.html) [Frames](test/jdk/java/util/Map/MapFactories.java.frames.html) [Old](test/jdk/java/util/Map/MapFactories.java-.html) [New](test/jdk/java/util/Map/MapFactories.java.html) -----[Raw](raw%5Ffiles/new/test/jdk/java/util/Map/MapFactories.java)
test/jdk/java/util/Map/MapFactories.java
rev 48431 : 8193128: Reduce number of implementation classes returned by List/Set/Map.of() 8191418: List.of().indexOf(null) doesn't throw NullPointerException Reviewed-by: smarks, jrose, martin, plevart
10 lines changed: 10 ins; 0 del; 0 mod; 492 unchg
This code review page was prepared using /home/clredest/utils/webrev.ksh(vers 25.6-hg+openjdk.java.net).