open (original) (raw)
Code Review for open
| Prepared by: | redestad on Tue Aug 7 15:50:33 CEST 2018 |
|---|---|
| Workspace: | /home/clredest/src/jdk/open |
| Compare against: | ssh://hg.openjdk.java.net/jdk/jdk |
| Compare against version: | 51324 |
| Summary of changes: | 129 lines changed: 8 ins; 54 del; 67 mod; 12412 unchg |
| Changeset: | <open.changeset> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/java.base/share/classes/java/lang/Module.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/lang/Module.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/lang/Module.java.sdiff.html) [Frames](src/java.base/share/classes/java/lang/Module.java.frames.html) [Old](src/java.base/share/classes/java/lang/Module.java-.html) [New](src/java.base/share/classes/java/lang/Module.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/lang/Module.java) src/java.base/share/classes/java/lang/Module.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
2 lines changed: 0 ins; 1 del; 1 mod; 1632 unchg
[Cdiffs](src/java.base/share/classes/java/lang/ModuleLayer.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/lang/ModuleLayer.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/lang/ModuleLayer.java.sdiff.html) [Frames](src/java.base/share/classes/java/lang/ModuleLayer.java.frames.html) [Old](src/java.base/share/classes/java/lang/ModuleLayer.java-.html) [New](src/java.base/share/classes/java/lang/ModuleLayer.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/lang/ModuleLayer.java) src/java.base/share/classes/java/lang/ModuleLayer.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
3 lines changed: 0 ins; 1 del; 2 mod; 977 unchg
[Cdiffs](src/java.base/share/classes/java/lang/module/Configuration.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/lang/module/Configuration.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/lang/module/Configuration.java.sdiff.html) [Frames](src/java.base/share/classes/java/lang/module/Configuration.java.frames.html) [Old](src/java.base/share/classes/java/lang/module/Configuration.java-.html) [New](src/java.base/share/classes/java/lang/module/Configuration.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/lang/module/Configuration.java) src/java.base/share/classes/java/lang/module/Configuration.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
8 lines changed: 0 ins; 1 del; 7 mod; 610 unchg
[Cdiffs](src/java.base/share/classes/java/lang/module/ModuleDescriptor.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/lang/module/ModuleDescriptor.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/lang/module/ModuleDescriptor.java.sdiff.html) [Frames](src/java.base/share/classes/java/lang/module/ModuleDescriptor.java.frames.html) [Old](src/java.base/share/classes/java/lang/module/ModuleDescriptor.java-.html) [New](src/java.base/share/classes/java/lang/module/ModuleDescriptor.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/lang/module/ModuleDescriptor.java) src/java.base/share/classes/java/lang/module/ModuleDescriptor.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
82 lines changed: 3 ins; 45 del; 34 mod; 2667 unchg
[Cdiffs](src/java.base/share/classes/java/lang/module/ModuleFinder.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/lang/module/ModuleFinder.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/lang/module/ModuleFinder.java.sdiff.html) [Frames](src/java.base/share/classes/java/lang/module/ModuleFinder.java.frames.html) [Old](src/java.base/share/classes/java/lang/module/ModuleFinder.java-.html) [New](src/java.base/share/classes/java/lang/module/ModuleFinder.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/java/lang/module/ModuleFinder.java) src/java.base/share/classes/java/lang/module/ModuleFinder.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
1 line changed: 0 ins; 0 del; 1 mod; 380 unchg
[Cdiffs](src/java.base/share/classes/jdk/internal/module/Builder.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/module/Builder.java.udiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/module/Builder.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/module/Builder.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/module/Builder.java-.html) [New](src/java.base/share/classes/jdk/internal/module/Builder.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/module/Builder.java) src/java.base/share/classes/jdk/internal/module/Builder.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
7 lines changed: 0 ins; 1 del; 6 mod; 276 unchg
[Cdiffs](src/java.base/share/classes/jdk/internal/module/ExplodedSystemModules.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/module/ExplodedSystemModules.java.udiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/module/ExplodedSystemModules.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/module/ExplodedSystemModules.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/module/ExplodedSystemModules.java-.html) [New](src/java.base/share/classes/jdk/internal/module/ExplodedSystemModules.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/module/ExplodedSystemModules.java) src/java.base/share/classes/jdk/internal/module/ExplodedSystemModules.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
3 lines changed: 0 ins; 1 del; 2 mod; 79 unchg
[Cdiffs](src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java.udiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java-.html) [New](src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java) src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
3 lines changed: 0 ins; 0 del; 3 mod; 1055 unchg
[Cdiffs](src/java.base/share/classes/jdk/internal/module/ModuleInfo.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/module/ModuleInfo.java.udiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/module/ModuleInfo.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/module/ModuleInfo.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/module/ModuleInfo.java-.html) [New](src/java.base/share/classes/jdk/internal/module/ModuleInfo.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/module/ModuleInfo.java) src/java.base/share/classes/jdk/internal/module/ModuleInfo.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
4 lines changed: 0 ins; 1 del; 3 mod; 1099 unchg
[Cdiffs](src/java.base/share/classes/jdk/internal/module/ModulePatcher.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/module/ModulePatcher.java.udiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/module/ModulePatcher.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/module/ModulePatcher.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/module/ModulePatcher.java-.html) [New](src/java.base/share/classes/jdk/internal/module/ModulePatcher.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/module/ModulePatcher.java) src/java.base/share/classes/jdk/internal/module/ModulePatcher.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
2 lines changed: 0 ins; 1 del; 1 mod; 601 unchg
[Cdiffs](src/java.base/share/classes/jdk/internal/module/ModulePath.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/module/ModulePath.java.udiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/module/ModulePath.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/module/ModulePath.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/module/ModulePath.java-.html) [New](src/java.base/share/classes/jdk/internal/module/ModulePath.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/module/ModulePath.java) src/java.base/share/classes/jdk/internal/module/ModulePath.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
3 lines changed: 0 ins; 1 del; 2 mod; 785 unchg
[Cdiffs](src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java.udiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java-.html) [New](src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java) src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
2 lines changed: 0 ins; 1 del; 1 mod; 175 unchg
[Cdiffs](src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java.cdiff.html) [Udiffs](src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java.udiff.html) [Sdiffs](src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java.sdiff.html) [Frames](src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java.frames.html) [Old](src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java-.html) [New](src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java.html) -----[Raw](raw%5Ffiles/new/src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java) src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
3 lines changed: 0 ins; 0 del; 3 mod; 573 unchg
[Cdiffs](test/jdk/java/lang/module/ModuleDescriptorTest.java.cdiff.html) [Udiffs](test/jdk/java/lang/module/ModuleDescriptorTest.java.udiff.html) [Sdiffs](test/jdk/java/lang/module/ModuleDescriptorTest.java.sdiff.html) [Frames](test/jdk/java/lang/module/ModuleDescriptorTest.java.frames.html) [Old](test/jdk/java/lang/module/ModuleDescriptorTest.java-.html) [New](test/jdk/java/lang/module/ModuleDescriptorTest.java.html) -----[Raw](raw%5Ffiles/new/test/jdk/java/lang/module/ModuleDescriptorTest.java) test/jdk/java/lang/module/ModuleDescriptorTest.java
rev 51325 : 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb
6 lines changed: 5 ins; 0 del; 1 mod; 1503 unchg
This code review page was prepared using /home/clredest/utils/webrev.ksh(vers 25.6-hg+openjdk.java.net).