hotspot (original) (raw)
Code Review for hotspot
Prepared by: | roland on Mon Sep 10 12:07:57 CEST 2012 |
---|---|
Workspace: | /net/mackdrive/export/jrts/work/rw140007/permgen/hotspot |
Compare against: | http://closedjdk.us.oracle.com/hsdev/hotspot-metadata/hotspot |
Compare against version: | qparent |
Summary of changes: | 242 lines changed: 208 ins; 1 del; 33 mod; 38901 unchg |
Patch of changes: | <hotspot.patch> |
Legend: | Modified file Deleted file New file |
[Cdiffs](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.cpp.cdiff.html) [Udiffs](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.cpp.udiff.html) [Sdiffs](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.cpp.sdiff.html) [Frames](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.cpp.frames.html) [Old](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.cpp-.html) [New](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.cpp.html) [Patch](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.cpp.patch) [Raw](raw%5Ffiles/new/src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.cpp)
src/cpu/sparc/vm/c1_FrameMap_sparc.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
66 lines changed: 66 ins; 0 del; 0 mod; 371 unchg
[Cdiffs](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.hpp.cdiff.html) [Udiffs](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.hpp.udiff.html) [Sdiffs](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.hpp.sdiff.html) [Frames](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.hpp.frames.html) [Old](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.hpp-.html) [New](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.hpp.html) [Patch](src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.hpp.patch) [Raw](raw%5Ffiles/new/src/cpu/sparc/vm/c1%5FFrameMap%5Fsparc.hpp)
src/cpu/sparc/vm/c1_FrameMap_sparc.hpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
33 lines changed: 33 ins; 0 del; 0 mod; 161 unchg
[Cdiffs](src/cpu/sparc/vm/c1%5FLIRAssembler%5Fsparc.cpp.cdiff.html) [Udiffs](src/cpu/sparc/vm/c1%5FLIRAssembler%5Fsparc.cpp.udiff.html) [Sdiffs](src/cpu/sparc/vm/c1%5FLIRAssembler%5Fsparc.cpp.sdiff.html) [Frames](src/cpu/sparc/vm/c1%5FLIRAssembler%5Fsparc.cpp.frames.html) [Old](src/cpu/sparc/vm/c1%5FLIRAssembler%5Fsparc.cpp-.html) [New](src/cpu/sparc/vm/c1%5FLIRAssembler%5Fsparc.cpp.html) [Patch](src/cpu/sparc/vm/c1%5FLIRAssembler%5Fsparc.cpp.patch) [Raw](raw%5Ffiles/new/src/cpu/sparc/vm/c1%5FLIRAssembler%5Fsparc.cpp)
src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
7 lines changed: 7 ins; 0 del; 0 mod; 3437 unchg
[Cdiffs](src/cpu/sparc/vm/c1%5FLIRGenerator%5Fsparc.cpp.cdiff.html) [Udiffs](src/cpu/sparc/vm/c1%5FLIRGenerator%5Fsparc.cpp.udiff.html) [Sdiffs](src/cpu/sparc/vm/c1%5FLIRGenerator%5Fsparc.cpp.sdiff.html) [Frames](src/cpu/sparc/vm/c1%5FLIRGenerator%5Fsparc.cpp.frames.html) [Old](src/cpu/sparc/vm/c1%5FLIRGenerator%5Fsparc.cpp-.html) [New](src/cpu/sparc/vm/c1%5FLIRGenerator%5Fsparc.cpp.html) [Patch](src/cpu/sparc/vm/c1%5FLIRGenerator%5Fsparc.cpp.patch) [Raw](raw%5Ffiles/new/src/cpu/sparc/vm/c1%5FLIRGenerator%5Fsparc.cpp)
src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
8 lines changed: 1 ins; 0 del; 7 mod; 1198 unchg
[Cdiffs](src/cpu/sparc/vm/sharedRuntime%5Fsparc.cpp.cdiff.html) [Udiffs](src/cpu/sparc/vm/sharedRuntime%5Fsparc.cpp.udiff.html) [Sdiffs](src/cpu/sparc/vm/sharedRuntime%5Fsparc.cpp.sdiff.html) [Frames](src/cpu/sparc/vm/sharedRuntime%5Fsparc.cpp.frames.html) [Old](src/cpu/sparc/vm/sharedRuntime%5Fsparc.cpp-.html) [New](src/cpu/sparc/vm/sharedRuntime%5Fsparc.cpp.html) [Patch](src/cpu/sparc/vm/sharedRuntime%5Fsparc.cpp.patch) [Raw](raw%5Ffiles/new/src/cpu/sparc/vm/sharedRuntime%5Fsparc.cpp)
src/cpu/sparc/vm/sharedRuntime_sparc.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
2 lines changed: 2 ins; 0 del; 0 mod; 4117 unchg
[Cdiffs](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.cpp.cdiff.html) [Udiffs](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.cpp.udiff.html) [Sdiffs](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.cpp.sdiff.html) [Frames](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.cpp.frames.html) [Old](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.cpp-.html) [New](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.cpp.html) [Patch](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.cpp.patch) [Raw](raw%5Ffiles/new/src/cpu/x86/vm/c1%5FFrameMap%5Fx86.cpp)
src/cpu/x86/vm/c1_FrameMap_x86.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
28 lines changed: 28 ins; 0 del; 0 mod; 326 unchg
[Cdiffs](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.hpp.cdiff.html) [Udiffs](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.hpp.udiff.html) [Sdiffs](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.hpp.sdiff.html) [Frames](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.hpp.frames.html) [Old](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.hpp-.html) [New](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.hpp.html) [Patch](src/cpu/x86/vm/c1%5FFrameMap%5Fx86.hpp.patch) [Raw](raw%5Ffiles/new/src/cpu/x86/vm/c1%5FFrameMap%5Fx86.hpp)
src/cpu/x86/vm/c1_FrameMap_x86.hpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
16 lines changed: 16 ins; 0 del; 0 mod; 144 unchg
[Cdiffs](src/cpu/x86/vm/c1%5FLIRAssembler%5Fx86.cpp.cdiff.html) [Udiffs](src/cpu/x86/vm/c1%5FLIRAssembler%5Fx86.cpp.udiff.html) [Sdiffs](src/cpu/x86/vm/c1%5FLIRAssembler%5Fx86.cpp.sdiff.html) [Frames](src/cpu/x86/vm/c1%5FLIRAssembler%5Fx86.cpp.frames.html) [Old](src/cpu/x86/vm/c1%5FLIRAssembler%5Fx86.cpp-.html) [New](src/cpu/x86/vm/c1%5FLIRAssembler%5Fx86.cpp.html) [Patch](src/cpu/x86/vm/c1%5FLIRAssembler%5Fx86.cpp.patch) [Raw](raw%5Ffiles/new/src/cpu/x86/vm/c1%5FLIRAssembler%5Fx86.cpp)
src/cpu/x86/vm/c1_LIRAssembler_x86.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
11 lines changed: 11 ins; 0 del; 0 mod; 3786 unchg
[Cdiffs](src/cpu/x86/vm/c1%5FLIRGenerator%5Fx86.cpp.cdiff.html) [Udiffs](src/cpu/x86/vm/c1%5FLIRGenerator%5Fx86.cpp.udiff.html) [Sdiffs](src/cpu/x86/vm/c1%5FLIRGenerator%5Fx86.cpp.sdiff.html) [Frames](src/cpu/x86/vm/c1%5FLIRGenerator%5Fx86.cpp.frames.html) [Old](src/cpu/x86/vm/c1%5FLIRGenerator%5Fx86.cpp-.html) [New](src/cpu/x86/vm/c1%5FLIRGenerator%5Fx86.cpp.html) [Patch](src/cpu/x86/vm/c1%5FLIRGenerator%5Fx86.cpp.patch) [Raw](raw%5Ffiles/new/src/cpu/x86/vm/c1%5FLIRGenerator%5Fx86.cpp)
src/cpu/x86/vm/c1_LIRGenerator_x86.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
9 lines changed: 1 ins; 1 del; 7 mod; 1339 unchg
[Cdiffs](src/cpu/x86/vm/sharedRuntime%5Fx86%5F32.cpp.cdiff.html) [Udiffs](src/cpu/x86/vm/sharedRuntime%5Fx86%5F32.cpp.udiff.html) [Sdiffs](src/cpu/x86/vm/sharedRuntime%5Fx86%5F32.cpp.sdiff.html) [Frames](src/cpu/x86/vm/sharedRuntime%5Fx86%5F32.cpp.frames.html) [Old](src/cpu/x86/vm/sharedRuntime%5Fx86%5F32.cpp-.html) [New](src/cpu/x86/vm/sharedRuntime%5Fx86%5F32.cpp.html) [Patch](src/cpu/x86/vm/sharedRuntime%5Fx86%5F32.cpp.patch) [Raw](raw%5Ffiles/new/src/cpu/x86/vm/sharedRuntime%5Fx86%5F32.cpp)
src/cpu/x86/vm/sharedRuntime_x86_32.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
1 line changed: 1 ins; 0 del; 0 mod; 3456 unchg
[Cdiffs](src/cpu/x86/vm/sharedRuntime%5Fx86%5F64.cpp.cdiff.html) [Udiffs](src/cpu/x86/vm/sharedRuntime%5Fx86%5F64.cpp.udiff.html) [Sdiffs](src/cpu/x86/vm/sharedRuntime%5Fx86%5F64.cpp.sdiff.html) [Frames](src/cpu/x86/vm/sharedRuntime%5Fx86%5F64.cpp.frames.html) [Old](src/cpu/x86/vm/sharedRuntime%5Fx86%5F64.cpp-.html) [New](src/cpu/x86/vm/sharedRuntime%5Fx86%5F64.cpp.html) [Patch](src/cpu/x86/vm/sharedRuntime%5Fx86%5F64.cpp.patch) [Raw](raw%5Ffiles/new/src/cpu/x86/vm/sharedRuntime%5Fx86%5F64.cpp)
src/cpu/x86/vm/sharedRuntime_x86_64.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
1 line changed: 1 ins; 0 del; 0 mod; 4047 unchg
[Cdiffs](src/share/vm/c1/c1%5FFrameMap.hpp.cdiff.html) [Udiffs](src/share/vm/c1/c1%5FFrameMap.hpp.udiff.html) [Sdiffs](src/share/vm/c1/c1%5FFrameMap.hpp.sdiff.html) [Frames](src/share/vm/c1/c1%5FFrameMap.hpp.frames.html) [Old](src/share/vm/c1/c1%5FFrameMap.hpp-.html) [New](src/share/vm/c1/c1%5FFrameMap.hpp.html) [Patch](src/share/vm/c1/c1%5FFrameMap.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/c1/c1%5FFrameMap.hpp)
src/share/vm/c1/c1_FrameMap.hpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
4 lines changed: 4 ins; 0 del; 0 mod; 294 unchg
[Cdiffs](src/share/vm/c1/c1%5FLIR.cpp.cdiff.html) [Udiffs](src/share/vm/c1/c1%5FLIR.cpp.udiff.html) [Sdiffs](src/share/vm/c1/c1%5FLIR.cpp.sdiff.html) [Frames](src/share/vm/c1/c1%5FLIR.cpp.frames.html) [Old](src/share/vm/c1/c1%5FLIR.cpp-.html) [New](src/share/vm/c1/c1%5FLIR.cpp.html) [Patch](src/share/vm/c1/c1%5FLIR.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/c1/c1%5FLIR.cpp)
src/share/vm/c1/c1_LIR.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
7 lines changed: 6 ins; 0 del; 1 mod; 2049 unchg
[Cdiffs](src/share/vm/c1/c1%5FLIR.hpp.cdiff.html) [Udiffs](src/share/vm/c1/c1%5FLIR.hpp.udiff.html) [Sdiffs](src/share/vm/c1/c1%5FLIR.hpp.sdiff.html) [Frames](src/share/vm/c1/c1%5FLIR.hpp.frames.html) [Old](src/share/vm/c1/c1%5FLIR.hpp-.html) [New](src/share/vm/c1/c1%5FLIR.hpp.html) [Patch](src/share/vm/c1/c1%5FLIR.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/c1/c1%5FLIR.hpp)
src/share/vm/c1/c1_LIR.hpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
26 lines changed: 24 ins; 0 del; 2 mod; 2365 unchg
[Cdiffs](src/share/vm/c1/c1%5FLIRGenerator.cpp.cdiff.html) [Udiffs](src/share/vm/c1/c1%5FLIRGenerator.cpp.udiff.html) [Sdiffs](src/share/vm/c1/c1%5FLIRGenerator.cpp.sdiff.html) [Frames](src/share/vm/c1/c1%5FLIRGenerator.cpp.frames.html) [Old](src/share/vm/c1/c1%5FLIRGenerator.cpp-.html) [New](src/share/vm/c1/c1%5FLIRGenerator.cpp.html) [Patch](src/share/vm/c1/c1%5FLIRGenerator.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/c1/c1%5FLIRGenerator.cpp)
src/share/vm/c1/c1_LIRGenerator.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
14 lines changed: 0 ins; 0 del; 14 mod; 3205 unchg
[Cdiffs](src/share/vm/c1/c1%5FLinearScan.cpp.cdiff.html) [Udiffs](src/share/vm/c1/c1%5FLinearScan.cpp.udiff.html) [Sdiffs](src/share/vm/c1/c1%5FLinearScan.cpp.sdiff.html) [Frames](src/share/vm/c1/c1%5FLinearScan.cpp.frames.html) [Old](src/share/vm/c1/c1%5FLinearScan.cpp-.html) [New](src/share/vm/c1/c1%5FLinearScan.cpp.html) [Patch](src/share/vm/c1/c1%5FLinearScan.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/c1/c1%5FLinearScan.cpp)
src/share/vm/c1/c1_LinearScan.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
6 lines changed: 6 ins; 0 del; 0 mod; 6723 unchg
[Cdiffs](src/share/vm/c1/c1%5FValueType.cpp.cdiff.html) [Udiffs](src/share/vm/c1/c1%5FValueType.cpp.udiff.html) [Sdiffs](src/share/vm/c1/c1%5FValueType.cpp.sdiff.html) [Frames](src/share/vm/c1/c1%5FValueType.cpp.frames.html) [Old](src/share/vm/c1/c1%5FValueType.cpp-.html) [New](src/share/vm/c1/c1%5FValueType.cpp.html) [Patch](src/share/vm/c1/c1%5FValueType.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/c1/c1%5FValueType.cpp)
src/share/vm/c1/c1_ValueType.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
1 line changed: 1 ins; 0 del; 0 mod; 176 unchg
[Cdiffs](src/share/vm/opto/runtime.cpp.cdiff.html) [Udiffs](src/share/vm/opto/runtime.cpp.udiff.html) [Sdiffs](src/share/vm/opto/runtime.cpp.sdiff.html) [Frames](src/share/vm/opto/runtime.cpp.frames.html) [Old](src/share/vm/opto/runtime.cpp-.html) [New](src/share/vm/opto/runtime.cpp.html) [Patch](src/share/vm/opto/runtime.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/runtime.cpp)
src/share/vm/opto/runtime.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 1356 unchg
[Cdiffs](src/share/vm/utilities/globalDefinitions.cpp.cdiff.html) [Udiffs](src/share/vm/utilities/globalDefinitions.cpp.udiff.html) [Sdiffs](src/share/vm/utilities/globalDefinitions.cpp.sdiff.html) [Frames](src/share/vm/utilities/globalDefinitions.cpp.frames.html) [Old](src/share/vm/utilities/globalDefinitions.cpp-.html) [New](src/share/vm/utilities/globalDefinitions.cpp.html) [Patch](src/share/vm/utilities/globalDefinitions.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/utilities/globalDefinitions.cpp)
src/share/vm/utilities/globalDefinitions.cpp
rev 3845 : 7195816: NPG: Crash in c1_ValueType - ShouldNotReachHere Summary: C1 needs knowledge of T_METADATA at the LIR level. Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 351 unchg
This code review page was prepared using /net/mackdrive/export/jrts/work/rw140007/jdk7-fixes/webrev(vers 23.18-hg).