hotspot (original) (raw)
Code Review for hotspot
| Prepared by: | roland on Mon Nov 18 21:54:11 CET 2013 |
|---|---|
| Workspace: | /net/mackdrive/export/jrts/work/rw140007/c2-speculation/hotspot |
| Compare against: | http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot |
| Compare against version: | deoptfix |
| Summary of changes: | 198 lines changed: 108 ins; 3 del; 87 mod; 35971 unchg |
| Patch of changes: | <hotspot.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/vm/opto/callGenerator.cpp.cdiff.html) [Udiffs](src/share/vm/opto/callGenerator.cpp.udiff.html) [Sdiffs](src/share/vm/opto/callGenerator.cpp.sdiff.html) [Frames](src/share/vm/opto/callGenerator.cpp.frames.html) [Old](src/share/vm/opto/callGenerator.cpp-.html) [New](src/share/vm/opto/callGenerator.cpp.html) [Patch](src/share/vm/opto/callGenerator.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/callGenerator.cpp) src/share/vm/opto/callGenerator.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
2 lines changed: 0 ins; 0 del; 2 mod; 1193 unchg
[Cdiffs](src/share/vm/opto/cfgnode.cpp.cdiff.html) [Udiffs](src/share/vm/opto/cfgnode.cpp.udiff.html) [Sdiffs](src/share/vm/opto/cfgnode.cpp.sdiff.html) [Frames](src/share/vm/opto/cfgnode.cpp.frames.html) [Old](src/share/vm/opto/cfgnode.cpp-.html) [New](src/share/vm/opto/cfgnode.cpp.html) [Patch](src/share/vm/opto/cfgnode.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/cfgnode.cpp) src/share/vm/opto/cfgnode.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
4 lines changed: 0 ins; 0 del; 4 mod; 2229 unchg
[Cdiffs](src/share/vm/opto/compile.cpp.cdiff.html) [Udiffs](src/share/vm/opto/compile.cpp.udiff.html) [Sdiffs](src/share/vm/opto/compile.cpp.sdiff.html) [Frames](src/share/vm/opto/compile.cpp.frames.html) [Old](src/share/vm/opto/compile.cpp-.html) [New](src/share/vm/opto/compile.cpp.html) [Patch](src/share/vm/opto/compile.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/compile.cpp) src/share/vm/opto/compile.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
25 lines changed: 16 ins; 1 del; 8 mod; 3946 unchg
[Cdiffs](src/share/vm/opto/connode.cpp.cdiff.html) [Udiffs](src/share/vm/opto/connode.cpp.udiff.html) [Sdiffs](src/share/vm/opto/connode.cpp.sdiff.html) [Frames](src/share/vm/opto/connode.cpp.frames.html) [Old](src/share/vm/opto/connode.cpp-.html) [New](src/share/vm/opto/connode.cpp.html) [Patch](src/share/vm/opto/connode.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/connode.cpp) src/share/vm/opto/connode.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
4 lines changed: 0 ins; 0 del; 4 mod; 1374 unchg
[Cdiffs](src/share/vm/opto/graphKit.cpp.cdiff.html) [Udiffs](src/share/vm/opto/graphKit.cpp.udiff.html) [Sdiffs](src/share/vm/opto/graphKit.cpp.sdiff.html) [Frames](src/share/vm/opto/graphKit.cpp.frames.html) [Old](src/share/vm/opto/graphKit.cpp-.html) [New](src/share/vm/opto/graphKit.cpp.html) [Patch](src/share/vm/opto/graphKit.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/graphKit.cpp) src/share/vm/opto/graphKit.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
4 lines changed: 0 ins; 0 del; 4 mod; 4115 unchg
[Cdiffs](src/share/vm/opto/loopopts.cpp.cdiff.html) [Udiffs](src/share/vm/opto/loopopts.cpp.udiff.html) [Sdiffs](src/share/vm/opto/loopopts.cpp.sdiff.html) [Frames](src/share/vm/opto/loopopts.cpp.frames.html) [Old](src/share/vm/opto/loopopts.cpp-.html) [New](src/share/vm/opto/loopopts.cpp.html) [Patch](src/share/vm/opto/loopopts.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/loopopts.cpp) src/share/vm/opto/loopopts.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
4 lines changed: 0 ins; 0 del; 4 mod; 2789 unchg
[Cdiffs](src/share/vm/opto/memnode.cpp.cdiff.html) [Udiffs](src/share/vm/opto/memnode.cpp.udiff.html) [Sdiffs](src/share/vm/opto/memnode.cpp.sdiff.html) [Frames](src/share/vm/opto/memnode.cpp.frames.html) [Old](src/share/vm/opto/memnode.cpp-.html) [New](src/share/vm/opto/memnode.cpp.html) [Patch](src/share/vm/opto/memnode.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/memnode.cpp) src/share/vm/opto/memnode.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
2 lines changed: 0 ins; 0 del; 2 mod; 4582 unchg
[Cdiffs](src/share/vm/opto/multnode.cpp.cdiff.html) [Udiffs](src/share/vm/opto/multnode.cpp.udiff.html) [Sdiffs](src/share/vm/opto/multnode.cpp.sdiff.html) [Frames](src/share/vm/opto/multnode.cpp.frames.html) [Old](src/share/vm/opto/multnode.cpp-.html) [New](src/share/vm/opto/multnode.cpp.html) [Patch](src/share/vm/opto/multnode.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/multnode.cpp) src/share/vm/opto/multnode.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 208 unchg
[Cdiffs](src/share/vm/opto/node.cpp.cdiff.html) [Udiffs](src/share/vm/opto/node.cpp.udiff.html) [Sdiffs](src/share/vm/opto/node.cpp.sdiff.html) [Frames](src/share/vm/opto/node.cpp.frames.html) [Old](src/share/vm/opto/node.cpp-.html) [New](src/share/vm/opto/node.cpp.html) [Patch](src/share/vm/opto/node.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/node.cpp) src/share/vm/opto/node.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
2 lines changed: 0 ins; 0 del; 2 mod; 2131 unchg
[Cdiffs](src/share/vm/opto/parse1.cpp.cdiff.html) [Udiffs](src/share/vm/opto/parse1.cpp.udiff.html) [Sdiffs](src/share/vm/opto/parse1.cpp.sdiff.html) [Frames](src/share/vm/opto/parse1.cpp.frames.html) [Old](src/share/vm/opto/parse1.cpp-.html) [New](src/share/vm/opto/parse1.cpp.html) [Patch](src/share/vm/opto/parse1.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/parse1.cpp) src/share/vm/opto/parse1.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
2 lines changed: 0 ins; 0 del; 2 mod; 2191 unchg
[Cdiffs](src/share/vm/opto/parse2.cpp.cdiff.html) [Udiffs](src/share/vm/opto/parse2.cpp.udiff.html) [Sdiffs](src/share/vm/opto/parse2.cpp.sdiff.html) [Frames](src/share/vm/opto/parse2.cpp.frames.html) [Old](src/share/vm/opto/parse2.cpp-.html) [New](src/share/vm/opto/parse2.cpp.html) [Patch](src/share/vm/opto/parse2.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/parse2.cpp) src/share/vm/opto/parse2.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
5 lines changed: 0 ins; 0 del; 5 mod; 2398 unchg
[Cdiffs](src/share/vm/opto/parse3.cpp.cdiff.html) [Udiffs](src/share/vm/opto/parse3.cpp.udiff.html) [Sdiffs](src/share/vm/opto/parse3.cpp.sdiff.html) [Frames](src/share/vm/opto/parse3.cpp.frames.html) [Old](src/share/vm/opto/parse3.cpp-.html) [New](src/share/vm/opto/parse3.cpp.html) [Patch](src/share/vm/opto/parse3.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/parse3.cpp) src/share/vm/opto/parse3.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 537 unchg
[Cdiffs](src/share/vm/opto/phaseX.cpp.cdiff.html) [Udiffs](src/share/vm/opto/phaseX.cpp.udiff.html) [Sdiffs](src/share/vm/opto/phaseX.cpp.sdiff.html) [Frames](src/share/vm/opto/phaseX.cpp.frames.html) [Old](src/share/vm/opto/phaseX.cpp-.html) [New](src/share/vm/opto/phaseX.cpp.html) [Patch](src/share/vm/opto/phaseX.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/phaseX.cpp) src/share/vm/opto/phaseX.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
3 lines changed: 0 ins; 1 del; 2 mod; 1805 unchg
[Cdiffs](src/share/vm/opto/type.cpp.cdiff.html) [Udiffs](src/share/vm/opto/type.cpp.udiff.html) [Sdiffs](src/share/vm/opto/type.cpp.sdiff.html) [Frames](src/share/vm/opto/type.cpp.frames.html) [Old](src/share/vm/opto/type.cpp-.html) [New](src/share/vm/opto/type.cpp.html) [Patch](src/share/vm/opto/type.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/type.cpp) src/share/vm/opto/type.cpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
53 lines changed: 20 ins; 1 del; 32 mod; 4801 unchg
[Cdiffs](src/share/vm/opto/type.hpp.cdiff.html) [Udiffs](src/share/vm/opto/type.hpp.udiff.html) [Sdiffs](src/share/vm/opto/type.hpp.sdiff.html) [Frames](src/share/vm/opto/type.hpp.frames.html) [Old](src/share/vm/opto/type.hpp-.html) [New](src/share/vm/opto/type.hpp.html) [Patch](src/share/vm/opto/type.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/type.hpp) src/share/vm/opto/type.hpp
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
23 lines changed: 9 ins; 0 del; 14 mod; 1672 unchg
------ ------ ------ ------ ---[New](test/compiler/types/TestSpeculationFailedHigherEqual.java.html) [Patch](test/compiler/types/TestSpeculationFailedHigherEqual.java.patch) [Raw](raw%5Ffiles/new/test/compiler/types/TestSpeculationFailedHigherEqual.java) test/compiler/types/TestSpeculationFailedHigherEqual.java
rev 5645 : 8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed Summary: type methods shouldn't always operate on speculative part Reviewed-by:
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using ../../c2-inlining/webrev.ksh(vers 23.18-hg-never-dev).