hotspot (original) (raw)
Code Review for hotspot
| Prepared by: | roland on Tue Mar 17 11:31:32 CET 2015 |
|---|---|
| Workspace: | /net/mackdrive/export/jrts/work/rw140007/jdk9-repo/hotspot |
| Compare against: | http://hg.openjdk.java.net/jdk9/hs-comp/hotspot |
| Compare against version: | 7995 |
| Summary of changes: | 471 lines changed: 179 ins; 292 del; 0 mod; 21062 unchg |
| Patch of changes: | <hotspot.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/vm/opto/castnode.cpp.cdiff.html) [Udiffs](src/share/vm/opto/castnode.cpp.udiff.html) [Sdiffs](src/share/vm/opto/castnode.cpp.sdiff.html) [Frames](src/share/vm/opto/castnode.cpp.frames.html) [Old](src/share/vm/opto/castnode.cpp-.html) [New](src/share/vm/opto/castnode.cpp.html) [Patch](src/share/vm/opto/castnode.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/castnode.cpp) src/share/vm/opto/castnode.cpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
31 lines changed: 0 ins; 31 del; 0 mod; 359 unchg
[Cdiffs](src/share/vm/opto/castnode.hpp.cdiff.html) [Udiffs](src/share/vm/opto/castnode.hpp.udiff.html) [Sdiffs](src/share/vm/opto/castnode.hpp.sdiff.html) [Frames](src/share/vm/opto/castnode.hpp.frames.html) [Old](src/share/vm/opto/castnode.hpp-.html) [New](src/share/vm/opto/castnode.hpp.html) [Patch](src/share/vm/opto/castnode.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/castnode.hpp) src/share/vm/opto/castnode.hpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
6 lines changed: 0 ins; 6 del; 0 mod; 128 unchg
[Cdiffs](src/share/vm/opto/compile.cpp.cdiff.html) [Udiffs](src/share/vm/opto/compile.cpp.udiff.html) [Sdiffs](src/share/vm/opto/compile.cpp.sdiff.html) [Frames](src/share/vm/opto/compile.cpp.frames.html) [Old](src/share/vm/opto/compile.cpp-.html) [New](src/share/vm/opto/compile.cpp.html) [Patch](src/share/vm/opto/compile.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/compile.cpp) src/share/vm/opto/compile.cpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
43 lines changed: 42 ins; 1 del; 0 mod; 4291 unchg
[Cdiffs](src/share/vm/opto/gcm.cpp.cdiff.html) [Udiffs](src/share/vm/opto/gcm.cpp.udiff.html) [Sdiffs](src/share/vm/opto/gcm.cpp.sdiff.html) [Frames](src/share/vm/opto/gcm.cpp.frames.html) [Old](src/share/vm/opto/gcm.cpp-.html) [New](src/share/vm/opto/gcm.cpp.html) [Patch](src/share/vm/opto/gcm.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/gcm.cpp) src/share/vm/opto/gcm.cpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
31 lines changed: 31 ins; 0 del; 0 mod; 2028 unchg
[Cdiffs](src/share/vm/opto/matcher.cpp.cdiff.html) [Udiffs](src/share/vm/opto/matcher.cpp.udiff.html) [Sdiffs](src/share/vm/opto/matcher.cpp.sdiff.html) [Frames](src/share/vm/opto/matcher.cpp.frames.html) [Old](src/share/vm/opto/matcher.cpp-.html) [New](src/share/vm/opto/matcher.cpp.html) [Patch](src/share/vm/opto/matcher.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/matcher.cpp) src/share/vm/opto/matcher.cpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
22 lines changed: 22 ins; 0 del; 0 mod; 2609 unchg
[Cdiffs](src/share/vm/opto/memnode.cpp.cdiff.html) [Udiffs](src/share/vm/opto/memnode.cpp.udiff.html) [Sdiffs](src/share/vm/opto/memnode.cpp.sdiff.html) [Frames](src/share/vm/opto/memnode.cpp.frames.html) [Old](src/share/vm/opto/memnode.cpp-.html) [New](src/share/vm/opto/memnode.cpp.html) [Patch](src/share/vm/opto/memnode.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/memnode.cpp) src/share/vm/opto/memnode.cpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
210 lines changed: 0 ins; 210 del; 0 mod; 4336 unchg
[Cdiffs](src/share/vm/opto/memnode.hpp.cdiff.html) [Udiffs](src/share/vm/opto/memnode.hpp.udiff.html) [Sdiffs](src/share/vm/opto/memnode.hpp.sdiff.html) [Frames](src/share/vm/opto/memnode.hpp.frames.html) [Old](src/share/vm/opto/memnode.hpp-.html) [New](src/share/vm/opto/memnode.hpp.html) [Patch](src/share/vm/opto/memnode.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/memnode.hpp) src/share/vm/opto/memnode.hpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
4 lines changed: 0 ins; 4 del; 0 mod; 1391 unchg
[Cdiffs](src/share/vm/opto/narrowptrnode.cpp.cdiff.html) [Udiffs](src/share/vm/opto/narrowptrnode.cpp.udiff.html) [Sdiffs](src/share/vm/opto/narrowptrnode.cpp.sdiff.html) [Frames](src/share/vm/opto/narrowptrnode.cpp.frames.html) [Old](src/share/vm/opto/narrowptrnode.cpp-.html) [New](src/share/vm/opto/narrowptrnode.cpp.html) [Patch](src/share/vm/opto/narrowptrnode.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/narrowptrnode.cpp) src/share/vm/opto/narrowptrnode.cpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
4 lines changed: 0 ins; 4 del; 0 mod; 109 unchg
[Cdiffs](src/share/vm/opto/narrowptrnode.hpp.cdiff.html) [Udiffs](src/share/vm/opto/narrowptrnode.hpp.udiff.html) [Sdiffs](src/share/vm/opto/narrowptrnode.hpp.sdiff.html) [Frames](src/share/vm/opto/narrowptrnode.hpp.frames.html) [Old](src/share/vm/opto/narrowptrnode.hpp-.html) [New](src/share/vm/opto/narrowptrnode.hpp.html) [Patch](src/share/vm/opto/narrowptrnode.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/narrowptrnode.hpp) src/share/vm/opto/narrowptrnode.hpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
1 line changed: 0 ins; 1 del; 0 mod; 118 unchg
[Cdiffs](src/share/vm/opto/node.cpp.cdiff.html) [Udiffs](src/share/vm/opto/node.cpp.udiff.html) [Sdiffs](src/share/vm/opto/node.cpp.sdiff.html) [Frames](src/share/vm/opto/node.cpp.frames.html) [Old](src/share/vm/opto/node.cpp-.html) [New](src/share/vm/opto/node.cpp.html) [Patch](src/share/vm/opto/node.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/node.cpp) src/share/vm/opto/node.cpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
6 lines changed: 0 ins; 6 del; 0 mod; 2177 unchg
[Cdiffs](src/share/vm/opto/node.hpp.cdiff.html) [Udiffs](src/share/vm/opto/node.hpp.udiff.html) [Sdiffs](src/share/vm/opto/node.hpp.sdiff.html) [Frames](src/share/vm/opto/node.hpp.frames.html) [Old](src/share/vm/opto/node.hpp-.html) [New](src/share/vm/opto/node.hpp.html) [Patch](src/share/vm/opto/node.hpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/node.hpp) src/share/vm/opto/node.hpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
3 lines changed: 0 ins; 3 del; 0 mod; 1612 unchg
[Cdiffs](src/share/vm/opto/phaseX.cpp.cdiff.html) [Udiffs](src/share/vm/opto/phaseX.cpp.udiff.html) [Sdiffs](src/share/vm/opto/phaseX.cpp.sdiff.html) [Frames](src/share/vm/opto/phaseX.cpp.frames.html) [Old](src/share/vm/opto/phaseX.cpp-.html) [New](src/share/vm/opto/phaseX.cpp.html) [Patch](src/share/vm/opto/phaseX.cpp.patch) [Raw](raw%5Ffiles/new/src/share/vm/opto/phaseX.cpp) src/share/vm/opto/phaseX.cpp
rev 8006 : 8069191: moving predicate out of loops may cause array accesses to bypass null check Summary: Remove CastPP nodes only during final graph reshape Reviewed-by:
26 lines changed: 0 ins; 26 del; 0 mod; 1904 unchg
------ ------ ------ ------ ---[New](test/compiler/loopopts/TestPredicateLostDependency.java.html) [Patch](test/compiler/loopopts/TestPredicateLostDependency.java.patch) [Raw](raw%5Ffiles/new/test/compiler/loopopts/TestPredicateLostDependency.java) test/compiler/loopopts/TestPredicateLostDependency.java
rev 7920 : fix
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using ../../c2-inlining/webrev.ksh(vers 23.18-hg-never-dev).