jdk (original) (raw)

Code Review for jdk

Prepared by: sflores on Wed Sep 12 21:11:00 EDT 2012
Workspace: /home/sflores/ws/openJDK8/tl-sunec-bug/jdk
Compare against: http://hg.openjdk.java.net/jdk8/tl/jdk
Summary of changes: 1880 lines changed: 1048 ins; 759 del; 73 mod; 5794 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/sun/security/ec/ECDHKeyAgreement.java.cdiff.html) [Udiffs](src/share/classes/sun/security/ec/ECDHKeyAgreement.java.udiff.html) [Sdiffs](src/share/classes/sun/security/ec/ECDHKeyAgreement.java.sdiff.html) [Frames](src/share/classes/sun/security/ec/ECDHKeyAgreement.java.frames.html) [Old](src/share/classes/sun/security/ec/ECDHKeyAgreement.java-.html) [New](src/share/classes/sun/security/ec/ECDHKeyAgreement.java.html) [Patch](src/share/classes/sun/security/ec/ECDHKeyAgreement.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/ec/ECDHKeyAgreement.java) src/share/classes/sun/security/ec/ECDHKeyAgreement.java

3 lines changed: 2 ins; 0 del; 1 mod; 174 unchg

[Cdiffs](src/share/classes/sun/security/ec/ECDSASignature.java.cdiff.html) [Udiffs](src/share/classes/sun/security/ec/ECDSASignature.java.udiff.html) [Sdiffs](src/share/classes/sun/security/ec/ECDSASignature.java.sdiff.html) [Frames](src/share/classes/sun/security/ec/ECDSASignature.java.frames.html) [Old](src/share/classes/sun/security/ec/ECDSASignature.java-.html) [New](src/share/classes/sun/security/ec/ECDSASignature.java.html) [Patch](src/share/classes/sun/security/ec/ECDSASignature.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/ec/ECDSASignature.java) src/share/classes/sun/security/ec/ECDSASignature.java

1 line changed: 0 ins; 0 del; 1 mod; 426 unchg

[Cdiffs](src/share/classes/sun/security/ec/ECKeyPairGenerator.java.cdiff.html) [Udiffs](src/share/classes/sun/security/ec/ECKeyPairGenerator.java.udiff.html) [Sdiffs](src/share/classes/sun/security/ec/ECKeyPairGenerator.java.sdiff.html) [Frames](src/share/classes/sun/security/ec/ECKeyPairGenerator.java.frames.html) [Old](src/share/classes/sun/security/ec/ECKeyPairGenerator.java-.html) [New](src/share/classes/sun/security/ec/ECKeyPairGenerator.java.html) [Patch](src/share/classes/sun/security/ec/ECKeyPairGenerator.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/ec/ECKeyPairGenerator.java) src/share/classes/sun/security/ec/ECKeyPairGenerator.java

4 lines changed: 1 ins; 0 del; 3 mod; 170 unchg

[Cdiffs](src/share/classes/sun/security/ec/ECParameters.java.cdiff.html) [Udiffs](src/share/classes/sun/security/ec/ECParameters.java.udiff.html) [Sdiffs](src/share/classes/sun/security/ec/ECParameters.java.sdiff.html) [Frames](src/share/classes/sun/security/ec/ECParameters.java.frames.html) [Old](src/share/classes/sun/security/ec/ECParameters.java-.html) [New](src/share/classes/sun/security/ec/ECParameters.java.html) [Patch](src/share/classes/sun/security/ec/ECParameters.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/ec/ECParameters.java) src/share/classes/sun/security/ec/ECParameters.java

239 lines changed: 49 ins; 164 del; 26 mod; 159 unchg

[Cdiffs](src/share/classes/sun/security/ec/ECPrivateKeyImpl.java.cdiff.html) [Udiffs](src/share/classes/sun/security/ec/ECPrivateKeyImpl.java.udiff.html) [Sdiffs](src/share/classes/sun/security/ec/ECPrivateKeyImpl.java.sdiff.html) [Frames](src/share/classes/sun/security/ec/ECPrivateKeyImpl.java.frames.html) [Old](src/share/classes/sun/security/ec/ECPrivateKeyImpl.java-.html) [New](src/share/classes/sun/security/ec/ECPrivateKeyImpl.java.html) [Patch](src/share/classes/sun/security/ec/ECPrivateKeyImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/ec/ECPrivateKeyImpl.java) src/share/classes/sun/security/ec/ECPrivateKeyImpl.java

6 lines changed: 0 ins; 1 del; 5 mod; 158 unchg

[Cdiffs](src/share/classes/sun/security/ec/ECPublicKeyImpl.java.cdiff.html) [Udiffs](src/share/classes/sun/security/ec/ECPublicKeyImpl.java.udiff.html) [Sdiffs](src/share/classes/sun/security/ec/ECPublicKeyImpl.java.sdiff.html) [Frames](src/share/classes/sun/security/ec/ECPublicKeyImpl.java.frames.html) [Old](src/share/classes/sun/security/ec/ECPublicKeyImpl.java-.html) [New](src/share/classes/sun/security/ec/ECPublicKeyImpl.java.html) [Patch](src/share/classes/sun/security/ec/ECPublicKeyImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/ec/ECPublicKeyImpl.java) src/share/classes/sun/security/ec/ECPublicKeyImpl.java

7 lines changed: 0 ins; 0 del; 7 mod; 122 unchg

[Cdiffs](src/share/classes/sun/security/ec/NamedCurve.java.cdiff.html) [Udiffs](src/share/classes/sun/security/ec/NamedCurve.java.udiff.html) [Sdiffs](src/share/classes/sun/security/ec/NamedCurve.java.sdiff.html) [Frames](src/share/classes/sun/security/ec/NamedCurve.java.frames.html) [Old](src/share/classes/sun/security/ec/NamedCurve.java-.html) [New](src/share/classes/sun/security/ec/NamedCurve.java.html) [Patch](src/share/classes/sun/security/ec/NamedCurve.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/ec/NamedCurve.java) src/share/classes/sun/security/ec/NamedCurve.java

599 lines changed: 2 ins; 584 del; 13 mod; 67 unchg

[Cdiffs](src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java.cdiff.html) [Udiffs](src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java.udiff.html) [Sdiffs](src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java.sdiff.html) [Frames](src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java.frames.html) [Old](src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java-.html) [New](src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java.html) [Patch](src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java) src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java

18 lines changed: 1 ins; 6 del; 11 mod; 293 unchg

[Cdiffs](src/share/classes/sun/security/pkcs11/P11Key.java.cdiff.html) [Udiffs](src/share/classes/sun/security/pkcs11/P11Key.java.udiff.html) [Sdiffs](src/share/classes/sun/security/pkcs11/P11Key.java.sdiff.html) [Frames](src/share/classes/sun/security/pkcs11/P11Key.java.frames.html) [Old](src/share/classes/sun/security/pkcs11/P11Key.java-.html) [New](src/share/classes/sun/security/pkcs11/P11Key.java.html) [Patch](src/share/classes/sun/security/pkcs11/P11Key.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/pkcs11/P11Key.java) src/share/classes/sun/security/pkcs11/P11Key.java

2 lines changed: 0 ins; 1 del; 1 mod; 1153 unchg

[Cdiffs](src/share/classes/sun/security/pkcs11/P11KeyStore.java.cdiff.html) [Udiffs](src/share/classes/sun/security/pkcs11/P11KeyStore.java.udiff.html) [Sdiffs](src/share/classes/sun/security/pkcs11/P11KeyStore.java.sdiff.html) [Frames](src/share/classes/sun/security/pkcs11/P11KeyStore.java.frames.html) [Old](src/share/classes/sun/security/pkcs11/P11KeyStore.java-.html) [New](src/share/classes/sun/security/pkcs11/P11KeyStore.java.html) [Patch](src/share/classes/sun/security/pkcs11/P11KeyStore.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/pkcs11/P11KeyStore.java) src/share/classes/sun/security/pkcs11/P11KeyStore.java

2 lines changed: 1 ins; 0 del; 1 mod; 2666 unchg

[Cdiffs](src/share/classes/sun/security/ssl/JsseJce.java.cdiff.html) [Udiffs](src/share/classes/sun/security/ssl/JsseJce.java.udiff.html) [Sdiffs](src/share/classes/sun/security/ssl/JsseJce.java.sdiff.html) [Frames](src/share/classes/sun/security/ssl/JsseJce.java.frames.html) [Old](src/share/classes/sun/security/ssl/JsseJce.java-.html) [New](src/share/classes/sun/security/ssl/JsseJce.java.html) [Patch](src/share/classes/sun/security/ssl/JsseJce.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/ssl/JsseJce.java) src/share/classes/sun/security/ssl/JsseJce.java

9 lines changed: 2 ins; 3 del; 4 mod; 406 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/oracle/crypto/ec/ECKeySizeParameterSpec.java.html) [Patch](src/share/classes/com/oracle/crypto/ec/ECKeySizeParameterSpec.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/oracle/crypto/ec/ECKeySizeParameterSpec.java) src/share/classes/com/oracle/crypto/ec/ECKeySizeParameterSpec.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/sun/security/ec/CurveDB.java.html) [Patch](src/share/classes/sun/security/ec/CurveDB.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/ec/CurveDB.java) src/share/classes/sun/security/ec/CurveDB.java

660 lines changed: 660 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/sun/security/util/ECUtil.java.html) [Patch](src/share/classes/sun/security/util/ECUtil.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/sun/security/util/ECUtil.java) src/share/classes/sun/security/util/ECUtil.java

264 lines changed: 264 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/sflores/bin/webrev.ksh(vers 23.18-hg).