jdk (original) (raw)

Code Review for jdk

Prepared by: martin_uy on Tue Jul 18 14:02:01 ART 2017
Workspace: /home/martin/redhat/java/openjdk/repositories/public/jdk10/jdk
Compare against: http://hg.openjdk.java.net/jdk10/jdk10/jdk
Summary of changes: 1309 lines changed: 1303 ins; 0 del; 6 mod; 14609 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java.cdiff.html) [Udiffs](src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java.udiff.html) [Sdiffs](src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java.sdiff.html) [Frames](src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java.frames.html) [Old](src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java-.html) [New](src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java.html) [Patch](src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java) src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java

31 lines changed: 31 ins; 0 del; 0 mod; 159 unchg

[Cdiffs](src/java.base/share/classes/javax/net/ssl/SSLParameters.java.cdiff.html) [Udiffs](src/java.base/share/classes/javax/net/ssl/SSLParameters.java.udiff.html) [Sdiffs](src/java.base/share/classes/javax/net/ssl/SSLParameters.java.sdiff.html) [Frames](src/java.base/share/classes/javax/net/ssl/SSLParameters.java.frames.html) [Old](src/java.base/share/classes/javax/net/ssl/SSLParameters.java-.html) [New](src/java.base/share/classes/javax/net/ssl/SSLParameters.java.html) [Patch](src/java.base/share/classes/javax/net/ssl/SSLParameters.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/javax/net/ssl/SSLParameters.java) src/java.base/share/classes/javax/net/ssl/SSLParameters.java

52 lines changed: 52 ins; 0 del; 0 mod; 678 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java-.html) [New](src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java) src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java

39 lines changed: 38 ins; 0 del; 1 mod; 1901 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/ExtensionType.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/ExtensionType.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/ExtensionType.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/ExtensionType.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/ExtensionType.java-.html) [New](src/java.base/share/classes/sun/security/ssl/ExtensionType.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/ExtensionType.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/ExtensionType.java) src/java.base/share/classes/sun/security/ssl/ExtensionType.java

4 lines changed: 4 ins; 0 del; 0 mod; 111 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java-.html) [New](src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java) src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java

5 lines changed: 5 ins; 0 del; 0 mod; 2405 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/HelloExtensions.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/HelloExtensions.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/HelloExtensions.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/HelloExtensions.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/HelloExtensions.java-.html) [New](src/java.base/share/classes/sun/security/ssl/HelloExtensions.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/HelloExtensions.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/HelloExtensions.java) src/java.base/share/classes/sun/security/ssl/HelloExtensions.java

2 lines changed: 2 ins; 0 del; 0 mod; 161 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java-.html) [New](src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java) src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java

6 lines changed: 5 ins; 0 del; 1 mod; 2309 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java-.html) [New](src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java) src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java

26 lines changed: 26 ins; 0 del; 0 mod; 1009 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java-.html) [New](src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java) src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java

8 lines changed: 8 ins; 0 del; 0 mod; 2738 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java-.html) [New](src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java) src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java

11 lines changed: 11 ins; 0 del; 0 mod; 2282 unchg

[Cdiffs](src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java.cdiff.html) [Udiffs](src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java.udiff.html) [Sdiffs](src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java.sdiff.html) [Frames](src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java.frames.html) [Old](src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java-.html) [New](src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java) src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java

70 lines changed: 66 ins; 0 del; 4 mod; 856 unchg

------ ------ ------ ------ ---[New](src/java.base/share/classes/javax/net/ssl/CertificateAuthority.java.html) [Patch](src/java.base/share/classes/javax/net/ssl/CertificateAuthority.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/javax/net/ssl/CertificateAuthority.java) src/java.base/share/classes/javax/net/ssl/CertificateAuthority.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java) src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java

171 lines changed: 171 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/java.base/share/classes/sun/security/ssl/CertificateAuthorityImpl.java.html) [Patch](src/java.base/share/classes/sun/security/ssl/CertificateAuthorityImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/sun/security/ssl/CertificateAuthorityImpl.java) src/java.base/share/classes/sun/security/ssl/CertificateAuthorityImpl.java

138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/sun/security/ssl/ClientHandshaker/CertificateAuthoritiesClientTest.java.html) [Patch](test/sun/security/ssl/ClientHandshaker/CertificateAuthoritiesClientTest.java.patch) [Raw](raw%5Ffiles/new/test/sun/security/ssl/ClientHandshaker/CertificateAuthoritiesClientTest.java) test/sun/security/ssl/ClientHandshaker/CertificateAuthoritiesClientTest.java

330 lines changed: 330 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/sun/security/ssl/ServerHandshaker/CertificateAuthoritiesServerTest.java.html) [Patch](test/sun/security/ssl/ServerHandshaker/CertificateAuthoritiesServerTest.java.patch) [Raw](raw%5Ffiles/new/test/sun/security/ssl/ServerHandshaker/CertificateAuthoritiesServerTest.java) test/sun/security/ssl/ServerHandshaker/CertificateAuthoritiesServerTest.java

334 lines changed: 334 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/martin/Programs/webrev.ksh(vers 25.16-hg+openjdk.java.net).